[GitHub] [kafka] hudeqi commented on a diff in pull request #13719: MINOR:Fix illogical log in fetchOffsetAndTruncate method

hudeqi commented on code in PR #13719: URL: https://github.com/apache/kafka/pull/13719#discussion_r1196003399 ## core/src/main/scala/kafka/server/AbstractFetcherThread.scala: ## @@ -680,12 +680,15 @@ abstract class AbstractFetcherThread(name: String, */ val offset

[GitHub] [kafka] kamalcph commented on a diff in pull request #13719: MINOR:Fix illogical log in fetchOffsetAndTruncate method

kamalcph commented on code in PR #13719: URL: https://github.com/apache/kafka/pull/13719#discussion_r1195954775 ## core/src/main/scala/kafka/server/AbstractFetcherThread.scala: ## @@ -680,12 +680,15 @@ abstract class AbstractFetcherThread(name: String, */ val offs

[GitHub] [kafka] hudeqi commented on a diff in pull request #13719: MINOR:Fix illogical log in fetchOffsetAndTruncate method

hudeqi commented on code in PR #13719: URL: https://github.com/apache/kafka/pull/13719#discussion_r1195912888 ## core/src/main/scala/kafka/server/AbstractFetcherThread.scala: ## @@ -680,12 +680,15 @@ abstract class AbstractFetcherThread(name: String, */ val offset

[GitHub] [kafka] jolshan commented on a diff in pull request #13608: KAFKA-14884: Include check transaction is still ongoing right before append

jolshan commented on code in PR #13608: URL: https://github.com/apache/kafka/pull/13608#discussion_r1195788236 ## storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateEntry.java: ## @@ -41,18 +42,35 @@ public class ProducerStateEntry { private int coord

[GitHub] [kafka] jolshan commented on a diff in pull request #13608: KAFKA-14884: Include check transaction is still ongoing right before append

jolshan commented on code in PR #13608: URL: https://github.com/apache/kafka/pull/13608#discussion_r1195788236 ## storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateEntry.java: ## @@ -41,18 +42,35 @@ public class ProducerStateEntry { private int coord

[GitHub] [kafka] jolshan commented on a diff in pull request #13608: KAFKA-14884: Include check transaction is still ongoing right before append

jolshan commented on code in PR #13608: URL: https://github.com/apache/kafka/pull/13608#discussion_r1195786198 ## storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateEntry.java: ## @@ -104,27 +122,63 @@ public boolean maybeUpdateProducerEpoch(short produce

[GitHub] [kafka] artemlivshits commented on a diff in pull request #13608: KAFKA-14884: Include check transaction is still ongoing right before append

artemlivshits commented on code in PR #13608: URL: https://github.com/apache/kafka/pull/13608#discussion_r1194600838 ## storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateManager.java: ## @@ -183,6 +184,19 @@ private void clearProducerIds() { prod

[GitHub] [kafka] OmniaGM commented on pull request #11220: KAFKA-10777: Add additional configuration to control MirrorMaker 2 internal topics naming convention

OmniaGM commented on PR #11220: URL: https://github.com/apache/kafka/pull/11220#issuecomment-1550453763 > Hello, I know this PR is merged but I have an issue related to it while implementing a custom ReplicationPolicy to override the `heartbeat` topic name. According to the resources below,

[GitHub] [kafka] lucasbru opened a new pull request, #13725: Backport KAFKA-14172 to 3.2

lucasbru opened a new pull request, #13725: URL: https://github.com/apache/kafka/pull/13725 This fix is inspired by #12540. 1. Added a clearCache function for CachedStateStore, which would be triggered upon recycling a state manager. 2. Added the integration test inherited from #12

[GitHub] [kafka] junrao commented on a diff in pull request #13535: KAFKA-9579 Fetch implementation for records in the remote storage through a specific purgatory.

junrao commented on code in PR #13535: URL: https://github.com/apache/kafka/pull/13535#discussion_r1195723455 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -1175,49 +1216,101 @@ class ReplicaManager(val config: KafkaConfig, fetchPartitionStatus += (t

[GitHub] [kafka] ijuma commented on pull request #12462: [KAFKA-9965] Fix accumulator tryAppend, so that fresh new producerBatch is created

ijuma commented on PR #12462: URL: https://github.com/apache/kafka/pull/12462#issuecomment-1550160547 Where are we with this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka] kamalcph commented on a diff in pull request #13719: MINOR:Fix illogical log in fetchOffsetAndTruncate method

kamalcph commented on code in PR #13719: URL: https://github.com/apache/kafka/pull/13719#discussion_r1195494919 ## core/src/main/scala/kafka/server/AbstractFetcherThread.scala: ## @@ -680,12 +680,15 @@ abstract class AbstractFetcherThread(name: String, */ val offs

[GitHub] [kafka] kamalcph commented on pull request #13535: KAFKA-9579 Fetch implementation for records in the remote storage through a specific purgatory.

kamalcph commented on PR #13535: URL: https://github.com/apache/kafka/pull/13535#issuecomment-1549993361 > @satishd : Thanks for the updated PR. Are the test failures related to this PR especially the following ones related to remote store? > > ``` > [Build / JDK 11 and Scala 2.13

[GitHub] [kafka] rondagostino opened a new pull request, #13724: MINOR: more TopicsImage tests

rondagostino opened a new pull request, #13724: URL: https://github.com/apache/kafka/pull/13724 Adds additional testing for TopicsImage. For every image that we create, test that we can get to the final image with an intermediate stop at all intermediate images along the way. For example,

[GitHub] [kafka] ruslankrivoshein commented on a diff in pull request #13562: KAFKA-14581: Moving GetOffsetShell to tools

ruslankrivoshein commented on code in PR #13562: URL: https://github.com/apache/kafka/pull/13562#discussion_r1195250433 ## tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java: ## @@ -0,0 +1,160 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] ahibot commented on pull request #11220: KAFKA-10777: Add additional configuration to control MirrorMaker 2 internal topics naming convention

ahibot commented on PR #11220: URL: https://github.com/apache/kafka/pull/11220#issuecomment-1549750316 Hello, I know this issue is merged but I have some issue related to it when I tried to implement a custom ReplicationPolicy to override the `heartbeat` topic name. According to the

[jira] [Commented] (KAFKA-14692) Issues in Zookeeper to KRaft migration docs

[ https://issues.apache.org/jira/browse/KAFKA-14692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17723090#comment-17723090 ] Luke Chen commented on KAFKA-14692: --- Remove this from 3.4.1. > Issues in Zookeeper to

[jira] [Updated] (KAFKA-14692) Issues in Zookeeper to KRaft migration docs

[ https://issues.apache.org/jira/browse/KAFKA-14692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-14692: -- Fix Version/s: (was: 3.4.1) > Issues in Zookeeper to KRaft migration docs > --

[GitHub] [kafka] mdedetrich commented on a diff in pull request #13689: KAFKA-14975: Wait for TopicBasedRemoteLogMetadataManager.ensureInitializedAndNotClosed to initialize rather than throwing

mdedetrich commented on code in PR #13689: URL: https://github.com/apache/kafka/pull/13689#discussion_r1194911490 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManager.java: ## @@ -489,14 +498,28 @@ public boolean isIniti

[GitHub] [kafka] mdedetrich commented on a diff in pull request #13689: KAFKA-14975: Wait for TopicBasedRemoteLogMetadataManager.ensureInitializedAndNotClosed to initialize rather than throwing

mdedetrich commented on code in PR #13689: URL: https://github.com/apache/kafka/pull/13689#discussion_r1194911490 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManager.java: ## @@ -489,14 +498,28 @@ public boolean isIniti

[GitHub] [kafka] mdedetrich commented on a diff in pull request #13689: KAFKA-14975: Wait for TopicBasedRemoteLogMetadataManager.ensureInitializedAndNotClosed to initialize rather than throwing

mdedetrich commented on code in PR #13689: URL: https://github.com/apache/kafka/pull/13689#discussion_r1194911490 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManager.java: ## @@ -489,14 +498,28 @@ public boolean isIniti

[jira] [Created] (KAFKA-14998) Kafka server start fails with the following error java.lang.NumberFormatException: For input string: "a"

Nikilesh created KAFKA-14998: Summary: Kafka server start fails with the following error java.lang.NumberFormatException: For input string: "a" Key: KAFKA-14998 URL: https://issues.apache.org/jira/browse/KAFKA-14998

[jira] [Updated] (KAFKA-14998) Kafka server start fails with the following error java.lang.NumberFormatException: For input string: "a"

[ https://issues.apache.org/jira/browse/KAFKA-14998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nikilesh updated KAFKA-14998: - Description: Kafka fails to start because of the following error. The Kafka cluster was in a healthy st

[GitHub] [kafka] satishd commented on a diff in pull request #13535: KAFKA-9579 Fetch implementation for records in the remote storage through a specific purgatory.

satishd commented on code in PR #13535: URL: https://github.com/apache/kafka/pull/13535#discussion_r1194768781 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -600,25 +623,204 @@ public String toString() { } } -long findHighestRemoteOffset