[GitHub] [kafka] yashmayya commented on pull request #13530: KAFKA-14858: Handle exceptions thrown from Connector::taskConfigs in Connect's standalone mode

2023-06-11 Thread via GitHub
yashmayya commented on PR #13530: URL: https://github.com/apache/kafka/pull/13530#issuecomment-1586626234 One thing to note is that all existing connector failure state transitions occur through `WorkerConnector::onFailure` which updates an internal state to `FAILED` as well as the

[GitHub] [kafka] dengziming commented on a diff in pull request #13826: KAFKA-15060: fix the ApiVersionManager interface

2023-06-11 Thread via GitHub
dengziming commented on code in PR #13826: URL: https://github.com/apache/kafka/pull/13826#discussion_r1226040921 ## core/src/main/scala/kafka/server/ApiVersionManager.scala: ## @@ -141,24 +136,22 @@ class DefaultApiVersionManager( val enabledApis =

[jira] [Resolved] (KAFKA-15036) Kraft leader change fails when invoking getFinalizedFeatures

2023-06-11 Thread Deng Ziming (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deng Ziming resolved KAFKA-15036. - Resolution: Fixed > Kraft leader change fails when invoking getFinalizedFeatures >

[GitHub] [kafka] dengziming merged pull request #13832: KAFKA-15036: Add a test case for controller failover

2023-06-11 Thread via GitHub
dengziming merged PR #13832: URL: https://github.com/apache/kafka/pull/13832 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] stevenbooke opened a new pull request, #13842: KAFKA-14995: Automate asf.yaml collaborators refresh

2023-06-11 Thread via GitHub
stevenbooke opened a new pull request, #13842: URL: https://github.com/apache/kafka/pull/13842 Create Github Action workflow to run Python script which will automate the asf.yaml collaborators refresh. Tested the workflow locally using https://github.com/nektos/act. ###

[jira] [Commented] (KAFKA-14995) Automate asf.yaml collaborators refresh

2023-06-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17731410#comment-17731410 ] ASF GitHub Bot commented on KAFKA-14995: stevenbooke opened a new pull request, #521: URL:

[jira] [Commented] (KAFKA-15046) Produce performance issue under high disk load

2023-06-11 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17731375#comment-17731375 ] Jun Rao commented on KAFKA-15046: - The potential issue with moving the LeaderEpochFile flushing to an

[GitHub] [kafka] hgeraldino commented on a diff in pull request #13383: KAFKA-14059 Replace PowerMock with Mockito in WorkerSourceTaskTest

2023-06-11 Thread via GitHub
hgeraldino commented on code in PR #13383: URL: https://github.com/apache/kafka/pull/13383#discussion_r1220625126 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSourceTaskTest.java: ## @@ -706,95 +662,72 @@ public void

[GitHub] [kafka] cadonna merged pull request #13829: KAFKA-10199: Re-add revived tasks to the state updater after handling

2023-06-11 Thread via GitHub
cadonna merged PR #13829: URL: https://github.com/apache/kafka/pull/13829 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] cadonna commented on pull request #13829: KAFKA-10199: Re-add revived tasks to the state updater after handling

2023-06-11 Thread via GitHub
cadonna commented on PR #13829: URL: https://github.com/apache/kafka/pull/13829#issuecomment-1586163556 Build failures are unrelated: ``` Build / JDK 11 and Scala 2.13 /

[jira] [Commented] (KAFKA-15072) Flaky test MirrorConnectorsIntegrationExactlyOnceTest.testReplicationWithEmptyPartition

2023-06-11 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17731344#comment-17731344 ] Bruno Cadonna commented on KAFKA-15072: --- I also see the following test that fail with the same

[jira] [Comment Edited] (KAFKA-15072) Flaky test MirrorConnectorsIntegrationExactlyOnceTest.testReplicationWithEmptyPartition

2023-06-11 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17731344#comment-17731344 ] Bruno Cadonna edited comment on KAFKA-15072 at 6/11/23 1:05 PM: I also

[jira] [Resolved] (KAFKA-15077) FileTokenRetriever doesn't trim the token before returning it.

2023-06-11 Thread Manikumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar resolved KAFKA-15077. --- Resolution: Fixed > FileTokenRetriever doesn't trim the token before returning it. >

[GitHub] [kafka] omkreddy merged pull request #13835: KAFKA-15077: Added code to trim token in FileTokenRetriever, added test.

2023-06-11 Thread via GitHub
omkreddy merged PR #13835: URL: https://github.com/apache/kafka/pull/13835 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] omkreddy commented on pull request #13835: KAFKA-15077: Added code to trim token in FileTokenRetriever, added test.

2023-06-11 Thread via GitHub
omkreddy commented on PR #13835: URL: https://github.com/apache/kafka/pull/13835#issuecomment-1586036037 Test failures are not related -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the