[GitHub] [kafka] drawxy commented on a diff in pull request #13847: KAFKA-15082: The log retention policy doesn't take effect after altering log dir

drawxy commented on code in PR #13847: URL: https://github.com/apache/kafka/pull/13847#discussion_r1235160754 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -881,6 +881,7 @@ class ReplicaManager(val config: KafkaConfig, if

[GitHub] [kafka] cadonna merged pull request #12739: Replace EasyMock and PowerMock with Mockito | TimeOrderedCachingPersistentWindowStoreTest

cadonna merged PR #12739: URL: https://github.com/apache/kafka/pull/12739 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] cadonna commented on pull request #12739: Replace EasyMock and PowerMock with Mockito | TimeOrderedCachingPersistentWindowStoreTest

cadonna commented on PR #12739: URL: https://github.com/apache/kafka/pull/12739#issuecomment-1598624082 Build failures are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] cadonna commented on a diff in pull request #13855: KAFKA-14936: Add Grace period logic to Stream Table Join (2/N)

cadonna commented on code in PR #13855: URL: https://github.com/apache/kafka/pull/13855#discussion_r1235135157 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java: ## @@ -1256,10 +1261,25 @@ private KStream doStreamTableJoin(final KTable

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13874: KAFKA-14133: Migrate various mocks in TaskManagerTest to Mockito

divijvaidya commented on code in PR #13874: URL: https://github.com/apache/kafka/pull/13874#discussion_r1235104678 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -3550,14 +3538,12 @@ public void

[GitHub] [kafka] cadonna commented on a diff in pull request #13855: KAFKA-14936: Add Grace period logic to Stream Table Join (2/N)

cadonna commented on code in PR #13855: URL: https://github.com/apache/kafka/pull/13855#discussion_r1235096344 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java: ## @@ -1256,10 +1261,25 @@ private KStream doStreamTableJoin(final KTable

[GitHub] [kafka] cadonna commented on a diff in pull request #13855: KAFKA-14936: Add Grace period logic to Stream Table Join (2/N)

cadonna commented on code in PR #13855: URL: https://github.com/apache/kafka/pull/13855#discussion_r1235102765 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java: ## @@ -1256,10 +1261,25 @@ private KStream doStreamTableJoin(final KTable

[GitHub] [kafka] cadonna commented on a diff in pull request #13855: KAFKA-14936: Add Grace period logic to Stream Table Join (2/N)

cadonna commented on code in PR #13855: URL: https://github.com/apache/kafka/pull/13855#discussion_r1235096344 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java: ## @@ -1256,10 +1261,25 @@ private KStream doStreamTableJoin(final KTable

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13868: MINOR: Close ReplicaManager correctly in ReplicaManagerTest

divijvaidya commented on code in PR #13868: URL: https://github.com/apache/kafka/pull/13868#discussion_r1235094378 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -4935,12 +4991,17 @@ class ReplicaManagerTest { topicPartition, leaderEpoch +

[GitHub] [kafka] xiaocairush opened a new pull request, #13882: MINOR:Fix some typos for core

xiaocairush opened a new pull request, #13882: URL: https://github.com/apache/kafka/pull/13882 *More detailed description of your change, Hi there, I found lots of typos in this repo. I believe you will be mad If I committed all typos. So this PR is just a fix for core module.

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13868: MINOR: Close ReplicaManager correctly in ReplicaManagerTest

divijvaidya commented on code in PR #13868: URL: https://github.com/apache/kafka/pull/13868#discussion_r1235061965 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -4935,12 +4991,17 @@ class ReplicaManagerTest { topicPartition, leaderEpoch +

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13868: MINOR: Close ReplicaManager correctly in ReplicaManagerTest

divijvaidya commented on code in PR #13868: URL: https://github.com/apache/kafka/pull/13868#discussion_r1235057956 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -343,6 +348,7 @@ class ReplicaManagerTest { assertTrue(appendResult.hasFired)

[jira] [Commented] (KAFKA-7739) Kafka Tiered Storage

[ https://issues.apache.org/jira/browse/KAFKA-7739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735221#comment-17735221 ] Luke Chen commented on KAFKA-7739: -- [~jeqo] , please open a JIRA and welcome to contribute on it. Thank

[jira] [Commented] (KAFKA-14953) Add metrics for tiered storage

[ https://issues.apache.org/jira/browse/KAFKA-14953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735219#comment-17735219 ] Luke Chen commented on KAFKA-14953: --- [~jeqo] , which PR are you referring to? We haven't got any

[GitHub] [kafka] dajac commented on a diff in pull request #13868: MINOR: Close ReplicaManager correctly in ReplicaManagerTest

dajac commented on code in PR #13868: URL: https://github.com/apache/kafka/pull/13868#discussion_r1235012466 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -343,6 +348,7 @@ class ReplicaManagerTest { assertTrue(appendResult.hasFired) }

[GitHub] [kafka] dimitarndimitrov commented on pull request #13856: KAFKA-15087 Move/rewrite InterBrokerSendThread to server-commons

dimitarndimitrov commented on PR #13856: URL: https://github.com/apache/kafka/pull/13856#issuecomment-1598445990 Rebased and force-pushed to address a trivial conflict in `checkstyle/import-control-server-common.xml`. -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] jlprat commented on pull request #13839: MINOR:Fill missing parameter annotations for LogCleaner methods

jlprat commented on PR #13839: URL: https://github.com/apache/kafka/pull/13839#issuecomment-1598437574 Hi @hudeqi, it's on my list, yes. I'll try to review this either today or tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] hudeqi commented on pull request #13839: MINOR:Fill missing parameter annotations for LogCleaner methods

hudeqi commented on PR #13839: URL: https://github.com/apache/kafka/pull/13839#issuecomment-1598433842 Hi, are you still following this pr? @jlprat -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13873: KAFKA-14133: Migrate Consumer mock in TaskManagerTest to Mockito

divijvaidya commented on code in PR #13873: URL: https://github.com/apache/kafka/pull/13873#discussion_r1234973245 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -1046,15 +1036,13 @@ public void

[jira] [Commented] (KAFKA-14953) Add metrics for tiered storage

[ https://issues.apache.org/jira/browse/KAFKA-14953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735200#comment-17735200 ] Jorge Esteban Quilcate Otoya commented on KAFKA-14953: -- I think this one is merged,

[jira] [Commented] (KAFKA-7739) Kafka Tiered Storage

[ https://issues.apache.org/jira/browse/KAFKA-7739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735197#comment-17735197 ] Jorge Esteban Quilcate Otoya commented on KAFKA-7739: - [~satish.duggana] I remember a

[GitHub] [kafka] satishd commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

satishd commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1234980957 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -152,16 +152,42 @@ class UnifiedLog(@volatile var logStartOffset: Long, locally {

[GitHub] [kafka] satishd commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

satishd commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1234980098 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -618,6 +625,230 @@ public void run() { } } +public void

[GitHub] [kafka] satishd commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

satishd commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1234978872 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1331,7 +1370,15 @@ class UnifiedLog(@volatile var logStartOffset: Long, private def

[GitHub] [kafka] hudeqi commented on a diff in pull request #13877: MINOR:Fix wrong semantics hint in TROGDOR.md

hudeqi commented on code in PR #13877: URL: https://github.com/apache/kafka/pull/13877#discussion_r1234947715 ## TROGDOR.md: ## @@ -143,7 +143,7 @@ RoundTripWorkload tests both production and consumption. The workload starts a ### ConsumeBench ConsumeBench starts one or

[GitHub] [kafka] leo0842 opened a new pull request, #13881: fix typo of ProducerConfig and KafkaProducer

leo0842 opened a new pull request, #13881: URL: https://github.com/apache/kafka/pull/13881 ADPATIVE -> ADAPTIVE -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Assigned] (KAFKA-15050) Prompts in the quickstarts

[ https://issues.apache.org/jira/browse/KAFKA-15050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tom Bentley reassigned KAFKA-15050: --- Assignee: Joobi S B > Prompts in the quickstarts > -- > >

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13877: MINOR:Fix wrong semantics hint in TROGDOR.md

divijvaidya commented on code in PR #13877: URL: https://github.com/apache/kafka/pull/13877#discussion_r1234911426 ## TROGDOR.md: ## @@ -143,7 +143,7 @@ RoundTripWorkload tests both production and consumption. The workload starts a ### ConsumeBench ConsumeBench starts one

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13878: MINOR: Move RocksDBTimeOrderedKeyValueBufferTest to use Junit5

divijvaidya commented on code in PR #13878: URL: https://github.com/apache/kafka/pull/13878#discussion_r1234904954 ## streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBTimeOrderedKeyValueBufferTest.java: ## @@ -32,31 +32,28 @@ import

[GitHub] [kafka] dajac commented on a diff in pull request #13880: KAFKA-14462; [19/N] Add CoordinatorLoader implementation

dajac commented on code in PR #13880: URL: https://github.com/apache/kafka/pull/13880#discussion_r1234894652 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordSerDe.java: ## @@ -0,0 +1,161 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] dajac commented on a diff in pull request #13880: KAFKA-14462; [19/N] Add CoordinatorLoader implementation

dajac commented on code in PR #13880: URL: https://github.com/apache/kafka/pull/13880#discussion_r1234893680 ## core/src/main/scala/kafka/coordinator/group/CoordinatorLoaderImpl.scala: ## @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] dajac opened a new pull request, #13880: KAFKA-14462; [19/N] Add CoordinatorLoader implementation

dajac opened a new pull request, #13880: URL: https://github.com/apache/kafka/pull/13880 This patch adds a coordinator loader implementation. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build

[GitHub] [kafka] machi1990 commented on pull request #12045: KAFKA-12319: Change calculation of window size used to calculate `Rate`

machi1990 commented on PR #12045: URL: https://github.com/apache/kafka/pull/12045#issuecomment-1598287543 One of my PR[1] was bitten again by this test. Would people be open to getting in a tactical fix[2] to stabilize CI while this PR is being reviewed? @mimaison @tombentley

[GitHub] [kafka] YORICHEONG closed pull request #13879: Yoricheong kafka read note

YORICHEONG closed pull request #13879: Yoricheong kafka read note URL: https://github.com/apache/kafka/pull/13879 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [kafka] YORICHEONG opened a new pull request, #13879: Yoricheong kafka read note

YORICHEONG opened a new pull request, #13879: URL: https://github.com/apache/kafka/pull/13879 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

[GitHub] [kafka] showuon commented on pull request #13838: MINOR: Reduce MM2 integration test flakiness due to missing dummy offset commits

showuon commented on PR #13838: URL: https://github.com/apache/kafka/pull/13838#issuecomment-1598185695 > Reverted in #13864 until we can address the issues with the `MirrorConnectorsIntegrationTransactionsTest::testReplication` test case. Thank you, @C0urante ! -- This is an

<    1   2