jeffkbkim commented on code in PR #13963:
URL: https://github.com/apache/kafka/pull/13963#discussion_r1259142145
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -720,19 +764,121 @@ private
CoordinatorResult consumerGr
rreddy-22 commented on code in PR #13920:
URL: https://github.com/apache/kafka/pull/13920#discussion_r1259195095
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java:
##
@@ -194,6 +193,7 @@ private boolean allSubscriptionsEqual(Set
yashmayya commented on code in PR #13801:
URL: https://github.com/apache/kafka/pull/13801#discussion_r1259168414
##
connect/runtime/src/main/java/org/apache/kafka/connect/storage/ConnectorOffsetBackingStore.java:
##
@@ -279,8 +284,51 @@ public Future set(Map
values, Callback
eziosudo commented on PR #13982:
URL: https://github.com/apache/kafka/pull/13982#issuecomment-1630095390
> scalaCollectionCompat has a new version `2.11`, did we consider that?
Yes, just found the release note here, seems harmless.
yashmayya commented on code in PR #13801:
URL: https://github.com/apache/kafka/pull/13801#discussion_r1259161121
##
connect/runtime/src/main/java/org/apache/kafka/connect/storage/ConnectorOffsetBackingStore.java:
##
@@ -279,8 +284,51 @@ public Future set(Map
values, Callback
yashmayya commented on code in PR #13801:
URL: https://github.com/apache/kafka/pull/13801#discussion_r1259160336
##
connect/runtime/src/main/java/org/apache/kafka/connect/storage/ConnectorOffsetBackingStore.java:
##
@@ -279,8 +284,51 @@ public Future set(Map
values, Callback
[
https://issues.apache.org/jira/browse/KAFKA-15139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
hudeqi resolved KAFKA-15139.
Resolution: Fixed
> Optimize the performance of `Set.removeAll(List)` in
> `MirrorCheckpointConnector`
>
hudeqi commented on PR #13913:
URL: https://github.com/apache/kafka/pull/13913#issuecomment-1630082775
I have added the unit test for the related ”createAcl failure“ case, thanks
for the review! @C0urante
--
This is an automated message from the Apache Git Service.
To respond to the
CalvinConfluent commented on code in PR #13963:
URL: https://github.com/apache/kafka/pull/13963#discussion_r1259133929
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -2402,6 +2448,584 @@ public void
satishd commented on code in PR #13275:
URL: https://github.com/apache/kafka/pull/13275#discussion_r1259130578
##
storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java:
##
@@ -0,0 +1,671 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
satishd commented on code in PR #13275:
URL: https://github.com/apache/kafka/pull/13275#discussion_r1259130451
##
storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java:
##
@@ -0,0 +1,671 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
satishd commented on PR #13275:
URL: https://github.com/apache/kafka/pull/13275#issuecomment-1630042350
> Just a few comments related to TxnIndex potentially being optional.
@jeqo There is already
[KAFKA-14993](https://issues.apache.org/jira/browse/KAFKA-14993) to address
that.
satishd commented on code in PR #13275:
URL: https://github.com/apache/kafka/pull/13275#discussion_r1259126161
##
storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java:
##
@@ -0,0 +1,671 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
satishd commented on code in PR #13275:
URL: https://github.com/apache/kafka/pull/13275#discussion_r1259125780
##
storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java:
##
@@ -0,0 +1,671 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
satishd commented on code in PR #13275:
URL: https://github.com/apache/kafka/pull/13275#discussion_r1259125780
##
storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java:
##
@@ -0,0 +1,671 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
jeffkbkim commented on code in PR #13870:
URL: https://github.com/apache/kafka/pull/13870#discussion_r1259115771
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -367,6 +446,155 @@ public
CoordinatorResult consumerGro
[
https://issues.apache.org/jira/browse/KAFKA-15175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741819#comment-17741819
]
Ismael Juma commented on KAFKA-15175:
-
nio2 is not necessarily faster than nio - it's a different
[
https://issues.apache.org/jira/browse/KAFKA-15152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741814#comment-17741814
]
Phuc Hong Tran edited comment on KAFKA-15152 at 7/11/23 2:30 AM:
-
Hi
[
https://issues.apache.org/jira/browse/KAFKA-15152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phuc Hong Tran reassigned KAFKA-15152:
--
Assignee: Phuc Hong Tran
> Fix incorrect format specifiers when formatting string
>
[
https://issues.apache.org/jira/browse/KAFKA-15152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741814#comment-17741814
]
Phuc Hong Tran commented on KAFKA-15152:
Hi [~divijvaidya], can I have this one assign to me?
jeffkbkim commented on code in PR #13870:
URL: https://github.com/apache/kafka/pull/13870#discussion_r1259098972
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -2377,156 +2606,2165 @@ public void
jeffkbkim commented on code in PR #13870:
URL: https://github.com/apache/kafka/pull/13870#discussion_r1259098122
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -2377,156 +2606,2165 @@ public void
jeffkbkim commented on code in PR #13870:
URL: https://github.com/apache/kafka/pull/13870#discussion_r1259097546
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -2377,156 +2606,2165 @@ public void
jeffkbkim commented on code in PR #13870:
URL: https://github.com/apache/kafka/pull/13870#discussion_r1259096806
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -2377,156 +2606,2165 @@ public void
jeffkbkim commented on code in PR #13870:
URL: https://github.com/apache/kafka/pull/13870#discussion_r1259095013
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -2377,156 +2606,2165 @@ public void
hudeqi commented on code in PR #13913:
URL: https://github.com/apache/kafka/pull/13913#discussion_r1259093047
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceConnector.java:
##
@@ -581,13 +582,23 @@ void incrementalAlterConfigs(Map
topicConfigs) {
hudeqi commented on code in PR #13913:
URL: https://github.com/apache/kafka/pull/13913#discussion_r1259093047
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceConnector.java:
##
@@ -581,13 +582,23 @@ void incrementalAlterConfigs(Map
topicConfigs) {
jeffkbkim commented on code in PR #13870:
URL: https://github.com/apache/kafka/pull/13870#discussion_r1259062674
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -2377,156 +2606,2165 @@ public void
jeffkbkim commented on code in PR #13870:
URL: https://github.com/apache/kafka/pull/13870#discussion_r1259059291
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -2377,156 +2606,2165 @@ public void
jeffkbkim commented on code in PR #13870:
URL: https://github.com/apache/kafka/pull/13870#discussion_r1259054171
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -2377,156 +2606,2165 @@ public void
jeffkbkim commented on code in PR #13870:
URL: https://github.com/apache/kafka/pull/13870#discussion_r1259054171
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -2377,156 +2606,2165 @@ public void
jeffkbkim commented on code in PR #13870:
URL: https://github.com/apache/kafka/pull/13870#discussion_r1259049772
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -2377,156 +2606,2165 @@ public void
jeffkbkim commented on code in PR #13870:
URL: https://github.com/apache/kafka/pull/13870#discussion_r1259047855
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -2377,156 +2606,2165 @@ public void
jeffkbkim commented on code in PR #13870:
URL: https://github.com/apache/kafka/pull/13870#discussion_r1259040832
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -228,14 +261,21 @@ public List build(TopicsImage
jeffkbkim commented on code in PR #13870:
URL: https://github.com/apache/kafka/pull/13870#discussion_r1259030830
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupCoordinatorServiceTest.java:
##
@@ -271,4 +289,110 @@ public void testOnResignation() {
kirktrue closed pull request #13989: KAFKA-14937: Refactoring for client code
to reduce boilerplate
URL: https://github.com/apache/kafka/pull/13989
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
jeffkbkim commented on code in PR #13870:
URL: https://github.com/apache/kafka/pull/13870#discussion_r1259029305
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1043,4 +1221,1331 @@ public void
kirktrue opened a new pull request, #13990:
URL: https://github.com/apache/kafka/pull/13990
There are a number of places in the client code where the same basic calls
are made by more than one client implementation. Minor refactoring will reduce
the amount of boilerplate code necessary for
kirktrue closed pull request #13989: KAFKA-14937: Refactoring for client code
to reduce boilerplate
URL: https://github.com/apache/kafka/pull/13989
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
kirktrue opened a new pull request, #13989:
URL: https://github.com/apache/kafka/pull/13989
There are a number of places in the client code where the same basic calls
are made by more than one client implementation. Minor refactoring will reduce
the amount of boilerplate code necessary for
jeffkbkim commented on code in PR #13870:
URL: https://github.com/apache/kafka/pull/13870#discussion_r1259002211
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1043,4 +1221,1331 @@ public void
jeffkbkim commented on code in PR #13870:
URL: https://github.com/apache/kafka/pull/13870#discussion_r1258999406
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1043,4 +1221,1331 @@ public void
eziosudo commented on code in PR #13982:
URL: https://github.com/apache/kafka/pull/13982#discussion_r1258959682
##
gradle/dependencies.gradle:
##
@@ -142,8 +142,8 @@ versions += [
slf4j: "1.7.36",
snappy: "1.1.10.1",
spotbugs: "4.7.3",
- swaggerAnnotations: "2.2.8",
-
gharris1727 merged PR #13946:
URL: https://github.com/apache/kafka/pull/13946
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jeqo commented on code in PR #13944:
URL: https://github.com/apache/kafka/pull/13944#discussion_r1258934931
##
core/src/main/scala/kafka/server/KafkaRequestHandler.scala:
##
@@ -277,6 +277,12 @@ class BrokerTopicMetrics(name: Option[String]) {
jeffkbkim commented on code in PR #13870:
URL: https://github.com/apache/kafka/pull/13870#discussion_r1258937169
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -579,4 +618,32 @@ public void shutdown() {
gharris1727 commented on PR #13946:
URL: https://github.com/apache/kafka/pull/13946#issuecomment-1629762524
Flaky test failures in the Mirror suite appear unrelated, and the tests pass
locally. Merging.
--
This is an automated message from the Apache Git Service.
To respond to the
jeffkbkim commented on code in PR #13870:
URL: https://github.com/apache/kafka/pull/13870#discussion_r1258934915
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -579,4 +618,32 @@ public void shutdown() {
jeqo commented on code in PR #13837:
URL: https://github.com/apache/kafka/pull/13837#discussion_r1258880361
##
storage/src/test/java/org/apache/kafka/server/log/remote/storage/LocalTieredStorage.java:
##
@@ -0,0 +1,578 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
jeffkbkim commented on code in PR #13870:
URL: https://github.com/apache/kafka/pull/13870#discussion_r1258924230
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -266,9 +282,32 @@ public CompletableFuture joinGroup(
hachikuji commented on code in PR #13787:
URL: https://github.com/apache/kafka/pull/13787#discussion_r1258915597
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -578,7 +578,7 @@ class Partition(val topicPartition: TopicPartition,
// Returns a verification guard
Philip Nee created KAFKA-15175:
--
Summary: Assess the use of nio2 asynchronous channel for
KafkaConsumer
Key: KAFKA-15175
URL: https://issues.apache.org/jira/browse/KAFKA-15175
Project: Kafka
ahuang98 commented on PR #13988:
URL: https://github.com/apache/kafka/pull/13988#issuecomment-1629679221
There's probably some value in leaving in the `controllerId`,
`controllerEpoch`, `brokerEpoch` as well. It won't elongate the log by much
--
This is an automated message from the
ahuang98 opened a new pull request, #13988:
URL: https://github.com/apache/kafka/pull/13988
Logging the following
```
[2023-07-10 13:15:22,703] WARN [Channel manager on controller 3000]: Not
sending request UpdateMetadata to broker 0, since it is offline.
jeqo commented on code in PR #13275:
URL: https://github.com/apache/kafka/pull/13275#discussion_r1258867599
##
storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java:
##
@@ -0,0 +1,671 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
divijvaidya commented on PR #13956:
URL: https://github.com/apache/kafka/pull/13956#issuecomment-1629633140
@mimaison @showuon requesting your review. We have many cases of CI failing
with hundreds of test failing and this thread leak is one of the reason for it.
Hence, the urgency.
--
divijvaidya commented on PR #13284:
URL: https://github.com/apache/kafka/pull/13284#issuecomment-1629620630
Thank you for your patience on this one @C0urante. Appreciate it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
divijvaidya commented on code in PR #13982:
URL: https://github.com/apache/kafka/pull/13982#discussion_r1258807856
##
gradle/dependencies.gradle:
##
@@ -142,8 +142,8 @@ versions += [
slf4j: "1.7.36",
snappy: "1.1.10.1",
spotbugs: "4.7.3",
- swaggerAnnotations:
divijvaidya commented on code in PR #13986:
URL: https://github.com/apache/kafka/pull/13986#discussion_r1258779004
##
docs/upgrade.html:
##
@@ -19,6 +19,22 @@
Philip Nee created KAFKA-15174:
--
Summary: Ensure the correct thread is executing the callbacks
Key: KAFKA-15174
URL: https://issues.apache.org/jira/browse/KAFKA-15174
Project: Kafka
Issue Type:
[
https://issues.apache.org/jira/browse/KAFKA-15173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philip Nee updated KAFKA-15173:
---
Labels: kip-945 (was: )
> ApplicationEventQueue and BackgroundEventQueue should be bounded
>
Philip Nee created KAFKA-15173:
--
Summary: ApplicationEventQueue and BackgroundEventQueue should be
bounded
Key: KAFKA-15173
URL: https://issues.apache.org/jira/browse/KAFKA-15173
Project: Kafka
Cerchie opened a new pull request, #13987:
URL: https://github.com/apache/kafka/pull/13987
Change in response to
[KIP-941](https://cwiki.apache.org/confluence/display/KAFKA/KIP-941%3A+Range+queries+to+accept+null+lower+and+upper+bounds).
Changes line 57 in the RangeQuery class file
jolshan commented on code in PR #13963:
URL: https://github.com/apache/kafka/pull/13963#discussion_r1258697658
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/MockCoordinatorTimer.java:
##
@@ -0,0 +1,144 @@
+/*
+ * Licensed to the Apache Software
jolshan commented on code in PR #13963:
URL: https://github.com/apache/kafka/pull/13963#discussion_r1258697658
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/MockCoordinatorTimer.java:
##
@@ -0,0 +1,144 @@
+/*
+ * Licensed to the Apache Software
dajac commented on code in PR #13963:
URL: https://github.com/apache/kafka/pull/13963#discussion_r1258688221
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -720,19 +765,116 @@ private
CoordinatorResult consumerGr
jolshan commented on code in PR #13963:
URL: https://github.com/apache/kafka/pull/13963#discussion_r1258683353
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -720,19 +765,116 @@ private
CoordinatorResult consumerGr
dajac commented on code in PR #13963:
URL: https://github.com/apache/kafka/pull/13963#discussion_r1258682428
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -720,19 +765,116 @@ private
CoordinatorResult consumerGr
jolshan commented on code in PR #13963:
URL: https://github.com/apache/kafka/pull/13963#discussion_r1258681834
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -720,19 +765,116 @@ private
CoordinatorResult consumerGr
Mickael Maison created KAFKA-15172:
--
Summary: Allow exact mirroring of ACLs between clusters
Key: KAFKA-15172
URL: https://issues.apache.org/jira/browse/KAFKA-15172
Project: Kafka
Issue
dajac commented on code in PR #13963:
URL: https://github.com/apache/kafka/pull/13963#discussion_r1258669748
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -720,19 +765,116 @@ private
CoordinatorResult consumerGr
eziosudo commented on PR #13982:
URL: https://github.com/apache/kafka/pull/13982#issuecomment-1629456542
> Thank you for the changes. We need to update the corresponding entries in
LICENSE file too:
>
>
dajac commented on code in PR #13963:
URL: https://github.com/apache/kafka/pull/13963#discussion_r1258664011
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -720,19 +765,116 @@ private
CoordinatorResult consumerGr
C0urante commented on code in PR #13945:
URL: https://github.com/apache/kafka/pull/13945#discussion_r1258640264
##
connect/file/src/main/java/org/apache/kafka/connect/file/FileStreamSourceConnector.java:
##
@@ -101,4 +105,35 @@ public ExactlyOnceSupport exactlyOnceSupport(Map
jolshan commented on code in PR #13963:
URL: https://github.com/apache/kafka/pull/13963#discussion_r1258653960
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -720,19 +765,116 @@ private
CoordinatorResult consumerGr
jolshan commented on code in PR #13963:
URL: https://github.com/apache/kafka/pull/13963#discussion_r1258653960
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -720,19 +765,116 @@ private
CoordinatorResult consumerGr
jolshan commented on code in PR #13963:
URL: https://github.com/apache/kafka/pull/13963#discussion_r1258650248
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -700,17 +726,36 @@ private
CoordinatorResult consumerGr
jolshan commented on code in PR #13963:
URL: https://github.com/apache/kafka/pull/13963#discussion_r1258644974
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -720,19 +765,116 @@ private
CoordinatorResult consumerGr
jolshan commented on code in PR #13963:
URL: https://github.com/apache/kafka/pull/13963#discussion_r1258644974
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -720,19 +765,116 @@ private
CoordinatorResult consumerGr
[
https://issues.apache.org/jira/browse/KAFKA-15145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-15145:
--
Fix Version/s: 3.5.1
> AbstractWorkerSourceTask re-processes records filtered out by SMTs on
C0urante merged PR #13955:
URL: https://github.com/apache/kafka/pull/13955
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
C0urante commented on code in PR #13913:
URL: https://github.com/apache/kafka/pull/13913#discussion_r1258611895
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceConnector.java:
##
@@ -581,13 +582,23 @@ void incrementalAlterConfigs(Map
topicConfigs) {
vamossagar12 commented on PR #13801:
URL: https://github.com/apache/kafka/pull/13801#issuecomment-1629387962
> Thanks @vamossagar12, this is looking much better now!
Thanks Yash.. I addressed your comments.
--
This is an automated message from the Apache Git Service.
To respond to
vamossagar12 commented on code in PR #13801:
URL: https://github.com/apache/kafka/pull/13801#discussion_r1258617166
##
connect/runtime/src/main/java/org/apache/kafka/connect/storage/ConnectorOffsetBackingStore.java:
##
@@ -279,8 +284,51 @@ public Future set(Map
values,
vamossagar12 commented on code in PR #13801:
URL: https://github.com/apache/kafka/pull/13801#discussion_r1258614182
##
connect/runtime/src/test/java/org/apache/kafka/connect/storage/OffsetStorageWriterTest.java:
##
@@ -233,4 +496,10 @@ private void expectStore(Map key, byte[]
vamossagar12 commented on code in PR #13801:
URL: https://github.com/apache/kafka/pull/13801#discussion_r1258613193
##
connect/runtime/src/main/java/org/apache/kafka/connect/storage/ConnectorOffsetBackingStore.java:
##
@@ -279,8 +284,51 @@ public Future set(Map
values,
vamossagar12 commented on code in PR #13801:
URL: https://github.com/apache/kafka/pull/13801#discussion_r1258609819
##
connect/runtime/src/main/java/org/apache/kafka/connect/storage/ConnectorOffsetBackingStore.java:
##
@@ -279,8 +284,51 @@ public Future set(Map
values,
vamossagar12 commented on code in PR #13801:
URL: https://github.com/apache/kafka/pull/13801#discussion_r1258609819
##
connect/runtime/src/main/java/org/apache/kafka/connect/storage/ConnectorOffsetBackingStore.java:
##
@@ -279,8 +284,51 @@ public Future set(Map
values,
vamossagar12 commented on code in PR #13801:
URL: https://github.com/apache/kafka/pull/13801#discussion_r1258608091
##
connect/runtime/src/main/java/org/apache/kafka/connect/storage/ConnectorOffsetBackingStore.java:
##
@@ -279,8 +284,51 @@ public Future set(Map
values,
yashmayya commented on PR #13955:
URL: https://github.com/apache/kafka/pull/13955#issuecomment-1629367616
Thanks Chris, I agree with the point you brought up regarding potential
poison pill messages. This PR can be merged.
--
This is an automated message from the Apache Git Service.
To
C0urante commented on PR #13946:
URL: https://github.com/apache/kafka/pull/13946#issuecomment-1629366713
@hudeqi I think @gharris1727 can merge this now :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
yashmayya commented on code in PR #13955:
URL: https://github.com/apache/kafka/pull/13955#discussion_r1258603343
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/AbstractWorkerSourceTaskTest.java:
##
@@ -651,6 +652,40 @@ public void
[
https://issues.apache.org/jira/browse/KAFKA-14059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-14059:
--
Fix Version/s: 3.6.0
> Replace EasyMock and PowerMock with Mockito in WorkerSourceTaskTest
>
[
https://issues.apache.org/jira/browse/KAFKA-14059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton resolved KAFKA-14059.
---
Resolution: Done
> Replace EasyMock and PowerMock with Mockito in WorkerSourceTaskTest
>
C0urante merged PR #13383:
URL: https://github.com/apache/kafka/pull/13383
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
C0urante merged PR #13284:
URL: https://github.com/apache/kafka/pull/13284
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
bbejeck commented on PR #13661:
URL: https://github.com/apache/kafka/pull/13661#issuecomment-1629346978
Merged #13661 into trunk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
bbejeck merged PR #13661:
URL: https://github.com/apache/kafka/pull/13661
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
divijvaidya commented on code in PR #13941:
URL: https://github.com/apache/kafka/pull/13941#discussion_r1258587583
##
clients/src/test/java/org/apache/kafka/common/utils/ChunkedBytesStreamTest.java:
##
@@ -149,6 +160,38 @@ public void testCorrectnessForMethodSkip(int
bbejeck commented on PR #13661:
URL: https://github.com/apache/kafka/pull/13661#issuecomment-1629339267
Failures unrelated
```
JDK 8 and Scala 2.12 / testUnregisterBroker() –
org.apache.kafka.controller.QuorumControllerTest
JDK 8 and Scala 2.12 / testConfigurationOperations() –
1 - 100 of 174 matches
Mail list logo