[jira] [Created] (KAFKA-15216) InternalSinkRecord::newRecord method ignores the headers argument

2023-07-18 Thread Yash Mayya (Jira)
Yash Mayya created KAFKA-15216: -- Summary: InternalSinkRecord::newRecord method ignores the headers argument Key: KAFKA-15216 URL: https://issues.apache.org/jira/browse/KAFKA-15216 Project: Kafka

[GitHub] [kafka] DL1231 commented on pull request #14042: KAFKA-15205:Catch InterruptedException when calling ShutDownableThrea…

2023-07-18 Thread via GitHub
DL1231 commented on PR #14042: URL: https://github.com/apache/kafka/pull/14042#issuecomment-1641493151 @divijvaidya I apologize for the interruption, but I tried to write unit tests to cover this scenario, but it failed. Do you have any suggestions? -- This is an automated message from th

[GitHub] [kafka] hudeqi opened a new pull request, #14043: KAFKA-15129;[9/N] Remove metrics in network package when broker shutdown

2023-07-18 Thread via GitHub
hudeqi opened a new pull request, #14043: URL: https://github.com/apache/kafka/pull/14043 This pr is used to remove the metrics in network package(`SocketServer`, `RequestChannel`, `Acceptor`) when broker shutdown. This pr has passed the corresponding unit test, and it is part of [KAFKA-

[GitHub] [kafka] DL1231 opened a new pull request, #14042: KAFKA-15205:Catch InterruptedException when calling ShutDownableThrea…

2023-07-18 Thread via GitHub
DL1231 opened a new pull request, #14042: URL: https://github.com/apache/kafka/pull/14042 https://issues.apache.org/jira/browse/KAFKA-15205 Catch InterruptedException when calling ShutDownableThread#awaitShutdown() ### Committer Checklist (excluded from commit message) - [ ] Veri

[jira] [Assigned] (KAFKA-15160) Message bytes duplication in Kafka headers when compression is enabled

2023-07-18 Thread Phuc Hong Tran (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phuc Hong Tran reassigned KAFKA-15160: -- Assignee: Phuc Hong Tran > Message bytes duplication in Kafka headers when compressio

[GitHub] [kafka] Phuc-Hong-Tran closed pull request #14026: KAFKA-15152: Fix incorrect format specifiers when formatting string

2023-07-18 Thread via GitHub
Phuc-Hong-Tran closed pull request #14026: KAFKA-15152: Fix incorrect format specifiers when formatting string URL: https://github.com/apache/kafka/pull/14026 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] nizhikov commented on pull request #13278: KAFKA-14591 DeleteRecordsCommand moved to tools

2023-07-18 Thread via GitHub
nizhikov commented on PR #13278: URL: https://github.com/apache/kafka/pull/13278#issuecomment-1641386848 Tests failures unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [kafka] nizhikov commented on pull request #13247: KAFKA-14595 Move value objects of ReassignPartitionsCommand to java

2023-07-18 Thread via GitHub
nizhikov commented on PR #13247: URL: https://github.com/apache/kafka/pull/13247#issuecomment-1641385324 Tests failures seems unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[jira] [Created] (KAFKA-15215) The default.dsl.store config is not compatible with custom state stores

2023-07-18 Thread A. Sophie Blee-Goldman (Jira)
A. Sophie Blee-Goldman created KAFKA-15215: -- Summary: The default.dsl.store config is not compatible with custom state stores Key: KAFKA-15215 URL: https://issues.apache.org/jira/browse/KAFKA-15215

[jira] [Updated] (KAFKA-15215) The default.dsl.store config is not compatible with custom state stores

2023-07-18 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-15215: --- Labels: needs-kip (was: ) > The default.dsl.store config is not compatible

[GitHub] [kafka] jeffkbkim commented on pull request #13870: KAFKA-14500; [5/N] Implement JoinGroup protocol in new GroupCoordinator

2023-07-18 Thread via GitHub
jeffkbkim commented on PR #13870: URL: https://github.com/apache/kafka/pull/13870#issuecomment-1641304041 the test failures are unrelated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #14017: KAFKA-14500; [6/6] Implement SyncGroup protocol in new GroupCoordinator

2023-07-18 Thread via GitHub
jeffkbkim commented on code in PR #14017: URL: https://github.com/apache/kafka/pull/14017#discussion_r1267462476 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -2643,9 +2652,175 @@ private CoordinatorResult updateStaticMem

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #14017: KAFKA-14500; [6/6] Implement SyncGroup protocol in new GroupCoordinator

2023-07-18 Thread via GitHub
jeffkbkim commented on code in PR #14017: URL: https://github.com/apache/kafka/pull/14017#discussion_r1267441961 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -2643,9 +2652,175 @@ private CoordinatorResult updateStaticMem

[GitHub] [kafka] gharris1727 commented on pull request #14029: KAFKA-10579: Upgrade reflections from 0.9.12 to 0.10.2

2023-07-18 Thread via GitHub
gharris1727 commented on PR #14029: URL: https://github.com/apache/kafka/pull/14029#issuecomment-1641250195 > Would it be too much to ask to run system tests? I ran the connect system tests on a spare machine and got 181/181 passing. -- This is an automated message from the Apache G

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #14017: KAFKA-14500; [6/6] Implement SyncGroup protocol in new GroupCoordinator

2023-07-18 Thread via GitHub
jeffkbkim commented on code in PR #14017: URL: https://github.com/apache/kafka/pull/14017#discussion_r1267427788 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -2643,9 +2652,175 @@ private CoordinatorResult updateStaticMem

[jira] [Commented] (KAFKA-15194) Rename local tiered storage segment with offset as prefix for easy navigation

2023-07-18 Thread Lan Ding (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744384#comment-17744384 ] Lan Ding commented on KAFKA-15194: -- [~divijvaidya] Sorry, just saw the message, [~owen-

[GitHub] [kafka] ijuma commented on pull request #13676: MINOR: Capture build scans on ge.apache.org to benefit from deep build insights

2023-07-18 Thread via GitHub
ijuma commented on PR #13676: URL: https://github.com/apache/kafka/pull/13676#issuecomment-1641123937 If I'm reading this right, it seems very restrictive. It's very common for other companies to build AK for their own purposes. If they're not allowed to use gradle enterprise, then it shoul

[jira] [Commented] (KAFKA-15205) Race condition in ShutdownableThread causes InterruptedException

2023-07-18 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744377#comment-17744377 ] Ismael Juma commented on KAFKA-15205: - Have you seen this behavior in practice? We s

[jira] [Closed] (KAFKA-10775) DOAP has incorrect category

2023-07-18 Thread Sebb (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb closed KAFKA-10775. > DOAP has incorrect category > --- > > Key: KAFKA-10775 > URL

[jira] [Updated] (KAFKA-15214) Add metrics for OffsetOutOfRangeException when tiered storage is enabled

2023-07-18 Thread Lixin Yao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lixin Yao updated KAFKA-15214: -- Parent: KAFKA-7739 Issue Type: Sub-task (was: Improvement) > Add metrics for OffsetOutOfRange

[jira] [Commented] (KAFKA-15000) High vulnerability PRISMA-2023-0067 reported in jackson-core

2023-07-18 Thread Said BOUDJELDA (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744366#comment-17744366 ] Said BOUDJELDA commented on KAFKA-15000: I can take this  Jira  > High vulnerab

[jira] [Assigned] (KAFKA-15000) High vulnerability PRISMA-2023-0067 reported in jackson-core

2023-07-18 Thread Said BOUDJELDA (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Said BOUDJELDA reassigned KAFKA-15000: -- Assignee: Said BOUDJELDA > High vulnerability PRISMA-2023-0067 reported in jackson-co

[GitHub] [kafka] muralibasani commented on pull request #13417: KAFKA-14585: Moving StorageTool from core to tools module

2023-07-18 Thread via GitHub
muralibasani commented on PR #13417: URL: https://github.com/apache/kafka/pull/13417#issuecomment-1641043256 @fvaleri Managed to remove the core dependency from tools. If am in the right direction, will add tests, fix conflicts, and several other minor things. -- This is an autom

[GitHub] [kafka] mjsax commented on pull request #14031: Docs: Include ZK Deprecation notice and information

2023-07-18 Thread via GitHub
mjsax commented on PR #14031: URL: https://github.com/apache/kafka/pull/14031#issuecomment-1641032657 Merged to `trunk` and cherry-picked to `3.5` branch. Will take care to get the changes into `kafka-site`, too. -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [kafka] mjsax merged pull request #14031: Docs: Include ZK Deprecation notice and information

2023-07-18 Thread via GitHub
mjsax merged PR #14031: URL: https://github.com/apache/kafka/pull/14031 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] cmccabe commented on a diff in pull request #14010: KAFKA-15183: Add more controller, loader, snapshot emitter metrics

2023-07-18 Thread via GitHub
cmccabe commented on code in PR #14010: URL: https://github.com/apache/kafka/pull/14010#discussion_r1267289475 ## metadata/src/main/java/org/apache/kafka/controller/metrics/QuorumControllerMetrics.java: ## @@ -176,17 +210,53 @@ public long dualWriteOffset() { } publi

[jira] [Updated] (KAFKA-15091) Javadocs for SourceTask::commit are incorrect

2023-07-18 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-15091: -- Fix Version/s: 3.3.3 > Javadocs for SourceTask::commit are incorrect > ---

[GitHub] [kafka] cmccabe commented on a diff in pull request #14010: KAFKA-15183: Add more controller, loader, snapshot emitter metrics

2023-07-18 Thread via GitHub
cmccabe commented on code in PR #14010: URL: https://github.com/apache/kafka/pull/14010#discussion_r1267289020 ## metadata/src/main/java/org/apache/kafka/controller/metrics/QuorumControllerMetrics.java: ## @@ -113,7 +124,30 @@ public Long value() { return time.m

[jira] [Updated] (KAFKA-15091) Javadocs for SourceTask::commit are incorrect

2023-07-18 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-15091: -- Fix Version/s: 3.4.2 > Javadocs for SourceTask::commit are incorrect > ---

[GitHub] [kafka] cmccabe commented on a diff in pull request #14010: KAFKA-15183: Add more controller, loader, snapshot emitter metrics

2023-07-18 Thread via GitHub
cmccabe commented on code in PR #14010: URL: https://github.com/apache/kafka/pull/14010#discussion_r1267287803 ## metadata/src/main/java/org/apache/kafka/image/loader/MetadataLoader.java: ## @@ -418,24 +415,30 @@ LogDeltaManifest loadLogDelta( public void handleLoadSnapshot

[jira] [Updated] (KAFKA-15091) Javadocs for SourceTask::commit are incorrect

2023-07-18 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-15091: -- Fix Version/s: 3.5.2 > Javadocs for SourceTask::commit are incorrect > ---

[GitHub] [kafka] C0urante merged pull request #13948: KAFKA-15091: Fix misleading Javadoc for SourceTask::commit

2023-07-18 Thread via GitHub
C0urante merged PR #13948: URL: https://github.com/apache/kafka/pull/13948 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] C0urante commented on a diff in pull request #13948: KAFKA-15091: Fix misleading Javadoc for SourceTask::commit

2023-07-18 Thread via GitHub
C0urante commented on code in PR #13948: URL: https://github.com/apache/kafka/pull/13948#discussion_r1267283474 ## connect/api/src/main/java/org/apache/kafka/connect/source/SourceTask.java: ## @@ -105,9 +105,11 @@ public void initialize(SourceTaskContext context) { public a

[GitHub] [kafka] C0urante commented on a diff in pull request #13948: KAFKA-15091: Fix misleading Javadoc for SourceTask::commit

2023-07-18 Thread via GitHub
C0urante commented on code in PR #13948: URL: https://github.com/apache/kafka/pull/13948#discussion_r1267278752 ## connect/api/src/main/java/org/apache/kafka/connect/source/SourceTask.java: ## @@ -105,9 +105,11 @@ public void initialize(SourceTaskContext context) { public a

[jira] [Assigned] (KAFKA-12842) Failing test: org.apache.kafka.connect.integration.ConnectWorkerIntegrationTest.testSourceTaskNotBlockedOnShutdownWithNonExistentTopic

2023-07-18 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris reassigned KAFKA-12842: --- Assignee: Greg Harris > Failing test: > org.apache.kafka.connect.integration.ConnectWorker

[jira] [Assigned] (KAFKA-8690) Flakey test ConnectWorkerIntegrationTest#testAddAndRemoveWorke

2023-07-18 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris reassigned KAFKA-8690: -- Assignee: Greg Harris > Flakey test ConnectWorkerIntegrationTest#testAddAndRemoveWorke >

[jira] [Assigned] (KAFKA-10579) Flaky test connect.integration.InternalTopicsIntegrationTest.testStartWhenInternalTopicsCreatedManuallyWithCompactForBrokersDefaultCleanupPolicy

2023-07-18 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris reassigned KAFKA-10579: --- Assignee: Greg Harris > Flaky test > connect.integration.InternalTopicsIntegrationTest.tes

[GitHub] [kafka] forlack commented on pull request #14031: Docs: Include ZK Deprecation notice and information

2023-07-18 Thread via GitHub
forlack commented on PR #14031: URL: https://github.com/apache/kafka/pull/14031#issuecomment-1640948633 I updated the sentence suggested by @ijuma -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (KAFKA-15214) Add metrics for OffsetOutOfRangeException when tiered storage is enabled

2023-07-18 Thread Lixin Yao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744347#comment-17744347 ] Lixin Yao commented on KAFKA-15214: --- Here is one of the example scenarios motivates me

[GitHub] [kafka] cmccabe commented on a diff in pull request #14010: KAFKA-15183: Add more controller, loader, snapshot emitter metrics

2023-07-18 Thread via GitHub
cmccabe commented on code in PR #14010: URL: https://github.com/apache/kafka/pull/14010#discussion_r1267254133 ## metadata/src/main/java/org/apache/kafka/controller/metrics/QuorumControllerMetrics.java: ## @@ -113,7 +124,30 @@ public Long value() { return time.m

[GitHub] [kafka] cmccabe commented on a diff in pull request #14010: KAFKA-15183: Add more controller, loader, snapshot emitter metrics

2023-07-18 Thread via GitHub
cmccabe commented on code in PR #14010: URL: https://github.com/apache/kafka/pull/14010#discussion_r1267253682 ## metadata/src/main/java/org/apache/kafka/controller/metrics/QuorumControllerMetrics.java: ## @@ -113,7 +124,30 @@ public Long value() { return time.m

[GitHub] [kafka] cmccabe commented on a diff in pull request #14010: KAFKA-15183: Add more controller, loader, snapshot emitter metrics

2023-07-18 Thread via GitHub
cmccabe commented on code in PR #14010: URL: https://github.com/apache/kafka/pull/14010#discussion_r1267252934 ## core/src/main/scala/kafka/server/SharedServer.scala: ## @@ -282,15 +294,15 @@ class SharedServer( setDisabledReason(snapshotsDisabledReason). s

[GitHub] [kafka] cmccabe commented on a diff in pull request #14010: KAFKA-15183: Add more controller, loader, snapshot emitter metrics

2023-07-18 Thread via GitHub
cmccabe commented on code in PR #14010: URL: https://github.com/apache/kafka/pull/14010#discussion_r1267251882 ## core/src/main/scala/kafka/server/SharedServer.scala: ## @@ -282,15 +294,15 @@ class SharedServer( setDisabledReason(snapshotsDisabledReason). s

[GitHub] [kafka] cmccabe commented on a diff in pull request #14010: KAFKA-15183: Add more controller, loader, snapshot emitter metrics

2023-07-18 Thread via GitHub
cmccabe commented on code in PR #14010: URL: https://github.com/apache/kafka/pull/14010#discussion_r1267251209 ## core/src/main/scala/kafka/server/SharedServer.scala: ## @@ -259,15 +262,24 @@ class SharedServer( raftManager = _raftManager _raftManager.startup()

[GitHub] [kafka] cmccabe commented on a diff in pull request #14010: KAFKA-15183: Add more controller, loader, snapshot emitter metrics

2023-07-18 Thread via GitHub
cmccabe commented on code in PR #14010: URL: https://github.com/apache/kafka/pull/14010#discussion_r1267248743 ## metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java: ## @@ -782,7 +735,7 @@ public void testTimeouts() throws Throwable { b

[GitHub] [kafka] cmccabe commented on a diff in pull request #14010: KAFKA-15183: Add more controller, loader, snapshot emitter metrics

2023-07-18 Thread via GitHub
cmccabe commented on code in PR #14010: URL: https://github.com/apache/kafka/pull/14010#discussion_r1267249264 ## metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java: ## @@ -140,39 +142,6 @@ public class QuorumControllerTest { static final Bootstrap

[GitHub] [kafka] gharris1727 commented on a diff in pull request #13971: KAFKA-15150: Add ServiceLoaderScanner implementation

2023-07-18 Thread via GitHub
gharris1727 commented on code in PR #13971: URL: https://github.com/apache/kafka/pull/13971#discussion_r1267248169 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/PluginScanner.java: ## @@ -118,35 +120,80 @@ private void loadJdbcDrivers(final ClassLoa

[GitHub] [kafka] cmccabe commented on a diff in pull request #14010: KAFKA-15183: Add more controller, loader, snapshot emitter metrics

2023-07-18 Thread via GitHub
cmccabe commented on code in PR #14010: URL: https://github.com/apache/kafka/pull/14010#discussion_r1267246622 ## metadata/src/test/java/org/apache/kafka/image/loader/metrics/MetadataLoaderMetricsTest.java: ## @@ -0,0 +1,148 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] C0urante commented on a diff in pull request #14024: KAFKA-13431: Expose the original pre-transform topic partition and offset in sink records

2023-07-18 Thread via GitHub
C0urante commented on code in PR #14024: URL: https://github.com/apache/kafka/pull/14024#discussion_r1267245540 ## connect/api/src/main/java/org/apache/kafka/connect/sink/SinkRecord.java: ## @@ -65,7 +180,8 @@ public SinkRecord newRecord(String topic, Integer kafkaPartition, Sc

[GitHub] [kafka] C0urante commented on a diff in pull request #13971: KAFKA-15150: Add ServiceLoaderScanner implementation

2023-07-18 Thread via GitHub
C0urante commented on code in PR #13971: URL: https://github.com/apache/kafka/pull/13971#discussion_r1267237169 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/PluginScanner.java: ## @@ -118,35 +120,80 @@ private void loadJdbcDrivers(final ClassLoader

[GitHub] [kafka] C0urante commented on a diff in pull request #13971: KAFKA-15150: Add ServiceLoaderScanner implementation

2023-07-18 Thread via GitHub
C0urante commented on code in PR #13971: URL: https://github.com/apache/kafka/pull/13971#discussion_r1267238592 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/PluginScanner.java: ## @@ -118,35 +120,80 @@ private void loadJdbcDrivers(final ClassLoader

[GitHub] [kafka] C0urante commented on a diff in pull request #13971: KAFKA-15150: Add ServiceLoaderScanner implementation

2023-07-18 Thread via GitHub
C0urante commented on code in PR #13971: URL: https://github.com/apache/kafka/pull/13971#discussion_r1267236920 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/PluginScanner.java: ## @@ -118,35 +120,80 @@ private void loadJdbcDrivers(final ClassLoader

[jira] [Updated] (KAFKA-14669) Include MirrorMaker connector configurations in docs

2023-07-18 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-14669: -- Priority: Blocker (was: Major) > Include MirrorMaker connector configurations in docs > -

[jira] [Commented] (KAFKA-14669) Include MirrorMaker connector configurations in docs

2023-07-18 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744337#comment-17744337 ] Chris Egerton commented on KAFKA-14669: --- Reopening and marking as a blocker with f

[jira] [Reopened] (KAFKA-14669) Include MirrorMaker connector configurations in docs

2023-07-18 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton reopened KAFKA-14669: --- > Include MirrorMaker connector configurations in docs > ---

[GitHub] [kafka] C0urante commented on pull request #14041: KAFKA-14469: Add MirrorMaker 2 configs to table of contents in docs page

2023-07-18 Thread via GitHub
C0urante commented on PR #14041: URL: https://github.com/apache/kafka/pull/14041#issuecomment-1640847533 CC @tinaselenge; sorry for missing this during review! Just wanted to give you a heads-up in case you make or review docs changes in the future. @gharris1727 @mimaison would apprec

[GitHub] [kafka] C0urante opened a new pull request, #14041: KAFKA-14469: Add MirrorMaker 2 configs to table of contents in docs page

2023-07-18 Thread via GitHub
C0urante opened a new pull request, #14041: URL: https://github.com/apache/kafka/pull/14041 Follow-up for https://github.com/apache/kafka/pull/13658, where we forgot to update the table of contents to include the new 3.8 section for MirrorMaker 2. ### Committer Checklist (excluded fr

[jira] [Commented] (KAFKA-15214) Add metrics for OffsetOutOfRangeException when tiered storage is enabled

2023-07-18 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744334#comment-17744334 ] Divij Vaidya commented on KAFKA-15214: -- Hi Lixin Can you help us understand more ab

[GitHub] [kafka] bmscomp commented on pull request #14032: MINOR: Upgrade Gradle wrapper version to 8.2.1

2023-07-18 Thread via GitHub
bmscomp commented on PR #14032: URL: https://github.com/apache/kafka/pull/14032#issuecomment-1640794180 @divijvaidya It's a rebase issue, now that I am using the last version of `.asf.yam` as an issue is fixed before the execution is going on -- This is an automated message from the

[GitHub] [kafka] divijvaidya commented on pull request #14032: MINOR: Upgrade Gradle wrapper version to 8.2.1

2023-07-18 Thread via GitHub
divijvaidya commented on PR #14032: URL: https://github.com/apache/kafka/pull/14032#issuecomment-1640773987 Tests are failing with a related error. ``` * What went wrong: Gradle could not start your build. > Cannot create service of type BuildSessionActionExecutor using me

[GitHub] [kafka] stevenbooke commented on pull request #13842: KAFKA-14995: Automate asf.yaml collaborators refresh

2023-07-18 Thread via GitHub
stevenbooke commented on PR #13842: URL: https://github.com/apache/kafka/pull/13842#issuecomment-1640762194 As you have recommended, the script will create a new branch for the changes, commit the changes to the new branch, and open a pull request with the updated `.asf.yaml` file. The upda

[GitHub] [kafka] Staniel commented on a diff in pull request #13944: KAFKA-14953: Add tiered storage related metrics

2023-07-18 Thread via GitHub
Staniel commented on code in PR #13944: URL: https://github.com/apache/kafka/pull/13944#discussion_r1267173038 ## core/src/main/java/kafka/log/remote/RemoteLogReader.java: ## @@ -54,10 +60,14 @@ public Void call() { logger.debug("Reading records from remote storage

[GitHub] [kafka] stevenbooke commented on a diff in pull request #13842: KAFKA-14995: Automate asf.yaml collaborators refresh

2023-07-18 Thread via GitHub
stevenbooke commented on code in PR #13842: URL: https://github.com/apache/kafka/pull/13842#discussion_r1267168635 ## refresh-collaborators.py: ## @@ -0,0 +1,67 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the N

[jira] [Updated] (KAFKA-15214) Add metrics for OffsetOutOfRangeException when tiered storage is enabled

2023-07-18 Thread Lixin Yao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lixin Yao updated KAFKA-15214: -- Description: In the current metrics RemoteReadErrorsPerSec, the exception type OffsetOutOfRangeExcept

[GitHub] [kafka] tanay27 opened a new pull request, #14040: KAFKA-15212: Delete Classgraph-MIT license

2023-07-18 Thread via GitHub
tanay27 opened a new pull request, #14040: URL: https://github.com/apache/kafka/pull/14040 Deleted classgraph MIT result file. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Ve

[jira] [Created] (KAFKA-15214) Add metrics for OffsetOutOfRangeException when tiered storage is enabled

2023-07-18 Thread Lixin Yao (Jira)
Lixin Yao created KAFKA-15214: - Summary: Add metrics for OffsetOutOfRangeException when tiered storage is enabled Key: KAFKA-15214 URL: https://issues.apache.org/jira/browse/KAFKA-15214 Project: Kafka

[jira] [Assigned] (KAFKA-15212) Remove unneeded classgraph license file

2023-07-18 Thread Tanay Karmarkar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tanay Karmarkar reassigned KAFKA-15212: --- Assignee: Tanay Karmarkar > Remove unneeded classgraph license file > -

[GitHub] [kafka] bmscomp commented on a diff in pull request #14032: MINOR: Upgrade Gradle wrapper version to 8.2.1

2023-07-18 Thread via GitHub
bmscomp commented on code in PR #14032: URL: https://github.com/apache/kafka/pull/14032#discussion_r1267159224 ## gradle/wrapper/gradle-wrapper.properties: ## @@ -1,7 +1,7 @@ distributionBase=GRADLE_USER_HOME distributionPath=wrapper/dists -distributionSha256Sum=5625a0ae20fe00

[jira] [Comment Edited] (KAFKA-15190) Allow configuring a streams process ID

2023-07-18 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744288#comment-17744288 ] Matthias J. Sax edited comment on KAFKA-15190 at 7/18/23 6:22 PM:

[GitHub] [kafka] gharris1727 opened a new pull request, #14039: KAFKA-15211: Mock InvalidParameterException in DistributedConfigTest

2023-07-18 Thread via GitHub
gharris1727 opened a new pull request, #14039: URL: https://github.com/apache/kafka/pull/14039 This exception doesn't get thrown by the BouncyCastleProvider's implementation of HmacSHA256, so simulate the error just in case BouncyCastle is loaded before the test is run. ### Committer

[GitHub] [kafka] Staniel commented on a diff in pull request #13944: KAFKA-14953: Add tiered storage related metrics

2023-07-18 Thread via GitHub
Staniel commented on code in PR #13944: URL: https://github.com/apache/kafka/pull/13944#discussion_r1267143752 ## core/src/main/java/kafka/log/remote/RemoteLogReader.java: ## @@ -54,10 +60,14 @@ public Void call() { logger.debug("Reading records from remote storage

[GitHub] [kafka] cmccabe commented on a diff in pull request #13643: KAFKA-15213: provide the exact offset to QuorumController.replay

2023-07-18 Thread via GitHub
cmccabe commented on code in PR #13643: URL: https://github.com/apache/kafka/pull/13643#discussion_r1267142346 ## raft/src/main/java/org/apache/kafka/raft/internals/BatchAccumulator.java: ## @@ -89,52 +91,12 @@ public BatchAccumulator( this.appendLock = new ReentrantLoc

[GitHub] [kafka] cmccabe commented on a diff in pull request #13643: KAFKA-15213: provide the exact offset to QuorumController.replay

2023-07-18 Thread via GitHub
cmccabe commented on code in PR #13643: URL: https://github.com/apache/kafka/pull/13643#discussion_r1267137597 ## raft/src/main/java/org/apache/kafka/raft/RaftClient.java: ## @@ -172,15 +176,17 @@ default void beginShutdown() {} * uncommitted entries after observing an epo

[GitHub] [kafka] cmccabe commented on a diff in pull request #13643: MINOR: provide the exact offset to QuorumController.replay

2023-07-18 Thread via GitHub
cmccabe commented on code in PR #13643: URL: https://github.com/apache/kafka/pull/13643#discussion_r1267130598 ## raft/src/main/java/org/apache/kafka/raft/RaftClient.java: ## @@ -80,8 +81,11 @@ interface Listener { * epoch. * * @param leader the cur

[jira] [Updated] (KAFKA-8466) Remove 'jackson-module-scala' dependency (and replace it with some code)

2023-07-18 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-8466: Labels: newbie (was: ) > Remove 'jackson-module-scala' dependency (and replace it with some code)

[jira] [Created] (KAFKA-15213) Provide the exact offset to QuorumController.replay

2023-07-18 Thread Colin McCabe (Jira)
Colin McCabe created KAFKA-15213: Summary: Provide the exact offset to QuorumController.replay Key: KAFKA-15213 URL: https://issues.apache.org/jira/browse/KAFKA-15213 Project: Kafka Issue Typ

[jira] [Commented] (KAFKA-8466) Remove 'jackson-module-scala' dependency (and replace it with some code)

2023-07-18 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744315#comment-17744315 ] Divij Vaidya commented on KAFKA-8466: - Based on the comment above marking as Unassign

[jira] [Assigned] (KAFKA-8466) Remove 'jackson-module-scala' dependency (and replace it with some code)

2023-07-18 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya reassigned KAFKA-8466: --- Assignee: (was: Dejan Stojadinović) > Remove 'jackson-module-scala' dependency (and repl

[jira] [Updated] (KAFKA-15000) High vulnerability PRISMA-2023-0067 reported in jackson-core

2023-07-18 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-15000: - Affects Version/s: 3.5.1 > High vulnerability PRISMA-2023-0067 reported in jackson-core > --

[jira] [Updated] (KAFKA-15000) High vulnerability PRISMA-2023-0067 reported in jackson-core

2023-07-18 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-15000: - Fix Version/s: 3.6.0 > High vulnerability PRISMA-2023-0067 reported in jackson-core > --

[jira] [Updated] (KAFKA-15212) Remove unneeded classgraph license file

2023-07-18 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-15212: - Summary: Remove unneeded classgraph license file (was: Remove classgraph license) > Remove unn

[jira] [Created] (KAFKA-15212) Remove classgraph license

2023-07-18 Thread Divij Vaidya (Jira)
Divij Vaidya created KAFKA-15212: Summary: Remove classgraph license Key: KAFKA-15212 URL: https://issues.apache.org/jira/browse/KAFKA-15212 Project: Kafka Issue Type: Bug Reporte

[jira] [Created] (KAFKA-15211) DistributedConfigTest#shouldFailWithInvalidKeySize fails when run after TestSslUtils#generate

2023-07-18 Thread Greg Harris (Jira)
Greg Harris created KAFKA-15211: --- Summary: DistributedConfigTest#shouldFailWithInvalidKeySize fails when run after TestSslUtils#generate Key: KAFKA-15211 URL: https://issues.apache.org/jira/browse/KAFKA-15211

[jira] [Assigned] (KAFKA-15208) Upgrade Jackson dependencies to version 2.15.2

2023-07-18 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya reassigned KAFKA-15208: Assignee: Said BOUDJELDA > Upgrade Jackson dependencies to version 2.15.2 > -

[jira] [Updated] (KAFKA-15208) Upgrade Jackson dependencies to version 2.15.2

2023-07-18 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-15208: - Fix Version/s: 3.6.0 > Upgrade Jackson dependencies to version 2.15.2 >

[jira] [Resolved] (KAFKA-10775) DOAP has incorrect category

2023-07-18 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-10775. Fix Version/s: 3.1.0 Assignee: Sebb Resolution: Fixed > DOAP has incorrect

[GitHub] [kafka] mimaison commented on pull request #11423: Update doap_Kafka.rdf

2023-07-18 Thread via GitHub
mimaison commented on PR #11423: URL: https://github.com/apache/kafka/pull/11423#issuecomment-1640685154 Right, I wasn't aware of the associated ticket. I closed it now. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] divijvaidya commented on a diff in pull request #14032: MINOR: Upgrade Gradle wrapper version to 8.2.1

2023-07-18 Thread via GitHub
divijvaidya commented on code in PR #14032: URL: https://github.com/apache/kafka/pull/14032#discussion_r1267117269 ## gradle/wrapper/gradle-wrapper.properties: ## @@ -1,7 +1,7 @@ distributionBase=GRADLE_USER_HOME distributionPath=wrapper/dists -distributionSha256Sum=5625a0ae20

[jira] [Assigned] (KAFKA-15205) Race condition in ShutdownableThread causes InterruptedException

2023-07-18 Thread Tanay Karmarkar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tanay Karmarkar reassigned KAFKA-15205: --- Assignee: (was: Tanay Karmarkar) > Race condition in ShutdownableThread causes

[jira] [Assigned] (KAFKA-15205) Race condition in ShutdownableThread causes InterruptedException

2023-07-18 Thread Tanay Karmarkar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tanay Karmarkar reassigned KAFKA-15205: --- Assignee: Tanay Karmarkar > Race condition in ShutdownableThread causes Interrupted

[jira] [Assigned] (KAFKA-15199) remove leading and trailing spaces from user input in release.py

2023-07-18 Thread Tanay Karmarkar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tanay Karmarkar reassigned KAFKA-15199: --- Assignee: Tanay Karmarkar > remove leading and trailing spaces from user input in r

[GitHub] [kafka] nizhikov commented on pull request #13278: KAFKA-14591 DeleteRecordsCommand moved to tools

2023-07-18 Thread via GitHub
nizhikov commented on PR #13278: URL: https://github.com/apache/kafka/pull/13278#issuecomment-164085 @mimaison Thanks for the review. It seems I addressed all your comments. Please, take a look one more time. -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [kafka] gharris1727 commented on a diff in pull request #13971: KAFKA-15150: Add ServiceLoaderScanner implementation

2023-07-18 Thread via GitHub
gharris1727 commented on code in PR #13971: URL: https://github.com/apache/kafka/pull/13971#discussion_r1267103768 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/PluginScanner.java: ## @@ -118,35 +120,80 @@ private void loadJdbcDrivers(final ClassLoa

[GitHub] [kafka] nizhikov commented on a diff in pull request #13278: KAFKA-14591 DeleteRecordsCommand moved to tools

2023-07-18 Thread via GitHub
nizhikov commented on code in PR #13278: URL: https://github.com/apache/kafka/pull/13278#discussion_r1267096601 ## server-common/src/main/java/org/apache/kafka/server/util/CoreUtils.java: ## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m

[jira] [Commented] (KAFKA-10775) DOAP has incorrect category

2023-07-18 Thread Piotr Zygielo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744305#comment-17744305 ] Piotr Zygielo commented on KAFKA-10775: --- May I ask to have it closed, please? I c

[GitHub] [kafka] gharris1727 commented on a diff in pull request #13971: KAFKA-15150: Add ServiceLoaderScanner implementation

2023-07-18 Thread via GitHub
gharris1727 commented on code in PR #13971: URL: https://github.com/apache/kafka/pull/13971#discussion_r1267094589 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/PluginScanner.java: ## @@ -118,35 +120,80 @@ private void loadJdbcDrivers(final ClassLoa

[GitHub] [kafka] nizhikov commented on a diff in pull request #13278: KAFKA-14591 DeleteRecordsCommand moved to tools

2023-07-18 Thread via GitHub
nizhikov commented on code in PR #13278: URL: https://github.com/apache/kafka/pull/13278#discussion_r1267093982 ## server-common/src/main/java/org/apache/kafka/server/util/CoreUtils.java: ## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m

[GitHub] [kafka] nizhikov commented on a diff in pull request #13278: KAFKA-14591 DeleteRecordsCommand moved to tools

2023-07-18 Thread via GitHub
nizhikov commented on code in PR #13278: URL: https://github.com/apache/kafka/pull/13278#discussion_r1267084525 ## tools/src/main/java/org/apache/kafka/tools/DeleteRecordsCommand.java: ## @@ -0,0 +1,220 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mor

[GitHub] [kafka] gharris1727 commented on a diff in pull request #13971: KAFKA-15150: Add ServiceLoaderScanner implementation

2023-07-18 Thread via GitHub
gharris1727 commented on code in PR #13971: URL: https://github.com/apache/kafka/pull/13971#discussion_r1267082036 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/PluginScanner.java: ## @@ -118,35 +120,80 @@ private void loadJdbcDrivers(final ClassLoa

[jira] [Commented] (KAFKA-15207) ProducerIdManager#generateProducerId() should return different error code for newer clients

2023-07-18 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744300#comment-17744300 ] Justine Olshan commented on KAFKA-15207: It's a bit tricky to know when we are r

  1   2   3   >