[GitHub] [kafka] fvaleri commented on pull request #13562: KAFKA-14581: Moving GetOffsetShell to tools

2023-07-18 Thread via GitHub
fvaleri commented on PR #13562: URL: https://github.com/apache/kafka/pull/13562#issuecomment-1639858809 Just wanted to let you know that TopicFilter and related classes have been merged, so you can rebase this PR from trunk. -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] ijuma commented on a diff in pull request #14031: Docs: Include ZK Deprecation notice and information

2023-07-18 Thread via GitHub
ijuma commented on code in PR #14031: URL: https://github.com/apache/kafka/pull/14031#discussion_r1266492977 ## docs/ops.html: ## @@ -3482,8 +3482,24 @@ 6.9 Stable version The current stable branch is 3.5. Kafka is regularly updated to include the latest release in the

[GitHub] [kafka] showuon commented on a diff in pull request #14028: KAFKA-15196 Additional ZK migration metrics

2023-07-18 Thread via GitHub
showuon commented on code in PR #14028: URL: https://github.com/apache/kafka/pull/14028#discussion_r1266313198 ## metadata/src/main/java/org/apache/kafka/controller/metrics/ControllerMetadataMetrics.java: ## @@ -117,6 +120,15 @@ public Integer value() { return (

[jira] [Comment Edited] (KAFKA-15181) Race condition on partition assigned to TopicBasedRemoteLogMetadataManager

2023-07-18 Thread Abhijeet Kumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744124#comment-17744124 ] Abhijeet Kumar edited comment on KAFKA-15181 at 7/18/23 9:08 AM: -

[jira] [Commented] (KAFKA-15181) Race condition on partition assigned to TopicBasedRemoteLogMetadataManager

2023-07-18 Thread Abhijeet Kumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744124#comment-17744124 ] Abhijeet Kumar commented on KAFKA-15181: As far as I know, the ReplicaFetcher ke

[GitHub] [kafka] satishd commented on a diff in pull request #14012: KAFKA-15181: fix(storage): wait for consumer to be synced after assigning partitions

2023-07-18 Thread via GitHub
satishd commented on code in PR #14012: URL: https://github.com/apache/kafka/pull/14012#discussion_r1266471753 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerManager.java: ## @@ -139,6 +163,35 @@ public void close() throws IOException {

[GitHub] [kafka] mimaison merged pull request #13585: KAFKA-14737: Move kafka.utils.json to server-common

2023-07-18 Thread via GitHub
mimaison merged PR #13585: URL: https://github.com/apache/kafka/pull/13585 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] mimaison merged pull request #13158: KAFKA-14647: Moving TopicFilter to server-common/utils

2023-07-18 Thread via GitHub
mimaison merged PR #13158: URL: https://github.com/apache/kafka/pull/13158 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] kamalcph commented on a diff in pull request #14012: KAFKA-15181: fix(storage): wait for consumer to be synced after assigning partitions

2023-07-18 Thread via GitHub
kamalcph commented on code in PR #14012: URL: https://github.com/apache/kafka/pull/14012#discussion_r1266424383 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerManager.java: ## @@ -139,6 +163,35 @@ public void close() throws IOException {

[jira] [Commented] (KAFKA-14467) Add a test to validate the replica state after processing the OFFSET_MOVED_TO_TIERED_STORAGE error, especially for the transactional state

2023-07-18 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744105#comment-17744105 ] Divij Vaidya commented on KAFKA-14467: -- Oh, I should have mentioned. I talked to [~

[GitHub] [kafka] divijvaidya commented on pull request #14032: MINOR: Upgrade Gradle wrapper version to 8.2.1

2023-07-18 Thread via GitHub
divijvaidya commented on PR #14032: URL: https://github.com/apache/kafka/pull/14032#issuecomment-1639755398 Need a change at https://github.com/apache/kafka/blob/2574bef61c7c53a8db6b23f8cde990cbe3fa2e11/gradlew#L118 as well. Please refer to your previous commit for the files that need to be

[GitHub] [kafka] divijvaidya commented on pull request #14029: KAFKA-10579: Upgrade reflections from 0.9.12 to 0.10.2

2023-07-18 Thread via GitHub
divijvaidya commented on PR #14029: URL: https://github.com/apache/kafka/pull/14029#issuecomment-1639749126 Looks good. Separately, I believe we should migrate away from this library since it not under active maintenance since 2021. This poses a supply chain risk to this project. I have cre

[jira] [Updated] (KAFKA-15203) Remove dependency on Reflections

2023-07-18 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-15203: - Component/s: connect > Remove dependency on Reflections > - > >

[jira] [Created] (KAFKA-15203) Remove dependency on Reflections

2023-07-18 Thread Divij Vaidya (Jira)
Divij Vaidya created KAFKA-15203: Summary: Remove dependency on Reflections Key: KAFKA-15203 URL: https://issues.apache.org/jira/browse/KAFKA-15203 Project: Kafka Issue Type: Bug

[GitHub] [kafka] divijvaidya commented on pull request #13837: KAFKA-9564: Local Tiered Storage implementation for Remote Storage Manager

2023-07-18 Thread via GitHub
divijvaidya commented on PR #13837: URL: https://github.com/apache/kafka/pull/13837#issuecomment-1639739419 Hey @satishd In case you didn't know, you can add co-authors in the commit by adding a line at the end of commit such as: ``` - Co-authored-by: Person2 ```

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #13983: KAFKA-14734: Use CommandDefaultOptions in StreamsResetter

2023-07-18 Thread via GitHub
vamossagar12 commented on code in PR #13983: URL: https://github.com/apache/kafka/pull/13983#discussion_r1266402516 ## tools/src/main/java/org/apache/kafka/tools/StreamsResetter.java: ## @@ -133,77 +112,69 @@ public class StreamsResetter { + "*** Warning! This tool

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #13983: KAFKA-14734: Use CommandDefaultOptions in StreamsResetter

2023-07-18 Thread via GitHub
vamossagar12 commented on code in PR #13983: URL: https://github.com/apache/kafka/pull/13983#discussion_r1266400659 ## tools/src/main/java/org/apache/kafka/tools/StreamsResetter.java: ## @@ -703,8 +544,216 @@ public static boolean matchesInternalTopicFormat(final String topicNa

[GitHub] [kafka] fvaleri commented on a diff in pull request #13983: KAFKA-14734: Use CommandDefaultOptions in StreamsResetter

2023-07-18 Thread via GitHub
fvaleri commented on code in PR #13983: URL: https://github.com/apache/kafka/pull/13983#discussion_r1266396090 ## tools/src/main/java/org/apache/kafka/tools/StreamsResetter.java: ## @@ -133,77 +112,69 @@ public class StreamsResetter { + "*** Warning! This tool makes

[GitHub] [kafka] showuon commented on a diff in pull request #14012: KAFKA-15181: fix(storage): wait for consumer to be synced after assigning partitions

2023-07-18 Thread via GitHub
showuon commented on code in PR #14012: URL: https://github.com/apache/kafka/pull/14012#discussion_r1266396163 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerManager.java: ## @@ -139,6 +163,35 @@ public void close() throws IOException {

[GitHub] [kafka] fvaleri commented on a diff in pull request #13983: KAFKA-14734: Use CommandDefaultOptions in StreamsResetter

2023-07-18 Thread via GitHub
fvaleri commented on code in PR #13983: URL: https://github.com/apache/kafka/pull/13983#discussion_r1266396090 ## tools/src/main/java/org/apache/kafka/tools/StreamsResetter.java: ## @@ -133,77 +112,69 @@ public class StreamsResetter { + "*** Warning! This tool makes

[jira] [Commented] (KAFKA-14467) Add a test to validate the replica state after processing the OFFSET_MOVED_TO_TIERED_STORAGE error, especially for the transactional state

2023-07-18 Thread hudeqi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744087#comment-17744087 ] hudeqi commented on KAFKA-14467: Isn't this issue [~showuon]  in charge ? > Add a test

[GitHub] [kafka] vamossagar12 commented on pull request #13158: KAFKA-14647: Moving TopicFilter to server-common/utils

2023-07-18 Thread via GitHub
vamossagar12 commented on PR #13158: URL: https://github.com/apache/kafka/pull/13158#issuecomment-1639693030 @mimaison can this be merged if all changes look fine? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [kafka] vamossagar12 commented on pull request #13283: KAFKA-13152: Kip 770 buffer size fix

2023-07-18 Thread via GitHub
vamossagar12 commented on PR #13283: URL: https://github.com/apache/kafka/pull/13283#issuecomment-1639692086 @mjsax , @guozhangwang this has been marked for 3.6 release. If possible can it be reviewed? -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #13983: KAFKA-14734: Use CommandDefaultOptions in StreamsResetter

2023-07-18 Thread via GitHub
vamossagar12 commented on code in PR #13983: URL: https://github.com/apache/kafka/pull/13983#discussion_r1266363807 ## tools/src/main/java/org/apache/kafka/tools/StreamsResetter.java: ## @@ -513,8 +373,8 @@ private void resetByDuration(final Consumer client, // visible f

[GitHub] [kafka] kamalcph commented on a diff in pull request #14012: KAFKA-15181: fix(storage): wait for consumer to be synced after assigning partitions

2023-07-18 Thread via GitHub
kamalcph commented on code in PR #14012: URL: https://github.com/apache/kafka/pull/14012#discussion_r1266337735 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerManager.java: ## @@ -139,6 +163,35 @@ public void close() throws IOException {

[GitHub] [kafka] satishd opened a new pull request, #14034: KAFKA-14483 Move/Rewrite of LocalLog to storage module.

2023-07-18 Thread via GitHub
satishd opened a new pull request, #14034: URL: https://github.com/apache/kafka/pull/14034 KAFKA-14483 Move/Rewrite of LocalLog to storage module. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI bui

[GitHub] [kafka] artemlivshits commented on a diff in pull request #14033: KAFKA-14920: Address timeouts and out of order sequences

2023-07-18 Thread via GitHub
artemlivshits commented on code in PR #14033: URL: https://github.com/apache/kafka/pull/14033#discussion_r1266314760 ## storage/src/main/java/org/apache/kafka/storage/internals/log/VerificationStateEntry.java: ## @@ -41,4 +48,21 @@ public long timestamp() { public Object ve

<    1   2   3