vamossagar12 commented on PR #14051:
URL: https://github.com/apache/kafka/pull/14051#issuecomment-1646758971
Actually now that I think of it, instead of null check, can we =>
1) Remove the `canAddReplicaToIsr` call from
[here](https://github.com/apache/kafka/blob/trunk/core/src/main/s
ex172000 commented on code in PR #14075:
URL: https://github.com/apache/kafka/pull/14075#discussion_r1271382072
##
build.gradle:
##
@@ -808,10 +809,9 @@ if (userEnableTestCoverage) {
executionData.from = javaProjects.jacocoTestReport.executionData
reports {
- ht
[
https://issues.apache.org/jira/browse/KAFKA-15235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17745996#comment-17745996
]
Said BOUDJELDA commented on KAFKA-15235:
[~ethaden] I already made a pull reque
bmscomp opened a new pull request, #14075:
URL: https://github.com/apache/kafka/pull/14075
Fixing the Jacoco report generation issue, in the current Gradle version 8.x
### Committer Checklist (excluded from commit message)
- [x] Verify design and implementation
- [ ] Verify tes
[
https://issues.apache.org/jira/browse/KAFKA-15235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Said BOUDJELDA updated KAFKA-15235:
---
Description:
On current dev branch, gradle 8.x fails while trying to generate test coverage
[
https://issues.apache.org/jira/browse/KAFKA-15235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Said BOUDJELDA updated KAFKA-15235:
---
Description:
On current dev branch, gradle 8.x fails while trying to generate test coverage
[
https://issues.apache.org/jira/browse/KAFKA-15235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Said BOUDJELDA updated KAFKA-15235:
---
Description:
On current dev branch, gradle 8.x fails while trying to generate test coverage
[
https://issues.apache.org/jira/browse/KAFKA-15235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Said BOUDJELDA updated KAFKA-15235:
---
Labels: buid coverage gradle tools (was: )
> No test coverage reports for Java due to setti
[
https://issues.apache.org/jira/browse/KAFKA-15235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17745995#comment-17745995
]
Said BOUDJELDA commented on KAFKA-15235:
I think I have a solution for this, I'l
[
https://issues.apache.org/jira/browse/KAFKA-15235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Said BOUDJELDA reassigned KAFKA-15235:
--
Assignee: Said BOUDJELDA
> No test coverage reports for Java due to settings for Jaco
[
https://issues.apache.org/jira/browse/KAFKA-15235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Said BOUDJELDA updated KAFKA-15235:
---
Description:
On current dev branch, gradle 8.x fails while trying to generate test coverage
[
https://issues.apache.org/jira/browse/KAFKA-15235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Said BOUDJELDA updated KAFKA-15235:
---
Description:
On current dev branch, gradle 8.x fails while trying to generate test coverage
[
https://issues.apache.org/jira/browse/KAFKA-15235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Said BOUDJELDA updated KAFKA-15235:
---
Description:
On current dev branch, gradle 8.x fails while trying to generate test coverage
[
https://issues.apache.org/jira/browse/KAFKA-15235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Said BOUDJELDA updated KAFKA-15235:
---
Description:
On current dev branch, gradle 8.x fails while trying to generate test coverage
[
https://issues.apache.org/jira/browse/KAFKA-15235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17745985#comment-17745985
]
Said BOUDJELDA edited comment on KAFKA-15235 at 7/22/23 8:03 PM:
-
[
https://issues.apache.org/jira/browse/KAFKA-15235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17745985#comment-17745985
]
Said BOUDJELDA edited comment on KAFKA-15235 at 7/22/23 8:03 PM:
-
[
https://issues.apache.org/jira/browse/KAFKA-15235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17745985#comment-17745985
]
Said BOUDJELDA commented on KAFKA-15235:
I can give this a try if you want ?
>
[
https://issues.apache.org/jira/browse/KAFKA-1718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17745983#comment-17745983
]
Said BOUDJELDA commented on KAFKA-1718:
---
Does this bug exists always ?
> "Message
abhijeetk88 opened a new pull request, #14074:
URL: https://github.com/apache/kafka/pull/14074
[WIP]
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*S
abhijeetk88 opened a new pull request, #14073:
URL: https://github.com/apache/kafka/pull/14073
[WIP]
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*S
bmscomp commented on PR #14072:
URL: https://github.com/apache/kafka/pull/14072#issuecomment-1646649580
Checking the release notes the new version contains much dependency upgrades
and few bug fixing, sur no breaking changes :
https://github.com/xerial/snappy-java/releases/tag/v
bmscomp opened a new pull request, #14072:
URL: https://github.com/apache/kafka/pull/14072
This is a minor version upgrade of snappy compression library, to latest
stable version 1.1.10.3
### Committer Checklist (excluded from commit message)
- [x] Verify design and implementa
Abhijeet Kumar created KAFKA-15236:
--
Summary: Rename Remote Storage metrics to remove ambiguity
Key: KAFKA-15236
URL: https://issues.apache.org/jira/browse/KAFKA-15236
Project: Kafka
Issue T
Eike Thaden created KAFKA-15235:
---
Summary: No test coverage reports for Java due to settings for
Jacoco being incompatible with Gradle 8.x
Key: KAFKA-15235
URL: https://issues.apache.org/jira/browse/KAFKA-15235
ashmeet13 commented on PR #12988:
URL: https://github.com/apache/kafka/pull/12988#issuecomment-1646633996
Will be re-picking this. My bad for dropping this in the middle.
Will update soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
LinShunKang commented on code in PR #12685:
URL: https://github.com/apache/kafka/pull/12685#discussion_r1271319659
##
clients/src/main/java/org/apache/kafka/common/utils/Utils.java:
##
@@ -517,6 +519,50 @@ public static int murmur2(final byte[] data) {
return h;
}
muralibasani commented on PR #13417:
URL: https://github.com/apache/kafka/pull/13417#issuecomment-1646626261
> Hi, the behavior is different when I pass an invalid config file:
>
> ```shell
> ### OLD
> $ bin/kafka-storage.sh info -c
~/.local/tmp/kafka/server2/config/log4j.proper
muralibasani commented on PR #13417:
URL: https://github.com/apache/kafka/pull/13417#issuecomment-1646626123
@fvaleri code fixed based on review comments.
- new LogConfig constructor added
- new method to validate zk and broker config
- new test with zk config fail
--
This is an a
erikvanoosten opened a new pull request, #14071:
URL: https://github.com/apache/kafka/pull/14071
... so that alternative locking mechanisms can be explored. For example PR
#13914 could be implemented without changes to the Kafka library.
This idea was brought forward by Chris Egerton
[
https://issues.apache.org/jira/browse/KAFKA-15194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya updated KAFKA-15194:
-
Fix Version/s: 3.6.0
> Rename local tiered storage segment with offset as prefix for easy naviga
[
https://issues.apache.org/jira/browse/KAFKA-15194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya resolved KAFKA-15194.
--
Resolution: Fixed
> Rename local tiered storage segment with offset as prefix for easy navigat
divijvaidya commented on PR #14057:
URL: https://github.com/apache/kafka/pull/14057#issuecomment-1646565055
Thank you for your contribution @Owen-CH-Leung! Feel free to pick up more
KIP-405 related items from it's parent ticket.
--
This is an automated message from the Apache Git Service.
divijvaidya merged PR #14057:
URL: https://github.com/apache/kafka/pull/14057
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apa
tisonkun opened a new pull request, #14070:
URL: https://github.com/apache/kafka/pull/14070
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testin
muralibasani commented on PR #13417:
URL: https://github.com/apache/kafka/pull/13417#issuecomment-1646547619
> Hi, the behavior is different when I pass an invalid config file:
>
> ```shell
> ### OLD
> $ bin/kafka-storage.sh info -c
~/.local/tmp/kafka/server2/config/log4j.proper
nizhikov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1271272707
##
tools/src/main/java/org/apache/kafka/tools/reassign/ActiveMoveState.java:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
Divij Vaidya created KAFKA-15234:
Summary: Automate adding version to system tests
Key: KAFKA-15234
URL: https://issues.apache.org/jira/browse/KAFKA-15234
Project: Kafka
Issue Type: Sub-task
divijvaidya opened a new pull request, #14069:
URL: https://github.com/apache/kafka/pull/14069
Adding new version 3.5.1 to system tests as per
https://cwiki.apache.org/confluence/display/KAFKA/Release+Process
(search for "In trunk update the following files with the current release
n
muralibasani commented on code in PR #13417:
URL: https://github.com/apache/kafka/pull/13417#discussion_r1271260477
##
checkstyle/import-control.xml:
##
@@ -302,6 +302,11 @@
+
+
+
+
+
Review Comment:
Nice one. removed.
--
This is an
39 matches
Mail list logo
