florin-akermann opened a new pull request, #14174:
URL: https://github.com/apache/kafka/pull/14174
https://cwiki.apache.org/confluence/display/KAFKA/KIP-962%3A+Relax+non-null+key+requirement+in+Kafka+Streams
Test Strategy:
Basic tests on minimal topologies with call to '.repart
mimaison commented on code in PR #14172:
URL: https://github.com/apache/kafka/pull/14172#discussion_r1288390063
##
tools/src/main/java/org/apache/kafka/tools/reassign/ActiveMoveState.java:
##
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
[
https://issues.apache.org/jira/browse/KAFKA-15172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752398#comment-17752398
]
hudeqi commented on KAFKA-15172:
Hi, I have initiated a kip discussion:
[https://lists.
riedelmax commented on PR #14124:
URL: https://github.com/apache/kafka/pull/14124#issuecomment-1671187508
I will find time in the next days to fix those.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[
https://issues.apache.org/jira/browse/KAFKA-15259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752396#comment-17752396
]
Tomonari Yamashita commented on KAFKA-15259:
My opinion is neutral on whethe
divijvaidya commented on PR #14153:
URL: https://github.com/apache/kafka/pull/14153#issuecomment-1671124312
Thank you for reviewing @yashmayya. The CI is still flaky with large number
of failures and I am restarting it.
--
This is an automated message from the Apache Git Service.
To respo
divijvaidya commented on code in PR #14161:
URL: https://github.com/apache/kafka/pull/14161#discussion_r1288309828
##
core/src/main/scala/kafka/server/ConfigHandler.scala:
##
@@ -62,6 +62,12 @@ class TopicConfigHandler(private val logManager: LogManager,
kafkaConfig: KafkaC
yashmayya commented on code in PR #14153:
URL: https://github.com/apache/kafka/pull/14153#discussion_r1288307819
##
connect/runtime/src/test/java/org/apache/kafka/connect/util/KafkaBasedLogTest.java:
##
@@ -114,29 +113,49 @@ public class KafkaBasedLogTest {
private static f
kamalcph commented on code in PR #14161:
URL: https://github.com/apache/kafka/pull/14161#discussion_r1288298071
##
core/src/main/scala/kafka/server/ConfigHandler.scala:
##
@@ -62,6 +62,12 @@ class TopicConfigHandler(private val logManager: LogManager,
kafkaConfig: KafkaC
t
[
https://issues.apache.org/jira/browse/KAFKA-15309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752369#comment-17752369
]
Tomonari Yamashita commented on KAFKA-15309:
FYI, I've created a simple repr
prestona opened a new pull request, #14173:
URL: https://github.com/apache/kafka/pull/14173
- Rename TAG_BUFFER -> TAGGED_FIELDS (for better consistency with KIP-482
and the implementation)
- Add TAGGED_FIELDS into "protocol primitive types" section, and improve
description
- Exclude
divijvaidya commented on code in PR #14161:
URL: https://github.com/apache/kafka/pull/14161#discussion_r1288285456
##
core/src/test/scala/unit/kafka/server/KafkaServerTest.scala:
##
@@ -154,6 +155,92 @@ class KafkaServerTest extends QuorumTestHarness {
server.shutdown()
yashmayya commented on code in PR #14102:
URL: https://github.com/apache/kafka/pull/14102#discussion_r1288249581
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/DistributedHerderTest.java:
##
@@ -3872,7 +2952,7 @@ public void testVerifyTaskGeneratio
divijvaidya commented on code in PR #14135:
URL: https://github.com/apache/kafka/pull/14135#discussion_r1288249161
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -1862,7 +1884,35 @@ class KafkaConfig private(doLog: Boolean, val props:
java.util.Map[_, _], dynami
clolov commented on code in PR #14161:
URL: https://github.com/apache/kafka/pull/14161#discussion_r1288265653
##
core/src/main/scala/kafka/server/ConfigHandler.scala:
##
@@ -62,6 +62,12 @@ class TopicConfigHandler(private val logManager: LogManager,
kafkaConfig: KafkaC
top
msn-tldr commented on code in PR #14111:
URL: https://github.com/apache/kafka/pull/14111#discussion_r1288249340
##
clients/src/main/java/org/apache/kafka/clients/Metadata.java:
##
@@ -144,13 +159,25 @@ public long metadataExpireMs() {
*/
public synchronized int reques
[
https://issues.apache.org/jira/browse/KAFKA-15309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomonari Yamashita updated KAFKA-15309:
---
Attachment: app.log
KafkaProducerReproducer.java
> Add custom error
nizhikov commented on PR #13247:
URL: https://github.com/apache/kafka/pull/13247#issuecomment-1670967558
@mimaison Thanks for review and merge of #14096.
I create PR that contains java version of ReassignPartitionsCommand POJOs.
Please, take a look - #14172
--
This is an aut
nizhikov opened a new pull request, #14172:
URL: https://github.com/apache/kafka/pull/14172
This PR part of #13247 and introduces Java version of
ReassignPartitionsCommand POJOs
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ]
yashmayya commented on PR #14166:
URL: https://github.com/apache/kafka/pull/14166#issuecomment-1670963634
Thanks Mickael!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
mimaison merged PR #14166:
URL: https://github.com/apache/kafka/pull/14166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
lucasbru commented on code in PR #14001:
URL: https://github.com/apache/kafka/pull/14001#discussion_r1288175911
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/tasks/DefaultTaskExecutor.java:
##
@@ -86,12 +87,29 @@ private void runOnce(final long nowMs) {
lucasbru commented on code in PR #14001:
URL: https://github.com/apache/kafka/pull/14001#discussion_r1288175911
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/tasks/DefaultTaskExecutor.java:
##
@@ -86,12 +87,29 @@ private void runOnce(final long nowMs) {
divijvaidya commented on code in PR #14151:
URL: https://github.com/apache/kafka/pull/14151#discussion_r1288158470
##
core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java:
##
@@ -913,6 +969,12 @@ private RemoteLogManagerConfig createRLMConfig(Properties
props) {
divijvaidya commented on code in PR #13947:
URL: https://github.com/apache/kafka/pull/13947#discussion_r1288145597
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -343,21 +345,78 @@ public void onLeadershipChange(Set
partitionsBecomeLeader,
/**
*
[
https://issues.apache.org/jira/browse/KAFKA-14595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison reopened KAFKA-14595:
> Move ReassignPartitionsCommand to tools
> ---
>
>
mimaison merged PR #14096:
URL: https://github.com/apache/kafka/pull/14096
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
lucasbru opened a new pull request, #14171:
URL: https://github.com/apache/kafka/pull/14171
Implement setting and clearing task timeouts, as well as changing the output
on exceptions to make
it similar to the existing code path. This is a stacked PR, only the last
commit needs to be rev
aindriu-aiven commented on PR #14159:
URL: https://github.com/apache/kafka/pull/14159#issuecomment-1670825228
Thanks @gharris1727 I think I covered all the points you mentioned there any
issues at all though please let me know!
--
This is an automated message from the Apache Git Service.
101 - 129 of 129 matches
Mail list logo