[GitHub] [kafka] kamalcph commented on a diff in pull request #13947: KAFKA-15130: Delete remote segments when delete a topic

kamalcph commented on code in PR #13947: URL: https://github.com/apache/kafka/pull/13947#discussion_r1290341929 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -478,7 +481,8 @@ class ReplicaManager(val config: KafkaConfig, if (requestLeaderEpoch

[jira] [Updated] (KAFKA-15331) Handle remote log enabled topic deletion when leader is not available

[ https://issues.apache.org/jira/browse/KAFKA-15331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamal Chandraprakash updated KAFKA-15331: - Parent: KAFKA-7739 Issue Type: Sub-task (was: Task) > Handle remote

[jira] [Created] (KAFKA-15331) Handle remote log enabled topic deletion when leader is not available

Kamal Chandraprakash created KAFKA-15331: Summary: Handle remote log enabled topic deletion when leader is not available Key: KAFKA-15331 URL: https://issues.apache.org/jira/browse/KAFKA-15331

[GitHub] [kafka] kamalcph commented on a diff in pull request #13947: KAFKA-15130: Delete remote segments when delete a topic

kamalcph commented on code in PR #13947: URL: https://github.com/apache/kafka/pull/13947#discussion_r1290338684 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -558,17 +574,38 @@ class ReplicaManager(val config: KafkaConfig, }

[GitHub] [kafka] kamalcph commented on a diff in pull request #13947: KAFKA-15130: Delete remote segments when delete a topic

kamalcph commented on code in PR #13947: URL: https://github.com/apache/kafka/pull/13947#discussion_r1290329055 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -558,17 +574,38 @@ class ReplicaManager(val config: KafkaConfig, }

[GitHub] [kafka] kamalcph commented on a diff in pull request #13947: KAFKA-15130: Delete remote segments when delete a topic

kamalcph commented on code in PR #13947: URL: https://github.com/apache/kafka/pull/13947#discussion_r1290329358 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -343,21 +345,78 @@ public void onLeadershipChange(Set partitionsBecomeLeader, /** *

[jira] [Updated] (KAFKA-15327) Async consumer should commit offsets on close

[ https://issues.apache.org/jira/browse/KAFKA-15327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-15327: --- Description: In the current implementation of the KafkaConsumer, the ConsumerCoordinator

[GitHub] [kafka] kamalcph commented on pull request #14176: KAFKA-15295: Add config validation when remote storage is enabled on a topic

kamalcph commented on PR #14176: URL: https://github.com/apache/kafka/pull/14176#issuecomment-1673418121 We have added sufficient validations while creating/updating the topic. If the user didn't override the `local.retention.bytes`, `retention.bytes`, `retention.ms` or

[GitHub] [kafka] vveicc opened a new pull request, #14185: KAFKA-15287: Change NodeApiVersions.create() to support kraft

vveicc opened a new pull request, #14185: URL: https://github.com/apache/kafka/pull/14185 - Change NodeApiVersions.create() to support kraft - Change ApiKeysTest to support kraft - Change ApiVersionsResponseTest to support kraft ### Committer Checklist (excluded from commit

[GitHub] [kafka] tinaselenge commented on a diff in pull request #14183: KAFKA-15210: Mention vote should be open for at atleast 72 hours in the release script

tinaselenge commented on code in PR #14183: URL: https://github.com/apache/kafka/pull/14183#discussion_r1290156210 ## release.py: ## @@ -721,7 +721,7 @@ def select_gpg_key(): Release notes for the %(release_version)s release:

[GitHub] [kafka] clolov commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

clolov commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1290124230 ## core/src/main/scala/kafka/server/ConfigHandler.scala: ## @@ -62,6 +62,12 @@ class TopicConfigHandler(private val logManager: LogManager, kafkaConfig: KafkaC

[GitHub] [kafka] clolov commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

clolov commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1290120601 ## core/src/main/scala/kafka/server/ConfigHandler.scala: ## @@ -62,6 +62,12 @@ class TopicConfigHandler(private val logManager: LogManager, kafkaConfig: KafkaC

[GitHub] [kafka] clolov commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

clolov commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1290107019 ## core/src/main/scala/kafka/server/ConfigHandler.scala: ## @@ -62,6 +62,12 @@ class TopicConfigHandler(private val logManager: LogManager, kafkaConfig: KafkaC

[GitHub] [kafka] bachmanity1 commented on pull request #14142: KAFKA-7438: Replace EasyMock with Mockito & remove misleading tests in SessionSto…

bachmanity1 commented on PR #14142: URL: https://github.com/apache/kafka/pull/14142#issuecomment-1673143048 It looks like test failures are not related to this PR. ``` Build / JDK 11 and Scala 2.13 / testOffsetTranslationBehindReplicationFlow() –

[jira] [Closed] (KAFKA-14707) Possible read error in the Array type caused by insufficient remaining bytes

[ https://issues.apache.org/jira/browse/KAFKA-14707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nelson Bighetti closed KAFKA-14707. --- > Possible read error in the Array type caused by insufficient remaining bytes >

[jira] [Updated] (KAFKA-15328) Inter broker partition reassignment triggers offline log dirs randomly

[ https://issues.apache.org/jira/browse/KAFKA-15328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dgiri updated KAFKA-15328: -- Description: When running the intra-broker partition reassignments from one disk to another, kafka triggers

[GitHub] [kafka] tinaselenge commented on pull request #14184: KAFKA-15201: When git fails, the script goes into a loop

tinaselenge commented on PR #14184: URL: https://github.com/apache/kafka/pull/14184#issuecomment-1673077828 @divijvaidya I'm sorry, I realise this doesn't fix the issue. `cmd` function that executes git push takes optional parameters such as `num_retries` and `allow_failure`. When these

[jira] [Commented] (KAFKA-15330) Migration from ZK to KRaft works with 3.4 but fails from 3.5 upwards

[ https://issues.apache.org/jira/browse/KAFKA-15330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752771#comment-17752771 ] Roland Sommer commented on KAFKA-15330: --- In addition I did the same tests using 3.6.0-SNAPSHOT

[GitHub] [kafka] showuon commented on a diff in pull request #14151: KAFKA-15083: add config with "remote.log.metadata" prefix

showuon commented on code in PR #14151: URL: https://github.com/apache/kafka/pull/14151#discussion_r1289945895 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -913,6 +969,12 @@ private RemoteLogManagerConfig createRLMConfig(Properties props) {

[GitHub] [kafka] showuon commented on a diff in pull request #14151: KAFKA-15083: add config with "remote.log.metadata" prefix

showuon commented on code in PR #14151: URL: https://github.com/apache/kafka/pull/14151#discussion_r1289944769 ## storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java: ## @@ -134,6 +134,8 @@ public final class RemoteLogManagerConfig {

[GitHub] [kafka] kamalcph commented on a diff in pull request #14176: KAFKA-15295: Add config validation when remote storage is enabled on a topic

kamalcph commented on code in PR #14176: URL: https://github.com/apache/kafka/pull/14176#discussion_r1289921354 ## core/src/main/scala/kafka/server/ControllerServer.scala: ## @@ -231,7 +231,7 @@ class ControllerServer( setMetrics(quorumControllerMetrics).

[GitHub] [kafka] kamalcph commented on pull request #14176: KAFKA-15295: Add config validation when remote storage is enabled on a topic

kamalcph commented on PR #14176: URL: https://github.com/apache/kafka/pull/14176#issuecomment-1672992922 @divijvaidya @showuon Added the unit and integration test. Please take another look. Thanks! -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Created] (KAFKA-15330) Migration from ZK to KRaft works with 3.4 but fails from 3.5 upwards

Roland Sommer created KAFKA-15330: - Summary: Migration from ZK to KRaft works with 3.4 but fails from 3.5 upwards Key: KAFKA-15330 URL: https://issues.apache.org/jira/browse/KAFKA-15330 Project:

[GitHub] [kafka] satishd commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

satishd commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1289928040 ## core/src/main/scala/kafka/server/ConfigHandler.scala: ## @@ -62,6 +62,12 @@ class TopicConfigHandler(private val logManager: LogManager, kafkaConfig: KafkaC

[jira] [Created] (KAFKA-15329) Make default `remote.log.metadata.manager.class.name` as topic based RLMM

Luke Chen created KAFKA-15329: - Summary: Make default `remote.log.metadata.manager.class.name` as topic based RLMM Key: KAFKA-15329 URL: https://issues.apache.org/jira/browse/KAFKA-15329 Project: Kafka

[GitHub] [kafka] kamalcph commented on a diff in pull request #14176: KAFKA-15295: Add config validation when remote storage is enabled on a topic

kamalcph commented on code in PR #14176: URL: https://github.com/apache/kafka/pull/14176#discussion_r1289921354 ## core/src/main/scala/kafka/server/ControllerServer.scala: ## @@ -231,7 +231,7 @@ class ControllerServer( setMetrics(quorumControllerMetrics).

[GitHub] [kafka] kamalcph commented on pull request #14176: KAFKA-15295: Add config validation when remote storage is enabled on a topic

kamalcph commented on PR #14176: URL: https://github.com/apache/kafka/pull/14176#issuecomment-1672925848 > Regarding my previous comment: > > > where does kraft create topic and alter topic config invoke the validation because we seem to only be changing the controller config

[GitHub] [kafka] divijvaidya commented on pull request #14176: KAFKA-15295: Add config validation when remote storage is enabled on a topic

divijvaidya commented on PR #14176: URL: https://github.com/apache/kafka/pull/14176#issuecomment-1672922357 Regarding my previous comment: > where does kraft create topic and alter topic config invoke the validation because we seem to only be changing the controller config validation.

[jira] [Commented] (KAFKA-14049) Relax Non Null Requirement for KStreamGlobalKTable Left Join

[ https://issues.apache.org/jira/browse/KAFKA-14049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752738#comment-17752738 ] Florin Akermann commented on KAFKA-14049: - Same for me. I simply assigned it to me as it was

[GitHub] [kafka] divijvaidya commented on a diff in pull request #14183: KAFKA-15210: Mention vote should be open for at atleast 72 hours in the release script

divijvaidya commented on code in PR #14183: URL: https://github.com/apache/kafka/pull/14183#discussion_r1289835715 ## release.py: ## @@ -721,7 +721,7 @@ def select_gpg_key(): Release notes for the %(release_version)s release:

[GitHub] [kafka] divijvaidya commented on pull request #14184: KAFKA-15201: When git fails, the script goes into a loop

divijvaidya commented on PR #14184: URL: https://github.com/apache/kafka/pull/14184#issuecomment-1672871528 Thank you for picking this up @tinaselenge. Can you please help me understand in the description why the script was going in a loop and how does this PR fix it? It would also be nice

[jira] [Created] (KAFKA-15328) Inter broker partition reassignment triggers offline log dirs randomly

dgiri created KAFKA-15328: - Summary: Inter broker partition reassignment triggers offline log dirs randomly Key: KAFKA-15328 URL: https://issues.apache.org/jira/browse/KAFKA-15328 Project: Kafka

[GitHub] [kafka] AndrewJSchofield commented on a diff in pull request #14111: KAFKA-9800: Exponential backoff for Kafka clients - KIP-580

AndrewJSchofield commented on code in PR #14111: URL: https://github.com/apache/kafka/pull/14111#discussion_r1288667079 ## clients/src/main/java/org/apache/kafka/clients/Metadata.java: ## @@ -119,20 +130,24 @@ public synchronized Cluster fetch() { * @return remaining time

[GitHub] [kafka] divijvaidya commented on a diff in pull request #14135: KAFKA-14991: Implementation of KIP-937 which improves message timesta…

divijvaidya commented on code in PR #14135: URL: https://github.com/apache/kafka/pull/14135#discussion_r1289780489 ## core/src/test/scala/integration/kafka/api/PlaintextProducerSendTest.scala: ## @@ -120,17 +121,17 @@ class PlaintextProducerSendTest extends

[GitHub] [kafka] divijvaidya commented on pull request #14078: KAFKA-14780: Fix flaky test 'testSecondaryRefreshAfterElapsedDelay'

divijvaidya commented on PR #14078: URL: https://github.com/apache/kafka/pull/14078#issuecomment-1672790058 Unrelated failures: ``` [Build / JDK 11 and Scala 2.13 /

[jira] [Resolved] (KAFKA-14421) OffsetFetchRequest throws NPE Exception

[ https://issues.apache.org/jira/browse/KAFKA-14421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-14421. --- Resolution: Resolved Resolved in the later release. > OffsetFetchRequest throws NPE Exception >

[GitHub] [kafka] satishd commented on a diff in pull request #13947: KAFKA-15130: Delete remote segments when delete a topic

satishd commented on code in PR #13947: URL: https://github.com/apache/kafka/pull/13947#discussion_r1289750794 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -343,21 +345,78 @@ public void onLeadershipChange(Set partitionsBecomeLeader, /** *

[GitHub] [kafka] tinaselenge opened a new pull request, #14184: KAFKA-15201: When git fails, the script goes into a loop

tinaselenge opened a new pull request, #14184: URL: https://github.com/apache/kafka/pull/14184 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade

[GitHub] [kafka] tinaselenge opened a new pull request, #14183: KAFKA-15210: Mention vote should be open for at atleast 72 hours in the release script

tinaselenge opened a new pull request, #14183: URL: https://github.com/apache/kafka/pull/14183 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade

[jira] [Assigned] (KAFKA-15201) When git fails, script goes into a loop

[ https://issues.apache.org/jira/browse/KAFKA-15201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gantigmaa Selenge reassigned KAFKA-15201: - Assignee: Gantigmaa Selenge > When git fails, script goes into a loop >

[jira] [Assigned] (KAFKA-15210) Mention vote should be open for at atleast 72 hours

[ https://issues.apache.org/jira/browse/KAFKA-15210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gantigmaa Selenge reassigned KAFKA-15210: - Assignee: Gantigmaa Selenge > Mention vote should be open for at atleast 72

[GitHub] [kafka] fvaleri commented on a diff in pull request #13204: KAFKA-14593: Move LeaderElectionCommand to tools

fvaleri commented on code in PR #13204: URL: https://github.com/apache/kafka/pull/13204#discussion_r1289694241 ## tools/src/main/java/org/apache/kafka/tools/LeaderElectionCommand.java: ## @@ -0,0 +1,378 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] rreddy-22 opened a new pull request, #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

rreddy-22 opened a new pull request, #14182: URL: https://github.com/apache/kafka/pull/14182 This module contains code for the implementation of the Optimized Uniform Rack Aware Assignor. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] cmccabe merged pull request #14169: KAFKA-15318: Update the Authorizer via AclPublisher

cmccabe merged PR #14169: URL: https://github.com/apache/kafka/pull/14169 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] lihaosky opened a new pull request, #14181: KAFKA-15022: [10/N] docs for rack aware assignor

lihaosky opened a new pull request, #14181: URL: https://github.com/apache/kafka/pull/14181 Docs for rack aware assignor ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify

[jira] [Resolved] (KAFKA-15288) Change BrokerApiVersionsCommandTest to support kraft mode

[ https://issues.apache.org/jira/browse/KAFKA-15288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deng Ziming resolved KAFKA-15288. - Resolution: Fixed > Change BrokerApiVersionsCommandTest to support kraft mode >

[GitHub] [kafka] kamalcph commented on a diff in pull request #14176: KAFKA-15295: Add config validation when remote storage is enabled on a topic

kamalcph commented on code in PR #14176: URL: https://github.com/apache/kafka/pull/14176#discussion_r1289553687 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java: ## @@ -459,49 +463,53 @@ public static void validateValues(Map props) { long

[GitHub] [kafka] dengziming merged pull request #14175: KAFKA-15288: Change BrokerApiVersionsCommandTest to support kraft mode

dengziming merged PR #14175: URL: https://github.com/apache/kafka/pull/14175 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] satishd commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

satishd commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1289577043 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -696,11 +704,327 @@ public void run() { } } +public void

[GitHub] [kafka] satishd commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

satishd commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1289577043 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -696,11 +704,327 @@ public void run() { } } +public void

<    1   2