[GitHub] [kafka] showuon opened a new pull request, #14401: MINOR: Add verification for (local) log start offset in txn tests

2023-09-18 Thread via GitHub
showuon opened a new pull request, #14401: URL: https://github.com/apache/kafka/pull/14401 In this PR, we noticed failed tests caused by the verification of log start offset and local log start offset. After investigation: https://github.com/apache/kafka/pull/14347#issuecomment-1717110340

[GitHub] [kafka] github-actions[bot] commented on pull request #13224: KAFKA-14700: Produce request interceptors

2023-09-18 Thread via GitHub
github-actions[bot] commented on PR #13224: URL: https://github.com/apache/kafka/pull/13224#issuecomment-1724783402 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

[GitHub] [kafka] github-actions[bot] commented on pull request #13531: KAFKA-14885: fix kafka client connect to the broker that offline from…

2023-09-18 Thread via GitHub
github-actions[bot] commented on PR #13531: URL: https://github.com/apache/kafka/pull/13531#issuecomment-1724783276 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

[jira] [Assigned] (KAFKA-15432) RLM Stop partitions should not be invoked for non-tiered storage topics

2023-09-18 Thread Phuc Hong Tran (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phuc Hong Tran reassigned KAFKA-15432: -- Assignee: (was: Phuc Hong Tran) > RLM Stop partitions should not be invoked for

[jira] [Assigned] (KAFKA-15341) Enabling TS for a topic during rolling restart causes problems

2023-09-18 Thread Phuc Hong Tran (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phuc Hong Tran reassigned KAFKA-15341: -- Assignee: (was: Phuc Hong Tran) > Enabling TS for a topic during rolling restart

[GitHub] [kafka] philipnee commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

2023-09-18 Thread via GitHub
philipnee commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1329477649 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -136,6 +136,12 @@ public void

[GitHub] [kafka] hudeqi commented on pull request #13929: KAFKA-15129;[3/N] Remove metrics in AbstractFetcherManager when fetcher manager instance shutdown

2023-09-18 Thread via GitHub
hudeqi commented on PR #13929: URL: https://github.com/apache/kafka/pull/13929#issuecomment-1724720666 @nizhikov Hi, can you help review the PR of this series? Looks like @divijvaidya doesn't have time. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] philipnee commented on pull request #14386: KAFKA-14960: TopicMetadata request manager

2023-09-18 Thread via GitHub
philipnee commented on PR #14386: URL: https://github.com/apache/kafka/pull/14386#issuecomment-1724712594 @junrao @lianetm - I hope I've addressed most, if not all, comments that you pointed out. So, thank you both for reviewing my code. We did have an offline discussion about user

[GitHub] [kafka] philipnee commented on a diff in pull request #14386: KAFKA-14960: TopicMetadata request manager

2023-09-18 Thread via GitHub
philipnee commented on code in PR #14386: URL: https://github.com/apache/kafka/pull/14386#discussion_r1329455102 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/TopicMetadataRequestManager.java: ## @@ -0,0 +1,238 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] hni61223 opened a new pull request, #14400: KIP-979: Allow independently stop KRaft controllers or brokers

2023-09-18 Thread via GitHub
hni61223 opened a new pull request, #14400: URL: https://github.com/apache/kafka/pull/14400 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

[GitHub] [kafka] cmccabe opened a new pull request, #14399: Cmccabe kip 919 part 2

2023-09-18 Thread via GitHub
cmccabe opened a new pull request, #14399: URL: https://github.com/apache/kafka/pull/14399 KAFKA-15466: Add KIP-919 support for some admin APIs Add KIP-919 support for kafka-cluster.sh, kafka-features.sh, and kafka-metadata-quorum.sh. NetworkClient.java: don't hardcode

[jira] [Commented] (KAFKA-15473) Connect connector-plugins endpoint shows duplicate plugins

2023-09-18 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17766595#comment-17766595 ] Greg Harris commented on KAFKA-15473: - I've opened [https://github.com/apache/kafka/pull/14398] with

[GitHub] [kafka] gharris1727 commented on pull request #14398: KAFKA-15473: Hide duplicate plugins in /connector-plugins

2023-09-18 Thread via GitHub
gharris1727 commented on PR #14398: URL: https://github.com/apache/kafka/pull/14398#issuecomment-1724505887 @yashmayya Could you take a look at this? I'd also appreciate your opinion on whether this warrants blocking the 3.6.0 release, or if this is just a cosmetic improvement that

[GitHub] [kafka] gharris1727 opened a new pull request, #14398: KAFKA-15473: Hide duplicate plugins in /connector-plugins

2023-09-18 Thread via GitHub
gharris1727 opened a new pull request, #14398: URL: https://github.com/apache/kafka/pull/14398 In #14089 the PluginDesc::compareTo method was changed, such that plugins with the same name and version but different classloaders could be given a consistent order. This caused compareTo to

[jira] [Commented] (KAFKA-15473) Connect connector-plugins endpoint shows duplicate plugins

2023-09-18 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17766592#comment-17766592 ] Greg Harris commented on KAFKA-15473: - Plugins could also appear multiple times <3.6.0-rc0 if

[GitHub] [kafka] cmccabe commented on a diff in pull request #14376: KAFKA-15458: Fully resolve endpoint information before registering controllers

2023-09-18 Thread via GitHub
cmccabe commented on code in PR #14376: URL: https://github.com/apache/kafka/pull/14376#discussion_r1329294750 ## metadata/src/main/java/org/apache/kafka/metadata/ListenerInfo.java: ## @@ -0,0 +1,376 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[jira] [Commented] (KAFKA-15473) Connect connector-plugins endpoint shows duplicate plugins

2023-09-18 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17766578#comment-17766578 ] Greg Harris commented on KAFKA-15473: - it appears that the bug which prompted the fix in KAFKA-15244

[jira] [Updated] (KAFKA-15473) Connect connector-plugins endpoint shows duplicate plugins

2023-09-18 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-15473: Priority: Major (was: Blocker) > Connect connector-plugins endpoint shows duplicate plugins >

[GitHub] [kafka] philipnee commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

2023-09-18 Thread via GitHub
philipnee commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1329251065 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ## @@ -0,0 +1,265 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] kirktrue opened a new pull request, #14397: KAFKA-14274 [6, 7]: Introduction of more infrastructure for forthcoming fetch request manager

2023-09-18 Thread via GitHub
kirktrue opened a new pull request, #14397: URL: https://github.com/apache/kafka/pull/14397 WIP -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

2023-09-18 Thread via GitHub
lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1329227271 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ## @@ -0,0 +1,265 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

2023-09-18 Thread via GitHub
lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1329227271 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ## @@ -0,0 +1,265 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] philipnee commented on a diff in pull request #14386: KAFKA-14960: TopicMetadata request manager

2023-09-18 Thread via GitHub
philipnee commented on code in PR #14386: URL: https://github.com/apache/kafka/pull/14386#discussion_r1329215296 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CoordinatorRequestManager.java: ## @@ -38,8 +38,8 @@ * Whether there is an existing

[GitHub] [kafka] philipnee commented on a diff in pull request #14386: KAFKA-14960: TopicMetadata request manager

2023-09-18 Thread via GitHub
philipnee commented on code in PR #14386: URL: https://github.com/apache/kafka/pull/14386#discussion_r1329213351 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -298,8 +289,8 @@ private void onFailure(final long

[GitHub] [kafka] hachikuji commented on a diff in pull request #14053: KAFKA-15221; Fix the race between fetch requests from a rebooted follower.

2023-09-18 Thread via GitHub
hachikuji commented on code in PR #14053: URL: https://github.com/apache/kafka/pull/14053#discussion_r1329117983 ## core/src/main/scala/kafka/cluster/Replica.scala: ## @@ -98,14 +103,20 @@ class Replica(val brokerId: Int, val topicPartition: TopicPartition) extends Log *

[jira] [Created] (KAFKA-15475) Timeout request might retry forever even if the user API times out in AsyncConsumer

2023-09-18 Thread Philip Nee (Jira)
Philip Nee created KAFKA-15475: -- Summary: Timeout request might retry forever even if the user API times out in AsyncConsumer Key: KAFKA-15475 URL: https://issues.apache.org/jira/browse/KAFKA-15475

[jira] [Created] (KAFKA-15474) AbstractCoordinator.testWakeupAfterSyncGroupReceivedExternalCompletion seems flaky

2023-09-18 Thread Philip Nee (Jira)
Philip Nee created KAFKA-15474: -- Summary: AbstractCoordinator.testWakeupAfterSyncGroupReceivedExternalCompletion seems flaky Key: KAFKA-15474 URL: https://issues.apache.org/jira/browse/KAFKA-15474

[jira] [Resolved] (KAFKA-15306) Integrate committed offsets logic when updating fetching positions

2023-09-18 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-15306. - Fix Version/s: 3.7.0 Resolution: Fixed merged the PR to trunk > Integrate committed offsets

[GitHub] [kafka] junrao merged pull request #14385: KAFKA-15306 - Integrating committed offsets for updating fetch positions

2023-09-18 Thread via GitHub
junrao merged PR #14385: URL: https://github.com/apache/kafka/pull/14385 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] junrao commented on a diff in pull request #14385: KAFKA-15306 - Integrating committed offsets for updating fetch positions

2023-09-18 Thread via GitHub
junrao commented on code in PR #14385: URL: https://github.com/apache/kafka/pull/14385#discussion_r1329179154 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumerTest.java: ## @@ -361,6 +364,84 @@ public void testWakeup_committed() {

[GitHub] [kafka] lianetm commented on a diff in pull request #14385: KAFKA-15306 - Integrating committed offsets for updating fetch positions

2023-09-18 Thread via GitHub
lianetm commented on code in PR #14385: URL: https://github.com/apache/kafka/pull/14385#discussion_r1329165007 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumerTest.java: ## @@ -361,6 +364,84 @@ public void testWakeup_committed() {

[jira] [Created] (KAFKA-15473) Connect connector-plugins endpoint shows duplicate plugins

2023-09-18 Thread Greg Harris (Jira)
Greg Harris created KAFKA-15473: --- Summary: Connect connector-plugins endpoint shows duplicate plugins Key: KAFKA-15473 URL: https://issues.apache.org/jira/browse/KAFKA-15473 Project: Kafka

[GitHub] [kafka] hachikuji commented on a diff in pull request #14053: KAFKA-15221; Fix the race between fetch requests from a rebooted follower.

2023-09-18 Thread via GitHub
hachikuji commented on code in PR #14053: URL: https://github.com/apache/kafka/pull/14053#discussion_r1329117983 ## core/src/main/scala/kafka/cluster/Replica.scala: ## @@ -98,14 +103,20 @@ class Replica(val brokerId: Int, val topicPartition: TopicPartition) extends Log *

[GitHub] [kafka] junrao commented on a diff in pull request #14385: KAFKA-15306 - Integrating committed offsets for updating fetch positions

2023-09-18 Thread via GitHub
junrao commented on code in PR #14385: URL: https://github.com/apache/kafka/pull/14385#discussion_r1329117484 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumerTest.java: ## @@ -361,6 +364,84 @@ public void testWakeup_committed() {

[GitHub] [kafka] lianetm commented on pull request #14385: KAFKA-15306 - Integrating committed offsets for updating fetch positions

2023-09-18 Thread via GitHub
lianetm commented on PR #14385: URL: https://github.com/apache/kafka/pull/14385#issuecomment-1724069642 Latest comment addressed, thanks @junrao ! I merged latest changes from trunk and updated some tests accordingly. Build completed with 4 unrelated test failures: Build / JDK 17

[GitHub] [kafka] lucasbru commented on pull request #14226: KAFKA-15326: [8/N] Move consumer interaction out of processing methods

2023-09-18 Thread via GitHub
lucasbru commented on PR #14226: URL: https://github.com/apache/kafka/pull/14226#issuecomment-1723999648 Well, that one isn't failing. We do have `PauseAndResumeIntegrationTest` failing, is that flaky on master? Seems to fail only in the state updater variant -- This is an automated

[GitHub] [kafka] philipnee closed pull request #14391: MINOR: Implement toStringBase to avoid duplicated code

2023-09-18 Thread via GitHub
philipnee closed pull request #14391: MINOR: Implement toStringBase to avoid duplicated code URL: https://github.com/apache/kafka/pull/14391 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] philipnee commented on pull request #14391: MINOR: Implement toStringBase to avoid duplicated code

2023-09-18 Thread via GitHub
philipnee commented on PR #14391: URL: https://github.com/apache/kafka/pull/14391#issuecomment-1723925230 Apparently @kirktrue implemented those in his previous commit. So closing this. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] CalvinConfluent commented on pull request #14053: KAFKA-15221; Fix the race between fetch requests from a rebooted follower.

2023-09-18 Thread via GitHub
CalvinConfluent commented on PR #14053: URL: https://github.com/apache/kafka/pull/14053#issuecomment-1723910479 The failing tests can pass locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] kamalcph commented on a diff in pull request #14172: KAFKA-14595 Java version of ReassignPartitionsCommand POJOs

2023-09-18 Thread via GitHub
kamalcph commented on code in PR #14172: URL: https://github.com/apache/kafka/pull/14172#discussion_r1328974296 ## tools/src/main/java/org/apache/kafka/tools/reassign/MissingLogDirMoveState.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] lianetm commented on a diff in pull request #14391: MINOR: Implement toStringBase to avoid duplicated code

2023-09-18 Thread via GitHub
lianetm commented on code in PR #14391: URL: https://github.com/apache/kafka/pull/14391#discussion_r1328961825 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEvent.java: ## @@ -21,18 +21,27 @@ */ abstract public class ApplicationEvent

[jira] [Commented] (KAFKA-9569) RemoteStorageManager implementation for HDFS storage.

2023-09-18 Thread Viktor Somogyi-Vass (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17766427#comment-17766427 ] Viktor Somogyi-Vass commented on KAFKA-9569: [~Ying Zheng], [~satish.duggana] is this plugin

[GitHub] [kafka] clolov opened a new pull request, #14396: KAFKA-14133: Move KeyValueIteratorFacadeTest, KeyValueSegmentTest and MeteredKeyValueStoreTest to Mockito

2023-09-18 Thread via GitHub
clolov opened a new pull request, #14396: URL: https://github.com/apache/kafka/pull/14396 This pull requests migrates mocks from KeyValueIteratorFacadeTest, KeyValueSegmentTest and MeteredKeyValueStoreTest to Mockito. -- This is an automated message from the Apache Git Service. To

[jira] [Updated] (KAFKA-14133) Remaining EasyMock to Mockito tests

2023-09-18 Thread Christo Lolov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christo Lolov updated KAFKA-14133: -- Description: {color:#de350b}There are tests which use both PowerMock and EasyMock. I have

[GitHub] [kafka] nizhikov commented on a diff in pull request #14172: KAFKA-14595 Java version of ReassignPartitionsCommand POJOs

2023-09-18 Thread via GitHub
nizhikov commented on code in PR #14172: URL: https://github.com/apache/kafka/pull/14172#discussion_r1328804368 ## tools/src/main/java/org/apache/kafka/tools/reassign/MissingLogDirMoveState.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] tjouni opened a new pull request, #14395: MINOR: Fix format of allowed operations in kafka-acls error message

2023-09-18 Thread via GitHub
tjouni opened a new pull request, #14395: URL: https://github.com/apache/kafka/pull/14395 kafka-acls cli prints the following error message on invalid operation: ``` $ kafka-acls --bootstrap-server xxx:9095 --remove --allow-principal "User:abc" --allow-host * --operation

[GitHub] [kafka] clolov closed pull request #14256: [KAFKA-14133] Migrate EasyMock to Mockito in GlobalStateStoreProviderTest, KeyValue…

2023-09-18 Thread via GitHub
clolov closed pull request #14256: [KAFKA-14133] Migrate EasyMock to Mockito in GlobalStateStoreProviderTest, KeyValue… URL: https://github.com/apache/kafka/pull/14256 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] clolov commented on pull request #14256: [KAFKA-14133] Migrate EasyMock to Mockito in GlobalStateStoreProviderTest, KeyValue…

2023-09-18 Thread via GitHub
clolov commented on PR #14256: URL: https://github.com/apache/kafka/pull/14256#issuecomment-1723412639 There has been no activity on this or related pull requests for over a month. As detailed in https://github.com/apache/kafka/pull/14255 I will close them and take over the work. --

[GitHub] [kafka] clolov closed pull request #14257: [KAFKA-14133] Migrate EasyMock to Mockito in MeteredKeyValueStoreTest

2023-09-18 Thread via GitHub
clolov closed pull request #14257: [KAFKA-14133] Migrate EasyMock to Mockito in MeteredKeyValueStoreTest URL: https://github.com/apache/kafka/pull/14257 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] clolov commented on pull request #14257: [KAFKA-14133] Migrate EasyMock to Mockito in MeteredKeyValueStoreTest

2023-09-18 Thread via GitHub
clolov commented on PR #14257: URL: https://github.com/apache/kafka/pull/14257#issuecomment-1723412448 There has been no activity on this or related pull requests for over a month. As detailed in https://github.com/apache/kafka/pull/14255 I will close them and take over the work. --

[GitHub] [kafka] clolov closed pull request #14258: [KAFKA-14133] Migrate EasyMock to Mockito in MeteredSessionStoreTest

2023-09-18 Thread via GitHub
clolov closed pull request #14258: [KAFKA-14133] Migrate EasyMock to Mockito in MeteredSessionStoreTest URL: https://github.com/apache/kafka/pull/14258 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] clolov commented on pull request #14258: [KAFKA-14133] Migrate EasyMock to Mockito in MeteredSessionStoreTest

2023-09-18 Thread via GitHub
clolov commented on PR #14258: URL: https://github.com/apache/kafka/pull/14258#issuecomment-1723412284 There has been no activity on this or related pull requests for over a month. As detailed in https://github.com/apache/kafka/pull/14255 I will close them and take over the work. --

[GitHub] [kafka] clolov closed pull request #14259: [KAFKA-14133] Migrate EasyMock to Mockito in MeteredTimestampedKeyValueStoreTest

2023-09-18 Thread via GitHub
clolov closed pull request #14259: [KAFKA-14133] Migrate EasyMock to Mockito in MeteredTimestampedKeyValueStoreTest URL: https://github.com/apache/kafka/pull/14259 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] clolov commented on pull request #14259: [KAFKA-14133] Migrate EasyMock to Mockito in MeteredTimestampedKeyValueStoreTest

2023-09-18 Thread via GitHub
clolov commented on PR #14259: URL: https://github.com/apache/kafka/pull/14259#issuecomment-1723412142 There has been no activity on this or related pull requests for over a month. As detailed in https://github.com/apache/kafka/pull/14255 I will close them and take over the work. --

[GitHub] [kafka] clolov closed pull request #14260: [KAFKA-14133] Migrate EasyMock to Mockito in MeteredWindowStoreTest

2023-09-18 Thread via GitHub
clolov closed pull request #14260: [KAFKA-14133] Migrate EasyMock to Mockito in MeteredWindowStoreTest URL: https://github.com/apache/kafka/pull/14260 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] clolov commented on pull request #14260: [KAFKA-14133] Migrate EasyMock to Mockito in MeteredWindowStoreTest

2023-09-18 Thread via GitHub
clolov commented on PR #14260: URL: https://github.com/apache/kafka/pull/14260#issuecomment-1723411994 There has been no activity on this or related pull requests for over a month. As detailed in https://github.com/apache/kafka/pull/14255 I will close them and take over the work. --

[GitHub] [kafka] clolov closed pull request #14261: [KAFKA-14133] Migrate EasyMock to Mockito in ReadOnlyKeyValueStoreFacadeTest, ReadO…

2023-09-18 Thread via GitHub
clolov closed pull request #14261: [KAFKA-14133] Migrate EasyMock to Mockito in ReadOnlyKeyValueStoreFacadeTest, ReadO… URL: https://github.com/apache/kafka/pull/14261 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] clolov commented on pull request #14261: [KAFKA-14133] Migrate EasyMock to Mockito in ReadOnlyKeyValueStoreFacadeTest, ReadO…

2023-09-18 Thread via GitHub
clolov commented on PR #14261: URL: https://github.com/apache/kafka/pull/14261#issuecomment-1723411599 There has been no activity on this or related pull requests for over a month. As detailed in https://github.com/apache/kafka/pull/14255 I will close them and take over the work. --

[GitHub] [kafka] clolov closed pull request #14262: [KAFKA-14133] Migrate EasyMock to Mockito in RocksDBGenericOptionsToDbOptionsColumF…

2023-09-18 Thread via GitHub
clolov closed pull request #14262: [KAFKA-14133] Migrate EasyMock to Mockito in RocksDBGenericOptionsToDbOptionsColumF… URL: https://github.com/apache/kafka/pull/14262 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] clolov commented on pull request #14262: [KAFKA-14133] Migrate EasyMock to Mockito in RocksDBGenericOptionsToDbOptionsColumF…

2023-09-18 Thread via GitHub
clolov commented on PR #14262: URL: https://github.com/apache/kafka/pull/14262#issuecomment-1723411335 There has been no activity on this or related pull requests for over a month. As detailed in https://github.com/apache/kafka/pull/14255 I will close them and take over the work. --

[GitHub] [kafka] clolov closed pull request #14255: [KAFKA-14133] Migrate EasyMock to Mockito in StateRestoreCallbackAdapterTest, Store…

2023-09-18 Thread via GitHub
clolov closed pull request #14255: [KAFKA-14133] Migrate EasyMock to Mockito in StateRestoreCallbackAdapterTest, Store… URL: https://github.com/apache/kafka/pull/14255 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] clolov commented on pull request #14255: [KAFKA-14133] Migrate EasyMock to Mockito in StateRestoreCallbackAdapterTest, Store…

2023-09-18 Thread via GitHub
clolov commented on PR #14255: URL: https://github.com/apache/kafka/pull/14255#issuecomment-1723406610 I am closing this and related pull requests due to inactivity and taking over the remaining test work. If there is a timely response I will pause my work and let these go in trunk first.

[GitHub] [kafka] mannoopj commented on pull request #14389: Metadata schema checker

2023-09-18 Thread via GitHub
mannoopj commented on PR #14389: URL: https://github.com/apache/kafka/pull/14389#issuecomment-1723352632 @mumrah @ahuang98 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka] nizhikov commented on a diff in pull request #13247: KAFKA-14595 Move ReassignPartitionsCommand to java

2023-09-18 Thread via GitHub
nizhikov commented on code in PR #13247: URL: https://github.com/apache/kafka/pull/13247#discussion_r1328593318 ## tools/src/main/java/org/apache/kafka/tools/reassign/Tuple.java: ## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] tledkov commented on a diff in pull request #13247: KAFKA-14595 Move ReassignPartitionsCommand to java

2023-09-18 Thread via GitHub
tledkov commented on code in PR #13247: URL: https://github.com/apache/kafka/pull/13247#discussion_r1328587600 ## tools/src/main/java/org/apache/kafka/tools/reassign/Tuple.java: ## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] nizhikov commented on a diff in pull request #14355: KAFKA-14595 ReassignPartitionsUnitTest rewritten in java

2023-09-18 Thread via GitHub
nizhikov commented on code in PR #14355: URL: https://github.com/apache/kafka/pull/14355#discussion_r1328590905 ## tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsUnitTest.java: ## @@ -0,0 +1,788 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] tledkov commented on a diff in pull request #13247: KAFKA-14595 Move ReassignPartitionsCommand to java

2023-09-18 Thread via GitHub
tledkov commented on code in PR #13247: URL: https://github.com/apache/kafka/pull/13247#discussion_r1328587600 ## tools/src/main/java/org/apache/kafka/tools/reassign/Tuple.java: ## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] tledkov commented on a diff in pull request #13247: KAFKA-14595 Move ReassignPartitionsCommand to java

2023-09-18 Thread via GitHub
tledkov commented on code in PR #13247: URL: https://github.com/apache/kafka/pull/13247#discussion_r1328587600 ## tools/src/main/java/org/apache/kafka/tools/reassign/Tuple.java: ## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] tledkov commented on a diff in pull request #13247: KAFKA-14595 Move ReassignPartitionsCommand to java

2023-09-18 Thread via GitHub
tledkov commented on code in PR #13247: URL: https://github.com/apache/kafka/pull/13247#discussion_r1328587600 ## tools/src/main/java/org/apache/kafka/tools/reassign/Tuple.java: ## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] tledkov commented on a diff in pull request #14355: KAFKA-14595 ReassignPartitionsUnitTest rewritten in java

2023-09-18 Thread via GitHub
tledkov commented on code in PR #14355: URL: https://github.com/apache/kafka/pull/14355#discussion_r1328579643 ## tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsUnitTest.java: ## @@ -0,0 +1,788 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] kamalcph commented on a diff in pull request #14172: KAFKA-14595 Java version of ReassignPartitionsCommand POJOs

2023-09-18 Thread via GitHub
kamalcph commented on code in PR #14172: URL: https://github.com/apache/kafka/pull/14172#discussion_r1328541806 ## tools/src/main/java/org/apache/kafka/tools/reassign/MissingLogDirMoveState.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[jira] [Commented] (KAFKA-15169) Add tests for RemoteIndexCache

2023-09-18 Thread Arpit Goyal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17766318#comment-17766318 ] Arpit Goyal commented on KAFKA-15169: - [~isding_l] Can i pick this up ? > Add tests for

[GitHub] [kafka] nizhikov commented on a diff in pull request #14355: KAFKA-14595 ReassignPartitionsUnitTest rewritten in java

2023-09-18 Thread via GitHub
nizhikov commented on code in PR #14355: URL: https://github.com/apache/kafka/pull/14355#discussion_r1328532067 ## tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsUnitTest.java: ## @@ -0,0 +1,787 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] cadonna commented on pull request #14226: KAFKA-15326: [8/N] Move consumer interaction out of processing methods

2023-09-18 Thread via GitHub
cadonna commented on PR #14226: URL: https://github.com/apache/kafka/pull/14226#issuecomment-1723137841 I restarted the build since there was a suspicious integration test failure for `shouldReturnOffsetsForRepartitionTopicsForPurging`. -- This is an automated message from the Apache

[GitHub] [kafka] tledkov commented on a diff in pull request #14355: KAFKA-14595 ReassignPartitionsUnitTest rewritten in java

2023-09-18 Thread via GitHub
tledkov commented on code in PR #14355: URL: https://github.com/apache/kafka/pull/14355#discussion_r1328524712 ## tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsUnitTest.java: ## @@ -0,0 +1,787 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] nizhikov commented on pull request #14355: KAFKA-14595 ReassignPartitionsUnitTest rewritten in java

2023-09-18 Thread via GitHub
nizhikov commented on PR #14355: URL: https://github.com/apache/kafka/pull/14355#issuecomment-1723126659 Hello, @showuon . Are you ready to join the review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] nizhikov commented on a diff in pull request #14355: KAFKA-14595 ReassignPartitionsUnitTest rewritten in java

2023-09-18 Thread via GitHub
nizhikov commented on code in PR #14355: URL: https://github.com/apache/kafka/pull/14355#discussion_r1328512360 ## tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsUnitTest.java: ## @@ -0,0 +1,787 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] nizhikov commented on a diff in pull request #14355: KAFKA-14595 ReassignPartitionsUnitTest rewritten in java

2023-09-18 Thread via GitHub
nizhikov commented on code in PR #14355: URL: https://github.com/apache/kafka/pull/14355#discussion_r1328507634 ## tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsUnitTest.java: ## @@ -0,0 +1,787 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] tledkov commented on a diff in pull request #14355: KAFKA-14595 ReassignPartitionsUnitTest rewritten in java

2023-09-18 Thread via GitHub
tledkov commented on code in PR #14355: URL: https://github.com/apache/kafka/pull/14355#discussion_r1328505119 ## tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsUnitTest.java: ## @@ -0,0 +1,787 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] tledkov commented on a diff in pull request #14355: KAFKA-14595 ReassignPartitionsUnitTest rewritten in java

2023-09-18 Thread via GitHub
tledkov commented on code in PR #14355: URL: https://github.com/apache/kafka/pull/14355#discussion_r1328489811 ## tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsUnitTest.java: ## @@ -0,0 +1,787 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[jira] [Updated] (KAFKA-13973) block-cache-capacity metrics worth twice as much as normal

2023-09-18 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-13973: -- Fix Version/s: 3.7.0 > block-cache-capacity metrics worth twice as much as normal >

[jira] [Resolved] (KAFKA-13973) block-cache-capacity metrics worth twice as much as normal

2023-09-18 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna resolved KAFKA-13973. --- Resolution: Fixed > block-cache-capacity metrics worth twice as much as normal >

[jira] [Assigned] (KAFKA-13973) block-cache-capacity metrics worth twice as much as normal

2023-09-18 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna reassigned KAFKA-13973: - Assignee: Nicholas Telford > block-cache-capacity metrics worth twice as much as

[GitHub] [kafka] cadonna merged pull request #14317: KAFKA-13973: Fix inflated block cache metrics

2023-09-18 Thread via GitHub
cadonna merged PR #14317: URL: https://github.com/apache/kafka/pull/14317 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] nizhikov commented on a diff in pull request #14355: KAFKA-14595 ReassignPartitionsUnitTest rewritten in java

2023-09-18 Thread via GitHub
nizhikov commented on code in PR #14355: URL: https://github.com/apache/kafka/pull/14355#discussion_r1328432509 ## tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsUnitTest.java: ## @@ -0,0 +1,787 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] tledkov commented on a diff in pull request #14355: KAFKA-14595 ReassignPartitionsUnitTest rewritten in java

2023-09-18 Thread via GitHub
tledkov commented on code in PR #14355: URL: https://github.com/apache/kafka/pull/14355#discussion_r1328417149 ## tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsUnitTest.java: ## @@ -0,0 +1,787 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] tledkov commented on a diff in pull request #14355: KAFKA-14595 ReassignPartitionsUnitTest rewritten in java

2023-09-18 Thread via GitHub
tledkov commented on code in PR #14355: URL: https://github.com/apache/kafka/pull/14355#discussion_r1328417149 ## tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsUnitTest.java: ## @@ -0,0 +1,787 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[jira] [Resolved] (KAFKA-15472) Kraft broker does not seem to support sasl/scram authentication

2023-09-18 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] RivenSun resolved KAFKA-15472. -- Fix Version/s: 3.5.0 Resolution: Fixed > Kraft broker does not seem to support sasl/scram

[jira] [Commented] (KAFKA-15472) Kraft broker does not seem to support sasl/scram authentication

2023-09-18 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17766277#comment-17766277 ] RivenSun commented on KAFKA-15472: -- close this ticket... I found KAFKA-14084 at

[GitHub] [kafka] tledkov commented on a diff in pull request #14355: KAFKA-14595 ReassignPartitionsUnitTest rewritten in java

2023-09-18 Thread via GitHub
tledkov commented on code in PR #14355: URL: https://github.com/apache/kafka/pull/14355#discussion_r1328392039 ## tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsUnitTest.java: ## @@ -0,0 +1,787 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] tledkov commented on a diff in pull request #14355: KAFKA-14595 ReassignPartitionsUnitTest rewritten in java

2023-09-18 Thread via GitHub
tledkov commented on code in PR #14355: URL: https://github.com/apache/kafka/pull/14355#discussion_r1328392039 ## tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsUnitTest.java: ## @@ -0,0 +1,787 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[jira] [Created] (KAFKA-15472) Kraft broker does not seem to support sasl/scram authentication

2023-09-18 Thread RivenSun (Jira)
RivenSun created KAFKA-15472: Summary: Kraft broker does not seem to support sasl/scram authentication Key: KAFKA-15472 URL: https://issues.apache.org/jira/browse/KAFKA-15472 Project: Kafka

[GitHub] [kafka] tledkov commented on a diff in pull request #14355: KAFKA-14595 ReassignPartitionsUnitTest rewritten in java

2023-09-18 Thread via GitHub
tledkov commented on code in PR #14355: URL: https://github.com/apache/kafka/pull/14355#discussion_r1328392039 ## tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsUnitTest.java: ## @@ -0,0 +1,787 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] tledkov commented on a diff in pull request #14355: KAFKA-14595 ReassignPartitionsUnitTest rewritten in java

2023-09-18 Thread via GitHub
tledkov commented on code in PR #14355: URL: https://github.com/apache/kafka/pull/14355#discussion_r1328392039 ## tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsUnitTest.java: ## @@ -0,0 +1,787 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] tledkov commented on a diff in pull request #14355: KAFKA-14595 ReassignPartitionsUnitTest rewritten in java

2023-09-18 Thread via GitHub
tledkov commented on code in PR #14355: URL: https://github.com/apache/kafka/pull/14355#discussion_r1328392039 ## tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsUnitTest.java: ## @@ -0,0 +1,787 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[jira] [Commented] (KAFKA-10339) MirrorMaker2 Exactly-once Semantics

2023-09-18 Thread Angelos Kaltsikis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17766260#comment-17766260 ] Angelos Kaltsikis commented on KAFKA-10339: --- [~ChrisEgerton] Does that mean that the end to