showuon merged PR #14192:
URL: https://github.com/apache/kafka/pull/14192
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
kamalcph commented on code in PR #14459:
URL: https://github.com/apache/kafka/pull/14459#discussion_r1340946442
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -598,4 +615,13 @@ class RemoteIndexCacheTest {
timeIndex.flush()
}
}
+
+
showuon commented on PR #14192:
URL: https://github.com/apache/kafka/pull/14192#issuecomment-1740385785
Failed tests are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
showuon commented on PR #14458:
URL: https://github.com/apache/kafka/pull/14458#issuecomment-1740384154
@jlprat , PR updated. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
kamalcph commented on code in PR #14459:
URL: https://github.com/apache/kafka/pull/14459#discussion_r1340946442
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -598,4 +615,13 @@ class RemoteIndexCacheTest {
timeIndex.flush()
}
}
+
+
Rohit Bobade created KAFKA-15520:
Summary: Kafka Streams Stateful Aggregation Rebalancing causing
processing to pause on all partitions
Key: KAFKA-15520
URL: https://issues.apache.org/jira/browse/KAFKA-15520
vamossagar12 opened a new pull request, #14468:
URL: https://github.com/apache/kafka/pull/14468
The Javadoc for `GroupMetadataManager#throwIfMemberEpochIsInvalid` suggests
that it throws a `NotCoordinatorException` exception when the member epoch in
the consumer heartbeat request is greater
Vaibhav-Nazare commented on PR #13817:
URL: https://github.com/apache/kafka/pull/13817#issuecomment-1740308135
Hi @divijvaidya @mimaison @cmccabe any updates on how we want to proceed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/KAFKA-15488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770285#comment-17770285
]
Albert Wong commented on KAFKA-15488:
-
Under "Database Integration"
StarRocks Sink
Albert Wong created KAFKA-15519:
---
Summary: Add StarRocks to ecosystem page
Key: KAFKA-15519
URL: https://issues.apache.org/jira/browse/KAFKA-15519
Project: Kafka
Issue Type: Task
Re
dajac commented on code in PR #14467:
URL: https://github.com/apache/kafka/pull/14467#discussion_r1340783778
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -190,6 +191,11 @@ public GroupCoordinatorService build() {
jeffkbkim commented on code in PR #14408:
URL: https://github.com/apache/kafka/pull/14408#discussion_r1340788752
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupCoordinatorServiceTest.java:
##
@@ -936,4 +940,216 @@ public void
testLeaveGroupThrowsUnkn
jeffkbkim commented on code in PR #14408:
URL: https://github.com/apache/kafka/pull/14408#discussion_r1340783686
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java:
##
@@ -849,6 +853,42 @@ public void validateOffsetFetch(
}
jeffkbkim commented on code in PR #14408:
URL: https://github.com/apache/kafka/pull/14408#discussion_r1340783926
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorShard.java:
##
@@ -262,6 +267,44 @@ public HeartbeatResponseData genericGroupHea
jeffkbkim opened a new pull request, #14467:
URL: https://github.com/apache/kafka/pull/14467
Built on top of https://github.com/apache/kafka/pull/14408, this patch
implements the group & offset expiration in the new group coordinator.
### Committer Checklist (excluded from commit mess
dajac commented on code in PR #14462:
URL: https://github.com/apache/kafka/pull/14462#discussion_r1340758791
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -505,9 +508,52 @@ public
CompletableFuture> descri
dajac commented on code in PR #14408:
URL: https://github.com/apache/kafka/pull/14408#discussion_r1340716345
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorShard.java:
##
@@ -262,6 +267,44 @@ public HeartbeatResponseData genericGroupHeartbe
antonagestam commented on PR #14447:
URL: https://github.com/apache/kafka/pull/14447#issuecomment-1740133095
@dajac Thank you for merging this. As already hinted at, I don't think it's
too likely I'll get around to looking into implementing some enforcing
mechanism for this.
--
This is a
ableegoldman commented on PR #14435:
URL: https://github.com/apache/kafka/pull/14435#issuecomment-1740092723
@lucasbru you set up your apache account already, right? I'm leaving it to
you to merge but just let me know if you need me to do so
--
This is an automated message from the Apache
[
https://issues.apache.org/jira/browse/KAFKA-15493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770252#comment-17770252
]
Said BOUDJELDA commented on KAFKA-15493:
I need to redo all the test and start f
philipnee commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1340690791
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java:
##
@@ -106,7 +127,62 @@ public void onFailure(RuntimeException e) {
return
chb2ab commented on code in PR #1:
URL: https://github.com/apache/kafka/pull/1#discussion_r1340690328
##
clients/src/main/resources/common/message/FetchRequest.json:
##
@@ -53,7 +53,9 @@
//
// Version 15 adds the ReplicaState which includes new field ReplicaEpoch
chb2ab commented on PR #1:
URL: https://github.com/apache/kafka/pull/1#issuecomment-1740035642
> Thanks for the PR @chb2ab!
>
> Looks good overall. Since the KIP is awaiting a final vote, should this PR
wait until that goes through before merging?
Thank you Kirk, yeah I
dajac merged PR #14418:
URL: https://github.com/apache/kafka/pull/14418
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
rreddy-22 commented on code in PR #14416:
URL: https://github.com/apache/kafka/pull/14416#discussion_r1340525450
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java:
##
@@ -0,0 +1,409 @@
+/*
+ * Licensed to the Ap
[
https://issues.apache.org/jira/browse/KAFKA-15330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770194#comment-17770194
]
Colin McCabe commented on KAFKA-15330:
--
This seems likely to be a duplicate of KAFK
[
https://issues.apache.org/jira/browse/KAFKA-15230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770193#comment-17770193
]
Colin McCabe commented on KAFKA-15230:
--
This is fixed by the KIP-919 work.
> ApiVe
ahuang98 commented on code in PR #14206:
URL: https://github.com/apache/kafka/pull/14206#discussion_r1340519640
##
metadata/src/test/java/org/apache/kafka/image/ProducerIdsImageTest.java:
##
@@ -54,11 +54,24 @@ public class ProducerIdsImageTest {
setBrokerId(3).
[
https://issues.apache.org/jira/browse/KAFKA-15230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe reassigned KAFKA-15230:
Assignee: Colin McCabe
> ApiVersions data between controllers is not reliable
> -
[
https://issues.apache.org/jira/browse/KAFKA-15230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe resolved KAFKA-15230.
--
Fix Version/s: 3.7.0
Resolution: Fixed
> ApiVersions data between controllers is not re
rreddy-22 commented on code in PR #14416:
URL: https://github.com/apache/kafka/pull/14416#discussion_r1340500692
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java:
##
@@ -0,0 +1,409 @@
+/*
+ * Licensed to the Ap
rreddy-22 commented on code in PR #14416:
URL: https://github.com/apache/kafka/pull/14416#discussion_r1340500692
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java:
##
@@ -0,0 +1,409 @@
+/*
+ * Licensed to the Ap
rreddy-22 commented on code in PR #14416:
URL: https://github.com/apache/kafka/pull/14416#discussion_r1340497083
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java:
##
@@ -0,0 +1,409 @@
+/*
+ * Licensed to the Ap
rreddy-22 commented on code in PR #14416:
URL: https://github.com/apache/kafka/pull/14416#discussion_r1340488260
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AbstractUniformAssignmentBuilder.java:
##
@@ -0,0 +1,256 @@
+/*
+ * Licensed to the Apa
rreddy-22 commented on code in PR #14416:
URL: https://github.com/apache/kafka/pull/14416#discussion_r1340487558
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java:
##
@@ -0,0 +1,409 @@
+/*
+ * Licensed to the Ap
rreddy-22 commented on code in PR #14416:
URL: https://github.com/apache/kafka/pull/14416#discussion_r1340483136
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java:
##
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apach
rreddy-22 commented on code in PR #14416:
URL: https://github.com/apache/kafka/pull/14416#discussion_r1340482277
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AbstractUniformAssignmentBuilder.java:
##
@@ -0,0 +1,256 @@
+/*
+ * Licensed to the Apa
rreddy-22 commented on code in PR #14416:
URL: https://github.com/apache/kafka/pull/14416#discussion_r1340481221
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AbstractUniformAssignmentBuilder.java:
##
@@ -0,0 +1,256 @@
+/*
+ * Licensed to the Apa
[
https://issues.apache.org/jira/browse/KAFKA-15455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lianet Magrans reassigned KAFKA-15455:
--
Assignee: Lianet Magrans
> Add support for OffsetCommit version 9 in consumer
> -
rreddy-22 commented on PR #14418:
URL: https://github.com/apache/kafka/pull/14418#issuecomment-1739739962
> Thanks for this PR @rreddy-22 . LGTM. I had a slightly orthogonal question
, I see another class by the same name TopicIDPartition
[here](https://github.com/apache/kafka/blob/7ba6d7a0
rondagostino commented on code in PR #14206:
URL: https://github.com/apache/kafka/pull/14206#discussion_r1340468538
##
metadata/src/test/java/org/apache/kafka/image/ProducerIdsImageTest.java:
##
@@ -54,11 +54,24 @@ public class ProducerIdsImageTest {
setBrokerId(3).
bmscomp commented on PR #14450:
URL: https://github.com/apache/kafka/pull/14450#issuecomment-1739711254
Thank you @divijvaidya for closing this pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
nizhikov commented on PR #14456:
URL: https://github.com/apache/kafka/pull/14456#issuecomment-1739672639
Hello @tledkov can you, please, take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
philipnee commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1340402407
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Deserializers.java:
##
@@ -75,4 +75,12 @@ public void close() {
throw new KafkaExcep
dajac commented on PR #14447:
URL: https://github.com/apache/kafka/pull/14447#issuecomment-1739647220
I have opened https://issues.apache.org/jira/browse/KAFKA-15518 to improve
the generator for this particular case.
--
This is an automated message from the Apache Git Service.
To respond
David Jacot created KAFKA-15518:
---
Summary: The generator should ensure that versions of all the
fields are within the valid versions
Key: KAFKA-15518
URL: https://issues.apache.org/jira/browse/KAFKA-15518
dajac merged PR #14447:
URL: https://github.com/apache/kafka/pull/14447
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
yashmayya commented on PR #14464:
URL: https://github.com/apache/kafka/pull/14464#issuecomment-1739637687
One potential option to prevent such breakages in the future could be to use
[this
workaround](https://github.com/gradle/gradle/issues/1697#issuecomment-386824663)
and set a common Swa
dajac merged PR #14461:
URL: https://github.com/apache/kafka/pull/14461
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
dajac commented on code in PR #14418:
URL: https://github.com/apache/kafka/pull/14418#discussion_r1340389563
##
server-common/src/main/java/org/apache/kafka/server/common/TopicIdPartition.java:
##
@@ -54,3 +63,6 @@ public String toString() {
return topicId + ":" + parti
dajac commented on code in PR #14463:
URL: https://github.com/apache/kafka/pull/14463#discussion_r1340387942
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -131,6 +131,11 @@
*/
public class GroupMetadataManager {
+
philipnee commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1340351740
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -0,0 +1,324 @@
+/*
+ * Licensed to the Apache Software Founda
[
https://issues.apache.org/jira/browse/KAFKA-15467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Jacobs updated KAFKA-15467:
-
Component/s: (was: mirrormaker)
Description:
So this started with me thinking this was a
tinaselenge commented on code in PR #14455:
URL: https://github.com/apache/kafka/pull/14455#discussion_r1340297319
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -1546,9 +1546,9 @@ void enqueue(Call call, long now) {
*/
vo
tinaselenge commented on code in PR #14453:
URL: https://github.com/apache/kafka/pull/14453#discussion_r1340283213
##
core/src/test/scala/unit/kafka/tools/DumpLogSegmentsTest.scala:
##
@@ -105,7 +105,9 @@ class DumpLogSegmentsTest {
@AfterEach
def tearDown(): Unit = {
-
lianetm opened a new pull request, #14466:
URL: https://github.com/apache/kafka/pull/14466
This PR includes:
- new integration tests to validate the new consumer implementation,
covering fetching from manually assigned partitions (no group management
capabilities), and committing offsets
[
https://issues.apache.org/jira/browse/KAFKA-15467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770079#comment-17770079
]
Steve Jacobs commented on KAFKA-15467:
--
It's not mirrormaker2 it's the broker. I'm
jlprat commented on PR #14458:
URL: https://github.com/apache/kafka/pull/14458#issuecomment-1739263382
@showuon can you rebase this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
lianetm commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1340176254
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -0,0 +1,324 @@
+/*
+ * Licensed to the Apache Software Foundati
lucasbru commented on code in PR #14281:
URL: https://github.com/apache/kafka/pull/14281#discussion_r1340170824
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/tasks/TaskManager.java:
##
@@ -56,10 +58,10 @@ public interface TaskManager {
*
* Thi
lucasbru commented on code in PR #14281:
URL: https://github.com/apache/kafka/pull/14281#discussion_r1340169821
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/tasks/DefaultTaskManagerTest.java:
##
@@ -233,6 +236,18 @@ public void
shouldAssignTasksThatCanB
[
https://issues.apache.org/jira/browse/KAFKA-15510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rajini Sivaram resolved KAFKA-15510.
Fix Version/s: 3.7.0
Resolution: Fixed
> Follower's lastFetchedEpoch wrongly set wh
[
https://issues.apache.org/jira/browse/KAFKA-15510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770051#comment-17770051
]
Rajini Sivaram commented on KAFKA-15510:
This does not currently impact truncati
rajinisivaram merged PR #14457:
URL: https://github.com/apache/kafka/pull/14457
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.a
[
https://issues.apache.org/jira/browse/KAFKA-15499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya updated KAFKA-15499:
-
Fix Version/s: 3.6.0
> Fix the flaky DeleteSegmentsDueToLogStartOffsetBreachTest
> -
[
https://issues.apache.org/jira/browse/KAFKA-15499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya updated KAFKA-15499:
-
Affects Version/s: 3.6.0
> Fix the flaky DeleteSegmentsDueToLogStartOffsetBreachTest
> -
divijvaidya commented on PR #14439:
URL: https://github.com/apache/kafka/pull/14439#issuecomment-1739135002
Merged to trunk and 3.6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
divijvaidya commented on code in PR #14439:
URL: https://github.com/apache/kafka/pull/14439#discussion_r1340114261
##
storage/src/test/java/org/apache/kafka/server/log/remote/storage/LocalTieredStorageTest.java:
##
@@ -621,7 +612,7 @@ LogSegmentData nextSegment() {
}
divijvaidya merged PR #14439:
URL: https://github.com/apache/kafka/pull/14439
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apa
lucasbru commented on code in PR #14281:
URL: https://github.com/apache/kafka/pull/14281#discussion_r1340120008
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/tasks/DefaultTaskExecutor.java:
##
@@ -168,9 +192,10 @@ private StreamTask unassignCurrentTask()
divijvaidya commented on PR #14439:
URL: https://github.com/apache/kafka/pull/14439#issuecomment-1739123328
Unrelated test failures:
```
[Build / JDK 8 and Scala 2.12 /
kafka.api.DelegationTokenEndToEndAuthorizationWithOwnerTest.testCreateTokenForOtherUserFails(String).quorum=kraft](ht
lucasbru commented on code in PR #14281:
URL: https://github.com/apache/kafka/pull/14281#discussion_r1340115575
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/tasks/DefaultTaskExecutor.java:
##
@@ -237,8 +275,18 @@ public KafkaFuture unassign() {
lucasbru commented on code in PR #14281:
URL: https://github.com/apache/kafka/pull/14281#discussion_r1340113969
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/tasks/TaskManager.java:
##
@@ -56,10 +58,10 @@ public interface TaskManager {
*
* Thi
dajac commented on PR #14447:
URL: https://github.com/apache/kafka/pull/14447#issuecomment-1739070764
I am not sure how we could write an unit test for this one. However, I think
that we should at minimum improve the generator to verify this. It should not
possible to use a version for a fi
Mickael Maison created KAFKA-15517:
--
Summary: Improve MirrorMaker logging in case of authorization
errors
Key: KAFKA-15517
URL: https://issues.apache.org/jira/browse/KAFKA-15517
Project: Kafka
kamalcph commented on PR #14439:
URL: https://github.com/apache/kafka/pull/14439#issuecomment-1738855239
> Let me try to understand the situation here before I look into the code
change.
>
> 1. Leader A has a segment with offsets [1-3]. It expires this segment and
moves global start
divijvaidya commented on PR #14381:
URL: https://github.com/apache/kafka/pull/14381#issuecomment-1738839896
@satishd (gentle reminder), we are waiting for your review on this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
divijvaidya commented on PR #14439:
URL: https://github.com/apache/kafka/pull/14439#issuecomment-1738833954
Let me try to understand the situation here before I look into the code
change.
1. Leader A has a segment with offsets [1-3]. It expires this segment and
moves global start off
divijvaidya commented on code in PR #14453:
URL: https://github.com/apache/kafka/pull/14453#discussion_r1339822823
##
core/src/test/scala/unit/kafka/tools/DumpLogSegmentsTest.scala:
##
@@ -105,7 +105,9 @@ class DumpLogSegmentsTest {
@AfterEach
def tearDown(): Unit = {
-
divijvaidya commented on PR #14459:
URL: https://github.com/apache/kafka/pull/14459#issuecomment-1738783583
@Hangleton @satishd since you folks participated in the review for this PR,
do you have any additional comments?
--
This is an automated message from the Apache Git Service.
To resp
divijvaidya commented on PR #14459:
URL: https://github.com/apache/kafka/pull/14459#issuecomment-1738763546
Test failures are unrelated to Tiered Storage code.
```
[Build / JDK 21 and Scala 2.13 /
org.apache.kafka.streams.integration.NamedTopologyIntegrationTest.shouldRemoveOneNamedTop
81 matches
Mail list logo
