[GitHub] [kafka] yangy0000 commented on a diff in pull request #14408: KAFKA-14506: Implement DeleteGroups API and OffsetDelete API

yangy commented on code in PR #14408: URL: https://github.com/apache/kafka/pull/14408#discussion_r1341919233 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -333,6 +348,87 @@ public CoordinatorResult commitOffset(

[GitHub] [kafka] yangy0000 commented on a diff in pull request #14408: KAFKA-14506: Implement DeleteGroups API and OffsetDelete API

yangy commented on code in PR #14408: URL: https://github.com/apache/kafka/pull/14408#discussion_r1341918630 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -333,6 +348,87 @@ public CoordinatorResult commitOffset(

[GitHub] [kafka] yangy0000 commented on a diff in pull request #14408: KAFKA-14506: Implement DeleteGroups API and OffsetDelete API

yangy commented on code in PR #14408: URL: https://github.com/apache/kafka/pull/14408#discussion_r1341918630 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -333,6 +348,87 @@ public CoordinatorResult commitOffset(

[GitHub] [kafka] yangy0000 commented on a diff in pull request #14408: KAFKA-14506: Implement DeleteGroups API and OffsetDelete API

yangy commented on code in PR #14408: URL: https://github.com/apache/kafka/pull/14408#discussion_r1341918630 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -333,6 +348,87 @@ public CoordinatorResult commitOffset(

[GitHub] [kafka] yangy0000 commented on a diff in pull request #14408: KAFKA-14506: Implement DeleteGroups API and OffsetDelete API

yangy commented on code in PR #14408: URL: https://github.com/apache/kafka/pull/14408#discussion_r1341918630 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -333,6 +348,87 @@ public CoordinatorResult commitOffset(

[GitHub] [kafka] yangy0000 commented on a diff in pull request #14408: KAFKA-14506: Implement DeleteGroups API and OffsetDelete API

yangy commented on code in PR #14408: URL: https://github.com/apache/kafka/pull/14408#discussion_r1341917129 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -705,9 +783,39 @@ public CompletableFuture deleteOffsets(

[GitHub] [kafka] yangy0000 commented on a diff in pull request #14408: KAFKA-14506: Implement DeleteGroups API and OffsetDelete API

yangy commented on code in PR #14408: URL: https://github.com/apache/kafka/pull/14408#discussion_r1341917129 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -705,9 +783,39 @@ public CompletableFuture deleteOffsets(

[GitHub] [kafka] nizhikov commented on a diff in pull request #14456: KAFKA-14595 ReassignPartitionsIntegrationTest rewritten in java

nizhikov commented on code in PR #14456: URL: https://github.com/apache/kafka/pull/14456#discussion_r1341916863 ## tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsIntegrationTest.java: ## @@ -0,0 +1,924 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] nizhikov commented on a diff in pull request #14456: KAFKA-14595 ReassignPartitionsIntegrationTest rewritten in java

nizhikov commented on code in PR #14456: URL: https://github.com/apache/kafka/pull/14456#discussion_r1341916863 ## tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsIntegrationTest.java: ## @@ -0,0 +1,924 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] nizhikov commented on pull request #14456: KAFKA-14595 ReassignPartitionsIntegrationTest rewritten in java

nizhikov commented on PR #14456: URL: https://github.com/apache/kafka/pull/14456#issuecomment-1741691271 @jolshan I answered all your question. Take a look, please. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [kafka] nizhikov commented on a diff in pull request #14456: KAFKA-14595 ReassignPartitionsIntegrationTest rewritten in java

nizhikov commented on code in PR #14456: URL: https://github.com/apache/kafka/pull/14456#discussion_r1341916903 ## tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsIntegrationTest.java: ## @@ -0,0 +1,924 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] nizhikov commented on a diff in pull request #14456: KAFKA-14595 ReassignPartitionsIntegrationTest rewritten in java

nizhikov commented on code in PR #14456: URL: https://github.com/apache/kafka/pull/14456#discussion_r1341916863 ## tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsIntegrationTest.java: ## @@ -0,0 +1,924 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] nizhikov commented on a diff in pull request #14456: KAFKA-14595 ReassignPartitionsIntegrationTest rewritten in java

nizhikov commented on code in PR #14456: URL: https://github.com/apache/kafka/pull/14456#discussion_r1341916682 ## tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsIntegrationTest.java: ## @@ -0,0 +1,924 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Commented] (KAFKA-15520) Kafka Streams Stateful Aggregation Rebalancing causing processing to pause on all partitions

[ https://issues.apache.org/jira/browse/KAFKA-15520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770635#comment-17770635 ] A. Sophie Blee-Goldman commented on KAFKA-15520: {quote}Also added props

[GitHub] [kafka] dajac commented on a diff in pull request #14384: KAFKA-15415 On producer-batch retry, skip-backoff on a new leader

dajac commented on code in PR #14384: URL: https://github.com/apache/kafka/pull/14384#discussion_r1341872411 ## clients/src/main/java/org/apache/kafka/common/PartitionInfo.java: ## @@ -20,6 +20,7 @@ * This is used to describe per-partition state in the MetadataResponse. */

[GitHub] [kafka] jolshan commented on a diff in pull request #14456: KAFKA-14595 ReassignPartitionsIntegrationTest rewritten in java

jolshan commented on code in PR #14456: URL: https://github.com/apache/kafka/pull/14456#discussion_r1341851404 ## tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsIntegrationTest.java: ## @@ -0,0 +1,924 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [kafka] jolshan commented on a diff in pull request #14456: KAFKA-14595 ReassignPartitionsIntegrationTest rewritten in java

jolshan commented on code in PR #14456: URL: https://github.com/apache/kafka/pull/14456#discussion_r1341850939 ## tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsIntegrationTest.java: ## @@ -0,0 +1,924 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [kafka] jolshan commented on a diff in pull request #14456: KAFKA-14595 ReassignPartitionsIntegrationTest rewritten in java

jolshan commented on code in PR #14456: URL: https://github.com/apache/kafka/pull/14456#discussion_r1341849823 ## tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsIntegrationTest.java: ## @@ -0,0 +1,924 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [kafka] jolshan commented on a diff in pull request #14456: KAFKA-14595 ReassignPartitionsIntegrationTest rewritten in java

jolshan commented on code in PR #14456: URL: https://github.com/apache/kafka/pull/14456#discussion_r1341849249 ## tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsIntegrationTest.java: ## @@ -0,0 +1,924 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [kafka] jolshan commented on a diff in pull request #14456: KAFKA-14595 ReassignPartitionsIntegrationTest rewritten in java

jolshan commented on code in PR #14456: URL: https://github.com/apache/kafka/pull/14456#discussion_r1341849150 ## tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsIntegrationTest.java: ## @@ -0,0 +1,924 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [kafka] nizhikov commented on a diff in pull request #14456: KAFKA-14595 ReassignPartitionsIntegrationTest rewritten in java

nizhikov commented on code in PR #14456: URL: https://github.com/apache/kafka/pull/14456#discussion_r1341828934 ## tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsIntegrationTest.java: ## @@ -0,0 +1,924 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] nizhikov commented on pull request #14456: KAFKA-14595 ReassignPartitionsIntegrationTest rewritten in java

nizhikov commented on PR #14456: URL: https://github.com/apache/kafka/pull/14456#issuecomment-1741551570 @jolshan Thanks for the review. I resolve all your comments. Please, take a look one more time. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] dajac closed pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

dajac closed pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9 URL: https://github.com/apache/kafka/pull/13240 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [kafka] dajac commented on pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

dajac commented on PR #13240: URL: https://github.com/apache/kafka/pull/13240#issuecomment-1741511578 Closing this PR for now as the topic id work will be done later. We can re-open it when we resume the work. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] dajac commented on pull request #13493: KAFKA-14852: Propagate Topic Ids to the Group Coordinator for Offset Fetch

dajac commented on PR #13493: URL: https://github.com/apache/kafka/pull/13493#issuecomment-1741511409 Closing this PR for now as the topic id work will be done later. We can re-open it when we resume the work. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] dajac commented on pull request #13764: KAFKA-14691; [1/N] Add new fields to OffsetFetchRequest and OffsetFetchResponse - WIP

dajac commented on PR #13764: URL: https://github.com/apache/kafka/pull/13764#issuecomment-1741511285 Closing this PR for now as the topic id work will be done later. We can re-open it when we resume the work. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] dajac closed pull request #13352: Add support of topic ids for the OffsetFetch API from version 9.

dajac closed pull request #13352: Add support of topic ids for the OffsetFetch API from version 9. URL: https://github.com/apache/kafka/pull/13352 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] dajac commented on pull request #13352: Add support of topic ids for the OffsetFetch API from version 9.

dajac commented on PR #13352: URL: https://github.com/apache/kafka/pull/13352#issuecomment-1741511498 Closing this PR for now as the topic id work will be done later. We can re-open it when we resume the work. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] dajac closed pull request #13493: KAFKA-14852: Propagate Topic Ids to the Group Coordinator for Offset Fetch

dajac closed pull request #13493: KAFKA-14852: Propagate Topic Ids to the Group Coordinator for Offset Fetch URL: https://github.com/apache/kafka/pull/13493 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] dajac closed pull request #13764: KAFKA-14691; [1/N] Add new fields to OffsetFetchRequest and OffsetFetchResponse - WIP

dajac closed pull request #13764: KAFKA-14691; [1/N] Add new fields to OffsetFetchRequest and OffsetFetchResponse - WIP URL: https://github.com/apache/kafka/pull/13764 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [kafka] jolshan commented on a diff in pull request #14370: KAFKA-15449: Verify transactional offset commits (KIP-890 part 1)

jolshan commented on code in PR #14370: URL: https://github.com/apache/kafka/pull/14370#discussion_r1341806378 ## core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala: ## @@ -449,6 +452,10 @@ class GroupMetadataManager(brokerId: Int, | E

[GitHub] [kafka] jolshan commented on a diff in pull request #14469: MINOR: Remove the client side assignor from the ConsumerGroupHeartbeat API

jolshan commented on code in PR #14469: URL: https://github.com/apache/kafka/pull/14469#discussion_r1341802855 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -1999,15 +1991,7 @@ public void testReconciliationProcess() {

[GitHub] [kafka] dajac commented on a diff in pull request #14469: MINOR: Remove the client side assignor from the ConsumerGroupHeartbeat API

dajac commented on code in PR #14469: URL: https://github.com/apache/kafka/pull/14469#discussion_r1341805005 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -1999,15 +1991,7 @@ public void testReconciliationProcess() {

[GitHub] [kafka] jolshan commented on a diff in pull request #14469: MINOR: Remove the client side assignor from the ConsumerGroupHeartbeat API

jolshan commented on code in PR #14469: URL: https://github.com/apache/kafka/pull/14469#discussion_r1341799327 ## clients/src/main/resources/common/message/ConsumerGroupHeartbeatRequest.json: ## @@ -43,21 +43,6 @@ "about": "null if it didn't change since the last heartbea

[GitHub] [kafka] jsancio commented on a diff in pull request #14428: KAFKA-15489: resign leadership when no fetch from majority voters

jsancio commented on code in PR #14428: URL: https://github.com/apache/kafka/pull/14428#discussion_r1341771602 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java: ## @@ -485,6 +485,49 @@ public void testHandleBeginQuorumEpochAfterUserInitiatedResign() throws E

[GitHub] [kafka] dajac commented on a diff in pull request #14370: KAFKA-15449: Verify transactional offset commits (KIP-890 part 1)

dajac commented on code in PR #14370: URL: https://github.com/apache/kafka/pull/14370#discussion_r1341791921 ## core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataManagerTest.scala: ## @@ -1450,7 +1455,61 @@ class GroupMetadataManagerTest { any[Option[Reentrant

[GitHub] [kafka] philipnee commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

philipnee commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1341778036 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -0,0 +1,324 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [kafka] philipnee commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

philipnee commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1341775832 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -0,0 +1,324 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [kafka] dajac opened a new pull request, #14469: MINOR: Remove the client side assignor from the ConsumerGroupHeartbeat API

dajac opened a new pull request, #14469: URL: https://github.com/apache/kafka/pull/14469 As a first step, we plan to release a preview of the new consumer group rebalance protocol without the client side assignor. This patch removes all the related fields from the ConsumerGroupHeartbeat API

[GitHub] [kafka] philipnee commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

philipnee commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1341767013 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -0,0 +1,324 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [kafka] philipnee commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

philipnee commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1341699215 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -0,0 +1,324 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [kafka] philipnee commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

philipnee commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1341690694 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -0,0 +1,324 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1341666380 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -0,0 +1,324 @@ +/* + * Licensed to the Apache Software Foundati

[jira] [Commented] (KAFKA-15520) Kafka Streams Stateful Aggregation Rebalancing causing processing to pause on all partitions

[ https://issues.apache.org/jira/browse/KAFKA-15520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770556#comment-17770556 ] Rohit Bobade commented on KAFKA-15520: -- Yes, sounds good. We're planning to upgrade

[GitHub] [kafka] philipnee commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

philipnee commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1341669179 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -0,0 +1,324 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1341666380 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -0,0 +1,324 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1341662210 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AssignorSelection.java: ## @@ -56,7 +57,7 @@ public static AssignorSelection defaultAssignor() {

[GitHub] [kafka] dajac commented on a diff in pull request #14417: KAFKA-14519; [1/N] Implement coordinator runtime metrics

dajac commented on code in PR #14417: URL: https://github.com/apache/kafka/pull/14417#discussion_r1341655709 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -1242,7 +1304,11 @@ public void scheduleLoadOperation(

[GitHub] [kafka] dajac commented on a diff in pull request #14408: KAFKA-14506: Implement DeleteGroups API and OffsetDelete API

dajac commented on code in PR #14408: URL: https://github.com/apache/kafka/pull/14408#discussion_r1341653044 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java: ## @@ -849,6 +853,42 @@ public void validateOffsetFetch( }

[GitHub] [kafka] dajac commented on pull request #14468: MINOR: Correcting Javadocs for throwIfMemberEpochIsInvalid

dajac commented on PR #14468: URL: https://github.com/apache/kafka/pull/14468#issuecomment-1741275014 @vamossagar12 It looks like there is an issue with the build. Could you take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] dajac commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

dajac commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1341532755 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -0,0 +1,324 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] jlprat commented on pull request #14458: KAFKA-15498: bump snappy-java version to 1.1.10.5

jlprat commented on PR #14458: URL: https://github.com/apache/kafka/pull/14458#issuecomment-1741271449 @ijuma I agree with you, this is merely a patch update (according to the release notes). @showuon I see some strange failures regarding: `Failed to load SSL keystore /tmp/truststorexx

[GitHub] [kafka] ijuma commented on pull request #14458: KAFKA-15498: bump snappy-java version to 1.1.10.5

ijuma commented on PR #14458: URL: https://github.com/apache/kafka/pull/14458#issuecomment-1741267716 I don't think this is a 3.6.0 blocker, so I think we should not merge it to 3.6. Is that fair? -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [kafka] ijuma commented on pull request #14434: KAFKA-15498: bump snappy-java version to 1.1.10.4

ijuma commented on PR #14434: URL: https://github.com/apache/kafka/pull/14434#issuecomment-1741266891 That new version should stick to master, I don't see anything there that should be considered a release blocker. -- This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (KAFKA-15520) Kafka Streams Stateful Aggregation Rebalancing causing processing to pause on all partitions

[ https://issues.apache.org/jira/browse/KAFKA-15520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770539#comment-17770539 ] Matthias J. Sax commented on KAFKA-15520: - {quote}However, I'm seeing that when

[jira] [Resolved] (KAFKA-15491) RackId doesn't exist error while running WordCountDemo

[ https://issues.apache.org/jira/browse/KAFKA-15491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-15491. - Fix Version/s: 3.6.1 3.7.0 Assignee: Hao Li Resolution

[GitHub] [kafka] nizhikov commented on a diff in pull request #14456: KAFKA-14595 ReassignPartitionsIntegrationTest rewritten in java

nizhikov commented on code in PR #14456: URL: https://github.com/apache/kafka/pull/14456#discussion_r1341630758 ## tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsIntegrationTest.java: ## @@ -0,0 +1,897 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] mjsax commented on pull request #14415: MINOR: only log error when rack aware assignment is enabled

mjsax commented on PR #14415: URL: https://github.com/apache/kafka/pull/14415#issuecomment-1741244568 Thanks for the quick fix! -- Merged to `trunk` and cherry-picked to `3.6` branch (hope the new RC will pick it up). -- This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] mjsax merged pull request #14415: MINOR: only log error when rack aware assignment is enabled

mjsax merged PR #14415: URL: https://github.com/apache/kafka/pull/14415 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] jolshan commented on a diff in pull request #14456: KAFKA-14595 ReassignPartitionsIntegrationTest rewritten in java

jolshan commented on code in PR #14456: URL: https://github.com/apache/kafka/pull/14456#discussion_r1341592727 ## tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsIntegrationTest.java: ## @@ -0,0 +1,897 @@ +/* + * Licensed to the Apache Software Foundation (

[jira] [Commented] (KAFKA-6020) Broker side filtering

[ https://issues.apache.org/jira/browse/KAFKA-6020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770509#comment-17770509 ] Alexander Grzesik commented on KAFKA-6020: -- It would definitly help for several

[GitHub] [kafka] nizhikov commented on a diff in pull request #14456: KAFKA-14595 ReassignPartitionsIntegrationTest rewritten in java

nizhikov commented on code in PR #14456: URL: https://github.com/apache/kafka/pull/14456#discussion_r1341576601 ## tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsIntegrationTest.java: ## @@ -0,0 +1,897 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] jolshan commented on a diff in pull request #14456: KAFKA-14595 ReassignPartitionsIntegrationTest rewritten in java

jolshan commented on code in PR #14456: URL: https://github.com/apache/kafka/pull/14456#discussion_r1341562961 ## tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsIntegrationTest.java: ## @@ -0,0 +1,897 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [kafka] jolshan commented on a diff in pull request #14456: KAFKA-14595 ReassignPartitionsIntegrationTest rewritten in java

jolshan commented on code in PR #14456: URL: https://github.com/apache/kafka/pull/14456#discussion_r1341565812 ## tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsIntegrationTest.java: ## @@ -0,0 +1,897 @@ +/* + * Licensed to the Apache Software Foundation (

[jira] [Commented] (KAFKA-15169) Add tests for RemoteIndexCache

[ https://issues.apache.org/jira/browse/KAFKA-15169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770491#comment-17770491 ] Arpit Goyal commented on KAFKA-15169: - > Another one that comes to my mind is if we

[GitHub] [kafka] vamossagar12 commented on pull request #14468: [MINOR]: Correcting Javadocs for throwIfMemberEpochIsInvalid

vamossagar12 commented on PR #14468: URL: https://github.com/apache/kafka/pull/14468#issuecomment-1741100233 Done. I updated both the title and the PR description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [kafka] dajac commented on pull request #14468: Throwing NotCoordinatorException when received member epoch is greater than the one known by coordinator

dajac commented on PR #14468: URL: https://github.com/apache/kafka/pull/14468#issuecomment-1741092065 Thanks. Could you also update the title please and use 'MINOR:` as a prefix? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] vamossagar12 commented on pull request #14468: Throwing NotCoordinatorException when received member epoch is greater than the one known by coordinator

vamossagar12 commented on PR #14468: URL: https://github.com/apache/kafka/pull/14468#issuecomment-1741088207 Thanks for the context @dajac . I have updated the Javadocs accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [kafka] nizhikov commented on a diff in pull request #14456: KAFKA-14595 ReassignPartitionsIntegrationTest rewritten in java

nizhikov commented on code in PR #14456: URL: https://github.com/apache/kafka/pull/14456#discussion_r1341502221 ## tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsIntegrationTest.java: ## @@ -0,0 +1,896 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] nizhikov commented on a diff in pull request #14456: KAFKA-14595 ReassignPartitionsIntegrationTest rewritten in java

nizhikov commented on code in PR #14456: URL: https://github.com/apache/kafka/pull/14456#discussion_r1341497736 ## tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsIntegrationTest.java: ## @@ -0,0 +1,896 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] tledkov commented on a diff in pull request #14456: KAFKA-14595 ReassignPartitionsIntegrationTest rewritten in java

tledkov commented on code in PR #14456: URL: https://github.com/apache/kafka/pull/14456#discussion_r1341454901 ## tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsIntegrationTest.java: ## @@ -0,0 +1,896 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [kafka] dajac commented on pull request #14468: Throwing NotCoordinatorException when received member epoch is greater than the one known by coordinator

dajac commented on PR #14468: URL: https://github.com/apache/kafka/pull/14468#issuecomment-1741049133 @vamossagar12 Thanks for the PR. I think that we should rather fix the javadoc in this case. For the context, our initial idea was to return a NotCoordinatorException error in this case but

[GitHub] [kafka] jlprat commented on pull request #14458: KAFKA-15498: bump snappy-java version to 1.1.10.5

jlprat commented on PR #14458: URL: https://github.com/apache/kafka/pull/14458#issuecomment-1740852272 I was checking the failures and we have a plenty of new flaky tests that seem timing related. It might have been a CI server hiccup. I'll re-run the CI to be sure. Otherwise all the test f

[jira] [Reopened] (KAFKA-14956) Flaky test org.apache.kafka.connect.integration.OffsetsApiIntegrationTest#testGetSinkConnectorOffsetsDifferentKafkaClusterTargeted

[ https://issues.apache.org/jira/browse/KAFKA-14956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josep Prat reopened KAFKA-14956: It happened again here: https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-14458/3/testReport

[jira] [Commented] (KAFKA-15419) Flaky DescribeClusterRequestTest

[ https://issues.apache.org/jira/browse/KAFKA-15419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770421#comment-17770421 ] Josep Prat commented on KAFKA-15419: Another test in the same unit that failed: htt

[jira] [Commented] (KAFKA-12678) Flaky Test CustomQuotaCallbackTest.testCustomQuotaCallback

[ https://issues.apache.org/jira/browse/KAFKA-12678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770420#comment-17770420 ] Josep Prat commented on KAFKA-12678: Failed again: https://ci-builds.apache.org/job

[jira] [Commented] (KAFKA-15140) Improve TopicCommandIntegrationTest to be less flaky

[ https://issues.apache.org/jira/browse/KAFKA-15140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770418#comment-17770418 ] Josep Prat commented on KAFKA-15140: Another instance: https://ci-builds.apache.org

[jira] [Created] (KAFKA-15524) Flaky test org.apache.kafka.connect.integration.OffsetsApiIntegrationTest.testResetSinkConnectorOffsetsZombieSinkTasks

Josep Prat created KAFKA-15524: -- Summary: Flaky test org.apache.kafka.connect.integration.OffsetsApiIntegrationTest.testResetSinkConnectorOffsetsZombieSinkTasks Key: KAFKA-15524 URL: https://issues.apache.org/jira/br

[jira] [Created] (KAFKA-15523) Flaky test org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationSSLTest.testSyncTopicConfigs

Josep Prat created KAFKA-15523: -- Summary: Flaky test org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationSSLTest.testSyncTopicConfigs Key: KAFKA-15523 URL: https://issues.apache.org/jira/browse/KA

[jira] [Created] (KAFKA-15522) Flaky test org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationExactlyOnceTest.testOneWayReplicationWithFrequentOffsetSyncs

Josep Prat created KAFKA-15522: -- Summary: Flaky test org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationExactlyOnceTest.testOneWayReplicationWithFrequentOffsetSyncs Key: KAFKA-15522 URL: https://i

[jira] [Resolved] (KAFKA-15500) Code bug in SslPrincipalMapper.java

[ https://issues.apache.org/jira/browse/KAFKA-15500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-15500. Fix Version/s: 3.7.0 Resolution: Fixed > Code bug in SslPrincipalMapper.java >

[GitHub] [kafka] mimaison merged pull request #14441: KAFKA-15500: Correct SslPrincipalMapper.java

mimaison merged PR #14441: URL: https://github.com/apache/kafka/pull/14441 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] divijvaidya commented on pull request #14441: KAFKA-15500: Correct SslPrincipalMapper.java

divijvaidya commented on PR #14441: URL: https://github.com/apache/kafka/pull/14441#issuecomment-1740767993 > In this case `&` is treated as logical AND. I think the only difference with `&&` is that `&` always executes the right side expression even if the left side expression is false. So

[GitHub] [kafka] mimaison merged pull request #14464: MINOR: Fix build failure in genConnectOpenAPIDocs

mimaison merged PR #14464: URL: https://github.com/apache/kafka/pull/14464 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Updated] (KAFKA-15511) Exception not handled correctly if indexFile is corrupted.

[ https://issues.apache.org/jira/browse/KAFKA-15511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-15511: - Component/s: Tiered-Storage > Exception not handled correctly if indexFile is corrupted. >

[jira] [Updated] (KAFKA-15511) Exception not handled correctly if indexFile is corrupted.

[ https://issues.apache.org/jira/browse/KAFKA-15511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-15511: - Fix Version/s: 3.6.0 > Exception not handled correctly if indexFile is corrupted. > ---

[GitHub] [kafka] divijvaidya commented on pull request #14459: KAFKA-15511: Catch CorruptIndexException instead of CorruptRecordException

divijvaidya commented on PR #14459: URL: https://github.com/apache/kafka/pull/14459#issuecomment-1740758694 Merged to trunk and 3.6. Thank you for the contribution @iit2009060. For Apache projects, only the committers can merge code into the repository. -- This is an automated mess

[GitHub] [kafka] mimaison commented on pull request #14464: MINOR: Fix build failure in genConnectOpenAPIDocs

mimaison commented on PR #14464: URL: https://github.com/apache/kafka/pull/14464#issuecomment-1740754108 Yes it would be good to have the version in a single place to avoid these issues. I created https://issues.apache.org/jira/browse/KAFKA-15521 to track that work. I'll merge that n

[jira] [Created] (KAFKA-15521) Refactor build.gradle to align gradle swagger plugin with swagger dependencies

Mickael Maison created KAFKA-15521: -- Summary: Refactor build.gradle to align gradle swagger plugin with swagger dependencies Key: KAFKA-15521 URL: https://issues.apache.org/jira/browse/KAFKA-15521 Pr

[GitHub] [kafka] divijvaidya merged pull request #14459: KAFKA-15511: Catch CorruptIndexException instead of CorruptRecordException

divijvaidya merged PR #14459: URL: https://github.com/apache/kafka/pull/14459 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apa

[GitHub] [kafka] iit2009060 commented on pull request #14459: KAFKA-15511: Catch CorruptIndexException instead of CorruptRecordException

iit2009060 commented on PR #14459: URL: https://github.com/apache/kafka/pull/14459#issuecomment-1740662951 @divijvaidya It seems i don't have permission to merge it even after the approval. -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[jira] [Assigned] (KAFKA-15500) Code bug in SslPrincipalMapper.java

[ https://issues.apache.org/jira/browse/KAFKA-15500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison reassigned KAFKA-15500: -- Assignee: Svyatoslav > Code bug in SslPrincipalMapper.java >

[GitHub] [kafka] divijvaidya commented on pull request #14459: KAFKA-15511: Catch CorruptIndexException instead of CorruptRecordException

divijvaidya commented on PR #14459: URL: https://github.com/apache/kafka/pull/14459#issuecomment-1740659738 Unrelated test failures ``` [Build / JDK 8 and Scala 2.12 / integration.kafka.server.FetchFromFollowerIntegrationTest.testFollowerCompleteDelayedFetchesOnReplication(String).quor

[jira] [Commented] (KAFKA-14971) Flaky Test org.apache.kafka.connect.mirror.integration.IdentityReplicationIntegrationTest#testSyncTopicConfigs

[ https://issues.apache.org/jira/browse/KAFKA-14971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770363#comment-17770363 ] Josep Prat commented on KAFKA-14971: Another one: https://ci-builds.apache.org/job/

[jira] [Reopened] (KAFKA-13531) Flaky test NamedTopologyIntegrationTest

[ https://issues.apache.org/jira/browse/KAFKA-13531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josep Prat reopened KAFKA-13531: > Flaky test NamedTopologyIntegrationTest > --- > >

[GitHub] [kafka] mimaison commented on pull request #14441: KAFKA-15500: Correct SslPrincipalMapper.java

mimaison commented on PR #14441: URL: https://github.com/apache/kafka/pull/14441#issuecomment-1740654238 In this case `&` is treated as logical AND. I think the only difference with `&&` is that `&` always executes the right side expression even if the left side expression is false. So in

[jira] [Commented] (KAFKA-13531) Flaky test NamedTopologyIntegrationTest

[ https://issues.apache.org/jira/browse/KAFKA-13531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770362#comment-17770362 ] Josep Prat commented on KAFKA-13531: I've seen this on a recent build: https://ci-b

[jira] [Reopened] (KAFKA-13966) Flaky test `QuorumControllerTest.testUnregisterBroker`

[ https://issues.apache.org/jira/browse/KAFKA-13966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josep Prat reopened KAFKA-13966: > Flaky test `QuorumControllerTest.testUnregisterBroker` > ---

[jira] [Commented] (KAFKA-13966) Flaky test `QuorumControllerTest.testUnregisterBroker`

[ https://issues.apache.org/jira/browse/KAFKA-13966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770361#comment-17770361 ] Josep Prat commented on KAFKA-13966: I've seen this happening again: https://ci-bui

[jira] [Commented] (KAFKA-15206) Flaky test RemoteIndexCacheTest.testClose()

[ https://issues.apache.org/jira/browse/KAFKA-15206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770360#comment-17770360 ] Josep Prat commented on KAFKA-15206: Another instance: https://ci-builds.apache.org

  1   2   >