nizhikov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1345691324
##
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##
@@ -0,0 +1,1501 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
[
https://issues.apache.org/jira/browse/KAFKA-10199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna updated KAFKA-10199:
--
Fix Version/s: 3.7.0
> Separate state restoration into separate threads
>
[
https://issues.apache.org/jira/browse/KAFKA-10199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna resolved KAFKA-10199.
---
Resolution: Done
> Separate state restoration into separate threads
>
cadonna merged PR #13927:
URL: https://github.com/apache/kafka/pull/13927
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
tledkov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1345673613
##
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##
@@ -0,0 +1,1501 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
tledkov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1345673613
##
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##
@@ -0,0 +1,1501 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
nizhikov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1345657229
##
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##
@@ -0,0 +1,1501 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
nizhikov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1345648074
##
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##
@@ -0,0 +1,1501 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
nizhikov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1345647289
##
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##
@@ -0,0 +1,1501 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
tledkov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1345642089
##
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##
@@ -0,0 +1,1501 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
tledkov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1345633642
##
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##
@@ -0,0 +1,1501 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
tledkov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1345633642
##
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##
@@ -0,0 +1,1501 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
tledkov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1345633642
##
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##
@@ -0,0 +1,1501 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
tledkov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1345629562
##
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##
@@ -0,0 +1,1501 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
msn-tldr commented on code in PR #14384:
URL: https://github.com/apache/kafka/pull/14384#discussion_r1345592537
##
clients/src/test/java/org/apache/kafka/clients/producer/internals/SenderTest.java:
##
@@ -156,6 +157,8 @@ public class SenderTest {
private
msn-tldr commented on code in PR #14384:
URL: https://github.com/apache/kafka/pull/14384#discussion_r1345590803
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/ProducerBatch.java:
##
@@ -94,9 +100,40 @@ public ProducerBatch(TopicPartition tp,
nizhikov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1345590444
##
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##
@@ -0,0 +1,1501 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
jeel2420 commented on code in PR #14483:
URL: https://github.com/apache/kafka/pull/14483#discussion_r1345548349
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -132,7 +133,7 @@ class RemoteIndexCacheTest {
// this call should have invoked
dajac merged PR #14463:
URL: https://github.com/apache/kafka/pull/14463
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dajac commented on code in PR #14467:
URL: https://github.com/apache/kafka/pull/14467#discussion_r1345541333
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java:
##
@@ -539,26 +564,59 @@ public
jeel2420 opened a new pull request, #14483:
URL: https://github.com/apache/kafka/pull/14483
This PR fixes the concurrency bug in RemoteIndexCache.
(From Jira description)
RemoteIndexCache has a concurrency bug which leads to IOException while
fetching data from remote tier.
dajac commented on code in PR #14467:
URL: https://github.com/apache/kafka/pull/14467#discussion_r1345534442
##
core/src/main/scala/kafka/coordinator/group/CoordinatorPartitionWriter.scala:
##
@@ -123,50 +124,79 @@ class CoordinatorPartitionWriter[T](
val maxBatchSize
iit2009060 commented on code in PR #14482:
URL: https://github.com/apache/kafka/pull/14482#discussion_r1345533167
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -541,6 +541,126 @@ class RemoteIndexCacheTest {
verifyFetchIndexInvocation(count
tledkov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1345531820
##
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##
@@ -0,0 +1,1501 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
iit2009060 commented on code in PR #14482:
URL: https://github.com/apache/kafka/pull/14482#discussion_r1345526998
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -541,6 +541,126 @@ class RemoteIndexCacheTest {
verifyFetchIndexInvocation(count
iit2009060 commented on code in PR #14482:
URL: https://github.com/apache/kafka/pull/14482#discussion_r1345526187
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -541,6 +541,126 @@ class RemoteIndexCacheTest {
verifyFetchIndexInvocation(count
nizhikov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1345524979
##
tools/src/main/java/org/apache/kafka/tools/reassign/Tuple2.java:
##
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
nizhikov commented on PR #13247:
URL: https://github.com/apache/kafka/pull/13247#issuecomment-1746528192
@tledkov
> `ReplicationQuotasTestRig` no longer needed?
This class not used through current codebase.
But it has dependency on `ReassignPartitionCommand`.
So, for
dajac commented on code in PR #14462:
URL: https://github.com/apache/kafka/pull/14462#discussion_r1345506634
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -8686,6 +8695,88 @@ public void testListGroups() {
tledkov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1345514076
##
tools/src/main/java/org/apache/kafka/tools/reassign/Tuple2.java:
##
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
dajac merged PR #14408:
URL: https://github.com/apache/kafka/pull/14408
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-15481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeel Jotaniya reassigned KAFKA-15481:
-
Assignee: Jeel Jotaniya
> Concurrency bug in RemoteIndexCache leads to IOException
>
[
https://issues.apache.org/jira/browse/KAFKA-15535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya updated KAFKA-15535:
-
Labels: tiered-storage (was: )
> Add documentation of
vamossagar12 commented on PR #14327:
URL: https://github.com/apache/kafka/pull/14327#issuecomment-1746457140
@JimmyWang6 , In the PR title, you have mentioned `KAFKA-14048` which is the
uber ticket for KIP-848. Please change it to `KAFKA-14517` instead.
--
This is an automated message
vamossagar12 commented on PR #14423:
URL: https://github.com/apache/kafka/pull/14423#issuecomment-1746443694
Thanks for the PR @sangyongchoi. Couple of thoughts =>
1. If there are other instances of such lines which are meaningless, could
you also add them.
2. Can you add `[MINOR]`
vamossagar12 commented on code in PR #14432:
URL: https://github.com/apache/kafka/pull/14432#discussion_r1345450086
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -593,6 +609,9 @@ private void
iit2009060 commented on code in PR #14482:
URL: https://github.com/apache/kafka/pull/14482#discussion_r1345403872
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -541,6 +541,126 @@ class RemoteIndexCacheTest {
verifyFetchIndexInvocation(count
iit2009060 commented on code in PR #14482:
URL: https://github.com/apache/kafka/pull/14482#discussion_r1345392660
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -541,6 +541,126 @@ class RemoteIndexCacheTest {
verifyFetchIndexInvocation(count
vamossagar12 commented on PR #14463:
URL: https://github.com/apache/kafka/pull/14463#issuecomment-1746423437
Thanks @kirktrue , LGTM (I had already approved).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
iit2009060 commented on code in PR #14482:
URL: https://github.com/apache/kafka/pull/14482#discussion_r1345438999
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -541,6 +541,126 @@ class RemoteIndexCacheTest {
verifyFetchIndexInvocation(count
iit2009060 commented on code in PR #14482:
URL: https://github.com/apache/kafka/pull/14482#discussion_r1345403872
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -541,6 +541,126 @@ class RemoteIndexCacheTest {
verifyFetchIndexInvocation(count
iit2009060 commented on code in PR #14482:
URL: https://github.com/apache/kafka/pull/14482#discussion_r1345403872
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -541,6 +541,126 @@ class RemoteIndexCacheTest {
verifyFetchIndexInvocation(count
iit2009060 commented on code in PR #14482:
URL: https://github.com/apache/kafka/pull/14482#discussion_r1345392660
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -541,6 +541,126 @@ class RemoteIndexCacheTest {
verifyFetchIndexInvocation(count
raboof closed pull request #14474: KAFKA-14593: fix gradle build
URL: https://github.com/apache/kafka/pull/14474
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
raboof commented on PR #14474:
URL: https://github.com/apache/kafka/pull/14474#issuecomment-1746368814
This fix was also in #14475 which has been merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
divijvaidya commented on code in PR #14482:
URL: https://github.com/apache/kafka/pull/14482#discussion_r1345355926
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -541,6 +541,126 @@ class RemoteIndexCacheTest {
divijvaidya commented on code in PR #14480:
URL: https://github.com/apache/kafka/pull/14480#discussion_r1345351170
##
docs/ops.html:
##
@@ -1789,6 +1789,16 @@
divijvaidya commented on PR #14480:
URL: https://github.com/apache/kafka/pull/14480#issuecomment-1746315640
> If we don't already report the AddPartitionsToTxn request metrics in this
file, it doesn't make sense to add the verification variant. (As well as all
the other APIs we report)
soarez commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1345336375
##
generator/src/main/java/org/apache/kafka/message/FieldSpec.java:
##
@@ -157,11 +157,6 @@ private void checkTagInvariants() {
this.taggedVersions
ijuma commented on code in PR #14470:
URL: https://github.com/apache/kafka/pull/14470#discussion_r1345296313
##
core/src/main/scala/kafka/raft/KafkaMetadataLog.scala:
##
@@ -96,10 +96,10 @@ final class KafkaMetadataLog private (
}
private def
ijuma commented on code in PR #14470:
URL: https://github.com/apache/kafka/pull/14470#discussion_r1345292439
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -768,10 +768,10 @@ class UnifiedLog(@volatile var logStartOffset: Long,
// This will ensure that any log
[
https://issues.apache.org/jira/browse/KAFKA-15169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771713#comment-17771713
]
Arpit Goyal commented on KAFKA-15169:
-
[~divijvaidya] [~satish.duggana] [~showuon] Added few test
201 - 252 of 252 matches
Mail list logo
