Re: [PR] KAFKA-15481: Fix concurrency bug in RemoteIndexCache [kafka]

2023-10-13 Thread via GitHub
iit2009060 commented on code in PR #14483: URL: https://github.com/apache/kafka/pull/14483#discussion_r1348641063 ## core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala: ## @@ -568,27 +621,26 @@ class RemoteIndexCacheTest { } private def

Re: [PR] KAFKA-15481: Fix concurrency bug in RemoteIndexCache [kafka]

2023-10-13 Thread via GitHub
showuon commented on PR #14483: URL: https://github.com/apache/kafka/pull/14483#issuecomment-1762593153 @jeel2420 , there's a test failed due to this change, please take a look. https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-14483/10/ -- This is an automated message from

Re: [PR] KAFKA-15303: Avoid unnecessary re-serialization in FK-join [kafka]

2023-10-13 Thread via GitHub
guozhangwang commented on PR #14157: URL: https://github.com/apache/kafka/pull/14157#issuecomment-1762506459 > @guozhangwang -- yes, still looking for input on this. Don't need a full review, just some input if we think it's the right approach to begin with (cf Sophie's justified comment,

Re: [PR] MINOR: cleanup some compiler warnings in Kafka Streams examples [kafka]

2023-10-13 Thread via GitHub
mjsax merged PR #14547: URL: https://github.com/apache/kafka/pull/14547 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] MINOR: Only commit running active and standby tasks when tasks corrupted [kafka]

2023-10-13 Thread via GitHub
guozhangwang commented on code in PR #14508: URL: https://github.com/apache/kafka/pull/14508#discussion_r1359038910 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -223,10 +223,7 @@ boolean handleCorruption(final Set corruptedTasks)

Re: [PR] KAFKA-14519; [1/N] Implement coordinator runtime metrics [kafka]

2023-10-13 Thread via GitHub
jeffkbkim commented on PR #14417: URL: https://github.com/apache/kafka/pull/14417#issuecomment-1762463861 @jolshan should we still keep them as sensors or do we want to remove them? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] KAFKA-15605 Handle pending topic deletions during migration [kafka]

2023-10-13 Thread via GitHub
cmccabe commented on PR #14545: URL: https://github.com/apache/kafka/pull/14545#issuecomment-1762432231 Hmm, this isn’t how we agreed to handle this. We were going to get rid of deleting state in hybrid brokers as I recall. Then we were going to actually verify that broker topic IDs

[PR] MINOR: cleanup some warning in Kafka Streams examples [kafka]

2023-10-13 Thread via GitHub
mjsax opened a new pull request, #14547: URL: https://github.com/apache/kafka/pull/14547 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing

Re: [PR] KAFKA-14274 [6, 7]: Introduction of fetch request manager [kafka]

2023-10-13 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1358990797 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchBuffer.java: ## @@ -66,31 +82,107 @@ boolean isEmpty() { * @return {@code true} if

Re: [PR] KAFKA-14274 [6, 7]: Introduction of fetch request manager [kafka]

2023-10-13 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1358990617 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java: ## @@ -621,56 +825,163 @@ public void assign(Collection partitions)

Re: [PR] KAFKA-14274 [6, 7]: Introduction of fetch request manager [kafka]

2023-10-13 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1358990537 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java: ## @@ -621,56 +825,163 @@ public void assign(Collection partitions)

Re: [PR] KAFKA-14274 [6, 7]: Introduction of fetch request manager [kafka]

2023-10-13 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1358990414 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java: ## @@ -17,146 +17,195 @@ package

Re: [PR] KAFKA-14274 [6, 7]: Introduction of fetch request manager [kafka]

2023-10-13 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1358957417 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetchRequestManagerTest.java: ## @@ -0,0 +1,3573 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-14274 [6, 7]: Introduction of fetch request manager [kafka]

2023-10-13 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1358956804 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetchRequestManagerTest.java: ## @@ -0,0 +1,3573 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-14274 [6, 7]: Introduction of fetch request manager [kafka]

2023-10-13 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1358956462 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetchRequestManagerTest.java: ## @@ -0,0 +1,3573 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-14274 [6, 7]: Introduction of fetch request manager [kafka]

2023-10-13 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1358956176 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetchRequestManagerTest.java: ## @@ -0,0 +1,3573 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-14274 [6, 7]: Introduction of fetch request manager [kafka]

2023-10-13 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1358955393 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetchRequestManagerTest.java: ## @@ -0,0 +1,3573 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-14274 [6, 7]: Introduction of fetch request manager [kafka]

2023-10-13 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1358954499 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetchRequestManagerTest.java: ## @@ -0,0 +1,3573 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-14274 [6, 7]: Introduction of fetch request manager [kafka]

2023-10-13 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1358953536 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetchRequestManagerTest.java: ## @@ -0,0 +1,3573 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-14274 [6, 7]: Introduction of fetch request manager [kafka]

2023-10-13 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1358953131 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetchRequestManagerTest.java: ## @@ -0,0 +1,3573 @@ +/* + * Licensed to the Apache Software

[jira] [Updated] (KAFKA-15606) Verify & refactor correctness of FetcherTest.testCompletedFetchRemoval()

2023-10-13 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15606: -- Description: As part of the review for [FetchRequestManager pull

Re: [PR] KAFKA-14274 [6, 7]: Introduction of fetch request manager [kafka]

2023-10-13 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1358953070 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetchRequestManagerTest.java: ## @@ -0,0 +1,3573 @@ +/* + * Licensed to the Apache Software

[jira] [Updated] (KAFKA-15606) Verify & refactor correctness of FetcherTest.testCompletedFetchRemoval()

2023-10-13 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15606: -- Description: As part of the review for [pull request

[jira] [Updated] (KAFKA-15606) Verify & refactor correctness of FetcherTest.testCompletedFetchRemoval()

2023-10-13 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15606: -- Description: As part of the review for [pull request

[jira] [Updated] (KAFKA-15606) Verify & refactor correctness of FetcherTest.testCompletedFetchRemoval()

2023-10-13 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15606: -- Description: As part of the review for [pull request

[jira] [Updated] (KAFKA-15606) Verify & refactor correctness of FetcherTest.testCompletedFetchRemoval()

2023-10-13 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15606: -- Description: As part of the review for [pull request

[jira] [Updated] (KAFKA-15606) Verify & refactor correctness of FetcherTest.testCompletedFetchRemoval()

2023-10-13 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15606: -- Description: As part of the review for [pull request

Re: [PR] MINOR: Zk to KRaft migration is now production ready [kafka]

2023-10-13 Thread via GitHub
ocadaruma commented on code in PR #14546: URL: https://github.com/apache/kafka/pull/14546#discussion_r1358951019 ## docs/ops.html: ## @@ -3736,7 +3736,7 @@ ZooKeeper to KRaft Migration -ZooKeeper to KRaft migration is considered an Early Access feature and is not

[jira] [Created] (KAFKA-15606) Verify & refactor correctness of FetcherTest.testCompletedFetchRemoval()

2023-10-13 Thread Kirk True (Jira)
Kirk True created KAFKA-15606: - Summary: Verify & refactor correctness of FetcherTest.testCompletedFetchRemoval() Key: KAFKA-15606 URL: https://issues.apache.org/jira/browse/KAFKA-15606 Project: Kafka

[PR] MINOR: Zk to KRaft migration is now production ready [kafka]

2023-10-13 Thread via GitHub
ocadaruma opened a new pull request, #14546: URL: https://github.com/apache/kafka/pull/14546 - As of 3.6.0, ZK to KRaft migration is considered production ready so updating the doc * https://kafka.apache.org/blog#apache_kafka_360_release_announcement ### Committer Checklist

Re: [PR] KAFKA-14274 [6, 7]: Introduction of fetch request manager [kafka]

2023-10-13 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1358949767 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetchRequestManagerTest.java: ## @@ -0,0 +1,3573 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (KAFKA-15602) Breaking change in 3.4.0 ByteBufferSerializer

2023-10-13 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17775087#comment-17775087 ] Philip Nee commented on KAFKA-15602: Hi Luke, i think we need to do two things here. One is probably

Re: [PR] KAFKA-14274 [6, 7]: Introduction of fetch request manager [kafka]

2023-10-13 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1358918492 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetchRequestManagerTest.java: ## @@ -0,0 +1,3573 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-14274 [6, 7]: Introduction of fetch request manager [kafka]

2023-10-13 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1358914547 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetchRequestManagerTest.java: ## @@ -0,0 +1,3573 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-14274 [6, 7]: Introduction of fetch request manager [kafka]

2023-10-13 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1358914146 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetchRequestManagerTest.java: ## @@ -0,0 +1,3573 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (KAFKA-15208) Upgrade Jackson dependencies to version 2.15.3

2023-10-13 Thread Said BOUDJELDA (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17775070#comment-17775070 ] Said BOUDJELDA commented on KAFKA-15208: This JIRA is updated to mention an upgrade to version

[jira] [Updated] (KAFKA-15208) Upgrade Jackson dependencies to version 2.15.3

2023-10-13 Thread Said BOUDJELDA (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Said BOUDJELDA updated KAFKA-15208: --- Description: Upgrading the version of Jackson dependencies to the latest stable version

[jira] [Updated] (KAFKA-15208) Upgrade Jackson dependencies to version 2.15.3

2023-10-13 Thread Said BOUDJELDA (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Said BOUDJELDA updated KAFKA-15208: --- Summary: Upgrade Jackson dependencies to version 2.15.3 (was: Upgrade Jackson dependencies

Re: [PR] KAFKA-15208: Upgrade Jackson dependencies to version 2.15.3 [kafka]

2023-10-13 Thread via GitHub
bmscomp commented on PR #13662: URL: https://github.com/apache/kafka/pull/13662#issuecomment-1762253746 The pull request is updated to take advantages of version 2.15.3 of `jackson databind ` that aims to fix much more issues and bring more enhancements, as we can mention :

[jira] [Commented] (KAFKA-15602) Breaking change in 3.4.0 ByteBufferSerializer

2023-10-13 Thread Luke Kirby (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17775069#comment-17775069 ] Luke Kirby commented on KAFKA-15602: {quote}The original intent of the PR was to make the serializer

[jira] [Commented] (KAFKA-15602) Breaking change in 3.4.0 ByteBufferSerializer

2023-10-13 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17775065#comment-17775065 ] Philip Nee commented on KAFKA-15602: The original intent of the PR was to make the serializer

Re: [PR] KIP-951: Server side and protocol changes for KIP-951 [kafka]

2023-10-13 Thread via GitHub
splett2 commented on code in PR #1: URL: https://github.com/apache/kafka/pull/1#discussion_r1358837845 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -620,6 +642,21 @@ class KafkaApis(val requestChannel: RequestChannel, topicPartition,

Re: [PR] KIP-951: Server side and protocol changes for KIP-951 [kafka]

2023-10-13 Thread via GitHub
splett2 commented on code in PR #1: URL: https://github.com/apache/kafka/pull/1#discussion_r1358837039 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -559,6 +560,26 @@ class KafkaApis(val requestChannel: RequestChannel, } } + case class

Re: [PR] KIP-951: Server side and protocol changes for KIP-951 [kafka]

2023-10-13 Thread via GitHub
chb2ab commented on code in PR #1: URL: https://github.com/apache/kafka/pull/1#discussion_r1358826931 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -620,6 +642,21 @@ class KafkaApis(val requestChannel: RequestChannel, topicPartition,

Re: [PR] KIP-951: Server side and protocol changes for KIP-951 [kafka]

2023-10-13 Thread via GitHub
jolshan commented on code in PR #1: URL: https://github.com/apache/kafka/pull/1#discussion_r1358796082 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -620,6 +642,21 @@ class KafkaApis(val requestChannel: RequestChannel, topicPartition,

Re: [PR] KAFKA-15582: Identify clean shutdown broker [kafka]

2023-10-13 Thread via GitHub
junrao commented on code in PR #14465: URL: https://github.com/apache/kafka/pull/14465#discussion_r1358649732 ## core/src/main/scala/kafka/log/CleanShutdownFileHandler.scala: ## @@ -0,0 +1,113 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] KAFKA-14274 [6, 7]: Introduction of fetch request manager [kafka]

2023-10-13 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1358791361 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetchRequestManagerTest.java: ## @@ -0,0 +1,3573 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-14405: Log a warning when users attempt to set a config controlled by Streams [kafka]

2023-10-13 Thread via GitHub
ashmeet13 commented on PR #12988: URL: https://github.com/apache/kafka/pull/12988#issuecomment-1762139883 Got it! I'll make this change - for now I have gone through the code and the following two references and compiled a list of configs that are somehow "controlled" by KS. For now

Re: [PR] KIP-951: Server side and protocol changes for KIP-951 [kafka]

2023-10-13 Thread via GitHub
chb2ab commented on code in PR #1: URL: https://github.com/apache/kafka/pull/1#discussion_r1358773873 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -620,6 +642,21 @@ class KafkaApis(val requestChannel: RequestChannel, topicPartition,

Re: [PR] KIP-951: Server side and protocol changes for KIP-951 [kafka]

2023-10-13 Thread via GitHub
chb2ab commented on code in PR #1: URL: https://github.com/apache/kafka/pull/1#discussion_r1358773301 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -559,6 +560,26 @@ class KafkaApis(val requestChannel: RequestChannel, } } + case class

Re: [PR] KAFKA-15452: Access SslPrincipalMapper and kerberosShortNamer in Custom KafkaPrincipalBuilder(KIP-982) [kafka]

2023-10-13 Thread via GitHub
rbaddam commented on PR #14491: URL: https://github.com/apache/kafka/pull/14491#issuecomment-1762132178 Thank you @omkreddy for the review and feedback. I have updated the

Re: [PR] KAFKA-14274 [6, 7]: Introduction of fetch request manager [kafka]

2023-10-13 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1358764452 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetchRequestManagerTest.java: ## @@ -0,0 +1,3573 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-14274 [6, 7]: Introduction of fetch request manager [kafka]

2023-10-13 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1358761112 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetchRequestManagerTest.java: ## @@ -0,0 +1,3573 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-14274 [6, 7]: Introduction of fetch request manager [kafka]

2023-10-13 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1358758478 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java: ## @@ -1107,7 +1107,7 @@ public void testFetchMaxPollRecords() {

[PR] KAFKA-15605 Handle pending topic deletions during migration [kafka]

2023-10-13 Thread via GitHub
mumrah opened a new pull request, #14545: URL: https://github.com/apache/kafka/pull/14545 After migrating metadata to KRaft, we need to finalize the pending topic deletions. Since the brokers need the StopReplica request in order to clean up their log directories, we can't simply exclude

[jira] [Commented] (KAFKA-15602) Breaking change in 3.4.0 ByteBufferSerializer

2023-10-13 Thread Luke Kirby (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17775037#comment-17775037 ] Luke Kirby commented on KAFKA-15602: {quote}The original documentation mentioned the user "{_}Do not

[jira] [Updated] (KAFKA-15605) Topics marked for deletion in ZK are incorrectly migrated to KRaft

2023-10-13 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-15605: - Summary: Topics marked for deletion in ZK are incorrectly migrated to KRaft (was: Topic marked

[jira] [Updated] (KAFKA-15605) Topics marked for deletion in ZK are incorrectly migrated to KRaft

2023-10-13 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-15605: - Description: When migrating topics from ZooKeeper, the KRaft controller reads all the topic

[jira] [Updated] (KAFKA-15605) Topics marked for deletion in ZK are incorrectly migrated to KRaft

2023-10-13 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-15605: - Description: When migrating topics from ZooKeeper, the KRaft controller reads all the topic

[jira] [Updated] (KAFKA-15605) Topics marked for deletion in ZK are incorrectly migrated to KRaft

2023-10-13 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-15605: - Description: When migrating topics from ZooKeeper, the KRaft controller reads all the topic

[jira] [Created] (KAFKA-15605) Topic marked for deletion are incorrectly migrated to KRaft

2023-10-13 Thread David Arthur (Jira)
David Arthur created KAFKA-15605: Summary: Topic marked for deletion are incorrectly migrated to KRaft Key: KAFKA-15605 URL: https://issues.apache.org/jira/browse/KAFKA-15605 Project: Kafka

[jira] [Commented] (KAFKA-15552) Duplicate Producer ID blocks during ZK migration

2023-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17775034#comment-17775034 ] ASF GitHub Bot commented on KAFKA-15552: ijuma commented on code in PR #560: URL:

Re: [PR] KAFKA-14274 [6, 7]: Introduction of fetch request manager [kafka]

2023-10-13 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1358717315 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetchRequestManagerTest.java: ## @@ -0,0 +1,3573 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-14274 [6, 7]: Introduction of fetch request manager [kafka]

2023-10-13 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1358713529 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetchRequestManagerTest.java: ## @@ -0,0 +1,3573 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-14274 [6, 7]: Introduction of fetch request manager [kafka]

2023-10-13 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1358712167 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetchRequestManagerTest.java: ## @@ -0,0 +1,3573 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (KAFKA-15552) Duplicate Producer ID blocks during ZK migration

2023-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17775032#comment-17775032 ] ASF GitHub Bot commented on KAFKA-15552: jolshan commented on code in PR #560: URL:

[jira] [Commented] (KAFKA-15552) Duplicate Producer ID blocks during ZK migration

2023-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17775029#comment-17775029 ] ASF GitHub Bot commented on KAFKA-15552: mumrah opened a new pull request, #560: URL:

Re: [PR] KAFKA-14274 [6, 7]: Introduction of fetch request manager [kafka]

2023-10-13 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1358701620 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetchRequestManagerTest.java: ## @@ -0,0 +1,3573 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-14274 [6, 7]: Introduction of fetch request manager [kafka]

2023-10-13 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1358693714 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetchRequestManagerTest.java: ## @@ -0,0 +1,3573 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-15452: Access SslPrincipalMapper and kerberosShortNamer in Custom KafkaPrincipalBuilder(KIP-982) [kafka]

2023-10-13 Thread via GitHub
omkreddy commented on PR #14491: URL: https://github.com/apache/kafka/pull/14491#issuecomment-1762024387 @rbaddam Thanks for the PR. Can you please update the KIP with newly added interfaces also. I will review the PR once KIP passes. -- This is an automated message from the Apache Git

Re: [PR] KAFKA-14481: Move LogSegment/LogSegments to storage module [kafka]

2023-10-13 Thread via GitHub
ijuma commented on PR #14529: URL: https://github.com/apache/kafka/pull/14529#issuecomment-1762008506 > @ijuma Thanks for the PR. I will review it tomorrow. Thanks @satishd. I won't merge until Tuesday to give you a chance to review. -- This is an automated message from the Apache

Re: [PR] KAFKA-14274 [6, 7]: Introduction of fetch request manager [kafka]

2023-10-13 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1358682245 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetchRequestManagerTest.java: ## @@ -0,0 +1,3573 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-14481: Move LogSegment/LogSegments to storage module [kafka]

2023-10-13 Thread via GitHub
ijuma commented on code in PR #14529: URL: https://github.com/apache/kafka/pull/14529#discussion_r135839 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogSegment.java: ## @@ -0,0 +1,873 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] KAFKA-14274 [6, 7]: Introduction of fetch request manager [kafka]

2023-10-13 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1358665833 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetchRequestManagerTest.java: ## @@ -0,0 +1,3573 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-14481: Move LogSegment/LogSegments to storage module [kafka]

2023-10-13 Thread via GitHub
ijuma commented on PR #14529: URL: https://github.com/apache/kafka/pull/14529#issuecomment-1761985192 > Thank you for patiently answering my comments Thanks for the review and for paying close attention to code quality (modularity, readability, etc.) - it's an important area! --

Re: [PR] KAFKA-14274 [6, 7]: Introduction of fetch request manager [kafka]

2023-10-13 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1358658187 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetchRequestManagerTest.java: ## @@ -0,0 +1,3573 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-15534: Inject request completion time when the request failed [kafka]

2023-10-13 Thread via GitHub
philipnee commented on PR #14532: URL: https://github.com/apache/kafka/pull/14532#issuecomment-1761979623 Hi @cadonna - Thank you for putting time into this PR, very much appreciated. I responded to some of your questions, let me know if there is still any ambiguity left. -- This is an

Re: [PR] KAFKA-15534: Inject request completion time when the request failed [kafka]

2023-10-13 Thread via GitHub
philipnee commented on code in PR #14532: URL: https://github.com/apache/kafka/pull/14532#discussion_r1358656536 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -184,13 +184,11 @@ private

Re: [PR] KAFKA-14767: Fix missing commitId build error after git gc [kafka]

2023-10-13 Thread via GitHub
ijuma commented on PR #13315: URL: https://github.com/apache/kafka/pull/13315#issuecomment-1761974609 Well, Jenkins failed - we need to firs that first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] KAFKA-14274 [6, 7]: Introduction of fetch request manager [kafka]

2023-10-13 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1358651225 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetchRequestManagerTest.java: ## @@ -0,0 +1,3573 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-15534: Inject request completion time when the request failed [kafka]

2023-10-13 Thread via GitHub
philipnee commented on code in PR #14532: URL: https://github.com/apache/kafka/pull/14532#discussion_r1358640330 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/NetworkClientDelegate.java: ## @@ -254,28 +250,38 @@ public String toString() { }

Re: [PR] KAFKA-15534: Inject request completion time when the request failed [kafka]

2023-10-13 Thread via GitHub
philipnee commented on code in PR #14532: URL: https://github.com/apache/kafka/pull/14532#discussion_r1358637014 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -290,7 +290,6 @@ private void onFailure(final long

Re: [PR] KAFKA-14767: Fix missing commitId build error after git gc [kafka]

2023-10-13 Thread via GitHub
gharris1727 commented on PR #13315: URL: https://github.com/apache/kafka/pull/13315#issuecomment-1761944410 Hey @ijuma @divijvaidya @C0urante or @yashmayya Could you review this build improvement? I'm still getting this `git gc` failure regularly when I try to build branches that

[jira] [Comment Edited] (KAFKA-15602) Breaking change in 3.4.0 ByteBufferSerializer

2023-10-13 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17774807#comment-17774807 ] Philip Nee edited comment on KAFKA-15602 at 10/13/23 5:43 PM: -- Hi

Re: [PR] MINOR: Debug EmbeddedConnect/KafkaCluster failures [kafka]

2023-10-13 Thread via GitHub
gharris1727 closed pull request #13580: MINOR: Debug EmbeddedConnect/KafkaCluster failures URL: https://github.com/apache/kafka/pull/13580 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-15428: Cluster-wide dynamic log adjustments for Connect [kafka]

2023-10-13 Thread via GitHub
gharris1727 commented on code in PR #14538: URL: https://github.com/apache/kafka/pull/14538#discussion_r1358597074 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Loggers.java: ## @@ -0,0 +1,213 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-14481: Move LogSegment/LogSegments to storage module [kafka]

2023-10-13 Thread via GitHub
ijuma commented on code in PR #14529: URL: https://github.com/apache/kafka/pull/14529#discussion_r1358592259 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogSegment.java: ## @@ -0,0 +1,873 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] KAFKA-14481: Move LogSegment/LogSegments to storage module [kafka]

2023-10-13 Thread via GitHub
ijuma commented on code in PR #14529: URL: https://github.com/apache/kafka/pull/14529#discussion_r1358592259 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogSegment.java: ## @@ -0,0 +1,873 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] KAFKA-14481: Move LogSegment/LogSegments to storage module [kafka]

2023-10-13 Thread via GitHub
divijvaidya commented on code in PR #14529: URL: https://github.com/apache/kafka/pull/14529#discussion_r1358569570 ## clients/src/main/java/org/apache/kafka/common/record/AbstractRecords.java: ## @@ -44,6 +45,17 @@ public RecordBatch firstBatch() { return

Re: [PR] KAFKA-14481: Move LogSegment/LogSegments to storage module [kafka]

2023-10-13 Thread via GitHub
divijvaidya commented on code in PR #14529: URL: https://github.com/apache/kafka/pull/14529#discussion_r1358566629 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogSegment.java: ## @@ -0,0 +1,873 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] KAFKA-15452: Access SslPrincipalMapper and kerberosShortNamer in Custom KafkaPrincipalBuilder(KIP-982) [kafka]

2023-10-13 Thread via GitHub
rbaddam commented on PR #14491: URL: https://github.com/apache/kafka/pull/14491#issuecomment-1761825493 Also we have implemented the SPIFFE Integration in our echo system and [these changes](https://github.com/apache/kafka/pull/14491) will help to make the Spiffe Integration smooth.

[jira] [Assigned] (KAFKA-15604) Add Telemetry RPCs Definitions

2023-10-13 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal reassigned KAFKA-15604: - Assignee: Apoorv Mittal > Add Telemetry RPCs Definitions >

[jira] [Assigned] (KAFKA-15601) Client metrics and observability

2023-10-13 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal reassigned KAFKA-15601: - Assignee: Apoorv Mittal > Client metrics and observability >

[jira] [Commented] (KAFKA-14482) Move LogLoader to storage module

2023-10-13 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17774988#comment-17774988 ] Ismael Juma commented on KAFKA-14482: - No worries, thanks for the quick response. :) > Move

[jira] [Assigned] (KAFKA-14482) Move LogLoader to storage module

2023-10-13 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma reassigned KAFKA-14482: --- Assignee: Ismael Juma > Move LogLoader to storage module >

[jira] [Updated] (KAFKA-14482) Move LogLoader to storage module

2023-10-13 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-14482: Fix Version/s: 3.7.0 > Move LogLoader to storage module > > >

Re: [PR] KAFKA-15338: The metric group documentation for metrics added in KAFK… [kafka]

2023-10-13 Thread via GitHub
mjsax commented on PR #14221: URL: https://github.com/apache/kafka/pull/14221#issuecomment-1761809518 No problem :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] KAFKA-14481: Move LogSegment/LogSegments to storage module [kafka]

2023-10-13 Thread via GitHub
ijuma commented on code in PR #14529: URL: https://github.com/apache/kafka/pull/14529#discussion_r1358306908 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogSegment.java: ## @@ -0,0 +1,887 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[jira] [Created] (KAFKA-15604) Add Telemetry RPCs Definitions

2023-10-13 Thread Apoorv Mittal (Jira)
Apoorv Mittal created KAFKA-15604: - Summary: Add Telemetry RPCs Definitions Key: KAFKA-15604 URL: https://issues.apache.org/jira/browse/KAFKA-15604 Project: Kafka Issue Type: Sub-task

Re: [PR] KIP-951: Server side and protocol changes for KIP-951 [kafka]

2023-10-13 Thread via GitHub
splett2 commented on code in PR #1: URL: https://github.com/apache/kafka/pull/1#discussion_r1358490055 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -559,6 +560,26 @@ class KafkaApis(val requestChannel: RequestChannel, } } + case class

  1   2   >