github-actions[bot] commented on PR #13321:
URL: https://github.com/apache/kafka/pull/13321#issuecomment-1773983472
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has merge
laglangyue opened a new pull request, #14606:
URL: https://github.com/apache/kafka/pull/14606
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
jira link
https:/
laglangyue commented on PR #14606:
URL: https://github.com/apache/kafka/pull/14606#issuecomment-1773973076
when I remove the method tryConnect, I find the networkClientDelegate is
not used in the OffsetsRequestManager, should I remove this?
--
This is an automated message from the Apache
s7pandey opened a new pull request, #14605:
URL: https://github.com/apache/kafka/pull/14605
This change is to introduce the MockFixedKeyProcessorContext, which extends
the existing `MockProcessorContext`, and is essential when trying to test a
`FixedKeyProcessor` in Unit Tests
Testin
CalvinConfluent opened a new pull request, #14604:
URL: https://github.com/apache/kafka/pull/14604
When completing the partition reassignment, the new ISR should be equal or
larger than the min ISR.
https://issues.apache.org/jira/browse/KAFKA-15665
--
This is an automated message f
Calvin Liu created KAFKA-15665:
--
Summary: Enforce min ISR when complete partition reassignment
Key: KAFKA-15665
URL: https://issues.apache.org/jira/browse/KAFKA-15665
Project: Kafka
Issue Type:
ijuma commented on code in PR #14517:
URL: https://github.com/apache/kafka/pull/14517#discussion_r1367770308
##
clients/src/main/java/org/apache/kafka/common/Uuid.java:
##
@@ -49,21 +49,21 @@ public class Uuid implements Comparable {
/**
* A UUID that is used to ident
soarez commented on code in PR #14578:
URL: https://github.com/apache/kafka/pull/14578#discussion_r1367768321
##
core/src/main/scala/kafka/server/BrokerMetadataCheckpoint.scala:
##
@@ -166,6 +166,7 @@ case class MetaProperties(
}
}
+// Return only the RawMetaProperties tha
soarez commented on code in PR #14517:
URL: https://github.com/apache/kafka/pull/14517#discussion_r1367768065
##
clients/src/main/java/org/apache/kafka/common/Uuid.java:
##
@@ -49,21 +49,21 @@ public class Uuid implements Comparable {
/**
* A UUID that is used to iden
CalvinConfluent opened a new pull request, #14603:
URL: https://github.com/apache/kafka/pull/14603
A follow-up change to move the clean shutdown file to the storage package.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
[
https://issues.apache.org/jira/browse/KAFKA-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17778085#comment-17778085
]
tangjiafu commented on KAFKA-15556:
---
I am a novice, and this issue seems to involve ch
showuon commented on PR #14576:
URL: https://github.com/apache/kafka/pull/14576#issuecomment-1773778684
Will take a look next week. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
ijuma commented on PR #13451:
URL: https://github.com/apache/kafka/pull/13451#issuecomment-1773778556
@junrao do you have cycles to review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
ijuma commented on code in PR #14597:
URL: https://github.com/apache/kafka/pull/14597#discussion_r1367722984
##
clients/src/main/java/org/apache/kafka/common/security/auth/KafkaPrincipal.java:
##
@@ -68,9 +73,15 @@ public boolean equals(Object o) {
if (this == o) return
ijuma commented on PR #14597:
URL: https://github.com/apache/kafka/pull/14597#issuecomment-1773777853
Thanks for the PR. There are a number of changes in this PR - which ones
actually made a difference to the numbers? Some of them are a bit questionable.
--
This is an automated message fr
ijuma commented on code in PR #14410:
URL: https://github.com/apache/kafka/pull/14410#discussion_r1367722599
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamsProducerTest.java:
##
@@ -197,8 +203,7 @@ public void before() {
);
eos
mimaison closed pull request #13860: KAFKA-15093: Add 3.4 and 3.5 Streams
upgrade system tests
URL: https://github.com/apache/kafka/pull/13860
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
mimaison commented on PR #13860:
URL: https://github.com/apache/kafka/pull/13860#issuecomment-1773771925
@mjsax Good call, I've split this PR in 2:
- 3.4: https://github.com/apache/kafka/pull/14601
- 3.5: https://github.com/apache/kafka/pull/14602
Closing this PR
--
This is an
mimaison opened a new pull request, #14602:
URL: https://github.com/apache/kafka/pull/14602
Extracted the 3.5 changes from https://github.com/apache/kafka/pull/13860
Only merge this PR after https://github.com/apache/kafka/pull/14601 is merged
### Committer Checklist (excluded f
mimaison opened a new pull request, #14601:
URL: https://github.com/apache/kafka/pull/14601
Extracted the 3.4 changes from https://github.com/apache/kafka/pull/13860
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test c
Mickael Maison created KAFKA-15664:
--
Summary: Add 3.4.0 streams upgrade/compatibility tests
Key: KAFKA-15664
URL: https://issues.apache.org/jira/browse/KAFKA-15664
Project: Kafka
Issue Type:
kamalcph commented on code in PR #14576:
URL: https://github.com/apache/kafka/pull/14576#discussion_r1367695583
##
storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataCacheTest.java:
##
@@ -26,83 +26,136 @@
import
org.apache.kafka.server.
kamalcph commented on PR #14576:
URL: https://github.com/apache/kafka/pull/14576#issuecomment-1773728659
> For my understanding. Previously whenever we encountered an invalid
transition the consumer threw and exception and exited. This did not resolve
itself upon broker restart. What you wa
[
https://issues.apache.org/jira/browse/KAFKA-15660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17778040#comment-17778040
]
Kamal Chandraprakash commented on KAFKA-15660:
--
In RemoteStorageManager, we
24 matches
Mail list logo
