[jira] [Commented] (KAFKA-15792) Kafka Streams stuck partition fixed after restarting the process

2023-11-05 Thread Patrick Pang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783114#comment-17783114 ] Patrick Pang commented on KAFKA-15792: -- Can it be related to

[jira] [Updated] (KAFKA-15792) Kafka Streams stuck partition fixed after restarting the process

2023-11-05 Thread Patrick Pang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Pang updated KAFKA-15792: - Description: Our Kafka Streams process often show slow in processing a particular partition on

[jira] [Resolved] (KAFKA-14515) Implement optimized uniform broker side assignor

2023-11-05 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-14515. - Fix Version/s: 3.7.0 Reviewer: David Jacot Resolution: Fixed > Implement

Re: [PR] KAFKA 14515: Optimized Uniform Rack Aware Assignor [kafka]

2023-11-05 Thread via GitHub
dajac merged PR #14416: URL: https://github.com/apache/kafka/pull/14416 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (KAFKA-15792) Kafka Streams stuck partition fixed after restarting the process

2023-11-05 Thread Patrick Pang (Jira)
Patrick Pang created KAFKA-15792: Summary: Kafka Streams stuck partition fixed after restarting the process Key: KAFKA-15792 URL: https://issues.apache.org/jira/browse/KAFKA-15792 Project: Kafka

Re: [PR] KAFKA-15574; [1/N]: Client state machine updates [kafka]

2023-11-05 Thread via GitHub
lianetm commented on code in PR #14690: URL: https://github.com/apache/kafka/pull/14690#discussion_r1382772899 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MemberState.java: ## @@ -48,26 +61,50 @@ public enum MemberState { * {@link

[PR] MINOR: edit enableCleaner description [kafka]

2023-11-05 Thread via GitHub
laststem opened a new pull request, #14703: URL: https://github.com/apache/kafka/pull/14703 Edit the description of enableCleaner to clarify -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-15170: CooperativeStickyAssignor may fail adjust assignment [kafka]

2023-11-05 Thread via GitHub
github-actions[bot] commented on PR #13965: URL: https://github.com/apache/kafka/pull/13965#issuecomment-1794032521 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

Re: [PR] KAFKA-15094: RemoteIndexCache stats [kafka]

2023-11-05 Thread via GitHub
github-actions[bot] commented on PR #14073: URL: https://github.com/apache/kafka/pull/14073#issuecomment-1794032472 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

Re: [PR] KAFKA-15266: Static configs set for non primary synonyms are ignored for Log configs [kafka]

2023-11-05 Thread via GitHub
github-actions[bot] commented on PR #14119: URL: https://github.com/apache/kafka/pull/14119#issuecomment-1794032454 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

Re: [PR] KAFKA-15574; [1/N]: Client state machine updates [kafka]

2023-11-05 Thread via GitHub
lianetm commented on code in PR #14690: URL: https://github.com/apache/kafka/pull/14690#discussion_r1382742662 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MemberState.java: ## @@ -24,21 +24,34 @@ public enum MemberState { /** - * Member has

Re: [PR] KAFKA-15574; [1/N]: Client state machine updates [kafka]

2023-11-05 Thread via GitHub
lianetm commented on code in PR #14690: URL: https://github.com/apache/kafka/pull/14690#discussion_r1382728096 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -172,10 +223,14 @@ private NetworkClientDelegate.UnsentRequest

Re: [PR] KAFKA-15451: Send offline dirs in broker heartbeat [kafka]

2023-11-05 Thread via GitHub
pprovenzano commented on code in PR #14368: URL: https://github.com/apache/kafka/pull/14368#discussion_r1382727792 ## core/src/main/scala/kafka/server/BrokerLifecycleManager.scala: ## @@ -410,6 +444,7 @@ class BrokerLifecycleManager( val errorCode =

Re: [PR] KAFKA-15574; [1/N]: Client state machine updates [kafka]

2023-11-05 Thread via GitHub
lianetm commented on code in PR #14690: URL: https://github.com/apache/kafka/pull/14690#discussion_r1382724053 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MemberState.java: ## @@ -48,26 +61,50 @@ public enum MemberState { * {@link

Re: [PR] KAFKA-15771: fix ProduceRequest#partitionSizes() to make it an atomic operation [kafka]

2023-11-05 Thread via GitHub
fxbing commented on PR #14674: URL: https://github.com/apache/kafka/pull/14674#issuecomment-1793977252 @vamossagar12 @hudeqi Can this PR be merged? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] KAFKA-15574; [1/N]: Client state machine updates [kafka]

2023-11-05 Thread via GitHub
philipnee commented on PR #14690: URL: https://github.com/apache/kafka/pull/14690#issuecomment-1793892733 @AndrewJSchofield - Thanks, I think that's what I have in mind as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] KAFKA-15574; [1/N]: Client state machine updates [kafka]

2023-11-05 Thread via GitHub
AndrewJSchofield commented on PR #14690: URL: https://github.com/apache/kafka/pull/14690#issuecomment-1793877944 @philipnee I meant that the code which runs in the `CompletableFuture.whenComplete()` could enqueue an action for the background thread to ensure that the main logic all runs in

Re: [PR] KAFKA-15574; [1/N]: Client state machine updates [kafka]

2023-11-05 Thread via GitHub
lianetm commented on code in PR #14690: URL: https://github.com/apache/kafka/pull/14690#discussion_r1382668541 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -181,33 +256,465 @@ public void

Re: [PR] KAFKA-15574; [1/N]: Client state machine updates [kafka]

2023-11-05 Thread via GitHub
lianetm commented on code in PR #14690: URL: https://github.com/apache/kafka/pull/14690#discussion_r1382667377 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -170,8 +242,11 @@ public void

Re: [PR] KAFKA-15574; [1/N]: Client state machine updates [kafka]

2023-11-05 Thread via GitHub
lianetm commented on code in PR #14690: URL: https://github.com/apache/kafka/pull/14690#discussion_r1382667315 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -77,32 +93,88 @@ public class MembershipManagerImpl implements

Re: [PR] KAFKA-15574; [1/N]: Client state machine updates [kafka]

2023-11-05 Thread via GitHub
lianetm commented on code in PR #14690: URL: https://github.com/apache/kafka/pull/14690#discussion_r1382666792 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -181,33 +242,465 @@ public void

Re: [PR] KAFKA-15574; [1/N]: Client state machine updates [kafka]

2023-11-05 Thread via GitHub
lianetm commented on code in PR #14690: URL: https://github.com/apache/kafka/pull/14690#discussion_r1382666862 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MemberState.java: ## @@ -24,21 +24,34 @@ public enum MemberState { /** - * Member has

Re: [PR] KAFKA-15574; [1/N]: Client state machine updates [kafka]

2023-11-05 Thread via GitHub
lianetm commented on code in PR #14690: URL: https://github.com/apache/kafka/pull/14690#discussion_r138273 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -181,33 +243,461 @@ public void

Re: [PR] KAFKA-15574; [1/N]: Client state machine updates [kafka]

2023-11-05 Thread via GitHub
lianetm commented on code in PR #14690: URL: https://github.com/apache/kafka/pull/14690#discussion_r1382666539 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MemberState.java: ## @@ -48,26 +61,50 @@ public enum MemberState { * {@link

Re: [PR] KAFKA-15574; [1/N]: Client state machine updates [kafka]

2023-11-05 Thread via GitHub
lianetm commented on code in PR #14690: URL: https://github.com/apache/kafka/pull/14690#discussion_r1382666152 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MemberState.java: ## @@ -24,21 +24,34 @@ public enum MemberState { /** - * Member has

Re: [PR] KAFKA-15574; [1/N]: Client state machine updates [kafka]

2023-11-05 Thread via GitHub
lianetm commented on code in PR #14690: URL: https://github.com/apache/kafka/pull/14690#discussion_r1382665763 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MemberState.java: ## @@ -24,21 +24,34 @@ public enum MemberState { /** - * Member has

Re: [PR] KAFKA-14509 [WIP] [2/2] Implement server side logic for ConsumerGroupDescribe API [kafka]

2023-11-05 Thread via GitHub
riedelmax commented on code in PR #14544: URL: https://github.com/apache/kafka/pull/14544#discussion_r1382621146 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupMember.java: ## @@ -545,6 +547,26 @@ public String

Re: [PR] KAFKA-14509 [WIP] [2/2] Implement server side logic for ConsumerGroupDescribe API [kafka]

2023-11-05 Thread via GitHub
riedelmax commented on code in PR #14544: URL: https://github.com/apache/kafka/pull/14544#discussion_r1382617127 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupMember.java: ## @@ -545,6 +547,26 @@ public String

Re: [PR] KAFKA-14509 [WIP] [2/2] Implement server side logic for ConsumerGroupDescribe API [kafka]

2023-11-05 Thread via GitHub
riedelmax commented on code in PR #14544: URL: https://github.com/apache/kafka/pull/14544#discussion_r1382608784 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -444,6 +445,43 @@ public List listGroups(List statesFi

Re: [PR] KAFKA-14509 [WIP] [2/2] Implement server side logic for ConsumerGroupDescribe API [kafka]

2023-11-05 Thread via GitHub
riedelmax commented on code in PR #14544: URL: https://github.com/apache/kafka/pull/14544#discussion_r1382605249 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -6206,12 +6206,40 @@ class KafkaApisTest {

[jira] [Commented] (KAFKA-15748) KRaft support in MetricsDuringTopicCreationDeletionTest

2023-11-05 Thread Zihao Lin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783009#comment-17783009 ] Zihao Lin commented on KAFKA-15748: --- Fixed via [https://github.com/apache/kafka/pull/14295]  > KRaft

Re: [PR] Kafka 12317: Relax non-null key requirement in Kafka Streams [kafka]

2023-11-05 Thread via GitHub
florin-akermann commented on PR #14174: URL: https://github.com/apache/kafka/pull/14174#issuecomment-1793747649 @wcarlson5 thanks for the merge. I think it would be good to tackle https://github.com/apache/kafka/pull/14107 in the same release. -- This is an automated message from the

[jira] [Commented] (KAFKA-15739) KRaft support in ResetConsumerGroupOffsetTest

2023-11-05 Thread Zihao Lin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17782976#comment-17782976 ] Zihao Lin commented on KAFKA-15739: --- Hi [~sameert]  I want to test my PR, but how to re-trigger the