Re: [PR] KAFKA-14112: Expose replication-offset-lag Mirror metric [kafka]

2023-12-30 Thread via GitHub
github-actions[bot] commented on PR #14077: URL: https://github.com/apache/kafka/pull/14077#issuecomment-1872660155 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge

Re: [PR] Bugfix: Prevent java.lang.UnsupportedOperationException. [kafka]

2023-12-30 Thread via GitHub
vamossagar12 commented on code in PR #14955: URL: https://github.com/apache/kafka/pull/14955#discussion_r1438796599 ## clients/src/test/java/org/apache/kafka/clients/admin/MockAdminClient.java: ## @@ -1014,7 +1014,9 @@ synchronized public DescribeLogDirsResult describeLogDirs(C

[jira] [Updated] (KAFKA-16039) RecordHeaders supports the addAll method

2023-12-30 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Rao updated KAFKA-16039: -- Labels: need-kip (was: ) > RecordHeaders supports the addAll method > ---

Re: [PR] Fixing flaky Unit tests in GroupMetadataManagerTest [kafka]

2023-12-30 Thread via GitHub
vamossagar12 commented on code in PR #15100: URL: https://github.com/apache/kafka/pull/15100#discussion_r1438790325 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -2191,11 +2191,7 @@ public void testStaticMemberGetsBac

[jira] [Comment Edited] (KAFKA-16063) Fix leaked ApplicationShutdownHooks in EndToEndAuthorizationTests

2023-12-30 Thread Arpit Goyal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801408#comment-17801408 ] Arpit Goyal edited comment on KAFKA-16063 at 12/31/23 2:08 AM: ---

[jira] [Comment Edited] (KAFKA-16063) Fix leaked ApplicationShutdownHooks in EndToEndAuthorizationTests

2023-12-30 Thread Arpit Goyal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801408#comment-17801408 ] Arpit Goyal edited comment on KAFKA-16063 at 12/31/23 2:08 AM: ---

[jira] [Commented] (KAFKA-16063) Fix leaked ApplicationShutdownHooks in EndToEndAuthorizationTests

2023-12-30 Thread Arpit Goyal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801408#comment-17801408 ] Arpit Goyal commented on KAFKA-16063: - [~divijvaidya] I am trying to reproduce the i

[jira] [Assigned] (KAFKA-16066) Upgrade apacheds to 2.0.0.AM27

2023-12-30 Thread Anish Lukkireddy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anish Lukkireddy reassigned KAFKA-16066: Assignee: Anish Lukkireddy > Upgrade apacheds to 2.0.0.AM27 > ---

[jira] [Assigned] (KAFKA-15721) KRaft support in DeleteTopicsRequestWithDeletionDisabledTest

2023-12-30 Thread Dmitry Werner (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmitry Werner reassigned KAFKA-15721: - Assignee: Dmitry Werner > KRaft support in DeleteTopicsRequestWithDeletionDisabledTest

Re: [PR] KAFKA-15742: KRaft support in GroupCoordinatorIntegrationTest [kafka]

2023-12-30 Thread via GitHub
wernerdv commented on PR #15086: URL: https://github.com/apache/kafka/pull/15086#issuecomment-1872610749 @divijvaidya If you have a chance, could you take a look at this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] KAFKA-16064: Improve ControllerApisTest [kafka]

2023-12-30 Thread via GitHub
wernerdv commented on PR #15091: URL: https://github.com/apache/kafka/pull/15091#issuecomment-1872609011 @divijvaidya thank you very much. This is only the beginning :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[jira] [Updated] (KAFKA-14928) Metrics collection contends on lock with log cleaning

2023-12-30 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-14928: - Fix Version/s: (was: 3.8.0) > Metrics collection contends on lock with log cleaning > --

[jira] [Commented] (KAFKA-16066) Upgrade apacheds to 2.0.0.AM27

2023-12-30 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801394#comment-17801394 ] Divij Vaidya commented on KAFKA-16066: -- Sure [~anishlukk123] please go ahead. You s

[jira] [Updated] (KAFKA-16064) Improve ControllerApisTest

2023-12-30 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-16064: - Fix Version/s: 3.8.0 > Improve ControllerApisTest > -- > >

Re: [PR] KAFKA-16064: Improve ControllerApisTest [kafka]

2023-12-30 Thread via GitHub
divijvaidya merged PR #15091: URL: https://github.com/apache/kafka/pull/15091 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apa

Re: [PR] KAFKA-16064: Improve ControllerApisTest [kafka]

2023-12-30 Thread via GitHub
divijvaidya commented on PR #15091: URL: https://github.com/apache/kafka/pull/15091#issuecomment-1872604096 @wernerdv I observed that this is your firs contribution to Apache Kafka. Congratulations! Hopefully, first of many more to come. -- This is an automated message from the Apache Git

Re: [PR] KAFKA-16064: Improve ControllerApisTest [kafka]

2023-12-30 Thread via GitHub
divijvaidya commented on PR #15091: URL: https://github.com/apache/kafka/pull/15091#issuecomment-1872603701 I have verified that the test is successful in CI: https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-15091/1/testReport/kafka.server/ControllerApisTest/ -- This is an aut

[jira] [Updated] (KAFKA-6527) Transient failure in DynamicBrokerReconfigurationTest.testDefaultTopicConfig

2023-12-30 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-6527: Labels: flakey flaky-test (was: flakey) > Transient failure in DynamicBrokerReconfigurationTest.te

Re: [PR] KAFKA-16025: Fix orphaned locks when rebalancing and store cleanup race on unassigned task directories [kafka]

2023-12-30 Thread via GitHub
divijvaidya commented on PR #15088: URL: https://github.com/apache/kafka/pull/15088#issuecomment-1872603263 @cadonna would you like to take a stab at reviewing this one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Updated] (KAFKA-16064) Improve ControllerApisTest

2023-12-30 Thread Dmitry Werner (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmitry Werner updated KAFKA-16064: -- Summary: Improve ControllerApisTest (was: improve ControllerApiTest) > Improve ControllerApis

[jira] [Commented] (KAFKA-15752) KRaft support in SaslSslAdminIntegrationTest

2023-12-30 Thread Anish Lukkireddy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801371#comment-17801371 ] Anish Lukkireddy commented on KAFKA-15752: -- [~sameert]  > KRaft support in Sas

Re: [PR] Fixing flaky Unit tests in GroupMetadataManagerTest [kafka]

2023-12-30 Thread via GitHub
divijvaidya commented on code in PR #15100: URL: https://github.com/apache/kafka/pull/15100#discussion_r1438569027 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -2191,11 +2191,7 @@ public void testStaticMemberGetsBack

Re: [PR] KAFKA-16052: Create a real dummy replicaManager instance to save heap memory [kafka]

2023-12-30 Thread via GitHub
divijvaidya commented on code in PR #15094: URL: https://github.com/apache/kafka/pull/15094#discussion_r1438567614 ## core/src/test/scala/unit/kafka/coordinator/AbstractCoordinatorConcurrencyTest.scala: ## @@ -148,25 +156,34 @@ abstract class AbstractCoordinatorConcurrencyTest[M

Re: [PR] KAFKA-9545: Fix IllegalStateException in updateLags [kafka]

2023-12-30 Thread via GitHub
cadonna commented on PR #15096: URL: https://github.com/apache/kafka/pull/15096#issuecomment-1872495055 Test failures `org.apache.kafka.streams.processor.internals.StreamThreadTest.shouldUpdateLagsAfterPolling[0]` seem related. See https://ci-builds.apache.org/job/Kafka/job/kafka-p