gharris1727 commented on PR #14762:
URL: https://github.com/apache/kafka/pull/14762#issuecomment-1896474948
I think due to the locking concerns I raised earlier, and that we can
resolve this resource leak in our tests, this PR is not viable to merge. We can
revisit this in the future if
gharris1727 closed pull request #14762: KAFKA-15826: Close consumer when sink
task is cancelled
URL: https://github.com/apache/kafka/pull/14762
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
gharris1727 commented on PR #14729:
URL: https://github.com/apache/kafka/pull/14729#issuecomment-1896468099
@chia7712 @showuon @mimaison Are any of you able to review this resource
leak fix? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message,
junrao commented on code in PR #15190:
URL: https://github.com/apache/kafka/pull/15190#discussion_r1456303419
##
core/src/main/scala/kafka/network/SocketServer.scala:
##
@@ -1140,9 +1141,9 @@ private[kafka] class Processor(
pprovenzano commented on PR #15197:
URL: https://github.com/apache/kafka/pull/15197#issuecomment-1896448532
Test failures are not related.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
jolshan commented on code in PR #15212:
URL: https://github.com/apache/kafka/pull/15212#discussion_r1456314640
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##
@@ -861,19 +861,9 @@ private void maybeUpdatePartitionEpoch(
philipnee opened a new pull request, #15216:
URL: https://github.com/apache/kafka/pull/15216
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
kirktrue commented on PR #14818:
URL: https://github.com/apache/kafka/pull/14818#issuecomment-1896409297
@jcme—Can you trigger a rebuild of the CI job? It looks like the last run
didn't work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
jolshan commented on PR #14856:
URL: https://github.com/apache/kafka/pull/14856#issuecomment-1896365557
Did we want to delete the old files in this PR or a follow up?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
jolshan commented on code in PR #14856:
URL: https://github.com/apache/kafka/pull/14856#discussion_r1456242441
##
tools/src/main/java/org/apache/kafka/tools/consumergroup/ConsumerGroupCommandOptions.java:
##
@@ -0,0 +1,263 @@
+/*
Review Comment:
Is the tools/consumergroup a
jolshan commented on code in PR #15176:
URL: https://github.com/apache/kafka/pull/15176#discussion_r1456228457
##
core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala:
##
@@ -935,8 +935,9 @@ private[group] class GroupCoordinator(
producerId,
[
https://issues.apache.org/jira/browse/KAFKA-16157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison updated KAFKA-16157:
---
Affects Version/s: 3.7.0
(was: 3.7.1)
> Topic recreation with
lianetm opened a new pull request, #15215:
URL: https://github.com/apache/kafka/pull/15215
This ensures that no records are fetched in the background thread while the
onPartitionsAssigned callback completes running in the Application thread. This
is achieved by pausing the partitions
philipnee commented on PR #15210:
URL: https://github.com/apache/kafka/pull/15210#issuecomment-1896275067
@lucasbru - Would you have time to review this? Seems like the failed tests
aren't necessary related.
--
This is an automated message from the Apache Git Service.
To respond to the
[
https://issues.apache.org/jira/browse/KAFKA-16157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gaurav Narula updated KAFKA-16157:
--
Description:
In a cluster with 4 brokers, `broker-1..broker-4` with 2 disks `d1` and `d2` in
[
https://issues.apache.org/jira/browse/KAFKA-16157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Proven Provenzano updated KAFKA-16157:
--
Priority: Blocker (was: Major)
> Topic recreation with offline disk doesn't update
philipnee commented on code in PR #15000:
URL: https://github.com/apache/kafka/pull/15000#discussion_r1456105594
##
core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala:
##
@@ -1336,8 +1336,9 @@ class PlaintextConsumerTest extends BaseConsumerTest {
[
https://issues.apache.org/jira/browse/KAFKA-16157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807814#comment-17807814
]
Mickael Maison commented on KAFKA-16157:
Did you hit this issue while testing 3.7.0 RC2 or with
mimaison commented on code in PR #14856:
URL: https://github.com/apache/kafka/pull/14856#discussion_r1456011084
##
tools/src/main/java/org/apache/kafka/tools/consumergroup/PartitionAssignmentState.java:
##
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation
[
https://issues.apache.org/jira/browse/KAFKA-16157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gaurav Narula updated KAFKA-16157:
--
Attachment: broker.log
broker.log.1
broker.log.2
Gaurav Narula created KAFKA-16157:
-
Summary: Topic recreation with offline disk doesn't update
leadership/shrink ISR correctly
Key: KAFKA-16157
URL: https://issues.apache.org/jira/browse/KAFKA-16157
kirktrue commented on PR #15206:
URL: https://github.com/apache/kafka/pull/15206#issuecomment-1896159822
Closing and reopening to kick off another test run
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
kirktrue closed pull request #15206: KAFKA-16104: Enable additional
PlaintextConsumerTest tests for new consumer
URL: https://github.com/apache/kafka/pull/15206
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[
https://issues.apache.org/jira/browse/KAFKA-15538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807783#comment-17807783
]
Lianet Magrans commented on KAFKA-15538:
Hey [~phuctran], you're right that the intention is
[
https://issues.apache.org/jira/browse/KAFKA-15538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lianet Magrans updated KAFKA-15538:
---
Description:
When using subscribe with a java regex (Pattern), we need to resolve it on the
AndrewJSchofield opened a new pull request, #15214:
URL: https://github.com/apache/kafka/pull/15214
The `ListClientMetricsResourcesResponse` definition is missing several
`"about"` descriptions. The main effect of this is that the Kafka protocol
documentation misses the descriptions of
[
https://issues.apache.org/jira/browse/KAFKA-16151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807773#comment-17807773
]
Lianet Magrans commented on KAFKA-16151:
[~kirktrue] isn't this the same as
[
https://issues.apache.org/jira/browse/KAFKA-16150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807772#comment-17807772
]
Lianet Magrans commented on KAFKA-16150:
[~kirktrue] this seems the same as
[
https://issues.apache.org/jira/browse/KAFKA-16134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807767#comment-17807767
]
Lianet Magrans edited comment on KAFKA-16134 at 1/17/24 3:21 PM:
-
Might
[
https://issues.apache.org/jira/browse/KAFKA-16134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807767#comment-17807767
]
Lianet Magrans commented on KAFKA-16134:
Might be related
>
lucasbru commented on code in PR #15000:
URL: https://github.com/apache/kafka/pull/15000#discussion_r1455790243
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1902,65 +1912,14 @@ private void
lucasbru commented on code in PR #15000:
URL: https://github.com/apache/kafka/pull/15000#discussion_r1455787900
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java:
##
@@ -844,6 +849,54 @@ public void testWakeupCommitted() {
[
https://issues.apache.org/jira/browse/KAFKA-16156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lianet Magrans updated KAFKA-16156:
---
Summary: System test failing for new consumer on endOffsets with negative
timestamps (was:
[
https://issues.apache.org/jira/browse/KAFKA-16156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lianet Magrans updated KAFKA-16156:
---
Description:
TransactionalMessageCopier run with 3.7 new consumer fails with "Invalid
Lianet Magrans created KAFKA-16156:
--
Summary: System test failing on endOffsets with negative timestamps
Key: KAFKA-16156
URL: https://issues.apache.org/jira/browse/KAFKA-16156
Project: Kafka
lucasbru merged PR #15204:
URL: https://github.com/apache/kafka/pull/15204
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
pprovenzano commented on code in PR #15197:
URL: https://github.com/apache/kafka/pull/15197#discussion_r1455684322
##
metadata/src/main/java/org/apache/kafka/image/FeaturesImage.java:
##
@@ -46,6 +46,18 @@ public final class FeaturesImage {
ZkMigrationState.NONE
lucasbru commented on code in PR #15000:
URL: https://github.com/apache/kafka/pull/15000#discussion_r1455660640
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -367,6 +372,42 @@ public void
lucasbru commented on code in PR #15000:
URL: https://github.com/apache/kafka/pull/15000#discussion_r1455660640
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -367,6 +372,42 @@ public void
lucasbru commented on code in PR #15000:
URL: https://github.com/apache/kafka/pull/15000#discussion_r1455670090
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -93,9 +94,11 @@ public CommitRequestManager(
final
lucasbru commented on code in PR #15000:
URL: https://github.com/apache/kafka/pull/15000#discussion_r1455660640
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -367,6 +372,42 @@ public void
OmniaGM commented on code in PR #15159:
URL: https://github.com/apache/kafka/pull/15159#discussion_r1455645909
##
checkstyle/import-control-core.xml:
##
@@ -94,6 +94,7 @@
+
Review Comment:
remove it
--
This is an automated message from the Apache Git
[
https://issues.apache.org/jira/browse/KAFKA-16155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lucas Brutschy updated KAFKA-16155:
---
Description:
Even with KAFKA-15942, the test PlaintextConsumerTest.testAutoCommitIntercept
Lucas Brutschy created KAFKA-16155:
--
Summary: Investigate testAutoCommitIntercept
Key: KAFKA-16155
URL: https://issues.apache.org/jira/browse/KAFKA-16155
Project: Kafka
Issue Type: Bug
clolov commented on code in PR #15213:
URL: https://github.com/apache/kafka/pull/15213#discussion_r1455525955
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1300,18 +1303,27 @@ class UnifiedLog(@volatile var logStartOffset: Long,
} else if (targetTimestamp ==
clolov opened a new pull request, #15213:
URL: https://github.com/apache/kafka/pull/15213
### Summary
This is the first part of the implementation of
[KIP-1005](https://cwiki.apache.org/confluence/display/KAFKA/KIP-1005%3A+Expose+EarliestLocalOffset+and+TieredOffset)
The
Christo Lolov created KAFKA-16154:
-
Summary: Make broker changes to return an offset for
LATEST_TIERED_TIMESTAMP
Key: KAFKA-16154
URL: https://issues.apache.org/jira/browse/KAFKA-16154
Project: Kafka
DL1231 commented on PR #15067:
URL: https://github.com/apache/kafka/pull/15067#issuecomment-1895664514
@dajac, PTAL, thanks in advance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
dajac opened a new pull request, #15212:
URL: https://github.com/apache/kafka/pull/15212
We had a case where a partition got assigned to two members and we found a
bug in the partition epochs bookkeeping. Basically, when a member has a
partition pending revocation re-assigned to him before
[
https://issues.apache.org/jira/browse/KAFKA-16147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot reassigned KAFKA-16147:
---
Assignee: David Jacot
> Partition is assigned to two members at the same time
>
DL1231 commented on PR #15211:
URL: https://github.com/apache/kafka/pull/15211#issuecomment-1895572781
@rreddy-22 PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
DL1231 opened a new pull request, #15211:
URL: https://github.com/apache/kafka/pull/15211
While using —list —state the current accepted values correspond to the
classic group type states.
This PR include support for the new group type states.
### Committer Checklist (excluded
[
https://issues.apache.org/jira/browse/KAFKA-4759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807680#comment-17807680
]
Szymon Scharmach commented on KAFKA-4759:
-
Updated PR is ready:
AndrewJSchofield commented on code in PR #15000:
URL: https://github.com/apache/kafka/pull/15000#discussion_r1455084554
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -367,6 +372,42 @@ public void
satishd closed pull request #15209: MINOR Removed unused CommittedOffsetsFile
class.
URL: https://github.com/apache/kafka/pull/15209
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
mimaison commented on code in PR #15159:
URL: https://github.com/apache/kafka/pull/15159#discussion_r1454953584
##
checkstyle/import-control-core.xml:
##
@@ -94,6 +94,7 @@
+
Review Comment:
I think we can remove that line too
--
This is an automated
Mickael Maison created KAFKA-16153:
--
Summary: kraft_upgrade_test system test is broken
Key: KAFKA-16153
URL: https://issues.apache.org/jira/browse/KAFKA-16153
Project: Kafka
Issue Type: Bug
101 - 157 of 157 matches
Mail list logo
