lucasbru commented on code in PR #15000:
URL: https://github.com/apache/kafka/pull/15000#discussion_r1459046282
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/OffsetCommitCallbackInvoker.java:
##
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software
[
https://issues.apache.org/jira/browse/KAFKA-15832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lianet Magrans updated KAFKA-15832:
---
Description:
Currently the reconciliation logic on the client is triggered when a new
Vedarth Sharma created KAFKA-16170:
--
Summary: Infinite logs observed when running single node kafka in
kraft mode with default KRaft properties in 3.7.0 RC2
Key: KAFKA-16170
URL:
Lucas Brutschy created KAFKA-16169:
--
Summary: FencedException in commitAsync not propagated without
callback
Key: KAFKA-16169
URL: https://issues.apache.org/jira/browse/KAFKA-16169
Project: Kafka
AndrewJSchofield commented on code in PR #15150:
URL: https://github.com/apache/kafka/pull/15150#discussion_r1459047606
##
clients/src/main/java/org/apache/kafka/clients/admin/ListConsumerGroupsOptions.java:
##
@@ -34,13 +35,24 @@ public class ListConsumerGroupsOptions extends
AndrewJSchofield commented on code in PR #15215:
URL: https://github.com/apache/kafka/pull/15215#discussion_r1459040148
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -1134,9 +1134,22 @@ private CompletableFuture
AndrewJSchofield commented on code in PR #15234:
URL: https://github.com/apache/kafka/pull/15234#discussion_r1459018939
##
server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java:
##
@@ -433,4 +459,26 @@ public Map matchPattern() {
return
[
https://issues.apache.org/jira/browse/KAFKA-16162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808658#comment-17808658
]
Proven Provenzano commented on KAFKA-16162:
---
Hi [~showuon]
I think my patch will also
apoorvmittal10 commented on PR #15228:
URL: https://github.com/apache/kafka/pull/15228#issuecomment-1900431524
> Thanks @apoorvmittal10!
>
> Merged to `trunk` and cherry-picked to `3.7` branch.
Thanks @mjsax
--
This is an automated message from the Apache Git Service.
To
[
https://issues.apache.org/jira/browse/KAFKA-15776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808653#comment-17808653
]
Francois Visconte commented on KAFKA-15776:
---
[~ckamal] Any idea on how to move forward on
dajac commented on code in PR #15215:
URL: https://github.com/apache/kafka/pull/15215#discussion_r1458965028
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -1134,9 +1134,22 @@ private CompletableFuture assignPartitions(
VictorvandenHoven commented on PR #14426:
URL: https://github.com/apache/kafka/pull/14426#issuecomment-1900331266
> @mjsax , @guozhangwang , can we merge this?
How long does it normally take to get a reaction?
--
This is an automated message from the Apache Git Service.
To respond
showuon commented on PR #15133:
URL: https://github.com/apache/kafka/pull/15133#issuecomment-1900326555
> Most are optional comments but the blocking comments before we merge are
the once related to removal of metrics when topic is deleted. I would assume
that removal needs to occur from
lucasbru merged PR #15210:
URL: https://github.com/apache/kafka/pull/15210
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
cadonna commented on code in PR #15000:
URL: https://github.com/apache/kafka/pull/15000#discussion_r1458727101
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/OffsetCommitCallbackInvoker.java:
##
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software
divijvaidya commented on code in PR #15133:
URL: https://github.com/apache/kafka/pull/15133#discussion_r1458819718
##
core/src/main/scala/kafka/server/KafkaRequestHandler.scala:
##
@@ -529,20 +564,33 @@ class BrokerTopicMetrics(name: Option[String], configOpt:
Joker-5 commented on PR #14963:
URL: https://github.com/apache/kafka/pull/14963#issuecomment-1900231164
> @Joker-5 I can add it in the PR description so that I don't forget. But
the tag needs to added to the final commit, once we merge it, so we cannot
really add it yet
Got it, many
[
https://issues.apache.org/jira/browse/KAFKA-16148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot reassigned KAFKA-16148:
---
Assignee: Jeff Kim
> Implement GroupMetadataManager#onUnloaded
>
divijvaidya commented on PR #14583:
URL: https://github.com/apache/kafka/pull/14583#issuecomment-1900157802
@atu-sharm would you like to continue on this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
stanislavkozlovski commented on code in PR #15186:
URL: https://github.com/apache/kafka/pull/15186#discussion_r1458752762
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java:
##
@@ -376,25 +376,21 @@ protected Map
prepareCloseFetchSessi
mimaison commented on code in PR #15158:
URL: https://github.com/apache/kafka/pull/15158#discussion_r1458684850
##
checkstyle/import-control-core.xml:
##
@@ -82,6 +82,7 @@
+
Review Comment:
Do we really need this change? core seems to build fine
[
https://issues.apache.org/jira/browse/KAFKA-16111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lucas Brutschy reassigned KAFKA-16111:
--
Assignee: (was: Lucas Brutschy)
> Implement tests for tricky rebalance callback
David Jacot created KAFKA-16168:
---
Summary: Implement GroupCoordinator.onPartitionsDeleted
Key: KAFKA-16168
URL: https://issues.apache.org/jira/browse/KAFKA-16168
Project: Kafka
Issue Type:
[
https://issues.apache.org/jira/browse/KAFKA-16162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808578#comment-17808578
]
Luke Chen commented on KAFKA-16162:
---
Thanks [~pprovenzano], I agree we also need to have a way to
dajac commented on code in PR #15150:
URL: https://github.com/apache/kafka/pull/15150#discussion_r1458665622
##
clients/src/main/java/org/apache/kafka/clients/admin/ConsumerGroupListing.java:
##
@@ -21,95 +21,111 @@
import java.util.Optional;
Review Comment:
We would need
dajac commented on code in PR #15152:
URL: https://github.com/apache/kafka/pull/15152#discussion_r1458663082
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -452,21 +453,39 @@ public Group group(String groupId, long
lucasbru merged PR #15206:
URL: https://github.com/apache/kafka/pull/15206
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ppatierno commented on code in PR #15193:
URL: https://github.com/apache/kafka/pull/15193#discussion_r1458520337
##
docs/ops.html:
##
@@ -3992,6 +3979,75 @@ Finalizing the migration
# Other configs ...
+ Reverting to ZooKeeper mode During the Migration
+
+While the
[
https://issues.apache.org/jira/browse/KAFKA-16144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808548#comment-17808548
]
Mickael Maison edited comment on KAFKA-16144 at 1/19/24 9:11 AM:
-
kamalcph commented on code in PR #15213:
URL: https://github.com/apache/kafka/pull/15213#discussion_r1458606590
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1300,18 +1303,27 @@ class UnifiedLog(@volatile var logStartOffset: Long,
} else if (targetTimestamp
[
https://issues.apache.org/jira/browse/KAFKA-16144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808548#comment-17808548
]
Mickael Maison commented on KAFKA-16144:
Marking this as a blocker as it's a regression and
[
https://issues.apache.org/jira/browse/KAFKA-16144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison updated KAFKA-16144:
---
Priority: Blocker (was: Major)
> Controller leader checkQuorum timer should skip only 1
danielgospodinow closed pull request #12712: KAFKA-14277: Add event queue size
method
URL: https://github.com/apache/kafka/pull/12712
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
[
https://issues.apache.org/jira/browse/KAFKA-16144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison updated KAFKA-16144:
---
Fix Version/s: 3.7.0
> Controller leader checkQuorum timer should skip only 1 controller
kamalcph commented on code in PR #15213:
URL: https://github.com/apache/kafka/pull/15213#discussion_r1458560112
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1300,18 +1303,27 @@ class UnifiedLog(@volatile var logStartOffset: Long,
} else if (targetTimestamp
dajac commented on code in PR #15205:
URL: https://github.com/apache/kafka/pull/15205#discussion_r1458581509
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupMember.java:
##
@@ -571,15 +577,29 @@ public
dajac commented on code in PR #15212:
URL: https://github.com/apache/kafka/pull/15212#discussion_r1458570521
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##
@@ -875,30 +875,43 @@ private void maybeRemovePartitionEpoch(
dajac commented on PR #15196:
URL: https://github.com/apache/kafka/pull/15196#issuecomment-1899964532
@jeffkbkim @dongnuo123 Thanks for your comments. I have addressed all of
them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
dajac commented on code in PR #15196:
URL: https://github.com/apache/kafka/pull/15196#discussion_r1458564906
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -1098,30 +1054,36 @@ private static boolean
dajac commented on PR #15221:
URL: https://github.com/apache/kafka/pull/15221#issuecomment-1899953142
@jeffkbkim @dongnuo123 Thanks for your comments. I addressed them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
dajac commented on code in PR #15221:
URL: https://github.com/apache/kafka/pull/15221#discussion_r1458553635
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java:
##
@@ -856,7 +899,8 @@ public boolean cleanupExpiredOffsets(String
101 - 141 of 141 matches
Mail list logo
