jlprat commented on code in PR #15279:
URL: https://github.com/apache/kafka/pull/15279#discussion_r1473118743
##
core/src/main/scala/kafka/network/RequestChannel.scala:
##
@@ -92,18 +92,18 @@ object RequestChannel extends Logging {
val envelope:
rreddy-22 commented on code in PR #15152:
URL: https://github.com/apache/kafka/pull/15152#discussion_r1473116357
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1819,6 +1822,10 @@ public void onLoaded() {
Gaurav Narula created KAFKA-16212:
-
Summary: Cache partitions by TopicIdPartition instead of
TopicPartition
Key: KAFKA-16212
URL: https://issues.apache.org/jira/browse/KAFKA-16212
Project: Kafka
gnarula commented on code in PR #15263:
URL: https://github.com/apache/kafka/pull/15263#discussion_r1473115063
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -2759,11 +2761,20 @@ class ReplicaManager(val config: KafkaConfig,
dajac commented on code in PR #15152:
URL: https://github.com/apache/kafka/pull/15152#discussion_r1473114805
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -726,6 +726,9 @@ private void removeGroup(
dajac commented on code in PR #15152:
URL: https://github.com/apache/kafka/pull/15152#discussion_r1473113934
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1819,6 +1822,10 @@ public void onLoaded() {
rreddy-22 commented on code in PR #15152:
URL: https://github.com/apache/kafka/pull/15152#discussion_r1473109613
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -726,6 +726,9 @@ private void removeGroup(
rreddy-22 commented on code in PR #15152:
URL: https://github.com/apache/kafka/pull/15152#discussion_r1473109228
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1819,6 +1822,10 @@ public void onLoaded() {
nicktelford commented on code in PR #15264:
URL: https://github.com/apache/kafka/pull/15264#discussion_r1473083987
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -874,6 +879,12 @@ public class StreamsConfig extends AbstractConfig {
nicktelford commented on code in PR #15264:
URL: https://github.com/apache/kafka/pull/15264#discussion_r1473084666
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java:
##
@@ -754,4 +754,11 @@ public void
nicktelford commented on code in PR #15264:
URL: https://github.com/apache/kafka/pull/15264#discussion_r1473084319
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java:
##
@@ -438,4 +438,11 @@ public Map changelogOffsets() {
nicktelford commented on code in PR #15264:
URL: https://github.com/apache/kafka/pull/15264#discussion_r1473083327
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -505,6 +505,11 @@ public class StreamsConfig extends AbstractConfig {
public
lqxshay commented on PR #14446:
URL: https://github.com/apache/kafka/pull/14446#issuecomment-1919417410
@mjsax gentle nudge on this one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
highluck opened a new pull request, #15301:
URL: https://github.com/apache/kafka/pull/15301
- remove un used code
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify
[
https://issues.apache.org/jira/browse/KAFKA-16185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lianet Magrans updated KAFKA-16185:
---
Description:
Currently, the intention in the client state machine is that the client always
tinaselenge opened a new pull request, #15300:
URL: https://github.com/apache/kafka/pull/15300
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of
dajac commented on PR #15253:
URL: https://github.com/apache/kafka/pull/15253#issuecomment-1919372877
Thanks @cadonna! I have addressed your comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
OmniaGM commented on code in PR #15279:
URL: https://github.com/apache/kafka/pull/15279#discussion_r1473036431
##
core/src/main/scala/kafka/network/RequestChannel.scala:
##
@@ -92,18 +92,18 @@ object RequestChannel extends Logging {
val envelope:
[
https://issues.apache.org/jira/browse/KAFKA-12549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17812756#comment-17812756
]
highluck commented on KAFKA-12549:
--
[~guozhang] Can I take the work with you?
> Allow state stores to
mumrah opened a new pull request, #15299:
URL: https://github.com/apache/kafka/pull/15299
This patch adds the MetadataType metric for both the brokers and
controllers, as defined in KIP-866. The values are: 1 (ZooKeeper), 2 (KRaft), 3
(Dual-Write). The brokers will only ever report
[
https://issues.apache.org/jira/browse/KAFKA-15744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
highluck reassigned KAFKA-15744:
Assignee: highluck
> KRaft support in CustomQuotaCallbackTest
>
[
https://issues.apache.org/jira/browse/KAFKA-16045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17812746#comment-17812746
]
Gaurav Narula commented on KAFKA-16045:
---
I've observed that {{allTopics}} seems to contain
highluck commented on PR #15294:
URL: https://github.com/apache/kafka/pull/15294#issuecomment-1919299676
Thanks for the explanation! I'll work on KIP again later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
highluck closed pull request #15294: MINOR: Remove unused exceptions
URL: https://github.com/apache/kafka/pull/15294
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
highluck commented on code in PR #15277:
URL: https://github.com/apache/kafka/pull/15277#discussion_r1472962425
##
gradle/dependencies.gradle:
##
@@ -88,8 +88,8 @@ else
// See https://issues.apache.org/jira/browse/KAFKA-12622 for steps to verify
the LICENSE-binary file is
cadonna commented on code in PR #15253:
URL: https://github.com/apache/kafka/pull/15253#discussion_r1472830748
##
clients/src/main/java/org/apache/kafka/clients/admin/internals/DescribeConsumerGroupsHandler.java:
##
@@ -89,18 +97,42 @@ public AdminApiLookupStrategy
mimaison merged PR #15167:
URL: https://github.com/apache/kafka/pull/15167
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
C0urante commented on PR #15249:
URL: https://github.com/apache/kafka/pull/15249#issuecomment-1919222609
The [fifth CI
run](https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-15249/10/tests/)
worked as well. Marking this ready for review.
@gharris1727
divijvaidya commented on PR #15294:
URL: https://github.com/apache/kafka/pull/15294#issuecomment-1919221694
These exceptions are part of public interface [1] and we need a KIP to
remove those. A KIP is required because we may have user clients handling these
exceptions.
[1]
C0urante commented on code in PR #15249:
URL: https://github.com/apache/kafka/pull/15249#discussion_r1472908745
##
connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectWorkerIntegrationTest.java:
##
@@ -238,9 +238,6 @@ public void testBrokerCoordinator()
divijvaidya commented on code in PR #15277:
URL: https://github.com/apache/kafka/pull/15277#discussion_r1472892693
##
gradle/dependencies.gradle:
##
@@ -234,6 +227,7 @@ libs += [
kafkaStreams_34: "org.apache.kafka:kafka-streams:$versions.kafka_34",
kafkaStreams_35:
lianetm commented on code in PR #15271:
URL: https://github.com/apache/kafka/pull/15271#discussion_r1472861675
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##
@@ -552,8 +555,63 @@ public void
lucasbru commented on code in PR #15271:
URL: https://github.com/apache/kafka/pull/15271#discussion_r1472843719
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##
@@ -552,8 +555,63 @@ public void
OmniaGM commented on code in PR #15274:
URL: https://github.com/apache/kafka/pull/15274#discussion_r1472771173
##
tools/src/main/java/org/apache/kafka/tools/consumer/ConsoleConsumer.java:
##
@@ -0,0 +1,233 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
OmniaGM commented on code in PR #15274:
URL: https://github.com/apache/kafka/pull/15274#discussion_r1472764137
##
tools/src/main/java/org/apache/kafka/tools/consumer/ConsoleConsumer.java:
##
@@ -0,0 +1,233 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
OmniaGM commented on code in PR #15274:
URL: https://github.com/apache/kafka/pull/15274#discussion_r1472734283
##
tools/src/main/java/org/apache/kafka/tools/consumer/ConsoleConsumer.java:
##
@@ -0,0 +1,233 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
OmniaGM commented on code in PR #15274:
URL: https://github.com/apache/kafka/pull/15274#discussion_r1472710835
##
tools/src/main/java/org/apache/kafka/tools/consumer/ConsoleConsumer.java:
##
@@ -0,0 +1,233 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
lucasbru commented on code in PR #15216:
URL: https://github.com/apache/kafka/pull/15216#discussion_r1472657940
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -108,6 +110,7 @@ public class HeartbeatRequestManager
dajac commented on code in PR #15271:
URL: https://github.com/apache/kafka/pull/15271#discussion_r1472793128
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##
@@ -552,8 +555,63 @@ public void
dengziming closed pull request #12065: KAFKA-13788: Use
AdminClient.incrementalAlterConfigs in ConfigCommand
URL: https://github.com/apache/kafka/pull/12065
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
jlprat merged PR #15272:
URL: https://github.com/apache/kafka/pull/15272
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jlprat commented on PR #15272:
URL: https://github.com/apache/kafka/pull/15272#issuecomment-1919044644
I checked that all tests pass locally, and the failures in CI seem all
unrelated to the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message,
myasinkaji commented on PR #15298:
URL: https://github.com/apache/kafka/pull/15298#issuecomment-1919042580
Clean-up sticky partitioner code a little bit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
myasinkaji closed pull request #15298: Clean-up sticky partitioner code a
little bit
URL: https://github.com/apache/kafka/pull/15298
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
gnarula commented on code in PR #15263:
URL: https://github.com/apache/kafka/pull/15263#discussion_r1472753854
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -874,7 +874,13 @@ class Partition(val topicPartition: TopicPartition,
private def
nizhikov commented on PR #15256:
URL: https://github.com/apache/kafka/pull/15256#issuecomment-1918995072
CI results looks good for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
satishd commented on PR #14034:
URL: https://github.com/apache/kafka/pull/14034#issuecomment-1918983502
Resolved the recent conflicts because of trunk changes in `UnifiedLog`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
clolov commented on PR #15261:
URL: https://github.com/apache/kafka/pull/15261#issuecomment-1918964713
Thank you, I will aim to address the comments as soon as possible!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
cadonna commented on PR #15188:
URL: https://github.com/apache/kafka/pull/15188#issuecomment-1918921920
@dajac If you feel more comfortable, we could implement and test everything
up to the point where the field is populated. We would then not populate the
field so that you do not need to
dajac commented on PR #15188:
URL: https://github.com/apache/kafka/pull/15188#issuecomment-1918915394
@Phuc-Hong-Tran Yep, that's right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
dajac commented on PR #15188:
URL: https://github.com/apache/kafka/pull/15188#issuecomment-1918915086
@cadonna Yes. We could for instance commit the RPC and then work
independently on the client and the server. My only concern is that we usually
discover issues while working on the server
Phuc-Hong-Tran commented on PR #15188:
URL: https://github.com/apache/kafka/pull/15188#issuecomment-1918907960
@dajac, when we're talking about the RPC, do we mean the field for the regex
in ConsumerGroupHeartbeatRequest.json?
--
This is an automated message from the Apache Git Service.
[
https://issues.apache.org/jira/browse/KAFKA-16160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17812669#comment-17812669
]
Phuc Hong Tran commented on KAFKA-16160:
[~pnee] I think we already have reconnectBackoff for
cadonna commented on PR #15188:
URL: https://github.com/apache/kafka/pull/15188#issuecomment-1918901251
@dajac OK, but we can implement and unit test everything up to the RPC,
right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
dajac commented on PR #15188:
URL: https://github.com/apache/kafka/pull/15188#issuecomment-1918899056
In my opinion, we should merge the client side only after the server side is
implemented. The reason is that we need to change the RPC (this is actually
missing in this PR) and this should
Phuc-Hong-Tran commented on PR #15188:
URL: https://github.com/apache/kafka/pull/15188#issuecomment-1918895644
I understand, will get back to speed on this one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
cadonna commented on PR #15188:
URL: https://github.com/apache/kafka/pull/15188#issuecomment-1918887578
@Phuc-Hong-Tran
> though isn't it this one aiming for 3.8 release?
Yes, but we have time-based releases in Apache Kafka. That means that the
deadline for the release will
Phuc-Hong-Tran commented on PR #15188:
URL: https://github.com/apache/kafka/pull/15188#issuecomment-1918876275
@cadonna thanks for the comment, I can still finish one as the deadline
required, though isn't it this one aiming for 3.8 release? Also the logic on
the broker is not implemented
cadonna commented on PR #15188:
URL: https://github.com/apache/kafka/pull/15188#issuecomment-1918874061
> - This feature is not yet implemented on the broker, so
cadonna commented on code in PR #15188:
URL: https://github.com/apache/kafka/pull/15188#discussion_r1472581740
##
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java:
##
@@ -753,6 +753,10 @@ public void subscribe(Pattern pattern,
fvaleri commented on PR #15273:
URL: https://github.com/apache/kafka/pull/15273#issuecomment-1918852761
@showuon I rebased and addressed your comments. Did not remove properties
definitions from KafkaConfig, because this breaks a lot of tests. I think this
should be done as part of
mimaison merged PR #14693:
URL: https://github.com/apache/kafka/pull/14693
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
giuseppelillo closed pull request #15297: feat: Create topic by specifying
topic id
URL: https://github.com/apache/kafka/pull/15297
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
giuseppelillo opened a new pull request, #15297:
URL: https://github.com/apache/kafka/pull/15297
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
lucasbru commented on code in PR #15271:
URL: https://github.com/apache/kafka/pull/15271#discussion_r1472523826
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -1350,21 +1321,33 @@ public Map>
currentAssignment() {
101 - 165 of 165 matches
Mail list logo
