FrankYang0529 commented on code in PR #15458:
URL: https://github.com/apache/kafka/pull/15458#discussion_r1510195954
##
tools/src/main/java/org/apache/kafka/tools/TopicCommand.java:
##
@@ -210,7 +210,7 @@ private static Integer
getReplicationFactor(TopicPartitionInfo tpi, Parti
wernerdv commented on PR #15457:
URL: https://github.com/apache/kafka/pull/15457#issuecomment-1975051194
Hello, @mimaison @OmniaGM
Please, take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
chia7712 commented on code in PR #15458:
URL: https://github.com/apache/kafka/pull/15458#discussion_r1510162458
##
tools/src/main/java/org/apache/kafka/tools/TopicCommand.java:
##
@@ -210,7 +210,7 @@ private static Integer
getReplicationFactor(TopicPartitionInfo tpi, PartitionR
FrankYang0529 commented on code in PR #15458:
URL: https://github.com/apache/kafka/pull/15458#discussion_r1510158945
##
tools/src/main/java/org/apache/kafka/tools/TopicCommand.java:
##
@@ -210,7 +210,7 @@ private static Integer
getReplicationFactor(TopicPartitionInfo tpi, Parti
FrankYang0529 opened a new pull request, #15459:
URL: https://github.com/apache/kafka/pull/15459
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of t
[
https://issues.apache.org/jira/browse/KAFKA-12187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kuan-Po Tseng reassigned KAFKA-12187:
-
Assignee: Kuan-Po Tseng (was: Chia-Ping Tsai)
> replace assertTrue(obj instanceof X) b
chia7712 commented on code in PR #15458:
URL: https://github.com/apache/kafka/pull/15458#discussion_r1510157302
##
tools/src/main/java/org/apache/kafka/tools/TopicCommand.java:
##
@@ -210,7 +210,7 @@ private static Integer
getReplicationFactor(TopicPartitionInfo tpi, PartitionR
[
https://issues.apache.org/jira/browse/KAFKA-12218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-12218.
Resolution: Duplicate
this was resolved by https://github.com/apache/kafka/pull/15404
> U
FrankYang0529 opened a new pull request, #15458:
URL: https://github.com/apache/kafka/pull/15458
Originally, `requestedTopic.isEmpty()` is before
`!Optional.ofNullable(requestedTopic).isPresent()`.
If `requestedTopic` is null, we get error from `requestedTopic.isEmpty()`.
Simpl
chia7712 commented on PR #14365:
URL: https://github.com/apache/kafka/pull/14365#issuecomment-1974982326
```
[2024-03-02T21:51:02.002Z]
kafka.api.PlaintextAdminIntegrationTest.testElectPreferredLeaders(String)[2]
failed, log available in
/home/jenkins/workspace/Kafka_kafka-pr_PR-14365/c
[
https://issues.apache.org/jira/browse/KAFKA-16246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dmitry Werner updated KAFKA-16246:
--
Fix Version/s: 3.8.0
> Cleanups in ConsoleConsumer
> ---
>
>
wernerdv opened a new pull request, #15457:
URL: https://github.com/apache/kafka/pull/15457
Removed Optional where it makes sense and removed the argument checking
logic that duplicates existing in ConsoleConsumerOptions#checkRequiredArgs().
### Committer Checklist (excluded from comm
bmscomp commented on PR #14365:
URL: https://github.com/apache/kafka/pull/14365#issuecomment-1974904749
@chia7712 Jqwik version is updated to 1.8.3 and conflicts are resolved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
[
https://issues.apache.org/jira/browse/KAFKA-16246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dmitry Werner reassigned KAFKA-16246:
-
Assignee: Dmitry Werner
> Cleanups in ConsoleConsumer
> ---
>
>
chia7712 commented on PR #14365:
URL: https://github.com/apache/kafka/pull/14365#issuecomment-1974864320
the last version of `jqwik` is 1.8.3. Maybe we should rebase the code with
1.8.3, and then merge it if there is no related failure.
--
This is an automated message from the Apache Git
mstepan closed pull request #14837: KAFKA-15154: proper StampedLock
synchronization added
URL: https://github.com/apache/kafka/pull/14837
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
[
https://issues.apache.org/jira/browse/KAFKA-16298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822804#comment-17822804
]
Chia Chuan Yu commented on KAFKA-16298:
---
Hi, [~lianetm]
I'm a new contributor an
chiacyu commented on PR #15444:
URL: https://github.com/apache/kafka/pull/15444#issuecomment-1974768078
Hi, @showuon
Just add a unit test for the condition of the empty snapshot.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please
18 matches
Mail list logo
