Re: [PR] KAFKA-16272: Update connect_distributed_test.py to support KIP-848’s group protocol config [kafka]

2024-03-21 Thread via GitHub
vamossagar12 commented on PR #15576: URL: https://github.com/apache/kafka/pull/15576#issuecomment-2014406407 @philipnee , I had assigned the ticket to myself and had started working on it (was in the process of testing it actually). Anyways since you have the PR, so you would want to contin

Re: [PR] KAFKA-15882: Add nightly docker image scan job [kafka]

2024-03-21 Thread via GitHub
VedarthConfluent commented on code in PR #15013: URL: https://github.com/apache/kafka/pull/15013#discussion_r1535081050 ## .github/workflows/docker_scan.yml: ## @@ -0,0 +1,43 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreemen

[jira] [Created] (KAFKA-16400) Update notification settings for cve detection scheduled workflow

2024-03-21 Thread Vedarth Sharma (Jira)
Vedarth Sharma created KAFKA-16400: -- Summary: Update notification settings for cve detection scheduled workflow Key: KAFKA-16400 URL: https://issues.apache.org/jira/browse/KAFKA-16400 Project: Kafka

Re: [PR] KAFKA-15062: Adding ppc64le build stage [kafka]

2024-03-21 Thread via GitHub
Vaibhav-Nazare commented on PR #13817: URL: https://github.com/apache/kafka/pull/13817#issuecomment-2014393617 Yes I would have followed the same , I have started a discussing on dev list. https://lists.apache.org/thread/f3yj7o5nfskz1onr59kmodm73kvtsktk -- This is an automated message f

Re: [PR] KAFKA-16314: Introducing the AbortableTransactionException [kafka]

2024-03-21 Thread via GitHub
sjhajharia commented on PR #15486: URL: https://github.com/apache/kafka/pull/15486#issuecomment-2014388345 Thank you @jolshan for the review. I have updated the test mentioned. Hopefully it gets into trunk soon. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] KAFKA-16156: beginningOrEndOffsets does not need to build an OffsetAndTimestamps object upon completion [kafka]

2024-03-21 Thread via GitHub
philipnee commented on code in PR #15525: URL: https://github.com/apache/kafka/pull/15525#discussion_r1535039670 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/OffsetsRequestManagerTest.java: ## @@ -480,11 +475,16 @@ public void testRequestFails_Authenticat

Re: [PR] KAFKA-16156: beginningOrEndOffsets does not need to build an OffsetAndTimestamps object upon completion [kafka]

2024-03-21 Thread via GitHub
philipnee commented on code in PR #15525: URL: https://github.com/apache/kafka/pull/15525#discussion_r1535038917 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/OffsetsRequestManagerTest.java: ## @@ -131,13 +131,11 @@ public void testListOffsetsRequest_Succe

Re: [PR] KAFKA-16156: beginningOrEndOffsets does not need to build an OffsetAndTimestamps object upon completion [kafka]

2024-03-21 Thread via GitHub
philipnee commented on code in PR #15525: URL: https://github.com/apache/kafka/pull/15525#discussion_r1535038917 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/OffsetsRequestManagerTest.java: ## @@ -131,13 +131,11 @@ public void testListOffsetsRequest_Succe

Re: [PR] KAFKA-16272: Update connect_distributed_test.py to support KIP-848’s group protocol config [kafka]

2024-03-21 Thread via GitHub
kirktrue commented on code in PR #15576: URL: https://github.com/apache/kafka/pull/15576#discussion_r1535030295 ## tests/kafkatest/tests/connect/connect_distributed_test.py: ## @@ -692,7 +692,12 @@ def test_file_source_and_sink(self, security_protocol, exactly_once_source, conn

Re: [PR] KAFKA-15302: Stale value returned when using store.all() with key deletion [docs] [kafka]

2024-03-21 Thread via GitHub
jinyongchoi commented on code in PR #15495: URL: https://github.com/apache/kafka/pull/15495#discussion_r1527474042 ## docs/streams/developer-guide/memory-mgmt.html: ## @@ -151,6 +151,10 @@ Serdes.Long()) .withCachingEnabled(); Record caches are not supported for v

Re: [PR] KAFKA-16374; High watermark updates should have a higher priority [kafka]

2024-03-21 Thread via GitHub
jeffkbkim commented on code in PR #15534: URL: https://github.com/apache/kafka/pull/15534#discussion_r1534979427 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntimeTest.java: ## @@ -2591,6 +2599,74 @@ public void testPartitionLoadGen

Re: [PR] KAFKA-15729: Add KRaft support in GetOffsetShellTest [kafka]

2024-03-21 Thread via GitHub
Owen-CH-Leung commented on code in PR #15489: URL: https://github.com/apache/kafka/pull/15489#discussion_r1534974289 ## tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java: ## @@ -182,14 +187,19 @@ public void testTopicPartitionsArg() { setUp();

[jira] [Updated] (KAFKA-16341) Fix un-compressed records

2024-03-21 Thread Manikumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar updated KAFKA-16341: -- Fix Version/s: 3.6.2 > Fix un-compressed records > - > > Key:

[jira] [Commented] (KAFKA-16389) consumer_test.py’s test_valid_assignment fails with new consumer

2024-03-21 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17829712#comment-17829712 ] Chia-Ping Tsai commented on KAFKA-16389: Just curious, why not fixing the failed

Re: [PR] KAFKA-16323: fix testRemoteFetchExpiresPerSecMetric [kafka]

2024-03-21 Thread via GitHub
showuon commented on code in PR #15463: URL: https://github.com/apache/kafka/pull/15463#discussion_r1534892451 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -4164,16 +4166,12 @@ class ReplicaManagerTest { mock(classOf[FetchDataInfo]) })

Re: [PR] KAFKA-16375: Fix for rejoin while reconciling [kafka]

2024-03-21 Thread via GitHub
lianetm commented on PR #15579: URL: https://github.com/apache/kafka/pull/15579#issuecomment-2013823539 Hey @lucasbru, could you please take a look at this one when you have a chance? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [PR] KAFKA-16386: Convert NETWORK_EXCEPTIONs from KIP-890 transaction verification [kafka]

2024-03-21 Thread via GitHub
squah-confluent commented on code in PR #15559: URL: https://github.com/apache/kafka/pull/15559#discussion_r1534709657 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala: ## @@ -921,7 +921,10 @@ private[group] class GroupCoordinator( ): Unit = {

Re: [PR] KAFKA-16386: Convert NETWORK_EXCEPTIONs from KIP-890 transaction verification [kafka]

2024-03-21 Thread via GitHub
squah-confluent commented on code in PR #15559: URL: https://github.com/apache/kafka/pull/15559#discussion_r1534709657 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala: ## @@ -921,7 +921,10 @@ private[group] class GroupCoordinator( ): Unit = {

Re: [PR] KAFKA-16386: Convert NETWORK_EXCEPTIONs from KIP-890 transaction verification [kafka]

2024-03-21 Thread via GitHub
squah-confluent commented on code in PR #15559: URL: https://github.com/apache/kafka/pull/15559#discussion_r1534709657 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala: ## @@ -921,7 +921,10 @@ private[group] class GroupCoordinator( ): Unit = {

Re: [PR] KAFKA-16314: Introducing the AbortableTransactionException [kafka]

2024-03-21 Thread via GitHub
jolshan commented on code in PR #15486: URL: https://github.com/apache/kafka/pull/15486#discussion_r1534705114 ## core/src/test/scala/unit/kafka/server/AddPartitionsToTxnManagerTest.scala: ## @@ -106,27 +106,27 @@ class AddPartitionsToTxnManagerTest { val transaction2Errors

[jira] [Updated] (KAFKA-16375) Fix logic for discarding reconciliation if member rejoined

2024-03-21 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-16375: --- Description: The current implementation of the new consumer discards the result of a reconci

Re: [PR] KAFKA-16271: Upgrade consumer_rolling_upgrade_test.py [kafka]

2024-03-21 Thread via GitHub
philipnee commented on PR #15578: URL: https://github.com/apache/kafka/pull/15578#issuecomment-2013721029 Hey @lucasbru - This is another PR that upgrades the system test with consumer group protocol. It would be great if you have time to review the PR! Thanks! -- This is an automated m

Re: [PR] KAFKA-16386: Convert NETWORK_EXCEPTIONs from KIP-890 transaction verification [kafka]

2024-03-21 Thread via GitHub
artemlivshits commented on code in PR #15559: URL: https://github.com/apache/kafka/pull/15559#discussion_r1534632389 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala: ## @@ -921,7 +921,10 @@ private[group] class GroupCoordinator( ): Unit = {

[jira] [Commented] (KAFKA-16385) Segment is rolled before segment.ms or segment.bytes breached

2024-03-21 Thread Jorge Esteban Quilcate Otoya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17829682#comment-17829682 ] Jorge Esteban Quilcate Otoya commented on KAFKA-16385: -- > I admin m

Re: [PR] KAFKA-15517: Improve MirrorMaker logging in case of authorization errors [kafka]

2024-03-21 Thread via GitHub
wernerdv commented on code in PR #15558: URL: https://github.com/apache/kafka/pull/15558#discussion_r1534499279 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceConnector.java: ## @@ -630,8 +631,16 @@ Map describeTopicConfigs(Set topics) Set

Re: [PR] KAFKA-15517: Improve MirrorMaker logging in case of authorization errors [kafka]

2024-03-21 Thread via GitHub
wernerdv commented on code in PR #15558: URL: https://github.com/apache/kafka/pull/15558#discussion_r1534494595 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorSourceConnectorTest.java: ## @@ -224,6 +229,39 @@ public void testNoBrokerAclAuthorizer() throws

Re: [PR] KAFKA-15882: Add nightly docker image scan job [kafka]

2024-03-21 Thread via GitHub
VedarthConfluent commented on code in PR #15013: URL: https://github.com/apache/kafka/pull/15013#discussion_r1534434427 ## .github/workflows/docker_scan.yml: ## @@ -0,0 +1,43 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreemen

Re: [PR] KAFKA-16217: Stop the abort transaction try loop when closing producers [kafka]

2024-03-21 Thread via GitHub
kirktrue commented on PR #15541: URL: https://github.com/apache/kafka/pull/15541#issuecomment-2013238826 @CalvinConfluent 👍 I wonder if there's any value in the unit test for verifying that `TransactionManager.close()` was invoked. -- This is an automated message from the Apache Gi

Re: [PR] KAFKA-16217: Stop the abort transaction try loop when closing producers [kafka]

2024-03-21 Thread via GitHub
kirktrue commented on code in PR #15541: URL: https://github.com/apache/kafka/pull/15541#discussion_r1529215985 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java: ## @@ -270,14 +270,7 @@ public void run() { while (!forceClose && transactio

[jira] [Assigned] (KAFKA-14246) Update threading model for Consumer

2024-03-21 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-14246: - Assignee: Kirk True (was: Philip Nee) > Update threading model for Consumer >

[jira] [Assigned] (KAFKA-16275) Update kraft_upgrade_test.py to support KIP-848’s group protocol config

2024-03-21 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-16275: - Assignee: (was: Kirk True) > Update kraft_upgrade_test.py to support KIP-848’s group protoc

Re: [PR] KAFKA-15882: Add nightly docker image scan job [kafka]

2024-03-21 Thread via GitHub
mimaison commented on code in PR #15013: URL: https://github.com/apache/kafka/pull/15013#discussion_r1534417939 ## .github/workflows/docker_scan.yml: ## @@ -0,0 +1,43 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See

[jira] [Assigned] (KAFKA-16389) consumer_test.py’s test_valid_assignment fails with new consumer

2024-03-21 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-16389: - Assignee: (was: Kirk True) > consumer_test.py’s test_valid_assignment fails with new consum

[jira] [Commented] (KAFKA-16275) Update kraft_upgrade_test.py to support KIP-848’s group protocol config

2024-03-21 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17829660#comment-17829660 ] Kirk True commented on KAFKA-16275: --- [~dajac] [[~lucasbru]—Does migrating this test to

Re: [PR] KRaft upgrade tests should only use latest stable mv [kafka]

2024-03-21 Thread via GitHub
jolshan merged PR #15566: URL: https://github.com/apache/kafka/pull/15566 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KRaft upgrade tests should only use latest stable mv [kafka]

2024-03-21 Thread via GitHub
jolshan commented on PR #15566: URL: https://github.com/apache/kafka/pull/15566#issuecomment-2013196878 For some reason the build retriggered for the description update. Given this is a system test change, I think we don't have to wait for the rebuild. Here is the old build for reference:

Re: [PR] KAFKA-16274: Update replica_scale_test.py to support KIP-848’s group protocol config [kafka]

2024-03-21 Thread via GitHub
kirktrue commented on PR #15577: URL: https://github.com/apache/kafka/pull/15577#issuecomment-2013189414 @lucasbru—Can you take a look at this system test migration? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] KAFKA-16276: Update transactions_test.py to support KIP-848’s group protocol config [kafka]

2024-03-21 Thread via GitHub
kirktrue commented on PR #15567: URL: https://github.com/apache/kafka/pull/15567#issuecomment-2013189272 @lucasbru—Can you take a look at this system test migration? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[PR] KAFKA-16271: Upgrade consumer_rolling_upgrade_test.py [kafka]

2024-03-21 Thread via GitHub
philipnee opened a new pull request, #15578: URL: https://github.com/apache/kafka/pull/15578 Upgrading the test to use the consumer group protocol -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[PR] KAFKA-16274: Update replica_scale_test.py to support KIP-848’s group protocol config [kafka]

2024-03-21 Thread via GitHub
kirktrue opened a new pull request, #15577: URL: https://github.com/apache/kafka/pull/15577 Added a new optional `group_protocol` parameter to the test methods, then passed that down to the methods involved. Unfortunately, because the new consumer can only be used with the new coordi

Re: [PR] KRaft upgrade tests should only use latest stable mv [kafka]

2024-03-21 Thread via GitHub
ahuang98 commented on PR #15566: URL: https://github.com/apache/kafka/pull/15566#issuecomment-2013184498 Thanks @jolshan, updated the description! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] KAFKA-15882: Add nightly docker image scan job [kafka]

2024-03-21 Thread via GitHub
VedarthConfluent commented on code in PR #15013: URL: https://github.com/apache/kafka/pull/15013#discussion_r1534363653 ## .github/workflows/docker_scan.yml: ## @@ -0,0 +1,43 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreemen

[jira] [Assigned] (KAFKA-16275) Update kraft_upgrade_test.py to support KIP-848’s group protocol config

2024-03-21 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-16275: - Assignee: Kirk True > Update kraft_upgrade_test.py to support KIP-848’s group protocol config >

[PR] KAFKA-16272: Update connect_distributed_test.py to support KIP-848’s group protocol config [kafka]

2024-03-21 Thread via GitHub
philipnee opened a new pull request, #15576: URL: https://github.com/apache/kafka/pull/15576 Update connect_distributed_test.py to support KIP-848’s group protocol config. Not all tests are updated because only a subset of it is using the consumer directly. -- This is an automated messa

[jira] [Assigned] (KAFKA-16274) Update replica_scale_test.py to support KIP-848’s group protocol config

2024-03-21 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-16274: - Assignee: Kirk True > Update replica_scale_test.py to support KIP-848’s group protocol config >

Re: [PR] KAFKA-15882: Add nightly docker image scan job [kafka]

2024-03-21 Thread via GitHub
VedarthConfluent commented on code in PR #15013: URL: https://github.com/apache/kafka/pull/15013#discussion_r1534363653 ## .github/workflows/docker_scan.yml: ## @@ -0,0 +1,43 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreemen

Re: [PR] KRaft upgrade tests should only use latest stable mv [kafka]

2024-03-21 Thread via GitHub
jolshan commented on PR #15566: URL: https://github.com/apache/kafka/pull/15566#issuecomment-2013167459 Thanks for the fix -- small nit in the description. It's not that the version didn't exist, but that we couldn't run the command (likely because there is no supported (stable) MV for 3.8

Re: [PR] KAFKA-15882: Add nightly docker image scan job [kafka]

2024-03-21 Thread via GitHub
VedarthConfluent commented on code in PR #15013: URL: https://github.com/apache/kafka/pull/15013#discussion_r1534363653 ## .github/workflows/docker_scan.yml: ## @@ -0,0 +1,43 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreemen

Re: [PR] Refactor SSL/SASL admin integration tests to not use a custom authorizer [kafka]

2024-03-21 Thread via GitHub
mimaison commented on code in PR #15377: URL: https://github.com/apache/kafka/pull/15377#discussion_r1534098042 ## core/src/test/scala/integration/kafka/api/SaslSslAdminIntegrationTest.scala: ## @@ -13,66 +13,94 @@ package kafka.api import java.util -import kafka.security.au

Re: [PR] KAFKA-15899 Move kafka.security package from core to server module [kafka]

2024-03-21 Thread via GitHub
nizhikov commented on PR #15572: URL: https://github.com/apache/kafka/pull/15572#issuecomment-2013016349 Hello, @ijuma I moved two of three `kafka.security` classes to `server` - `AclEntry`, `CredentialProvider`. Third one - `AclAuthorizer` quite big and have some dependencies on

Re: [PR] KAFKA-15950: Serialize broker heartbeat requests [kafka]

2024-03-21 Thread via GitHub
soarez commented on code in PR #14903: URL: https://github.com/apache/kafka/pull/14903#discussion_r1534216092 ## core/src/test/scala/unit/kafka/server/BrokerLifecycleManagerTest.scala: ## @@ -254,33 +262,41 @@ class BrokerLifecycleManagerTest { @Test def testKraftJBODMet

Re: [PR] KAFKA-15853: Move KafkaConfig Replication properties and docs out of … [kafka]

2024-03-21 Thread via GitHub
OmniaGM commented on PR #15575: URL: https://github.com/apache/kafka/pull/15575#issuecomment-2012802436 @nizhikov can you have a look please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[jira] [Commented] (KAFKA-8041) Flaky Test LogDirFailureTest#testIOExceptionDuringLogRoll

2024-03-21 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17829625#comment-17829625 ] Igor Soarez commented on KAFKA-8041: cc [~omnia_h_ibrahim] I think this is part of wh

[PR] KAFKA-15853: Move KafkaConfig Replication properties and docs out of … [kafka]

2024-03-21 Thread via GitHub
OmniaGM opened a new pull request, #15575: URL: https://github.com/apache/kafka/pull/15575 part 2 for https://github.com/apache/kafka/pull/15501 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build

Re: [PR] KAFKA-15729: Add KRaft support in GetOffsetShellTest [kafka]

2024-03-21 Thread via GitHub
chia7712 commented on code in PR #15489: URL: https://github.com/apache/kafka/pull/15489#discussion_r1534178664 ## tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java: ## @@ -182,14 +187,19 @@ public void testTopicPartitionsArg() { setUp(); Lis

Re: [PR] KAFKA-15729: Add KRaft support in GetOffsetShellTest [kafka]

2024-03-21 Thread via GitHub
Owen-CH-Leung commented on code in PR #15489: URL: https://github.com/apache/kafka/pull/15489#discussion_r1534175100 ## tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java: ## @@ -182,14 +187,19 @@ public void testTopicPartitionsArg() { setUp();

Re: [PR] KAFKA-15729: Add KRaft support in GetOffsetShellTest [kafka]

2024-03-21 Thread via GitHub
Owen-CH-Leung commented on code in PR #15489: URL: https://github.com/apache/kafka/pull/15489#discussion_r1534168170 ## tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java: ## @@ -338,6 +348,10 @@ private void assertExitCodeIsOne(String... args) { } pr

Re: [PR] KAFKA-15729: Add KRaft support in GetOffsetShellTest [kafka]

2024-03-21 Thread via GitHub
Owen-CH-Leung commented on code in PR #15489: URL: https://github.com/apache/kafka/pull/15489#discussion_r1534166771 ## tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java: ## @@ -182,14 +187,19 @@ public void testTopicPartitionsArg() { setUp();

Re: [PR] KAFKA-15729: Add KRaft support in GetOffsetShellTest [kafka]

2024-03-21 Thread via GitHub
Owen-CH-Leung commented on code in PR #15489: URL: https://github.com/apache/kafka/pull/15489#discussion_r1534165905 ## tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java: ## @@ -104,6 +104,11 @@ public Row(String name, int partition, Long timestamp) {

[jira] [Comment Edited] (KAFKA-8041) Flaky Test LogDirFailureTest#testIOExceptionDuringLogRoll

2024-03-21 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17829605#comment-17829605 ] Igor Soarez edited comment on KAFKA-8041 at 3/21/24 3:30 PM: -

[jira] [Commented] (KAFKA-8041) Flaky Test LogDirFailureTest#testIOExceptionDuringLogRoll

2024-03-21 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17829605#comment-17829605 ] Igor Soarez commented on KAFKA-8041: This failed again in [a PR build|[https://ci-bu

[jira] [Updated] (KAFKA-16342) Fix compressed records

2024-03-21 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-16342: --- Affects Version/s: 3.6.1 3.7.0 > Fix compressed records > ---

[jira] [Updated] (KAFKA-16363) Storage too crashes if dir is unavailable

2024-03-21 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Soarez updated KAFKA-16363: Summary: Storage too crashes if dir is unavailable (was: Storage crashes if dir is unavailable)

[jira] [Updated] (KAFKA-16363) Storage tool crashes if dir is unavailable

2024-03-21 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Soarez updated KAFKA-16363: Summary: Storage tool crashes if dir is unavailable (was: Storage too crashes if dir is unavailab

[jira] [Updated] (KAFKA-16341) Fix un-compressed records

2024-03-21 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-16341: --- Affects Version/s: 3.6.1 3.7.0 > Fix un-compressed records >

Re: [PR] KAFKA-15882: Add nightly docker image scan job [kafka]

2024-03-21 Thread via GitHub
mimaison commented on code in PR #15013: URL: https://github.com/apache/kafka/pull/15013#discussion_r1534135664 ## .github/workflows/docker_scan.yml: ## @@ -0,0 +1,43 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See

[jira] [Assigned] (KAFKA-16363) Storage crashes if dir is unavailable

2024-03-21 Thread Michael Westerby (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Westerby reassigned KAFKA-16363: Assignee: Michael Westerby > Storage crashes if dir is unavailable >

Re: [PR] KAFKA-16273: Update consumer_bench_test.py to use consumer group protocol [kafka]

2024-03-21 Thread via GitHub
lucasbru merged PR #15548: URL: https://github.com/apache/kafka/pull/15548 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] Image test improvements [kafka]

2024-03-21 Thread via GitHub
mimaison commented on PR #15373: URL: https://github.com/apache/kafka/pull/15373#issuecomment-2012481246 @ahuang98 The [last CI](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-15373/3/#showFailuresLink) run for this PR had a lot of test failures. I think if you rebase on trunk

[jira] [Assigned] (KAFKA-16206) KRaftMigrationZkWriter tries to delete deleted topic configs twice

2024-03-21 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison reassigned KAFKA-16206: -- Assignee: Alyssa Huang > KRaftMigrationZkWriter tries to delete deleted topic configs

[jira] [Resolved] (KAFKA-16206) KRaftMigrationZkWriter tries to delete deleted topic configs twice

2024-03-21 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-16206. Fix Version/s: 3.8.0 Resolution: Fixed > KRaftMigrationZkWriter tries to delete del

Re: [PR] KAFKA-16206 Fix unnecessary topic config deletion during ZK migration [kafka]

2024-03-21 Thread via GitHub
mimaison merged PR #14206: URL: https://github.com/apache/kafka/pull/14206 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-16372 Fix producer doc discrepancy with the exception behavior [kafka]

2024-03-21 Thread via GitHub
ocadaruma commented on PR #15574: URL: https://github.com/apache/kafka/pull/15574#issuecomment-2012462011 @showuon Could you take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[PR] KAFKA-16372 Fix producer doc discrepancy with the exception behavior [kafka]

2024-03-21 Thread via GitHub
ocadaruma opened a new pull request, #15574: URL: https://github.com/apache/kafka/pull/15574 - Currently, `Producer.send` doc is inconsistent with actual exception behavior * TimeoutException: This won't be thrown from `send` on buffer-full or metadata-missing actually. Instead, it wil

[PR] KAFKA-15951: MissingSourceTopicException should include topic names [kafka]

2024-03-21 Thread via GitHub
chickenchickenlove opened a new pull request, #15573: URL: https://github.com/apache/kafka/pull/15573 This is minor changes! - Jira : https://issues.apache.org/jira/browse/KAFKA-15951 - `MissingSourceTopicException` has field `missingTopics` to store missing topics. - The `Stre

Re: [PR] MINOR: Use --no-daemon when building with Jenkins [kafka]

2024-03-21 Thread via GitHub
dajac closed pull request #15057: MINOR: Use --no-daemon when building with Jenkins URL: https://github.com/apache/kafka/pull/15057 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] MINOR: Revert to Gradle 8.5 [DO NOT MERGE YET] [kafka]

2024-03-21 Thread via GitHub
jlprat commented on PR #15553: URL: https://github.com/apache/kafka/pull/15553#issuecomment-2012398621 I'm restarting the build. The previous run I started this morning (CET timezone) got hung towards the end (it was running for over 6 hours). -- This is an automated message from the Apac

[PR] KAFKA-15899 Move kafka.security package from core to server module [kafka]

2024-03-21 Thread via GitHub
nizhikov opened a new pull request, #15572: URL: https://github.com/apache/kafka/pull/15572 This PR moves `kafka.security` classes from `core` to `server` module. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test cove

[PR] KAFKA-16393 read/write sequence of buffers correctly [kafka]

2024-03-21 Thread via GitHub
ocadaruma opened a new pull request, #15571: URL: https://github.com/apache/kafka/pull/15571 - In `SslTransportLayer`, both read/write for sequence of buffers stop at index `length`, which isn't correct - Though this isn't causing any bug because the only use of these methods are with ar

Re: [PR] KAFKA-15062: Adding ppc64le build stage [kafka]

2024-03-21 Thread via GitHub
mimaison commented on PR #13817: URL: https://github.com/apache/kafka/pull/13817#issuecomment-2012341540 Instead of directly asking Infra, I think asking on the dev list first might have been better as suggested above. -- This is an automated message from the Apache Git Service. To respo

Re: [PR] KAFKA-16341: [backport] fix the LogValidator for non-compressed type (#15476) [kafka]

2024-03-21 Thread via GitHub
johnnychhsu commented on PR #15570: URL: https://github.com/apache/kafka/pull/15570#issuecomment-2012317972 oops, just remove it, thanks for the comment! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Assigned] (KAFKA-16393) SslTransportLayer doesn't implement write(ByteBuffer[], int, int) correctly

2024-03-21 Thread Haruki Okada (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haruki Okada reassigned KAFKA-16393: Assignee: Haruki Okada > SslTransportLayer doesn't implement write(ByteBuffer[], int, int

[PR] KAFKA-16341: [backport] fix the LogValidator for non-compressed type (#15476) [kafka]

2024-03-21 Thread via GitHub
johnnychhsu opened a new pull request, #15570: URL: https://github.com/apache/kafka/pull/15570 ## Context We have merged the fix for non-compressed type in LogValidator, and we need to backport it to 3.6. Jira: https://issues.apache.org/jira/browse/KAFKA-16341 Previous PR: https://g

Re: [PR] KAFKA-15062: Adding ppc64le build stage [kafka]

2024-03-21 Thread via GitHub
Vaibhav-Nazare commented on PR #13817: URL: https://github.com/apache/kafka/pull/13817#issuecomment-2012193438 @mimaison can you have a loot at it once at the JIRA mentioned in previous comment -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] MINOR: Tuple2 replaced with Map.Entry [kafka]

2024-03-21 Thread via GitHub
chia7712 commented on PR #15560: URL: https://github.com/apache/kafka/pull/15560#issuecomment-2012152816 the failed tests pass on my local ``` ./gradlew cleanTest :tools:test --tests MetadataQuorumCommandTest.testDescribeQuorumReplicationSuccessful --tests MetadataQuorumCommandTest.te

[jira] [Commented] (KAFKA-16136) CoordinatorTest.testTaskRequestWithOldStartMsGetsUpdated() is very flaky

2024-03-21 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17829529#comment-17829529 ] Igor Soarez commented on KAFKA-16136: - This seems to be a dupe of KAFKA-8115 > Coor

[jira] [Assigned] (KAFKA-16397) Use ByteBufferOutputStream to avoid array copy

2024-03-21 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-16397: -- Assignee: Chia Chuan Yu (was: Chia-Ping Tsai) > Use ByteBufferOutputStream to avoid

[jira] [Commented] (KAFKA-16397) Use ByteBufferOutputStream to avoid array copy

2024-03-21 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17829528#comment-17829528 ] Chia-Ping Tsai commented on KAFKA-16397: [~chiacyu] we all love performance impr

[jira] [Commented] (KAFKA-15899) Move kafka.security package from core to server module

2024-03-21 Thread Omnia Ibrahim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17829527#comment-17829527 ] Omnia Ibrahim commented on KAFKA-15899: --- [~nizhikov] sure I just assigned it to yo

[jira] [Assigned] (KAFKA-15899) Move kafka.security package from core to server module

2024-03-21 Thread Omnia Ibrahim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Omnia Ibrahim reassigned KAFKA-15899: - Assignee: Nikolay Izhikov (was: Omnia Ibrahim) > Move kafka.security package from core

[jira] [Commented] (KAFKA-16399) Add JBOD support in tiered storage

2024-03-21 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17829524#comment-17829524 ] Igor Soarez commented on KAFKA-16399: - I see. Your point is that restriction itself

[jira] [Commented] (KAFKA-16397) Use ByteBufferOutputStream to avoid array copy

2024-03-21 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17829519#comment-17829519 ] Apoorv Mittal commented on KAFKA-16397: --- [~chia7712] Yes please, go ahead. > Use

[jira] [Assigned] (KAFKA-16397) Use ByteBufferOutputStream to avoid array copy

2024-03-21 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal reassigned KAFKA-16397: - Assignee: Chia-Ping Tsai > Use ByteBufferOutputStream to avoid array copy > ---

[jira] [Updated] (KAFKA-16399) Add JBOD support in tiered storage

2024-03-21 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-16399: -- Description: Add JBOD support in tiered storage Currently, when JBOD is configured, the Tiered Storag

[jira] [Updated] (KAFKA-16399) Add JBOD support in tiered storage

2024-03-21 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-16399: -- Description: Add JBOD support in tiered storage   was:Add JBOD support in tiered storage > Add J

[jira] [Commented] (KAFKA-16341) Fix un-compressed records

2024-03-21 Thread Johnny Hsu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17829517#comment-17829517 ] Johnny Hsu commented on KAFKA-16341: on it now, thanks for the reminder  > Fix un-c

Re: [PR] KAFKA-16381: add lock for KafkaMetric config getter [kafka]

2024-03-21 Thread via GitHub
johnnychhsu commented on PR #15550: URL: https://github.com/apache/kafka/pull/15550#issuecomment-2012073628 thanks @vamossagar12 @ijuma for the comments. That's a fair point, I agree that a lock is heavy, and `volatile` should be good enough for this. Let me change this, thanks! -- Thi

Re: [PR] KAFKA-15062: Adding ppc64le build stage [kafka]

2024-03-21 Thread via GitHub
Vaibhav-Nazare commented on PR #13817: URL: https://github.com/apache/kafka/pull/13817#issuecomment-2012071722 I have created a JIRA to have the new job configured https://issues.apache.org/jira/browse/INFRA-25631 -- This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (KAFKA-16399) Add JBOD support in tiered storage

2024-03-21 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17829516#comment-17829516 ] Luke Chen commented on KAFKA-16399: --- [~soarez] , currently, when JBOD is configured, t

[jira] [Comment Edited] (KAFKA-16396) Producer use the same Key(string) result in multiple paritition

2024-03-21 Thread ZhenChun Pan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17829462#comment-17829462 ] ZhenChun Pan edited comment on KAFKA-16396 at 3/21/24 11:38 AM: --

  1   2   >