Owen-CH-Leung commented on code in PR #15489:
URL: https://github.com/apache/kafka/pull/15489#discussion_r1537117543
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -47,14 +51,16 @@
import static org.junit.jupiter.api.Assertions.assertTrue;
@Exte
chia7712 commented on PR #15588:
URL: https://github.com/apache/kafka/pull/15588#issuecomment-2017313746
@jeqo Could you please take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
philipnee commented on PR #15525:
URL: https://github.com/apache/kafka/pull/15525#issuecomment-2017309149
Hey @lucasbru - Would it be possible to ask you to review this PR? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
chia7712 commented on code in PR #15489:
URL: https://github.com/apache/kafka/pull/15489#discussion_r1537094676
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -47,14 +51,16 @@
import static org.junit.jupiter.api.Assertions.assertTrue;
@ExtendWit
Owen-CH-Leung commented on code in PR #15489:
URL: https://github.com/apache/kafka/pull/15489#discussion_r1537089434
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -283,7 +318,7 @@ public void testTopicPartitionsArgWithInternalExcluded() {
[
https://issues.apache.org/jira/browse/KAFKA-16410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-16410.
Fix Version/s: 3.8.0
Resolution: Fixed
> kafka-leader-election / LeaderElectionComm
chia7712 commented on PR #15591:
URL: https://github.com/apache/kafka/pull/15591#issuecomment-2017193931
cherry-pick to 3.7. see
https://github.com/apache/kafka/commit/3ea2acf60f2eea31d6ebbb667b8542defb1e6332
--
This is an automated message from the Apache Git Service.
To respond to the m
chia7712 merged PR #15591:
URL: https://github.com/apache/kafka/pull/15591
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 commented on PR #15583:
URL: https://github.com/apache/kafka/pull/15583#issuecomment-2017179316
backport to 3.7 by
https://github.com/apache/kafka/commit/0ebdc37ee7a77b4ef4be4dd8496db8b6b0abcc55
--
This is an automated message from the Apache Git Service.
To respond to the messag
chia7712 merged PR #15583:
URL: https://github.com/apache/kafka/pull/15583
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
dongnuo123 opened a new pull request, #15593:
URL: https://github.com/apache/kafka/pull/15593
Based on #15411, the draft pr currently contains triggering of group
conversion from a classic group to a consumer group.
In `consumerGroupHeartbeat`, the online migration will be triggered i
singhnama closed pull request #15590: KAFKA-15568: Use IncrementalAlterConfigs
API to update the dynamic config of broker in ConfigCommand tool
URL: https://github.com/apache/kafka/pull/15590
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
singhnama commented on PR #15590:
URL: https://github.com/apache/kafka/pull/15590#issuecomment-2017121258
thanks @dajac @ijuma @chia7712. I go through KIP-1011 and it talks about
making the change compatible. and we already have pr
https://github.com/apache/kafka/pull/15304 open for that @d
showuon commented on PR #15586:
URL: https://github.com/apache/kafka/pull/15586#issuecomment-2017024206
@FrankYang0529 , have you confirmed all DeleteRecordsCommand-tests passed in
your local env? In the 1st run, all 4 CI jobs failed with exit code 1. I've
re-run it. But it'd be good if you
gharris1727 commented on PR #15484:
URL: https://github.com/apache/kafka/pull/15484#issuecomment-2016931320
Hi @ijuma @rondagostino @dajac @showuon @C0urante PTAL at this change in
semantics of the Exit class.
I think this is the quickest way to resolve these build failures, but could
wernerdv opened a new pull request, #15592:
URL: https://github.com/apache/kafka/pull/15592
The method CommandLineUtils#maybePrintHelpOrVersion is called before
checking the required arguments.
Сurrent status:
`$ ./bin/kafka-consumer-groups.sh --version
Missing required argument
ijuma commented on PR #15590:
URL: https://github.com/apache/kafka/pull/15590#issuecomment-2016883334
As David said, we decided it was best to go the KIP route. And because 4.0
is around the corner, it's a good release vehicle to make the incompatible
change.
--
This is an automated mess
dajac commented on PR #15590:
URL: https://github.com/apache/kafka/pull/15590#issuecomment-2016859531
Thanks for the PR. There is actually a KIP for this change: KIP-1011: Use
incrementalAlterConfigs when updating broker configs by kafka-configs.sh. Are
you aware of it? cc @dengziming
--
chia7712 commented on code in PR #15589:
URL: https://github.com/apache/kafka/pull/15589#discussion_r1536848215
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryUtils.java:
##
@@ -204,16 +202,14 @@ public static byte[] compress(byte[] raw, Comp
brandboat commented on code in PR #15589:
URL: https://github.com/apache/kafka/pull/15589#discussion_r1536846618
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryUtils.java:
##
@@ -204,16 +202,14 @@ public static byte[] compress(byte[] raw, Com
[
https://issues.apache.org/jira/browse/KAFKA-16415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dmitry Werner updated KAFKA-16415:
--
Summary: Fix handling of "--version" option in ConsumerGroupCommand (was:
Fix handling "--ver
[
https://issues.apache.org/jira/browse/KAFKA-16415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dmitry Werner updated KAFKA-16415:
--
Summary: Fix ConsumerGroupCommand (was: Make sure all subclass of
CommandDefaultOptions can p
[
https://issues.apache.org/jira/browse/KAFKA-16415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dmitry Werner updated KAFKA-16415:
--
Summary: Fix handling "--version" option in ConsumerGroupCommand (was: Fix
ConsumerGroupComma
chiacyu commented on code in PR #15589:
URL: https://github.com/apache/kafka/pull/15589#discussion_r1536831206
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryUtils.java:
##
@@ -203,20 +201,19 @@ public static byte[] compress(byte[] raw, Compr
chiacyu commented on code in PR #15589:
URL: https://github.com/apache/kafka/pull/15589#discussion_r1536831097
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryUtils.java:
##
@@ -203,20 +201,19 @@ public static byte[] compress(byte[] raw, Compr
chia7712 commented on code in PR #15589:
URL: https://github.com/apache/kafka/pull/15589#discussion_r1536830823
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryUtils.java:
##
@@ -204,17 +202,16 @@ public static byte[] compress(byte[] raw, Comp
[
https://issues.apache.org/jira/browse/KAFKA-16415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17830258#comment-17830258
]
Chia-Ping Tsai commented on KAFKA-16415:
{quote}
I found only one issue that nee
brandboat commented on PR #15591:
URL: https://github.com/apache/kafka/pull/15591#issuecomment-2016826818
> Can you change the line#291 (
https://github.com/apache/kafka/blob/trunk/tools/src/test/java/org/apache/kafka/tools/LeaderElectionCommandTest.java#L291)
to use mainNoExit instead o
[
https://issues.apache.org/jira/browse/KAFKA-16415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17830255#comment-17830255
]
Dmitry Werner commented on KAFKA-16415:
---
[~chia7712] during the checking, I found
[
https://issues.apache.org/jira/browse/KAFKA-16415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17830252#comment-17830252
]
Chia-Ping Tsai commented on KAFKA-16415:
[~javakillah] thanks for doing the doub
[
https://issues.apache.org/jira/browse/KAFKA-16415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-16415:
---
Description:
grep the code base and it seems following tools does not process "--help" and
[
https://issues.apache.org/jira/browse/KAFKA-16415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17830251#comment-17830251
]
Dmitry Werner edited comment on KAFKA-16415 at 3/24/24 1:23 PM:
--
[
https://issues.apache.org/jira/browse/KAFKA-16415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17830251#comment-17830251
]
Dmitry Werner edited comment on KAFKA-16415 at 3/24/24 1:22 PM:
--
[
https://issues.apache.org/jira/browse/KAFKA-16415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17830251#comment-17830251
]
Dmitry Werner commented on KAFKA-16415:
---
[~chia7712] I have checked that the follo
chia7712 commented on PR #15583:
URL: https://github.com/apache/kafka/pull/15583#issuecomment-2016801661
```sh
./gradlew cleanTest :tools:test --tests
MetadataQuorumCommandTest.testDescribeQuorumReplicationSuccessful --tests
MetadataQuorumCommandTest.testDescribeQuorumStatusSuccessful --
[
https://issues.apache.org/jira/browse/KAFKA-16415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dmitry Werner reassigned KAFKA-16415:
-
Assignee: Dmitry Werner
> Make sure all subclass of CommandDefaultOptions can process "
wernerdv commented on PR #15583:
URL: https://github.com/apache/kafka/pull/15583#issuecomment-2016799378
> @wernerdv could you please attach the new console output from
`./bin/kafka-get-offsets.sh --version`
Yes, sure.
```
./bin/kafka-get-offsets.sh --version
3.8.0-SNAPSHOT
Chia-Ping Tsai created KAFKA-16415:
--
Summary: Make sure all subclass of CommandDefaultOptions can
process "--help" and "–version"
Key: KAFKA-16415
URL: https://issues.apache.org/jira/browse/KAFKA-16415
chia7712 commented on PR #15583:
URL: https://github.com/apache/kafka/pull/15583#issuecomment-2016793739
@wernerdv could you please attach the new console output from
`./bin/kafka-get-offsets.sh --version`
--
This is an automated message from the Apache Git Service.
To respond to the mess
chia7712 commented on PR #15553:
URL: https://github.com/apache/kafka/pull/15553#issuecomment-2016789588
> Open kafka.admin.AclCommandTest in IntelliJ Idea. I'm using 2023.3.5
Ultimate
Add println("a") at the beginning of testAclCliWithAuthorizer method
Run in terminal: ./gradl
chia7712 commented on PR #15590:
URL: https://github.com/apache/kafka/pull/15590#issuecomment-2016780811
> are we saying this because incrementalAlterConfigs was introduced in
(2.3.0)?
yep
> Would it be the case that someone running with older Kafka (2.3.0-) and
using the up
singhnama commented on PR #15590:
URL: https://github.com/apache/kafka/pull/15590#issuecomment-2016777066
> just curious. Are we going to remove the support from older kafka server?
The PR is great but users will be unable to use the tool (3.8.0) to operate the
older kafak (2.3.0-).
than
chiacyu commented on code in PR #15589:
URL: https://github.com/apache/kafka/pull/15589#discussion_r1536789689
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryUtils.java:
##
@@ -203,17 +201,13 @@ public static byte[] compress(byte[] raw, Compr
chia7712 commented on code in PR #15589:
URL: https://github.com/apache/kafka/pull/15589#discussion_r1536789605
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryUtils.java:
##
@@ -203,17 +201,17 @@ public static byte[] compress(byte[] raw, Comp
brandboat opened a new pull request, #15591:
URL: https://github.com/apache/kafka/pull/15591
https://issues.apache.org/jira/browse/KAFKA-16410
as title, set exit code on error in LeaderElectionCommand.java
### Committer Checklist (excluded from commit message)
- [ ] Verify de
chia7712 commented on code in PR #15589:
URL: https://github.com/apache/kafka/pull/15589#discussion_r1536789020
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryUtils.java:
##
@@ -203,20 +201,19 @@ public static byte[] compress(byte[] raw, Comp
chia7712 commented on PR #15590:
URL: https://github.com/apache/kafka/pull/15590#issuecomment-2016768386
just curious. Are we going to remove the support from older kafka server?
The PR is great but users will be unable to use the tool (3.8.0) to operate the
older kafak (2.3.0-).
I
singhnama opened a new pull request, #15590:
URL: https://github.com/apache/kafka/pull/15590
**What**
Use IncrementalAlterConfigs API to update the dynamic config of the broker
in the ConfigCommand tool.
**Why**
As part of [this
KIP](https://cwiki.apache.org/confluence/display/
chia7712 commented on code in PR #15589:
URL: https://github.com/apache/kafka/pull/15589#discussion_r1536784932
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryUtils.java:
##
@@ -203,17 +201,13 @@ public static byte[] compress(byte[] raw, Comp
[
https://issues.apache.org/jira/browse/KAFKA-16410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kuan Po Tseng reassigned KAFKA-16410:
-
Assignee: Kuan Po Tseng
> kafka-leader-election / LeaderElectionCommand doesn't set exi
[
https://issues.apache.org/jira/browse/KAFKA-16410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17830243#comment-17830243
]
Kuan Po Tseng commented on KAFKA-16410:
---
Hi [~gharris1727] , I'm willing to take o
[
https://issues.apache.org/jira/browse/KAFKA-16414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17830241#comment-17830241
]
Chia-Ping Tsai commented on KAFKA-16414:
[~brandboat] thanks for opening this ji
[
https://issues.apache.org/jira/browse/KAFKA-16385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17830230#comment-17830230
]
Kuan Po Tseng commented on KAFKA-16385:
---
Gentle ping [~chia7712], [~jeqo]. I've fi
Kuan Po Tseng created KAFKA-16414:
-
Summary: Inconsistent active segment expiration behavior between
retention.ms and retention.bytes
Key: KAFKA-16414
URL: https://issues.apache.org/jira/browse/KAFKA-16414
54 matches
Mail list logo
