[jira] [Commented] (KAFKA-16356) Remove class-name dispatch in RemoteLogMetadataSerde

2024-03-25 Thread Linu Shibu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830781#comment-17830781 ] Linu Shibu commented on KAFKA-16356: Yes [~yondy] , I will update this soon, thanks! > Remove

Re: [PR] MINOR: add docker usage documentation link in README.md [kafka]

2024-03-25 Thread via GitHub
showuon commented on code in PR #15600: URL: https://github.com/apache/kafka/pull/15600#discussion_r1538541164 ## README.md: ## @@ -285,6 +285,16 @@ See [tests/README.md](tests/README.md). See [vagrant/README.md](vagrant/README.md). +### Running in Docker ### +You could

Re: [PR] KAFKA-16416: Use NetworkClientTest to replace RequestResponseTest to be the example of log4j output [kafka]

2024-03-25 Thread via GitHub
showuon commented on code in PR #15596: URL: https://github.com/apache/kafka/pull/15596#discussion_r1538537571 ## README.md: ## @@ -56,7 +56,11 @@ Follow instructions in https://kafka.apache.org/quickstart ### Running a particular unit/integration test with log4j output ###

Re: [PR] KAFKA-15949: Unify metadata.version format in log and error message [kafka]

2024-03-25 Thread via GitHub
showuon commented on PR #15505: URL: https://github.com/apache/kafka/pull/15505#issuecomment-2019263725 Re-running CI build: https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-15505/6/ -- This is an automated message from the Apache Git Service. To respond to the message, please

[PR] MINOR: add docker usage documentation link in README.md [kafka]

2024-03-25 Thread via GitHub
KevinZTW opened a new pull request, #15600: URL: https://github.com/apache/kafka/pull/15600 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

Re: [PR] KAFKA-16385: Enhance documentation for retention.ms and retention.bytes configurations [kafka]

2024-03-25 Thread via GitHub
brandboat commented on code in PR #15588: URL: https://github.com/apache/kafka/pull/15588#discussion_r1538483814 ## clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java: ## @@ -67,13 +67,17 @@ public class TopicConfig { "(which consists of log

Re: [PR] KAFKA-16385: Enhance documentation for retention.ms and retention.bytes configurations [kafka]

2024-03-25 Thread via GitHub
brandboat commented on code in PR #15588: URL: https://github.com/apache/kafka/pull/15588#discussion_r1538478333 ## clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java: ## @@ -67,13 +67,17 @@ public class TopicConfig { "(which consists of log

Re: [PR] KAFKA-16385: Enhance documentation for retention.ms and retention.bytes configurations [kafka]

2024-03-25 Thread via GitHub
brandboat commented on code in PR #15588: URL: https://github.com/apache/kafka/pull/15588#discussion_r1538478333 ## clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java: ## @@ -67,13 +67,17 @@ public class TopicConfig { "(which consists of log

Re: [PR] KAFKA-16385: Enhance documentation for retention.ms and retention.bytes configurations [kafka]

2024-03-25 Thread via GitHub
brandboat commented on code in PR #15588: URL: https://github.com/apache/kafka/pull/15588#discussion_r1538478333 ## clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java: ## @@ -67,13 +67,17 @@ public class TopicConfig { "(which consists of log

Re: [PR] KAFKA-16323: fix testRemoteFetchExpiresPerSecMetric [kafka]

2024-03-25 Thread via GitHub
showuon commented on code in PR #15463: URL: https://github.com/apache/kafka/pull/15463#discussion_r1538452997 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -4164,16 +4164,13 @@ class ReplicaManagerTest { mock(classOf[FetchDataInfo])

[jira] [Resolved] (KAFKA-16409) kafka-delete-records / DeleteRecordsCommand should use standard exception handling

2024-03-25 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-16409. --- Fix Version/s: 3.8.0 Resolution: Fixed > kafka-delete-records / DeleteRecordsCommand should

Re: [PR] KAFKA-16409: DeleteRecordsCommand should use standard exception handling [kafka]

2024-03-25 Thread via GitHub
showuon merged PR #15586: URL: https://github.com/apache/kafka/pull/15586 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16409: DeleteRecordsCommand should use standard exception handling [kafka]

2024-03-25 Thread via GitHub
showuon commented on PR #15586: URL: https://github.com/apache/kafka/pull/15586#issuecomment-2019187474 Failed tests are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (KAFKA-15265) Remote copy/fetch quotas for tiered storage.

2024-03-25 Thread Henry Cai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830734#comment-17830734 ] Henry Cai commented on KAFKA-15265: --- How is the progress of this tiered storage quota work?  We are

[jira] [Commented] (KAFKA-16240) Flaky test PlaintextAdminIntegrationTest.testReplicaCanFetchFromLogStartOffsetAfterDeleteRecords(String).quorum=kraft

2024-03-25 Thread Zhiyuan Lei (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830733#comment-17830733 ] Zhiyuan Lei commented on KAFKA-16240: -   ``` TimeUnit.MILLISECONDS.sleep(1) val result1 =

Re: [PR] KAFKA-16272: Update connect_distributed_test.py to support KIP-848’s group protocol config [kafka]

2024-03-25 Thread via GitHub
philipnee commented on PR #15576: URL: https://github.com/apache/kafka/pull/15576#issuecomment-2019090272 @kirktrue @lucasbru - mind taking a second look? For this specific PR I only modified the tests using console consumer that's why several tests cases were omitted. -- This is an

Re: [PR] KAFKA-16272: Adding new coordinator related changes for connect_distributed.py [kafka]

2024-03-25 Thread via GitHub
philipnee commented on code in PR #15594: URL: https://github.com/apache/kafka/pull/15594#discussion_r1538356233 ## tests/kafkatest/services/connect.py: ## @@ -534,33 +535,40 @@ def received_messages(self): def start(self): self.logger.info("Creating connector

Re: [PR] KAFKA-16386: Convert NETWORK_EXCEPTIONs from KIP-890 transaction verification [kafka]

2024-03-25 Thread via GitHub
jolshan merged PR #15559: URL: https://github.com/apache/kafka/pull/15559 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16386: Convert NETWORK_EXCEPTIONs from KIP-890 transaction verification [kafka]

2024-03-25 Thread via GitHub
jolshan commented on PR #15559: URL: https://github.com/apache/kafka/pull/15559#issuecomment-2019067710

[jira] [Commented] (KAFKA-14089) Flaky ExactlyOnceSourceIntegrationTest.testSeparateOffsetsTopic

2024-03-25 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830728#comment-17830728 ] Justine Olshan commented on KAFKA-14089: I've seen this again as well.

[jira] [Commented] (KAFKA-15914) Flaky test - testAlterSinkConnectorOffsetsOverriddenConsumerGroupId - OffsetsApiIntegrationTest

2024-03-25 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830727#comment-17830727 ] Justine Olshan commented on KAFKA-15914: I'm seeing this as well. 

[PR] KAFKA-16200: Enforce that RequestManager implementations respect user-provided timeout [kafka]

2024-03-25 Thread via GitHub
kirktrue opened a new pull request, #15599: URL: https://github.com/apache/kafka/pull/15599 WIP ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including

Re: [PR] KAFKA-16084: Simplify and deduplicate standalone herder test mocking [kafka]

2024-03-25 Thread via GitHub
gharris1727 commented on code in PR #15389: URL: https://github.com/apache/kafka/pull/15389#discussion_r1538282799 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java: ## @@ -115,64 +115,61 @@ public class StandaloneHerderTest

Re: [PR] KAFKA-16156: beginningOrEndOffsets does not need to build an OffsetAndTimestamps object upon completion [kafka]

2024-03-25 Thread via GitHub
philipnee commented on PR #15525: URL: https://github.com/apache/kafka/pull/15525#issuecomment-2018886221 Hey @lucasbru - Thanks for taking the time to review this PR. Let me know if there's anything to add to the PR. -- This is an automated message from the Apache Git Service. To

Re: [PR] KAFKA-16156: beginningOrEndOffsets does not need to build an OffsetAndTimestamps object upon completion [kafka]

2024-03-25 Thread via GitHub
philipnee commented on code in PR #15525: URL: https://github.com/apache/kafka/pull/15525#discussion_r1538195311 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/OffsetsRequestManager.java: ## @@ -423,11 +432,11 @@ private CompletableFuture

Re: [PR] KAFKA-15538: Client support for java regex based subscription [kafka]

2024-03-25 Thread via GitHub
lianetm commented on PR #15585: URL: https://github.com/apache/kafka/pull/15585#issuecomment-2018835239 Hey @Phuc-Hong-Tran , thanks a lot for the PR! I had a first pass and left some comments. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] KAFKA-16385: Enhance documentation for retention.ms and retention.bytes configurations [kafka]

2024-03-25 Thread via GitHub
soarez commented on code in PR #15588: URL: https://github.com/apache/kafka/pull/15588#discussion_r1538177857 ## clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java: ## @@ -67,13 +67,17 @@ public class TopicConfig { "(which consists of log segments)

Re: [PR] KAFKA-15538: Client support for java regex based subscription [kafka]

2024-03-25 Thread via GitHub
lianetm commented on code in PR #15585: URL: https://github.com/apache/kafka/pull/15585#discussion_r1538180339 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1667,6 +1667,9 @@ private void

Re: [PR] KAFKA-15538: Client support for java regex based subscription [kafka]

2024-03-25 Thread via GitHub
lianetm commented on code in PR #15585: URL: https://github.com/apache/kafka/pull/15585#discussion_r1538173798 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -550,6 +550,11 @@ public ConsumerGroupHeartbeatRequestData

[jira] [Comment Edited] (KAFKA-16344) Internal topic mm2-offset-syncsinternal created with single partition is putting more load on the broker

2024-03-25 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830685#comment-17830685 ] Greg Harris edited comment on KAFKA-16344 at 3/25/24 8:06 PM: -- Hi

[jira] [Commented] (KAFKA-16344) Internal topic mm2-offset-syncsinternal created with single partition is putting more load on the broker

2024-03-25 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830685#comment-17830685 ] Greg Harris commented on KAFKA-16344: - Hi [~janardhanag] Yes, you should consider increasing

[jira] [Closed] (KAFKA-16224) Fix handling of deleted topic when auto-committing before revocation

2024-03-25 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna closed KAFKA-16224. - > Fix handling of deleted topic when auto-committing before revocation >

Re: [PR] KAFKA-16224: Do not retry committing if topic or partition deleted [kafka]

2024-03-25 Thread via GitHub
cadonna merged PR #15581: URL: https://github.com/apache/kafka/pull/15581 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15538: Client support for java regex based subscription [kafka]

2024-03-25 Thread via GitHub
lianetm commented on code in PR #15585: URL: https://github.com/apache/kafka/pull/15585#discussion_r1538161659 ## core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala: ## @@ -433,7 +433,7 @@ class PlaintextConsumerTest extends BaseConsumerTest { */ //

Re: [PR] KAFKA-16224: Do not retry committing if topic or partition deleted [kafka]

2024-03-25 Thread via GitHub
cadonna commented on PR #15581: URL: https://github.com/apache/kafka/pull/15581#issuecomment-2018802319 Build failures are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] KAFKA-15538: Client support for java regex based subscription [kafka]

2024-03-25 Thread via GitHub
lianetm commented on code in PR #15585: URL: https://github.com/apache/kafka/pull/15585#discussion_r1538161334 ## core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala: ## @@ -374,7 +374,7 @@ class PlaintextConsumerTest extends BaseConsumerTest { */ //

Re: [PR] KAFKA-15538: Client support for java regex based subscription [kafka]

2024-03-25 Thread via GitHub
lianetm commented on code in PR #15585: URL: https://github.com/apache/kafka/pull/15585#discussion_r1538158322 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1750,8 +1753,14 @@ private void subscribeInternal(Pattern pattern,

[jira] [Updated] (KAFKA-16420) Add thread-safe alternative to utils.Exit

2024-03-25 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-16420: Summary: Add thread-safe alternative to utils.Exit (was: Replace utils.Exit with a thread-safe

[jira] [Updated] (KAFKA-16294) Add group protocol migration enabling config

2024-03-25 Thread Dongnuo Lyu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dongnuo Lyu updated KAFKA-16294: Description: The online upgrade is triggered when a consumer group heartbeat request is received

Re: [PR] KAFKA-16411: Correctly migrate default client quota entities [kafka]

2024-03-25 Thread via GitHub
cmccabe commented on PR #15584: URL: https://github.com/apache/kafka/pull/15584#issuecomment-2018746846 > I don't think it's a good idea to introduce the new terms mangling & unmangling when there are already equivalent terms in the codebase – sanitizing/desanitizing – it makes it

[jira] [Updated] (KAFKA-16294) Add group protocol migration enabling config

2024-03-25 Thread Dongnuo Lyu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dongnuo Lyu updated KAFKA-16294: Description: The online upgrade is triggered when a consumer group heartbeat request is received

Re: [PR] KAFKA-16084: Simplify and deduplicate standalone herder test mocking [kafka]

2024-03-25 Thread via GitHub
ahmedsobeh commented on code in PR #15389: URL: https://github.com/apache/kafka/pull/15389#discussion_r1538122992 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java: ## @@ -726,21 +683,21 @@ public void testAccessors() throws

Re: [PR] KAFKA-16411: Correctly migrate default client quota entities [kafka]

2024-03-25 Thread via GitHub
cmccabe commented on code in PR #15584: URL: https://github.com/apache/kafka/pull/15584#discussion_r1538115580 ## core/src/main/scala/kafka/zk/migration/ZkConfigMigrationClient.scala: ## @@ -50,44 +51,54 @@ class ZkConfigMigrationClient( val adminZkClient = new

Re: [PR] KAFKA-16411: Correctly migrate default client quota entities [kafka]

2024-03-25 Thread via GitHub
cmccabe commented on code in PR #15584: URL: https://github.com/apache/kafka/pull/15584#discussion_r1538115580 ## core/src/main/scala/kafka/zk/migration/ZkConfigMigrationClient.scala: ## @@ -50,44 +51,54 @@ class ZkConfigMigrationClient( val adminZkClient = new

Re: [PR] KAFKA-16148: Implement GroupMetadataManager#onUnloaded [kafka]

2024-03-25 Thread via GitHub
jeffkbkim commented on PR #15446: URL: https://github.com/apache/kafka/pull/15446#issuecomment-2018694290 thanks @dajac. I have addressed your comments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Assigned] (KAFKA-16200) Enforce that RequestManager implementations respect user-provided timeout

2024-03-25 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-16200: - Assignee: Kirk True (was: Bruno Cadonna) > Enforce that RequestManager implementations

[PR] KAFKA-16420: Add instance methods to Exit to replace static methods [kafka]

2024-03-25 Thread via GitHub
gharris1727 opened a new pull request, #15598: URL: https://github.com/apache/kafka/pull/15598 This adds a thread-safe alternative to the current Exit implementation, which doesn't make use of static mutable fields. This solves a number of problems: 1. Thread isolation: Two tests

Re: [PR] KAFKA-7663: Reprocessing on user added global stores restore [kafka]

2024-03-25 Thread via GitHub
wcarlson5 commented on code in PR #15414: URL: https://github.com/apache/kafka/pull/15414#discussion_r1538043755 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java: ## @@ -236,6 +252,91 @@ private List topicPartitionsForStore(final

[jira] [Updated] (KAFKA-16160) AsyncKafkaConsumer is trying to connect to a disconnected node in a tight loop

2024-03-25 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16160: -- Priority: Blocker (was: Major) > AsyncKafkaConsumer is trying to connect to a disconnected node in a

[jira] [Updated] (KAFKA-15250) ConsumerNetworkThread is running tight loop

2024-03-25 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15250: -- Priority: Critical (was: Blocker) > ConsumerNetworkThread is running tight loop >

[jira] [Resolved] (KAFKA-15950) Serialize broker heartbeat requests

2024-03-25 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-15950. - Fix Version/s: 3.8.0 Resolution: Fixed merged the PR to trunk. > Serialize broker heartbeat

Re: [PR] KAFKA-15950: Serialize broker heartbeat requests [kafka]

2024-03-25 Thread via GitHub
junrao merged PR #14903: URL: https://github.com/apache/kafka/pull/14903 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (KAFKA-15250) ConsumerNetworkThread is running tight loop

2024-03-25 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15250: -- Priority: Blocker (was: Major) > ConsumerNetworkThread is running tight loop >

Re: [PR] KAFKA-15950: Serialize broker heartbeat requests [kafka]

2024-03-25 Thread via GitHub
junrao commented on PR #14903: URL: https://github.com/apache/kafka/pull/14903#issuecomment-2018530584 @soarez : Thanks for triaging the test failures. Will merge the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Assigned] (KAFKA-16271) Update consumer_rolling_upgrade_test.py to support KIP-848’s group protocol config

2024-03-25 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-16271: - Assignee: Philip Nee > Update consumer_rolling_upgrade_test.py to support KIP-848’s group

Re: [PR] KAFKA-15950: Serialize broker heartbeat requests [kafka]

2024-03-25 Thread via GitHub
soarez commented on PR #14903: URL: https://github.com/apache/kafka/pull/14903#issuecomment-2018506864 @junrao all the failed tests are being tracked. These were already tracked: * KAFKA-8041 kafka.server.LogDirFailureTest.testIOExceptionDuringCheckpoint(String).quorum=kraft

[jira] [Created] (KAFKA-16422) Flaky test org.apache.kafka.controller.QuorumControllerMetricsIntegrationTest."testFailingOverIncrementsNewActiveControllerCount(boolean).true"

2024-03-25 Thread Igor Soarez (Jira)
Igor Soarez created KAFKA-16422: --- Summary: Flaky test org.apache.kafka.controller.QuorumControllerMetricsIntegrationTest."testFailingOverIncrementsNewActiveControllerCount(boolean).true" Key: KAFKA-16422 URL:

[jira] [Resolved] (KAFKA-14246) Update threading model for Consumer

2024-03-25 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True resolved KAFKA-14246. --- Resolution: Fixed > Update threading model for Consumer > --- > >

[jira] [Commented] (KAFKA-16420) Replace utils.Exit with a thread-safe alternative

2024-03-25 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830603#comment-17830603 ] Greg Harris commented on KAFKA-16420: - I can't find a single ticket for "Remove Zookeeper", but I

[jira] [Created] (KAFKA-16421) Refactor CommandDefaultOptions subclasses to throw exceptions instead of calling exit.

2024-03-25 Thread Greg Harris (Jira)
Greg Harris created KAFKA-16421: --- Summary: Refactor CommandDefaultOptions subclasses to throw exceptions instead of calling exit. Key: KAFKA-16421 URL: https://issues.apache.org/jira/browse/KAFKA-16421

[jira] [Commented] (KAFKA-16349) ShutdownableThread fails build by calling Exit with race condition

2024-03-25 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830590#comment-17830590 ] Greg Harris commented on KAFKA-16349: - I added a tactical fix for the Exit class in my PR to resolve

Re: [PR] KAFKA-15853: Move KafkaConfig Replication properties and docs out of … [kafka]

2024-03-25 Thread via GitHub
OmniaGM commented on PR #15575: URL: https://github.com/apache/kafka/pull/15575#issuecomment-2018444788 > Hello @AndrewJSchofield @OmniaGM > > Looks like dependency on server tests not required but introduced in this PR. I have plans to double check this after minor comment in #15569

[jira] [Created] (KAFKA-16420) Replace utils.Exit with a thread-safe alternative

2024-03-25 Thread Greg Harris (Jira)
Greg Harris created KAFKA-16420: --- Summary: Replace utils.Exit with a thread-safe alternative Key: KAFKA-16420 URL: https://issues.apache.org/jira/browse/KAFKA-16420 Project: Kafka Issue Type:

Re: [PR] KAFKA-16386: Convert NETWORK_EXCEPTIONs from KIP-890 transaction verification [kafka]

2024-03-25 Thread via GitHub
jolshan commented on PR #15559: URL: https://github.com/apache/kafka/pull/15559#issuecomment-2018411363 Getting a fresh build before merging  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (KAFKA-16398) mirror-maker2 running into OOM while filtering (dropping) high number of messages

2024-03-25 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830576#comment-17830576 ] Greg Harris commented on KAFKA-16398: - Hi [~srivignesh] Thank you for providing your configuration.

Re: [PR] KAFKA-15950: Serialize broker heartbeat requests [kafka]

2024-03-25 Thread via GitHub
junrao commented on PR #14903: URL: https://github.com/apache/kafka/pull/14903#issuecomment-2018408733 @soarez : Are the failed tests in the latest run being tracked? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] KAFKA-15949: Unify metadata.version format in log and error message [kafka]

2024-03-25 Thread via GitHub
FrankYang0529 commented on PR #15505: URL: https://github.com/apache/kafka/pull/15505#issuecomment-2018399116 > @FrankYang0529 , there are some tests failing because of your change. Please take a look. Thanks. > > https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-15505/4

[PR] MINOR: AbstractConfig cleanup [kafka]

2024-03-25 Thread via GitHub
gharris1727 opened a new pull request, #15597: URL: https://github.com/apache/kafka/pull/15597 Add Utils.castToStringObjectMap and fix unchecked casts in AbstractConfig ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify

[jira] [Updated] (KAFKA-16419) Abstract validateMessagesAndAssignOffsetsCompressed of LogValidator to simply the process

2024-03-25 Thread Johnny Hsu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johnny Hsu updated KAFKA-16419: --- Description: Currently in the

[jira] [Updated] (KAFKA-16419) Abstract validateMessagesAndAssignOffsetsCompressed of LogValidator to simply the process

2024-03-25 Thread Johnny Hsu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johnny Hsu updated KAFKA-16419: --- Description: Currently in the

Re: [PR] KAFKA-16409: DeleteRecordsCommand should use standard exception handling [kafka]

2024-03-25 Thread via GitHub
FrankYang0529 commented on PR #15586: URL: https://github.com/apache/kafka/pull/15586#issuecomment-2018334375 > Failed with the same error again. Please help fix the errors. Thanks. Sorry, I will double check test result before creating a PR next time. I have updated the case. Thank

[jira] [Updated] (KAFKA-16419) Abstract validateMessagesAndAssignOffsetsCompressed of LogValidator to simply the process

2024-03-25 Thread Johnny Hsu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johnny Hsu updated KAFKA-16419: --- Description: Currently in the LogValidator.validateMessagesAndAssignOffsetsCompressed, there are

[jira] [Created] (KAFKA-16419) Abstract validateMessagesAndAssignOffsetsCompressed of LogValidator to simply the process

2024-03-25 Thread Johnny Hsu (Jira)
Johnny Hsu created KAFKA-16419: -- Summary: Abstract validateMessagesAndAssignOffsetsCompressed of LogValidator to simply the process Key: KAFKA-16419 URL: https://issues.apache.org/jira/browse/KAFKA-16419

Re: [PR] KAFKA-16156: beginningOrEndOffsets does not need to build an OffsetAndTimestamps object upon completion [kafka]

2024-03-25 Thread via GitHub
philipnee commented on code in PR #15525: URL: https://github.com/apache/kafka/pull/15525#discussion_r1537804695 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -411,8 +411,8 @@ public int memberEpoch() { public void

[jira] [Commented] (KAFKA-16318) Add javadoc to KafkaMetric

2024-03-25 Thread Johnny Hsu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830539#comment-17830539 ] Johnny Hsu commented on KAFKA-16318: the PR is merged, close this ticket > Add javadoc to

Re: [PR] MINOR: optimize EvictableKey/LastUsedKey compareTo function [kafka]

2024-03-25 Thread via GitHub
chia7712 closed pull request #9725: MINOR: optimize EvictableKey/LastUsedKey compareTo function URL: https://github.com/apache/kafka/pull/9725 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] MINOR: add comments to explain why it needs to add synchronization on… [kafka]

2024-03-25 Thread via GitHub
chia7712 closed pull request #9517: MINOR: add comments to explain why it needs to add synchronization on… URL: https://github.com/apache/kafka/pull/9517 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] KAFKA-10234 The key/value deserializer used by ConsoleConsumer is not… [kafka]

2024-03-25 Thread via GitHub
chia7712 closed pull request #8978: KAFKA-10234 The key/value deserializer used by ConsoleConsumer is not… URL: https://github.com/apache/kafka/pull/8978 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] KAFKA-10498 Consumer should do offset/epoch validation through when … [kafka]

2024-03-25 Thread via GitHub
chia7712 closed pull request #9796: KAFKA-10498 Consumer should do offset/epoch validation through when … URL: https://github.com/apache/kafka/pull/9796 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] MINOR: apply FilterByKeyIterator and FlattenedIterator to code base [kafka]

2024-03-25 Thread via GitHub
chia7712 closed pull request #9954: MINOR: apply FilterByKeyIterator and FlattenedIterator to code base URL: https://github.com/apache/kafka/pull/9954 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] MINOR: fix the soft link created by ducktape when running system test… [kafka]

2024-03-25 Thread via GitHub
chia7712 closed pull request #9798: MINOR: fix the soft link created by ducktape when running system test… URL: https://github.com/apache/kafka/pull/9798 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] MINOR: Convert connect assignment schemas to use generated protocol [kafka]

2024-03-25 Thread via GitHub
chia7712 closed pull request #9641: MINOR: Convert connect assignment schemas to use generated protocol URL: https://github.com/apache/kafka/pull/9641 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] KAFKA-12410 KafkaAPis ought to group fetch data before generating fet… [kafka]

2024-03-25 Thread via GitHub
chia7712 closed pull request #10269: KAFKA-12410 KafkaAPis ought to group fetch data before generating fet… URL: https://github.com/apache/kafka/pull/10269 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] MINOR: KRPC supports to get true type from entity type [kafka]

2024-03-25 Thread via GitHub
chia7712 closed pull request #10283: MINOR: KRPC supports to get true type from entity type URL: https://github.com/apache/kafka/pull/10283 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] MINOR: using INFO level to log 'no meta.properties' for broker server [kafka]

2024-03-25 Thread via GitHub
chia7712 closed pull request #10261: MINOR: using INFO level to log 'no meta.properties' for broker server URL: https://github.com/apache/kafka/pull/10261 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] MINOR: main function of o.a.k.c.p.t.Type does not show all types [kafka]

2024-03-25 Thread via GitHub
chia7712 closed pull request #10248: MINOR: main function of o.a.k.c.p.t.Type does not show all types URL: https://github.com/apache/kafka/pull/10248 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] KAFKA-12309 The revocation algorithm produces uneven distributions [kafka]

2024-03-25 Thread via GitHub
chia7712 closed pull request #10077: KAFKA-12309 The revocation algorithm produces uneven distributions URL: https://github.com/apache/kafka/pull/10077 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] MINOR: check duplicate advertised listeners based on resolved host [kafka]

2024-03-25 Thread via GitHub
chia7712 closed pull request #10577: MINOR: check duplicate advertised listeners based on resolved host URL: https://github.com/apache/kafka/pull/10577 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] MINOR: remove partition-level error from MetadataResponse#errorCounts [kafka]

2024-03-25 Thread via GitHub
chia7712 closed pull request #11128: MINOR: remove partition-level error from MetadataResponse#errorCounts URL: https://github.com/apache/kafka/pull/11128 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] MINOR: don't record the throttled rate when there is no throttled par… [kafka]

2024-03-25 Thread via GitHub
chia7712 closed pull request #12528: MINOR: don't record the throttled rate when there is no throttled par… URL: https://github.com/apache/kafka/pull/12528 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] KAFKA-13874 Avoid synchronization in SocketServer metrics [kafka]

2024-03-25 Thread via GitHub
chia7712 closed pull request #13285: KAFKA-13874 Avoid synchronization in SocketServer metrics URL: https://github.com/apache/kafka/pull/13285 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] MINOR: don't disconnect stale controller if the network client is res… [kafka]

2024-03-25 Thread via GitHub
chia7712 closed pull request #13395: MINOR: don't disconnect stale controller if the network client is res… URL: https://github.com/apache/kafka/pull/13395 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] KAFKA-14811 The forwarding requests are discarded when network client… [kafka]

2024-03-25 Thread via GitHub
chia7712 closed pull request #13405: KAFKA-14811 The forwarding requests are discarded when network client… URL: https://github.com/apache/kafka/pull/13405 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] KAFKA-16224: Do not retry committing if topic or partition deleted [kafka]

2024-03-25 Thread via GitHub
cadonna commented on PR #15581: URL: https://github.com/apache/kafka/pull/15581#issuecomment-2018163251 Sorry for that! I do not know why I am so sloppy with this PR. I am going to fix this now. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] KAFKA-16416: Use NetworkClientTest to replace RequestResponseTest to be the example of log4j output [kafka]

2024-03-25 Thread via GitHub
KevinZTW commented on code in PR #15596: URL: https://github.com/apache/kafka/pull/15596#discussion_r1537700914 ## README.md: ## @@ -56,7 +56,11 @@ Follow instructions in https://kafka.apache.org/quickstart ### Running a particular unit/integration test with log4j output ###

Re: [PR] KAFKA-16406: Splitting consumer integration test [kafka]

2024-03-25 Thread via GitHub
lucasbru merged PR #15535: URL: https://github.com/apache/kafka/pull/15535 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16406: Splitting consumer integration test [kafka]

2024-03-25 Thread via GitHub
lucasbru commented on PR #15535: URL: https://github.com/apache/kafka/pull/15535#issuecomment-2018145845 Two related flaky tests, `kafka.api.PlaintextConsumerTest.testExpandingTopicSubscriptions(String, String)[4]` and

Re: [PR] KAFKA-15951: MissingSourceTopicException should include topic names [kafka]

2024-03-25 Thread via GitHub
chickenchickenlove commented on code in PR #15573: URL: https://github.com/apache/kafka/pull/15573#discussion_r1537690828 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/RepartitionTopics.java: ## @@ -119,7 +119,8 @@ public Queue

Re: [PR] KAFKA-15951: MissingSourceTopicException should include topic names [kafka]

2024-03-25 Thread via GitHub
chickenchickenlove commented on code in PR #15573: URL: https://github.com/apache/kafka/pull/15573#discussion_r1537690828 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/RepartitionTopics.java: ## @@ -119,7 +119,8 @@ public Queue

Re: [PR] KAFKA-16323: fix testRemoteFetchExpiresPerSecMetric [kafka]

2024-03-25 Thread via GitHub
johnnychhsu commented on PR #15463: URL: https://github.com/apache/kafka/pull/15463#issuecomment-2018127603 updated @showuon it works in my local, thanks for the sharing! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

  1   2   >