chickenchickenlove commented on code in PR #15573:
URL: https://github.com/apache/kafka/pull/15573#discussion_r1537690828
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/RepartitionTopics.java:
##
@@ -119,7 +119,8 @@ public Queue
missingSourceTopicExceptio
johnnychhsu commented on PR #15463:
URL: https://github.com/apache/kafka/pull/15463#issuecomment-2018127603
updated @showuon
it works in my local, thanks for the sharing!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
Lianet Magrans created KAFKA-16418:
--
Summary: Split long-running admin client integration tests
Key: KAFKA-16418
URL: https://issues.apache.org/jira/browse/KAFKA-16418
Project: Kafka
Issue T
chia7712 commented on code in PR #15596:
URL: https://github.com/apache/kafka/pull/15596#discussion_r1537677312
##
README.md:
##
@@ -56,7 +56,11 @@ Follow instructions in https://kafka.apache.org/quickstart
### Running a particular unit/integration test with log4j output ###
C
KevinZTW opened a new pull request, #15596:
URL: https://github.com/apache/kafka/pull/15596
jira url: https://issues.apache.org/jira/browse/KAFKA-16416
For the part to introduce how to show log4j's info when executing unit test
in README, it seems that current example
`RequestResp
[
https://issues.apache.org/jira/browse/KAFKA-16375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lianet Magrans resolved KAFKA-16375.
Resolution: Fixed
> Fix logic for discarding reconciliation if member rejoined
> -
lianetm commented on PR #15581:
URL: https://github.com/apache/kafka/pull/15581#issuecomment-2018088332
Oh one more detail from the build logs we missed:
```
/home/jenkins/workspace/Kafka_kafka-pr_PR-15581/clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipMana
chickenchickenlove commented on code in PR #15573:
URL: https://github.com/apache/kafka/pull/15573#discussion_r1537649345
##
streams/src/main/java/org/apache/kafka/streams/errors/MissingSourceTopicException.java:
##
@@ -16,11 +16,25 @@
*/
package org.apache.kafka.streams.erro
cadonna commented on code in PR #15581:
URL: https://github.com/apache/kafka/pull/15581#discussion_r1537642692
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -298,10 +303,13 @@ private void
autoCommitSyncNowWithRetries(Offs
chickenchickenlove commented on code in PR #15573:
URL: https://github.com/apache/kafka/pull/15573#discussion_r1537642457
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/RepartitionTopics.java:
##
@@ -119,7 +119,8 @@ public Queue
missingSourceTopicExceptio
cadonna commented on code in PR #15581:
URL: https://github.com/apache/kafka/pull/15581#discussion_r1537639434
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -298,10 +303,13 @@ private void
autoCommitSyncNowWithRetries(Offs
cadonna commented on code in PR #15581:
URL: https://github.com/apache/kafka/pull/15581#discussion_r1537638864
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -298,10 +303,13 @@ private void
autoCommitSyncNowWithRetries(Offs
chiacyu commented on code in PR #15589:
URL: https://github.com/apache/kafka/pull/15589#discussion_r1537633908
##
clients/src/test/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryUtilsTest.java:
##
@@ -132,9 +132,9 @@ public void testCompressDecompress(Compressio
lianetm commented on code in PR #15581:
URL: https://github.com/apache/kafka/pull/15581#discussion_r1537629081
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -298,10 +303,13 @@ private void
autoCommitSyncNowWithRetries(Offs
lianetm commented on PR #15581:
URL: https://github.com/apache/kafka/pull/15581#issuecomment-2018046840
Thanks for the changes @cadonna , this will have a great impact I expect.
Just left some minor comments, otherwise LGTM once the build passes.
--
This is an automated message from the A
chia7712 commented on code in PR #15589:
URL: https://github.com/apache/kafka/pull/15589#discussion_r1537626874
##
clients/src/test/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryUtilsTest.java:
##
@@ -132,9 +132,9 @@ public void testCompressDecompress(Compressi
lianetm commented on code in PR #15581:
URL: https://github.com/apache/kafka/pull/15581#discussion_r1537624363
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -298,10 +303,13 @@ private void
autoCommitSyncNowWithRetries(Offs
lianetm commented on code in PR #15581:
URL: https://github.com/apache/kafka/pull/15581#discussion_r1537618245
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -298,10 +303,13 @@ private void
autoCommitSyncNowWithRetries(Offs
lianetm commented on PR #15535:
URL: https://github.com/apache/kafka/pull/15535#issuecomment-2018010890
Thanks both for the comments. I do like @AndrewJSchofield 's idea of having
it all categorized but I ended up with several unrelated tests that seemed hard
to group in a sensible way. Als
johnnychhsu commented on code in PR #15463:
URL: https://github.com/apache/kafka/pull/15463#discussion_r1537571752
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -4164,16 +4166,12 @@ class ReplicaManagerTest {
mock(classOf[FetchDataInfo])
[
https://issues.apache.org/jira/browse/KAFKA-16417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
zhaobo updated KAFKA-16417:
---
Description: If the initializing producer/consumer fails, the broker cannot
actually read and write the remo
[
https://issues.apache.org/jira/browse/KAFKA-16417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
zhaobo updated KAFKA-16417:
---
Description: (was: Encountered error while initializing
producer/consumer,)
> When initializeResources
[
https://issues.apache.org/jira/browse/KAFKA-16417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
zhaobo updated KAFKA-16417:
---
Description: Encountered error while initializing producer/consumer,
> When initializeResources throws an ex
soarez commented on code in PR #15584:
URL: https://github.com/apache/kafka/pull/15584#discussion_r1537526255
##
core/src/test/scala/integration/kafka/server/KRaftClusterTest.scala:
##
@@ -324,6 +325,68 @@ class KRaftClusterTest {
}
}
+ def setConsumerByteRate(
+a
bozhao12 opened a new pull request, #15595:
URL: https://github.com/apache/kafka/pull/15595
…edRemoteLogMetadataManager.scala, initializationFailed needs to be set to
true"
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed c
zhaobo created KAFKA-16417:
--
Summary: When initializeResources throws an exception in
TopicBasedRemoteLogMetadataManager.scala, initializationFailed needs to be set
to true
Key: KAFKA-16417
URL: https://issues.apache.or
OmniaGM commented on code in PR #15569:
URL: https://github.com/apache/kafka/pull/15569#discussion_r1537488997
##
server/src/main/java/org/apache/kafka/server/config/KafkaConfig.java:
##
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
FrankYang0529 commented on code in PR #15568:
URL: https://github.com/apache/kafka/pull/15568#discussion_r1537450872
##
core/src/test/scala/unit/kafka/log/LogManagerTest.scala:
##
@@ -1392,4 +1415,4 @@ object LogManagerTest {
data.topicStates().addAll(topics.values())
[
https://issues.apache.org/jira/browse/KAFKA-16356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17830450#comment-17830450
]
Rory commented on KAFKA-16356:
--
Hi [~linu], are you still working on this? If not I would l
ocadaruma commented on code in PR #15574:
URL: https://github.com/apache/kafka/pull/15574#discussion_r1537399407
##
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##
@@ -201,7 +201,7 @@ public class ProducerConfig extends AbstractConfig {
/** b
chia7712 commented on code in PR #15568:
URL: https://github.com/apache/kafka/pull/15568#discussion_r1537391493
##
core/src/test/scala/unit/kafka/log/LogManagerTest.scala:
##
@@ -1392,4 +1415,4 @@ object LogManagerTest {
data.topicStates().addAll(topics.values())
new L
cadonna commented on code in PR #15573:
URL: https://github.com/apache/kafka/pull/15573#discussion_r1537338065
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/RepartitionTopics.java:
##
@@ -119,7 +119,8 @@ public Queue
missingSourceTopicExceptions() {
lucasbru merged PR #15579:
URL: https://github.com/apache/kafka/pull/15579
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
lucasbru commented on code in PR #15525:
URL: https://github.com/apache/kafka/pull/15525#discussion_r1537350070
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ListOffsetsEvent.java:
##
@@ -32,8 +32,7 @@
* {@link OffsetAndTimestamp} found (offset of
FrankYang0529 commented on code in PR #15568:
URL: https://github.com/apache/kafka/pull/15568#discussion_r1537365803
##
core/src/test/scala/unit/kafka/log/LogManagerTest.scala:
##
@@ -1392,4 +1415,4 @@ object LogManagerTest {
data.topicStates().addAll(topics.values())
FrankYang0529 commented on code in PR #15568:
URL: https://github.com/apache/kafka/pull/15568#discussion_r1537361217
##
core/src/test/scala/unit/kafka/log/LogManagerTest.scala:
##
@@ -1303,6 +1303,29 @@ class LogManagerTest {
createLeaderAndIsrRequestForStrayDetection(p
FrankYang0529 commented on code in PR #15568:
URL: https://github.com/apache/kafka/pull/15568#discussion_r1537359652
##
core/src/test/scala/unit/kafka/log/LogManagerTest.scala:
##
@@ -1303,6 +1303,29 @@ class LogManagerTest {
createLeaderAndIsrRequestForStrayDetection(p
dajac commented on code in PR #15579:
URL: https://github.com/apache/kafka/pull/15579#discussion_r1537323017
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -1010,49 +1015,55 @@ private void revokeAndAssign(LocalAssignment
nizhikov commented on PR #15075:
URL: https://github.com/apache/kafka/pull/15075#issuecomment-2017604728
@chia7712 Done.
Please, note, there are several other PR's with same goal #15569 #15575
which are close to mergeable state in my opinion.
--
This is an automated message from th
cadonna commented on code in PR #15581:
URL: https://github.com/apache/kafka/pull/15581#discussion_r1537313537
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -272,14 +273,18 @@ private void maybeResetTimerWithBackoff(final
nizhikov commented on PR #15575:
URL: https://github.com/apache/kafka/pull/15575#issuecomment-2017577355
Hello @AndrewJSchofield @OmniaGM
Looks like dependenci on server tests not required but introduced in this PR.
I have plans to double check this after minor comment in #15569 wi
lucasbru commented on PR #15535:
URL: https://github.com/apache/kafka/pull/15535#issuecomment-2017575807
@AndrewJSchofield I think Lianet did not remove the `PlaintextConsumerTest`
to makes sure we still run the tests in `BaseConsumerTest` in the plaintext
case once. I guess we could make o
chia7712 commented on PR #15075:
URL: https://github.com/apache/kafka/pull/15075#issuecomment-2017574947
@nizhikov please rebase the code, and I will take a look later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
chia7712 commented on PR #15071:
URL: https://github.com/apache/kafka/pull/15071#issuecomment-2017572670
any update here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
vamossagar12 commented on PR #15576:
URL: https://github.com/apache/kafka/pull/15576#issuecomment-2017572320
@philipnee , here's the PR that I created:
https://github.com/apache/kafka/pull/15594. Actually I looked at your changes
now and it appears that the changes in the new PR consists of
vamossagar12 opened a new pull request, #15594:
URL: https://github.com/apache/kafka/pull/15594
Main changes:
1. Parameterizes the tests to use new coordinator and pass in consumer group
protocol. This would be applicable to sink connectors only.
2. Enhances the sink connector crea
lucasbru commented on code in PR #15535:
URL: https://github.com/apache/kafka/pull/15535#discussion_r1537284419
##
core/src/test/scala/integration/kafka/api/PlaintextConsumerAssignTest.scala:
##
@@ -0,0 +1,246 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under o
showuon commented on PR #15505:
URL: https://github.com/apache/kafka/pull/15505#issuecomment-2017562723
@FrankYang0529 , there are some tests failing because of your change. Please
take a look. Thanks.
https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-15505/4
--
This is an
showuon commented on PR #15561:
URL: https://github.com/apache/kafka/pull/15561#issuecomment-2017558109
@gaoran10, I'm going to merge it tomorrow if you don't have any other
comments. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
showuon commented on PR #15586:
URL: https://github.com/apache/kafka/pull/15586#issuecomment-201728
Failed with the same error again. Please help fix the errors. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
AndrewJSchofield commented on code in PR #15574:
URL: https://github.com/apache/kafka/pull/15574#discussion_r1537251855
##
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java:
##
@@ -143,8 +143,8 @@
*
* The buffer.memory controls the total amount of m
AndrewJSchofield commented on code in PR #15581:
URL: https://github.com/apache/kafka/pull/15581#discussion_r1537243649
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -272,14 +273,18 @@ private void maybeResetTimerWithBackof
mimaison merged PR #15013:
URL: https://github.com/apache/kafka/pull/15013
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-15882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison resolved KAFKA-15882.
Fix Version/s: 3.8.0
Resolution: Fixed
> Scheduled nightly github actions workflow
[
https://issues.apache.org/jira/browse/KAFKA-16374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-16374.
-
Fix Version/s: 3.8.0
Resolution: Fixed
> High watermark updates should have a higher prio
dajac merged PR #15534:
URL: https://github.com/apache/kafka/pull/15534
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
dajac commented on code in PR #15534:
URL: https://github.com/apache/kafka/pull/15534#discussion_r1537192799
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntimeTest.java:
##
@@ -504,12 +518,6 @@ public void testScheduleLoadingWithFail
[
https://issues.apache.org/jira/browse/KAFKA-16416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17830387#comment-17830387
]
Luke Chen edited comment on KAFKA-16416 at 3/25/24 7:53 AM:
[
https://issues.apache.org/jira/browse/KAFKA-16416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17830387#comment-17830387
]
Luke Chen commented on KAFKA-16416:
---
Also, in the readme, we said:
> Change the log4j
[
https://issues.apache.org/jira/browse/KAFKA-16398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17830386#comment-17830386
]
Srivignesh commented on KAFKA-16398:
Hi [~gharris1727] Thanks for your response. I h
[
https://issues.apache.org/jira/browse/KAFKA-16398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Srivignesh updated KAFKA-16398:
---
Attachment: connect-distributed.properties.template
mm2.config.template
> mirror-mak
showuon commented on code in PR #15549:
URL: https://github.com/apache/kafka/pull/15549#discussion_r1537157667
##
core/src/main/scala/kafka/server/KafkaServer.scala:
##
@@ -632,6 +634,7 @@ class KafkaServer(
case t: Throwable => throw new RuntimeException("Received a
[
https://issues.apache.org/jira/browse/KAFKA-16416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Cheng-Kai, Zhang reassigned KAFKA-16416:
Assignee: Cheng-Kai, Zhang
> Use NetworkClientTest to replace RequestResponseTest
Chia-Ping Tsai created KAFKA-16416:
--
Summary: Use NetworkClientTest to replace RequestResponseTest to
be the example of log4j output
Key: KAFKA-16416
URL: https://issues.apache.org/jira/browse/KAFKA-16416
[
https://issues.apache.org/jira/browse/KAFKA-16416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-16416:
---
Labels: newbie (was: )
> Use NetworkClientTest to replace RequestResponseTest to be the exa
101 - 165 of 165 matches
Mail list logo
