Re: [PR] KAFKA-16373: Adding code to support Apache Kafka Docker Official Images [kafka]

KrishVora01 commented on code in PR #15704: URL: https://github.com/apache/kafka/pull/15704#discussion_r1566786457 ## .github/workflows/prepare_docker_official_image_source.yml: ## @@ -0,0 +1,55 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contribu

Re: [PR] KAFKA-16373: Adding code to support Apache Kafka Docker Official Images [kafka]

KrishVora01 commented on code in PR #15704: URL: https://github.com/apache/kafka/pull/15704#discussion_r1566786231 ## docker/docker_official_image_build_test.py: ## @@ -0,0 +1,128 @@ +#!/usr/bin/env python + +# Licensed to the Apache Software Foundation (ASF) under one or more +

[PR] KAFKA-14509: [3/4] Add integration test for consumerGroupDescribe Api [kafka]

riedelmax opened a new pull request, #15727: URL: https://github.com/apache/kafka/pull/15727 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testi

Re: [PR] KAFKA-16373: Adding code to support Apache Kafka Docker Official Images [kafka]

KrishVora01 commented on code in PR #15704: URL: https://github.com/apache/kafka/pull/15704#discussion_r1566779353 ## docker/docker_official_image_build_test.py: ## @@ -0,0 +1,128 @@ +#!/usr/bin/env python + +# Licensed to the Apache Software Foundation (ASF) under one or more +

Re: [PR] KAFKA-16373: Adding code to support Apache Kafka Docker Official Images [kafka]

KrishVora01 commented on code in PR #15704: URL: https://github.com/apache/kafka/pull/15704#discussion_r1566778083 ## docker/generate_kafka_pr_template.sh: ## @@ -0,0 +1,76 @@ +#!/usr/bin/env bash + +# Licensed to the Apache Software Foundation (ASF) under one or more +# contrib

Re: [PR] KAFKA-16373: Adding code to support Apache Kafka Docker Official Images [kafka]

KrishVora01 commented on code in PR #15704: URL: https://github.com/apache/kafka/pull/15704#discussion_r1566755671 ## docker/generate_kafka_pr_template.sh: ## @@ -0,0 +1,61 @@ +#!/usr/bin/env bash Review Comment: This has been added -- This is an automated message from t

Re: [PR] JMH Benchmarks for testing the performance of the Server Side Rebalances: KIP_848 [kafka]

rreddy-22 commented on code in PR #15717: URL: https://github.com/apache/kafka/pull/15717#discussion_r1566753533 ## jmh-benchmarks/src/main/java/org/apache/kafka/jmh/group_coordinator/ServerSideAssignorBenchmark.java: ## @@ -0,0 +1,185 @@ +package org.apache.kafka.jmh.group_coor

Re: [PR] KAFKA-15875 Make Snapshot public [kafka]

github-actions[bot] commented on PR #14816: URL: https://github.com/apache/kafka/pull/14816#issuecomment-2058166826 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge

Re: [PR] KAFKA-16543:There may be ambiguous deletions in the `cleanupGroupMetadata` when the generation of the group is less than or equal to 0 [kafka]

hudeqi closed pull request #15706: KAFKA-16543:There may be ambiguous deletions in the `cleanupGroupMetadata` when the generation of the group is less than or equal to 0 URL: https://github.com/apache/kafka/pull/15706 -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] KAFKA-16543:There may be ambiguous deletions in the `cleanupGroupMetadata` when the generation of the group is less than or equal to 0 [kafka]

hudeqi commented on PR #15706: URL: https://github.com/apache/kafka/pull/15706#issuecomment-2058152299 > Hi @hudeqi. Thanks for the patch. I would like to better understand it. My first question is how would Flink commit Flink with a generationId equal to -1? The generation of the group is

Re: [PR] KAFKA-15685: added compatibility for MinGW [kafka]

Zta commented on PR #13321: URL: https://github.com/apache/kafka/pull/13321#issuecomment-2058148690 My OS is RHEL 8.7 and 8.8 In 3.5.1, I ran this script with kafka.tools.GetOffsetShell just fine. In 3.7.0, I got the following error: Error: Could not find or load main cla

[PR] MINOR: fix some typos [kafka]

Nicklee007 opened a new pull request, #15725: URL: https://github.com/apache/kafka/pull/15725 Fix some typos. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [PR] MINOR: Add test for PartitionMetadataFile [kafka]

KevinZTW commented on code in PR #15714: URL: https://github.com/apache/kafka/pull/15714#discussion_r1566619569 ## storage/src/test/java/org/apache/kafka/storage/internals/checkpoint/PartitionMetadataFileTest.java: ## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] MINOR: Add test for PartitionMetadataFile [kafka]

KevinZTW commented on code in PR #15714: URL: https://github.com/apache/kafka/pull/15714#discussion_r1566612658 ## storage/src/test/java/org/apache/kafka/storage/internals/checkpoint/PartitionMetadataFileTest.java: ## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] MINOR: Add test for PartitionMetadataFile [kafka]

KevinZTW commented on code in PR #15714: URL: https://github.com/apache/kafka/pull/15714#discussion_r1566612024 ## storage/src/test/java/org/apache/kafka/storage/internals/checkpoint/PartitionMetadataFileTest.java: ## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] MINOR: Add test for PartitionMetadataFile [kafka]

KevinZTW commented on code in PR #15714: URL: https://github.com/apache/kafka/pull/15714#discussion_r1566609363 ## storage/src/test/java/org/apache/kafka/storage/internals/checkpoint/PartitionMetadataFileTest.java: ## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] KAFKA-16556: SubscriptionState should not prematurely reset 'pending' partitions [kafka]

kirktrue commented on PR #15724: URL: https://github.com/apache/kafka/pull/15724#issuecomment-2058081763 @lucasbru—please kindly take a look at this issue that's occasionally causing consumers to ignore committed offsets. The result is the consumer resets the partition's position back to 0,

Re: [PR] MINOR: Add test for PartitionMetadataFile [kafka]

KevinZTW commented on code in PR #15714: URL: https://github.com/apache/kafka/pull/15714#discussion_r1566606914 ## storage/src/test/java/org/apache/kafka/storage/internals/checkpoint/PartitionMetadataFileTest.java: ## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foun

[PR] KAFKA-16556: SubscriptionState should not prematurely reset 'pending' partitions [kafka]

kirktrue opened a new pull request, #15724: URL: https://github.com/apache/kafka/pull/15724 Partitions that are marked as `pendingOnAssignedCallback` should not be reset in `resetInitializingPositions()`. Pending partitions are omitted from the set returned by `initializingPartitions()`. As

[jira] [Updated] (KAFKA-16556) SubscriptionState should not prematurely reset 'pending' partitions

[ https://issues.apache.org/jira/browse/KAFKA-16556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16556: -- Summary: SubscriptionState should not prematurely reset 'pending' partitions (was: Race condition bet

Re: [PR] KAFKA-15265: Add Remote Log Manager quota manager [kafka]

HenryCaiHaiying commented on code in PR #15625: URL: https://github.com/apache/kafka/pull/15625#discussion_r1566566286 ## core/src/main/java/kafka/log/remote/quota/RLMQuotaManager.java: ## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mo

Re: [PR] KAFKA-16555: Consumer's RequestState has incorrect logic to determine if inflight [kafka]

kirktrue commented on PR #15723: URL: https://github.com/apache/kafka/pull/15723#issuecomment-2057988468 @lucasbru—please kindly take a look at this issue that's occasionally causing duplicate heartbeat requests. cc @lianetm @philipnee -- This is an automated message from the Apac

[PR] KAFKA-16555: Consumer's RequestState has incorrect logic to determine if inflight [kafka]

kirktrue opened a new pull request, #15723: URL: https://github.com/apache/kafka/pull/15723 In some cases, the network layer is _very_ fast and can send out multiple requests within the same millisecond timestamp. The previous logic for tracking inflight status used timestamps: if the

[jira] [Updated] (KAFKA-15974) Enforce that event processing respects user-provided timeout

[ https://issues.apache.org/jira/browse/KAFKA-15974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15974: -- Reviewer: Lucas Brutschy (was: Bruno Cadonna) > Enforce that event processing respects user-provided

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

CalvinConfluent commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1566471100 ## metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java: ## @@ -423,6 +441,17 @@ public void replay(ConfigRecord record) {

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

CalvinConfluent commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1566455070 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -2360,4 +2363,9 @@ void setNewNextWriteOffset(long newNextWriteOffset) {

[jira] [Updated] (KAFKA-16556) Race condition between ConsumerRebalanceListener and SubscriptionState causes commit offsets to be reset

[ https://issues.apache.org/jira/browse/KAFKA-16556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16556: -- Summary: Race condition between ConsumerRebalanceListener and SubscriptionState causes commit offsets

Re: [PR] MINOR: fix duplicated return and other streams docs typos [kafka]

AyoubOm commented on code in PR #15713: URL: https://github.com/apache/kafka/pull/15713#discussion_r1566436979 ## streams/src/main/java/org/apache/kafka/streams/kstream/NamedOperation.java: ## @@ -17,7 +17,7 @@ package org.apache.kafka.streams.kstream; /** - * Default interf

[PR] MINOR: Fix io-[wait-]ratio metrics description [kafka]

emitskevich-blp opened a new pull request, #15722: URL: https://github.com/apache/kafka/pull/15722 [Implementation of KIP-773](https://github.com/apache/kafka/pull/11302) deprecated `iotime-total` and `io-waittime-total` metrics. It wasn't expected to mark `io-ratio` and `io-wait-ratio` de

[jira] [Created] (KAFKA-16558) Implement HeartbeatRequestState.toStringBase()

Kirk True created KAFKA-16558: - Summary: Implement HeartbeatRequestState.toStringBase() Key: KAFKA-16558 URL: https://issues.apache.org/jira/browse/KAFKA-16558 Project: Kafka Issue Type: Bug

[jira] [Updated] (KAFKA-16558) Implement HeartbeatRequestState.toStringBase()

[ https://issues.apache.org/jira/browse/KAFKA-16558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16558: -- Description: The inner class {{HeartbeatRequestState}} does not override the {{toStringBase()}} method

[jira] [Updated] (KAFKA-16557) Fix OffsetFetchRequestState.toString()

[ https://issues.apache.org/jira/browse/KAFKA-16557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16557: -- Summary: Fix OffsetFetchRequestState.toString() (was: Fix CommitRequestManager’s OffsetFetchRequestSt

[jira] [Created] (KAFKA-16557) Fix CommitRequestManager’s OffsetFetchRequestState.toString()

Kirk True created KAFKA-16557: - Summary: Fix CommitRequestManager’s OffsetFetchRequestState.toString() Key: KAFKA-16557 URL: https://issues.apache.org/jira/browse/KAFKA-16557 Project: Kafka Issu

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

CalvinConfluent commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1566242343 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -2360,4 +2363,9 @@ void setNewNextWriteOffset(long newNextWriteOffset) {

[jira] [Updated] (KAFKA-16556) Race condition between ConsumerRebalanceListener and SubscriptionState

[ https://issues.apache.org/jira/browse/KAFKA-16556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16556: -- Description: There appears to be a race condition between invoking the  {{ConsumerRebalanceListener}} 

[jira] [Assigned] (KAFKA-16556) Race condition between ConsumerRebalanceListener and SubscriptionState

[ https://issues.apache.org/jira/browse/KAFKA-16556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-16556: - Assignee: Kirk True > Race condition between ConsumerRebalanceListener and SubscriptionState >

[jira] [Created] (KAFKA-16556) Race condition between ConsumerRebalanceListener and SubscriptionState

Kirk True created KAFKA-16556: - Summary: Race condition between ConsumerRebalanceListener and SubscriptionState Key: KAFKA-16556 URL: https://issues.apache.org/jira/browse/KAFKA-16556 Project: Kafka

[jira] [Created] (KAFKA-16555) Consumer's RequestState has incorrect logic to determine if inflight

Kirk True created KAFKA-16555: - Summary: Consumer's RequestState has incorrect logic to determine if inflight Key: KAFKA-16555 URL: https://issues.apache.org/jira/browse/KAFKA-16555 Project: Kafka

[PR] KAFKA-16554: Online downgrade triggering and group type conversion [kafka]

dongnuo123 opened a new pull request, #15721: URL: https://github.com/apache/kafka/pull/15721 Online downgrade from a consumer group to a classic group is triggered when the last consumer that uses the consumer protocol leaves the group. A rebalance is manually triggered after the group con

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

CalvinConfluent commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1566242343 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -2360,4 +2363,9 @@ void setNewNextWriteOffset(long newNextWriteOffset) {

Re: [PR] JMH Benchmarks for testing the performance of the Server Side Rebalances: KIP_848 [kafka]

rreddy-22 commented on code in PR #15717: URL: https://github.com/apache/kafka/pull/15717#discussion_r1566238375 ## jmh-benchmarks/src/main/java/org/apache/kafka/jmh/group_coordinator/TargetAssignmentBuilderBenchmark.java: ## @@ -0,0 +1,259 @@ +package org.apache.kafka.jmh.group

Re: [PR] JMH Benchmarks for testing the performance of the Server Side Rebalances: KIP_848 [kafka]

rreddy-22 commented on code in PR #15717: URL: https://github.com/apache/kafka/pull/15717#discussion_r1566237268 ## jmh-benchmarks/src/main/java/org/apache/kafka/jmh/group_coordinator/ServerSideAssignorBenchmark.java: ## @@ -0,0 +1,185 @@ +package org.apache.kafka.jmh.group_coor

Re: [PR] JMH Benchmarks for testing the performance of the Server Side Rebalances: KIP_848 [kafka]

rreddy-22 commented on code in PR #15717: URL: https://github.com/apache/kafka/pull/15717#discussion_r1566234265 ## jmh-benchmarks/src/main/java/org/apache/kafka/jmh/group_coordinator/ServerSideAssignorBenchmark.java: ## @@ -0,0 +1,185 @@ +package org.apache.kafka.jmh.group_coor

Re: [PR] JMH Benchmarks for testing the performance of the Server Side Rebalances: KIP_848 [kafka]

rreddy-22 commented on code in PR #15717: URL: https://github.com/apache/kafka/pull/15717#discussion_r1566233067 ## jmh-benchmarks/src/main/java/org/apache/kafka/jmh/group_coordinator/ServerSideAssignorBenchmark.java: ## @@ -0,0 +1,185 @@ +package org.apache.kafka.jmh.group_coor

Re: [PR] JMH Benchmarks for testing the performance of the Server Side Rebalances: KIP_848 [kafka]

rreddy-22 commented on code in PR #15717: URL: https://github.com/apache/kafka/pull/15717#discussion_r1566224264 ## jmh-benchmarks/src/main/java/org/apache/kafka/jmh/group_coordinator/AssignPartitionsMicroBenchmark.java: ## @@ -0,0 +1,153 @@ +package org.apache.kafka.jmh.group_c

Re: [PR] JMH Benchmarks for testing the performance of the Server Side Rebalances: KIP_848 [kafka]

rreddy-22 commented on code in PR #15717: URL: https://github.com/apache/kafka/pull/15717#discussion_r1566219575 ## jmh-benchmarks/src/main/java/org/apache/kafka/jmh/group_coordinator/ServerSideAssignorBenchmark.java: ## @@ -0,0 +1,185 @@ +package org.apache.kafka.jmh.group_coor

[jira] [Created] (KAFKA-16554) Online downgrade triggering and group type conversion

Dongnuo Lyu created KAFKA-16554: --- Summary: Online downgrade triggering and group type conversion Key: KAFKA-16554 URL: https://issues.apache.org/jira/browse/KAFKA-16554 Project: Kafka Issue Typ

Re: [PR] JMH Benchmarks for testing the performance of the Server Side Rebalances: KIP_848 [kafka]

rreddy-22 commented on code in PR #15717: URL: https://github.com/apache/kafka/pull/15717#discussion_r1566211483 ## jmh-benchmarks/src/main/java/org/apache/kafka/jmh/group_coordinator/ClientSideAssignorBenchmark.java: ## @@ -0,0 +1,198 @@ +package org.apache.kafka.jmh.group_coor

Re: [PR] JMH Benchmarks for testing the performance of the Server Side Rebalances: KIP_848 [kafka]

rreddy-22 commented on code in PR #15717: URL: https://github.com/apache/kafka/pull/15717#discussion_r1566211207 ## jmh-benchmarks/src/main/java/org/apache/kafka/jmh/group_coordinator/ClientSideAssignorBenchmark.java: ## @@ -0,0 +1,198 @@ +package org.apache.kafka.jmh.group_coor

Re: [PR] JMH Benchmarks for testing the performance of the Server Side Rebalances: KIP_848 [kafka]

rreddy-22 commented on code in PR #15717: URL: https://github.com/apache/kafka/pull/15717#discussion_r1566204495 ## jmh-benchmarks/src/main/java/org/apache/kafka/jmh/group_coordinator/ServerSideAssignorBenchmark.java: ## @@ -0,0 +1,185 @@ +package org.apache.kafka.jmh.group_coor

Re: [PR] KAFKA-15615: Improve handling of fetching during metadata updates. [kafka]

appchemist commented on PR #15647: URL: https://github.com/apache/kafka/pull/15647#issuecomment-2057454239 > thanks for the PR! just curious, what is the problem without the newly added state? does it cause any issues? @johnnychhsu When a kafka consumer encounters a FENCED_LEADER_

Re: [PR] JMH Benchmarks for testing the performance of the Server Side Rebalances: KIP_848 [kafka]

rreddy-22 commented on code in PR #15717: URL: https://github.com/apache/kafka/pull/15717#discussion_r1566203863 ## jmh-benchmarks/src/main/java/org/apache/kafka/jmh/group_coordinator/ServerSideAssignorBenchmark.java: ## @@ -0,0 +1,185 @@ +package org.apache.kafka.jmh.group_coor

Re: [PR] JMH Benchmarks for testing the performance of the Server Side Rebalances: KIP_848 [kafka]

rreddy-22 commented on code in PR #15717: URL: https://github.com/apache/kafka/pull/15717#discussion_r1566200808 ## jmh-benchmarks/src/main/java/org/apache/kafka/jmh/group_coordinator/AssignPartitionsMicroBenchmark.java: ## @@ -0,0 +1,153 @@ +package org.apache.kafka.jmh.group_c

Re: [PR] JMH Benchmarks for testing the performance of the Server Side Rebalances: KIP_848 [kafka]

rreddy-22 commented on code in PR #15717: URL: https://github.com/apache/kafka/pull/15717#discussion_r1566199529 ## jmh-benchmarks/src/main/java/org/apache/kafka/jmh/group_coordinator/AssignPartitionsMicroBenchmark.java: ## @@ -0,0 +1,153 @@ +package org.apache.kafka.jmh.group_c

Re: [PR] KAFKA-13328, KAFKA-13329 (2): Add custom preflight validation support for connector header, key, and value converters [kafka]

C0urante commented on PR #14309: URL: https://github.com/apache/kafka/pull/14309#issuecomment-2057408474 Hi @gharris1727 sorry for the delay. I've resolved the merge conflicts; let me know what you think if you have a moment. -- This is an automated message from the Apache Git Service. To

[jira] [Commented] (KAFKA-13105) Expose a method in KafkaConfig to write the configs to a logger

[ https://issues.apache.org/jira/browse/KAFKA-13105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837366#comment-17837366 ] Johnny Hsu commented on KAFKA-13105: hi [~cmccabe] I would like to work on this if n

Re: [PR] KAFKA-15853: Move KafkaConfig log properties and docs out of core [kafka]

OmniaGM commented on code in PR #15569: URL: https://github.com/apache/kafka/pull/15569#discussion_r1566156280 ## server/src/main/java/org/apache/kafka/server/config/KafkaLogConfigs.java: ## @@ -0,0 +1,166 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-15853: Move KafkaConfig log properties and docs out of core [kafka]

OmniaGM commented on code in PR #15569: URL: https://github.com/apache/kafka/pull/15569#discussion_r1566156280 ## server/src/main/java/org/apache/kafka/server/config/KafkaLogConfigs.java: ## @@ -0,0 +1,166 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[PR] [WIP] KAFKA-16475: add test for TopicImageNodeTest [kafka]

johnnychhsu opened a new pull request, #15720: URL: https://github.com/apache/kafka/pull/15720 ## Context Add unit test for TopicImageNodeTest Jira ticket: https://issues.apache.org/jira/browse/KAFKA-16475 ## Test ### Committer Checklist (excluded from commit message) -

Re: [PR] KAFKA-15853: Move KafkaConfig log properties and docs out of core [kafka]

chia7712 commented on code in PR #15569: URL: https://github.com/apache/kafka/pull/15569#discussion_r1566129710 ## server/src/main/java/org/apache/kafka/server/config/KafkaLogConfigs.java: ## @@ -0,0 +1,166 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-15853: Move KafkaConfig Replication properties and docs out of … [kafka]

OmniaGM commented on code in PR #15575: URL: https://github.com/apache/kafka/pull/15575#discussion_r1566114227 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -1458,40 +1395,40 @@ class KafkaConfig private(doLog: Boolean, val props: java.util.Map[_, _], dynami d

Re: [PR] KAFKA-15853: Move KafkaConfig Replication properties and docs out of … [kafka]

OmniaGM commented on code in PR #15575: URL: https://github.com/apache/kafka/pull/15575#discussion_r1566111409 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -1458,40 +1395,40 @@ class KafkaConfig private(doLog: Boolean, val props: java.util.Map[_, _], dynami d

Re: [PR] KAFKA-16316: Configure reprocessing with addGlobalStateStore [kafka]

AyoubOm commented on code in PR #15619: URL: https://github.com/apache/kafka/pull/15619#discussion_r1566096443 ## streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java: ## @@ -613,6 +616,74 @@ public synchronized StreamsBuilder addGlobalStore(final StoreBuilder<

Re: [PR] KAFKA-15853: Move KafkaConfig Replication properties and docs out of … [kafka]

chia7712 commented on code in PR #15575: URL: https://github.com/apache/kafka/pull/15575#discussion_r1566098229 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -1458,40 +1395,40 @@ class KafkaConfig private(doLog: Boolean, val props: java.util.Map[_, _], dynami

[PR] KAFKA-16552: Create an internal config to control InitialTaskDelayMs in LogManager to speed up tests [kafka]

brandboat opened a new pull request, #15719: URL: https://github.com/apache/kafka/pull/15719 related to KAFKA-16552, Introduce a new internal config `log.initial.task.delay.ms` to control InitialTaskDelayMs in LogManager to speed up tests ### Committer Checklist (excluded from

[jira] [Commented] (KAFKA-16474) AsyncKafkaConsumer might send out heartbeat request without waiting for its response

[ https://issues.apache.org/jira/browse/KAFKA-16474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837342#comment-17837342 ] Philip Nee commented on KAFKA-16474: The log was attached: See line 7481 and 7492 i

[jira] [Updated] (KAFKA-16474) AsyncKafkaConsumer might send out heartbeat request without waiting for its response

[ https://issues.apache.org/jira/browse/KAFKA-16474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee updated KAFKA-16474: --- Attachment: failing_results.zip > AsyncKafkaConsumer might send out heartbeat request without waitin

Re: [PR] KAFKA-16436: Online upgrade triggering and group type conversion [kafka]

dajac commented on code in PR #15662: URL: https://github.com/apache/kafka/pull/15662#discussion_r1566001316 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java: ## @@ -1046,4 +1051,101 @@ public void testIsInStatesCaseInsensitiv

Re: [PR] MINOR: Various cleanups in tools [kafka]

mimaison merged PR #15709: URL: https://github.com/apache/kafka/pull/15709 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: Various cleanups in tools [kafka]

mimaison commented on PR #15709: URL: https://github.com/apache/kafka/pull/15709#issuecomment-2057128107 None of the failures seem related, merging to trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] KAFKA-16417:When initializeResources throws an exception in TopicBasedRemoteLogMetadataManager.scala, initializationFailed needs to be set to true [kafka]

johnnychhsu commented on code in PR #15595: URL: https://github.com/apache/kafka/pull/15595#discussion_r1565975540 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManager.java: ## @@ -436,6 +436,7 @@ private void initialize

Re: [PR] KAFKA-15649: Handle directory failure timeout [kafka]

mimaison commented on code in PR #15697: URL: https://github.com/apache/kafka/pull/15697#discussion_r1565973156 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -870,6 +875,7 @@ object KafkaConfig { .define(CreateTopicPolicyClassNameProp, CLASS, null, LOW, Cr

Re: [PR] MINOR: fix typo [kafka]

johnnychhsu commented on PR #15643: URL: https://github.com/apache/kafka/pull/15643#issuecomment-2057106113 thanks for the PR. this looks good to me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] KAFKA-15615: Improve handling of fetching during metadata updates. [kafka]

johnnychhsu commented on PR #15647: URL: https://github.com/apache/kafka/pull/15647#issuecomment-2057103180 thanks for the PR! just curious, what is the problem without the newly added state? does it cause any issues? -- This is an automated message from the Apache Git Service. To res

Re: [PR] KAFKA-16424: remove truncated logs after alter dir [kafka]

johnnychhsu commented on code in PR #15616: URL: https://github.com/apache/kafka/pull/15616#discussion_r1565898495 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogSegment.java: ## @@ -800,8 +802,23 @@ private Void deleteTypeIfExists(StorageAction delete, Stri

Re: [PR] MINOR: Various cleanups in server and server-common [kafka]

mimaison commented on code in PR #15710: URL: https://github.com/apache/kafka/pull/15710#discussion_r1565897312 ## server/src/main/java/org/apache/kafka/server/metrics/ClientMetricsInstance.java: ## @@ -116,8 +116,7 @@ public synchronized boolean maybeUpdatePushRequestTimestamp

Re: [PR] KAFKA-16373: Adding code to support Apache Kafka Docker Official Images [kafka]

soarez commented on code in PR #15704: URL: https://github.com/apache/kafka/pull/15704#discussion_r1565856796 ## docker/generate_kafka_pr_template.sh: ## @@ -0,0 +1,76 @@ +#!/usr/bin/env bash + +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

Re: [PR] MINOR: fix duplicated return and other streams docs typos [kafka]

johnnychhsu commented on code in PR #15713: URL: https://github.com/apache/kafka/pull/15713#discussion_r1565877195 ## streams/src/main/java/org/apache/kafka/streams/kstream/NamedOperation.java: ## @@ -17,7 +17,7 @@ package org.apache.kafka.streams.kstream; /** - * Default in

Re: [PR] KAFKA-15018: Failing offset flush for EOS when secondary offset store writes fails for tombstone records [kafka]

C0urante commented on PR #13801: URL: https://github.com/apache/kafka/pull/13801#issuecomment-2056973237 Thanks Sagar, great catch! I suspected this would be a gnarly one to tackle but it's turning out to be even harder than I thought. I think there's still an issue with the current s

Re: [PR] MINOR: fix duplicated return and other streams docs typos [kafka]

johnnychhsu commented on PR #15713: URL: https://github.com/apache/kafka/pull/15713#issuecomment-2056975870 thanks for the pr! this looks good to me, leave a simple comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] KAFKA-16436: Online upgrade triggering and group type conversion [kafka]

dajac commented on code in PR #15662: URL: https://github.com/apache/kafka/pull/15662#discussion_r1565866968 ## group-coordinator/src/main/resources/common/message/ConsumerGroupMemberMetadataValue.json: ## @@ -35,6 +35,20 @@ { "name": "RebalanceTimeoutMs", "type": "int32",

Re: [PR] MINOR: Various cleanups in server and server-common [kafka]

mimaison commented on code in PR #15710: URL: https://github.com/apache/kafka/pull/15710#discussion_r1565856071 ## server/src/main/java/org/apache/kafka/server/AssignmentsManager.java: ## @@ -321,7 +321,7 @@ public void run() throws Exception { AssignReplicasToD

Re: [PR] MINOR: Add missing docs for migration metrics [kafka]

soarez commented on code in PR #15718: URL: https://github.com/apache/kafka/pull/15718#discussion_r1565822707 ## docs/ops.html: ## @@ -2126,7 +2142,7 @@ https://github.com/apache/kafka/blob/3617dda9a5415ee1597967f754985fb73a5350c6/core/src/main/scala/kafka/controller/KafkaContro

Re: [PR] KAFKA-16528: Client HB timing fix [kafka]

lianetm commented on code in PR #15698: URL: https://github.com/apache/kafka/pull/15698#discussion_r1565783934 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -269,6 +269,9 @@ private NetworkClientDelegate.UnsentRequest m

[PR] MINOR: Add missing docs for migration metrics [kafka]

soarez opened a new pull request, #15718: URL: https://github.com/apache/kafka/pull/15718 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

Re: [PR] KAFKA-16528: Client HB timing fix [kafka]

lianetm commented on PR #15698: URL: https://github.com/apache/kafka/pull/15698#issuecomment-2056883089 Hey @cadonna, thanks a lot for your feedback! All comments addressed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] KAFKA-16528: Client HB timing fix [kafka]

lianetm commented on code in PR #15698: URL: https://github.com/apache/kafka/pull/15698#discussion_r1565815246 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -482,6 +484,14 @@ public long nextHeartbeatMs(final long curren

Re: [PR] KAFKA-16528: Client HB timing fix [kafka]

lianetm commented on code in PR #15698: URL: https://github.com/apache/kafka/pull/15698#discussion_r1565783934 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -269,6 +269,9 @@ private NetworkClientDelegate.UnsentRequest m

Re: [PR] MINOR: Various cleanups in clients [kafka]

mimaison commented on code in PR #15705: URL: https://github.com/apache/kafka/pull/15705#discussion_r1565764251 ## clients/src/main/java/org/apache/kafka/clients/admin/internals/CoordinatorStrategy.java: ## @@ -136,8 +136,8 @@ private CoordinatorKey requireSingletonAndType(Set

Re: [PR] MINOR: Various cleanups in clients [kafka]

mimaison commented on code in PR #15705: URL: https://github.com/apache/kafka/pull/15705#discussion_r1565721043 ## clients/src/main/java/org/apache/kafka/common/utils/BufferSupplier.java: ## @@ -79,12 +79,8 @@ public ByteBuffer get(int size) { @Override public

Re: [PR] MINOR: Various cleanups in clients [kafka]

mimaison commented on code in PR #15705: URL: https://github.com/apache/kafka/pull/15705#discussion_r1565719621 ## clients/src/main/java/org/apache/kafka/common/memory/GarbageCollectedMemoryPool.java: ## @@ -37,13 +37,13 @@ public class GarbageCollectedMemoryPool extends Simple

Re: [PR] MINOR: Various cleanups in clients [kafka]

mimaison commented on code in PR #15705: URL: https://github.com/apache/kafka/pull/15705#discussion_r1565718889 ## clients/src/main/java/org/apache/kafka/common/network/SslChannelBuilder.java: ## @@ -60,7 +58,6 @@ public SslChannelBuilder(Mode mode, this.mode = mode;

[jira] [Created] (KAFKA-16553) log controller configs when startup

Chia-Ping Tsai created KAFKA-16553: -- Summary: log controller configs when startup Key: KAFKA-16553 URL: https://issues.apache.org/jira/browse/KAFKA-16553 Project: Kafka Issue Type: Improveme

Re: [PR] KAFKA-16371: fix lingering pending commit when handling OFFSET_METADATA_TOO_LARGE [kafka]

dajac commented on code in PR #15536: URL: https://github.com/apache/kafka/pull/15536#discussion_r1565639650 ## core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataManagerTest.scala: ## @@ -1661,6 +1661,65 @@ class GroupMetadataManagerTest { assertEquals(0, TestUt

Re: [PR] KAFKA-16082: Avoid resuming future replica if current replica is in the same directory [kafka]

gaurav-narula commented on code in PR #15136: URL: https://github.com/apache/kafka/pull/15136#discussion_r1565638692 ## core/src/main/scala/kafka/log/LogManager.scala: ## @@ -1176,6 +1176,42 @@ class LogManager(logDirs: Seq[File], } } + def recoverAbandonedFutureLogs(

Re: [PR] KAFKA:-16399: Add JBOD support in tiered storage [kafka]

showuon commented on code in PR #15690: URL: https://github.com/apache/kafka/pull/15690#discussion_r1565635052 ## core/src/main/java/kafka/server/TierStateMachine.java: ## @@ -40,7 +92,72 @@ public interface TierStateMachine { */ PartitionFetchState start(TopicPartiti

Re: [PR] MINOR: Various cleanups in storage [kafka]

mimaison merged PR #15711: URL: https://github.com/apache/kafka/pull/15711 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-15230) ApiVersions data between controllers is not reliable

[ https://issues.apache.org/jira/browse/KAFKA-15230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-15230. Fix Version/s: (was: 3.7.0) Resolution: Duplicate this is fixed by https://issu

[jira] [Reopened] (KAFKA-15230) ApiVersions data between controllers is not reliable

[ https://issues.apache.org/jira/browse/KAFKA-15230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reopened KAFKA-15230: reopen to make it as duplicate > ApiVersions data between controllers is not reliable > -

[jira] [Resolved] (KAFKA-15369) Allow AdminClient to Talk Directly with the KRaft Controller Quorum and add Controller Registration

[ https://issues.apache.org/jira/browse/KAFKA-15369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-15369. Fix Version/s: 3.7.0 Assignee: Colin McCabe Resolution: Fixed > Allow Admi

  1   2   >