Re: [PR] KAFKA-15396:Add a metric indicating the version of the current running kafka server [kafka]

2024-04-17 Thread via GitHub
hudeqi closed pull request #14284: KAFKA-15396:Add a metric indicating the version of the current running kafka server URL: https://github.com/apache/kafka/pull/14284 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] KAFKA-15134:Enrich the prompt reason in CommitFailedException [kafka]

2024-04-17 Thread via GitHub
hudeqi closed pull request #13930: KAFKA-15134:Enrich the prompt reason in CommitFailedException URL: https://github.com/apache/kafka/pull/13930 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] KAFKA-14824: ReplicaAlterLogDirsThread may cause serious disk growing in case of potential exception [kafka]

2024-04-17 Thread via GitHub
hudeqi closed pull request #13421: KAFKA-14824: ReplicaAlterLogDirsThread may cause serious disk growing in case of potential exception URL: https://github.com/apache/kafka/pull/13421 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] KAFKA-15086:Set a reasonable segment size upper limit for MM2 internal topics [kafka]

2024-04-17 Thread via GitHub
hudeqi closed pull request #13852: KAFKA-15086:Set a reasonable segment size upper limit for MM2 internal topics URL: https://github.com/apache/kafka/pull/13852 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] KAFKA-14906:Extract the coordinator service log from server log [kafka]

2024-04-17 Thread via GitHub
hudeqi closed pull request #13568: KAFKA-14906:Extract the coordinator service log from server log URL: https://github.com/apache/kafka/pull/13568 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-15119:Support incremental syncTopicAcls in MirrorSourceConnector [kafka]

2024-04-17 Thread via GitHub
hudeqi closed pull request #13913: KAFKA-15119:Support incremental syncTopicAcls in MirrorSourceConnector URL: https://github.com/apache/kafka/pull/13913 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Created] (KAFKA-16582) Feature Request: Introduce max.record.size Configuration Parameter for Producers

2024-04-17 Thread Ramiz Mehran (Jira)
Ramiz Mehran created KAFKA-16582: Summary: Feature Request: Introduce max.record.size Configuration Parameter for Producers Key: KAFKA-16582 URL: https://issues.apache.org/jira/browse/KAFKA-16582 Proj

[jira] [Commented] (KAFKA-10034) Clarify Usage of "batch.size" and "max.request.size" Producer Configs

2024-04-17 Thread Ramiz Mehran (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17838450#comment-17838450 ] Ramiz Mehran commented on KAFKA-10034: -- "Firstly, this configuration is a cap on th

[jira] (KAFKA-10034) Clarify Usage of "batch.size" and "max.request.size" Producer Configs

2024-04-17 Thread Ramiz Mehran (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10034 ] Ramiz Mehran deleted comment on KAFKA-10034: -- was (Author: JIRAUSER290918): "Firstly, this configuration is a cap on the maximum uncompressed record batch size." should be changed to "First

[jira] [Commented] (KAFKA-10034) Clarify Usage of "batch.size" and "max.request.size" Producer Configs

2024-04-17 Thread Ramiz Mehran (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17838447#comment-17838447 ] Ramiz Mehran commented on KAFKA-10034: -- "Firstly, this configuration is a cap on th

Re: [PR] KAFKA-16197: Print Connect worker specific logs on poll timeout expiry [kafka]

2024-04-17 Thread via GitHub
vamossagar12 commented on PR #15305: URL: https://github.com/apache/kafka/pull/15305#issuecomment-2062936947 @showuon , just checking did you get a chance to look at the updated test? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (KAFKA-16467) Add README to docs folder

2024-04-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17838438#comment-17838438 ] ASF GitHub Bot commented on KAFKA-16467: showuon merged PR #596: URL: https://gi

Re: [PR] KAFKA-16424: remove truncated logs after alter dir [kafka]

2024-04-17 Thread via GitHub
showuon commented on PR #15616: URL: https://github.com/apache/kafka/pull/15616#issuecomment-2062889530 @FrankYang0529 , there is checkstyle error: `[2024-04-17T14:04:27.072Z] [ant:checkstyle] [ERROR] /home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-15616/storage/src/main/java/org/

Re: [PR] KAFKA-16424: remove truncated logs after alter dir [kafka]

2024-04-17 Thread via GitHub
showuon commented on code in PR #15616: URL: https://github.com/apache/kafka/pull/15616#discussion_r1569846240 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogSegment.java: ## @@ -801,8 +803,23 @@ private Void deleteTypeIfExists(StorageAction delete, Stri

Re: [PR] KAFKA-16073: Increment the local-log-start-offset before deleting segments in memory table [kafka]

2024-04-17 Thread via GitHub
showuon merged PR #15747: URL: https://github.com/apache/kafka/pull/15747 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-16073: Increment the local-log-start-offset before deleting segments in memory table [kafka]

2024-04-17 Thread via GitHub
showuon commented on PR #15747: URL: https://github.com/apache/kafka/pull/15747#issuecomment-2062884304 Failed tests are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] KAFKA-16073: Increment the local-log-start-offset before deleting segments in memory table [kafka]

2024-04-17 Thread via GitHub
showuon commented on PR #15748: URL: https://github.com/apache/kafka/pull/15748#issuecomment-2062882937 Looks like `LogCleanerParameterizedIntegrationTest` failed due to this change. Please take a look. Thanks. https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-15748/1/#showF

Re: [PR] KAFKA-16561: Disable `allow.auto.create.topics` in MirrorMaker2 Consumer Config [kafka]

2024-04-17 Thread via GitHub
aaron-ai commented on code in PR #15728: URL: https://github.com/apache/kafka/pull/15728#discussion_r1569813058 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorConnectorConfig.java: ## @@ -169,6 +170,7 @@ static Map sourceConsumerConfig(Map props) {

[jira] [Commented] (KAFKA-16574) The metrics of LogCleaner disappear after reconfiguration

2024-04-17 Thread Chia Chuan Yu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17838420#comment-17838420 ] Chia Chuan Yu commented on KAFKA-16574: --- Hi, [~chia7712]  Can I have this one ? t

Re: [PR] MINOR: Modify SocketServer#sendResponse trace msg [kafka]

2024-04-17 Thread via GitHub
TaiJuWu commented on code in PR #15749: URL: https://github.com/apache/kafka/pull/15749#discussion_r1569739083 ## core/src/main/scala/kafka/network/SocketServer.scala: ## @@ -1082,7 +1082,7 @@ private[kafka] class Processor( // `protected` for test usage protected[network]

Re: [PR] MINOR: Modify SocketServer#sendResponse trace msg [kafka]

2024-04-17 Thread via GitHub
TaiJuWu closed pull request #15749: MINOR: Modify SocketServer#sendResponse trace msg URL: https://github.com/apache/kafka/pull/15749 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[jira] [Updated] (KAFKA-16577) New consumer fails with stop within allotted timeout in consumer_test.py system test

2024-04-17 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16577: -- Description: The {{consumer_test.py}} system test intermittently fails with the following error: {co

[jira] [Updated] (KAFKA-16577) New consumer fails with stop within allotted timeout in consumer_test.py system test

2024-04-17 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16577: -- Summary: New consumer fails with stop within allotted timeout in consumer_test.py system test (was: N

Re: [PR] KAFKA-16308 [1/N]: Create FeatureVersion interface and add `--feature` flag and handling to StorageTool [kafka]

2024-04-17 Thread via GitHub
jolshan commented on PR #15685: URL: https://github.com/apache/kafka/pull/15685#issuecomment-2062753494 I noticed I need to do Quorum and Broker features which are basically the same implementation. Stay tuned. -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Created] (KAFKA-16581) Implement KafkaRaftClient unittest for membership change

2024-04-17 Thread Jira
José Armando García Sancio created KAFKA-16581: -- Summary: Implement KafkaRaftClient unittest for membership change Key: KAFKA-16581 URL: https://issues.apache.org/jira/browse/KAFKA-16581 P

[jira] [Updated] (KAFKA-16580) Write simulation tests for kraft membership change

2024-04-17 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-16580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-16580: --- Description: Update RaftEventSimulationTest to validate kraft.version

[jira] [Created] (KAFKA-16580) Write simulation tests for kraft membership change

2024-04-17 Thread Jira
José Armando García Sancio created KAFKA-16580: -- Summary: Write simulation tests for kraft membership change Key: KAFKA-16580 URL: https://issues.apache.org/jira/browse/KAFKA-16580 Project

[jira] [Updated] (KAFKA-14094) KIP-853: KRaft controller membership changes

2024-04-17 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-14094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-14094: --- Fix Version/s: 3.8.0 > KIP-853: KRaft controller membership changes

[jira] [Updated] (KAFKA-14094) KIP-853: KRaft controller membership changes

2024-04-17 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-14094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-14094: --- Labels: (was: 4.0-blocker) > KIP-853: KRaft controller membership

[jira] [Commented] (KAFKA-16557) Fix OffsetFetchRequestState.toString()

2024-04-17 Thread Fu Qiao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17838402#comment-17838402 ] Fu Qiao commented on KAFKA-16557: - Created a PR for this if you don't mind: [https://gi

[PR] KAFKA-16557: Fix toString of OffsetFetchRequestState [kafka]

2024-04-17 Thread via GitHub
phooq opened a new pull request, #15750: URL: https://github.com/apache/kafka/pull/15750 ### Description This PR is for [KAFKA-16557](https://issues.apache.org/jira/browse/KAFKA-16557). This is to enhance the debugging and troubleshooting for consumer related issues. ### Test

[jira] [Updated] (KAFKA-16579) Revert changes to consumer_rolling_upgrade_test.py for the new async Consumer

2024-04-17 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16579: -- Description: To test the new, asynchronous Kafka {{Consumer}} implementation, we migrated a slew of s

[jira] [Updated] (KAFKA-16579) Revert changes to consumer_rolling_upgrade_test.py for the new async Consumer

2024-04-17 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16579: -- Description: To test the new, asynchronous Kafka {{Consumer}} implementation, we migrated a slew of s

[jira] [Updated] (KAFKA-16578) Revert changes to connect_distributed_test.py for the new async Consumer

2024-04-17 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16578: -- Description: To test the new, asynchronous Kafka {{Consumer}} implementation, we migrated a slew of s

[jira] [Created] (KAFKA-16579) Revert changes to consumer_rolling_upgrade_test.py for the new async Consumer

2024-04-17 Thread Kirk True (Jira)
Kirk True created KAFKA-16579: - Summary: Revert changes to consumer_rolling_upgrade_test.py for the new async Consumer Key: KAFKA-16579 URL: https://issues.apache.org/jira/browse/KAFKA-16579 Project: Kafk

[jira] [Assigned] (KAFKA-16579) Revert changes to consumer_rolling_upgrade_test.py for the new async Consumer

2024-04-17 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-16579: - Assignee: Philip Nee (was: Kirk True) > Revert changes to consumer_rolling_upgrade_test.py for

[jira] [Created] (KAFKA-16578) Revert changes to connect_distributed_test.py for the new async Consumer

2024-04-17 Thread Kirk True (Jira)
Kirk True created KAFKA-16578: - Summary: Revert changes to connect_distributed_test.py for the new async Consumer Key: KAFKA-16578 URL: https://issues.apache.org/jira/browse/KAFKA-16578 Project: Kafka

[jira] [Updated] (KAFKA-16576) New consumer fails with assert in consumer_test.py’s test_consumer_failure system test

2024-04-17 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16576: -- Labels: flaky-test kip-848-client-support system-tests (was: kip-848-client-support system-tests) >

[jira] [Updated] (KAFKA-16577) New consumer fails with stop within allotted timeout in consumer_test.py’s test_consumer_bounce system test

2024-04-17 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16577: -- Labels: flaky-test kip-848-client-support system-tests (was: kip-848-client-support system-tests) >

[jira] [Updated] (KAFKA-16577) New consumer fails with stop within allotted timeout in consumer_test.py’s test_consumer_bounce system test

2024-04-17 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16577: -- Description: The {{consumer_test.py}} system test intermittently fails with the following error: {co

[jira] [Updated] (KAFKA-16577) New consumer fails with stop within allotted timeout in consumer_test.py’s test_consumer_bounce system test

2024-04-17 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16577: -- Summary: New consumer fails with stop within allotted timeout in consumer_test.py’s test_consumer_boun

[jira] [Created] (KAFKA-16577) New consumer fails with stop timeout in consumer_test.py’s test_consumer_bounce system test

2024-04-17 Thread Kirk True (Jira)
Kirk True created KAFKA-16577: - Summary: New consumer fails with stop timeout in consumer_test.py’s test_consumer_bounce system test Key: KAFKA-16577 URL: https://issues.apache.org/jira/browse/KAFKA-16577

[jira] [Updated] (KAFKA-16576) New consumer fails with assert in consumer_test.py’s test_consumer_failure system test

2024-04-17 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16576: -- Description: The {{consumer_test.py}} system test intermittently fails with the following error: {co

[jira] [Created] (KAFKA-16576) New consumer fails with assert in consumer_test.py’s test_consumer_failure system test

2024-04-17 Thread Kirk True (Jira)
Kirk True created KAFKA-16576: - Summary: New consumer fails with assert in consumer_test.py’s test_consumer_failure system test Key: KAFKA-16576 URL: https://issues.apache.org/jira/browse/KAFKA-16576 Proj

[jira] [Commented] (KAFKA-16557) Fix OffsetFetchRequestState.toString()

2024-04-17 Thread Fu Qiao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17838384#comment-17838384 ] Fu Qiao commented on KAFKA-16557: - Hey [~kirktrue] : I am new to Kafka, and would like t

Re: [PR] MINOR: Modify SocketServer#sendResponse trace msg [kafka]

2024-04-17 Thread via GitHub
splett2 commented on code in PR #15749: URL: https://github.com/apache/kafka/pull/15749#discussion_r1569578496 ## core/src/main/scala/kafka/network/SocketServer.scala: ## @@ -1082,7 +1082,7 @@ private[kafka] class Processor( // `protected` for test usage protected[network]

Re: [PR] KAFKA-16452: Bound high-watermark offset to range between LLSO and LEO [kafka]

2024-04-17 Thread via GitHub
junrao commented on code in PR #15634: URL: https://github.com/apache/kafka/pull/15634#discussion_r1569562746 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -282,15 +282,15 @@ class UnifiedLog(@volatile var logStartOffset: Long, /** * Update high watermark wit

Re: [PR] KAFKA-16555: Consumer's RequestState has incorrect logic to determine if inflight [kafka]

2024-04-17 Thread via GitHub
philipnee commented on code in PR #15723: URL: https://github.com/apache/kafka/pull/15723#discussion_r1569554430 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CoordinatorRequestManager.java: ## @@ -98,15 +98,15 @@ public NetworkClientDelegate.PollResult po

[PR] MINOR: Modify SocketServer#sendResponse trace msg [kafka]

2024-04-17 Thread via GitHub
TaiJuWu opened a new pull request, #15749: URL: https://github.com/apache/kafka/pull/15749 As title. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (includ

Re: [PR] KAFKA-16528: Client HB timing fix [kafka]

2024-04-17 Thread via GitHub
lianetm commented on PR #15698: URL: https://github.com/apache/kafka/pull/15698#issuecomment-2062253184 Thanks for the comments @kirktrue, all addressed. Regarding your comment regarding tests [here](https://github.com/apache/kafka/pull/15698#pullrequestreview-2004676007), we have t

Re: [PR] KAFKA-16528: Client HB timing fix [kafka]

2024-04-17 Thread via GitHub
lianetm commented on code in PR #15698: URL: https://github.com/apache/kafka/pull/15698#discussion_r1569511540 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ## @@ -231,6 +231,35 @@ public void testTimerNotDue() {

Re: [PR] KAFKA-16571: reassign_partitions_test.bounce_brokers should wait for messages to be sent to every partition [kafka]

2024-04-17 Thread via GitHub
jolshan commented on PR #15739: URL: https://github.com/apache/kafka/pull/15739#issuecomment-2062215298 I ran the test 3 times and it seems to be working ok. I can run a few more times if we want to confirm the flakiness is gone. -- This is an automated message from the Apache Git Service

Re: [PR] KAFKA-16528: Client HB timing fix [kafka]

2024-04-17 Thread via GitHub
lianetm commented on code in PR #15698: URL: https://github.com/apache/kafka/pull/15698#discussion_r1569504137 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -482,6 +482,15 @@ public long nextHeartbeatMs(final long curren

Re: [PR] KAFKA-16528: Client HB timing fix [kafka]

2024-04-17 Thread via GitHub
lianetm commented on code in PR #15698: URL: https://github.com/apache/kafka/pull/15698#discussion_r1569498394 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -380,7 +380,7 @@ private void onErrorResponse(final ConsumerGr

Re: [PR] MINOR: Remove unneeded explicit type arguments [kafka]

2024-04-17 Thread via GitHub
mimaison merged PR #15736: URL: https://github.com/apache/kafka/pull/15736 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-15853: Move KafkaConfig log properties and docs out of core [kafka]

2024-04-17 Thread via GitHub
OmniaGM commented on code in PR #15569: URL: https://github.com/apache/kafka/pull/15569#discussion_r1569436277 ## core/src/main/scala/kafka/server/ZkAdminManager.scala: ## @@ -80,10 +80,10 @@ class ZkAdminManager(val config: KafkaConfig, private val configHelper = new ConfigH

Re: [PR] MINOR: Remove unneeded explicit type arguments [kafka]

2024-04-17 Thread via GitHub
mimaison commented on PR #15736: URL: https://github.com/apache/kafka/pull/15736#issuecomment-2062104700 None of the test failures are related, merging to trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] KAFKA-16554: Online downgrade triggering and group type conversion [kafka]

2024-04-17 Thread via GitHub
dongnuo123 commented on code in PR #15721: URL: https://github.com/apache/kafka/pull/15721#discussion_r1569413973 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -777,6 +778,59 @@ public ClassicGroup classicGroup( }

Re: [PR] Fix typo [kafka]

2024-04-17 Thread via GitHub
birdoplank closed pull request #15743: Fix typo URL: https://github.com/apache/kafka/pull/15743 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-uns

Re: [PR] KAFKA-16554: Online downgrade triggering and group type conversion [kafka]

2024-04-17 Thread via GitHub
dongnuo123 commented on code in PR #15721: URL: https://github.com/apache/kafka/pull/15721#discussion_r1569405350 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -775,6 +777,126 @@ public ClassicGroup classicGroup(

Re: [PR] KAFKA-16565: IncrementalAssignmentConsumerEventHandler throws error when attempting to remove a partition that isn't assigned [kafka]

2024-04-17 Thread via GitHub
lianetm commented on code in PR #15737: URL: https://github.com/apache/kafka/pull/15737#discussion_r1569396277 ## tests/kafkatest/services/verifiable_consumer.py: ## @@ -140,22 +150,32 @@ class IncrementalAssignmentConsumerEventHandler(ConsumerEventHandler): def __init__(s

Re: [PR] KAFKA-16073: Increment the local-log-start-offset before deleting segments in memory table [kafka]

2024-04-17 Thread via GitHub
kamalcph commented on PR #15631: URL: https://github.com/apache/kafka/pull/15631#issuecomment-2062050733 > @kamalcph : Do you want this PR to be in 3.7 and 3.6? If so, could you create a separate cherry-pick RP? Thanks. Opened #15747 and #15748 to backport it to 3.7 and 3.6 branches.

[PR] KAFKA-16073: Increment the local-log-start-offset before deleting segments in memory table [kafka]

2024-04-17 Thread via GitHub
kamalcph opened a new pull request, #15748: URL: https://github.com/apache/kafka/pull/15748 cherry-picked from: d092787487047178c674bd60a182129a8d997c4a Co-authored-by: hzh0425 <642256...@qq.com> ### Committer Checklist (excluded from commit message) - [ ] Verify design and i

Re: [PR] KAFKA-16452: Bound high-watermark offset to range between LLSO and LEO [kafka]

2024-04-17 Thread via GitHub
kamalcph commented on code in PR #15634: URL: https://github.com/apache/kafka/pull/15634#discussion_r1569356239 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1223,6 +1223,12 @@ class UnifiedLog(@volatile var logStartOffset: Long, s"but we only have log segme

Re: [PR] KAFKA-16452: Bound high-watermark offset to range between LLSO and LEO [kafka]

2024-04-17 Thread via GitHub
kamalcph commented on code in PR #15634: URL: https://github.com/apache/kafka/pull/15634#discussion_r1563885907 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -282,15 +282,15 @@ class UnifiedLog(@volatile var logStartOffset: Long, /** * Update high watermark w

[PR] KAFKA-16073: Increment the local-log-start-offset before deleting segments in memory table [kafka]

2024-04-17 Thread via GitHub
kamalcph opened a new pull request, #15747: URL: https://github.com/apache/kafka/pull/15747 cherry-picked from: d092787487047178c674bd60a182129a8d997c4a Co-authored-by: hzh0425 <642256...@qq.com> ### Committer Checklist (excluded from commit message) - [ ] Verify design and i

[jira] [Created] (KAFKA-16575) Automatically remove KTable aggregation result when group becomes empty

2024-04-17 Thread Matthias J. Sax (Jira)
Matthias J. Sax created KAFKA-16575: --- Summary: Automatically remove KTable aggregation result when group becomes empty Key: KAFKA-16575 URL: https://issues.apache.org/jira/browse/KAFKA-16575 Project

Re: [PR] KAFKA-16452: Bound high-watermark offset to range between LLSO and LEO [kafka]

2024-04-17 Thread via GitHub
kamalcph commented on code in PR #15634: URL: https://github.com/apache/kafka/pull/15634#discussion_r1569328393 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -282,15 +282,15 @@ class UnifiedLog(@volatile var logStartOffset: Long, /** * Update high watermark w

Re: [PR] KAFKA-16572: allow defining number of disks per broker in ClusterTest [kafka]

2024-04-17 Thread via GitHub
chia7712 commented on code in PR #15745: URL: https://github.com/apache/kafka/pull/15745#discussion_r1569310965 ## core/src/test/java/kafka/testkit/TestKitNodes.java: ## @@ -82,6 +82,10 @@ public Builder setNumBrokerNodes(int numBrokerNodes) { return setBrokerNodes(

[jira] [Created] (KAFKA-16574) The metrics of LogCleaner disappear after reconfiguration

2024-04-17 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-16574: -- Summary: The metrics of LogCleaner disappear after reconfiguration Key: KAFKA-16574 URL: https://issues.apache.org/jira/browse/KAFKA-16574 Project: Kafka

[jira] [Commented] (KAFKA-16522) Admin client changes for adding and removing voters

2024-04-17 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-16522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17838347#comment-17838347 ] José Armando García Sancio commented on KAFKA-16522: [~phong260702]

[jira] [Resolved] (KAFKA-16405) Mismatch assignment error when running consumer rolling upgrade system tests

2024-04-17 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True resolved KAFKA-16405. --- Reviewer: Lucas Brutschy Resolution: Fixed > Mismatch assignment error when running consumer r

Re: [PR] KAFKA-16452: Bound high-watermark offset to range between LLSO and LEO [kafka]

2024-04-17 Thread via GitHub
kamalcph commented on code in PR #15634: URL: https://github.com/apache/kafka/pull/15634#discussion_r1563885907 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -282,15 +282,15 @@ class UnifiedLog(@volatile var logStartOffset: Long, /** * Update high watermark w

Re: [PR] KAFKA-16082: Avoid resuming future replica if current replica is in the same directory [kafka]

2024-04-17 Thread via GitHub
chia7712 commented on code in PR #15136: URL: https://github.com/apache/kafka/pull/15136#discussion_r1569178614 ## core/src/main/scala/kafka/log/LogManager.scala: ## @@ -1189,50 +1216,63 @@ class LogManager(logDirs: Seq[File], val sourceLog = currentLogs.get(topicPartitio

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

2024-04-17 Thread via GitHub
splett2 commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1569269269 ## metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java: ## @@ -2117,6 +2117,20 @@ ListPartitionReassignmentsResponseData listPartitionRea

[jira] [Updated] (KAFKA-16003) The znode /config/topics is not updated during KRaft migration in "dual-write" mode

2024-04-17 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-16003: - Fix Version/s: 3.7.1 > The znode /config/topics is not updated during KRaft migration in > "dua

Re: [PR] KAFKA-16480: Bump ListOffsets version, IBP version and mark last version of ListOffsets as unstable [kafka]

2024-04-17 Thread via GitHub
junrao commented on code in PR #15673: URL: https://github.com/apache/kafka/pull/15673#discussion_r1569221453 ## clients/src/main/java/org/apache/kafka/common/requests/ListOffsetsRequest.java: ## @@ -70,7 +70,7 @@ else if (isolationLevel == IsolationLevel.READ_COMMITTED)

Re: [PR] KAFKA-15853: Move KafkaConfig log properties and docs out of core [kafka]

2024-04-17 Thread via GitHub
mimaison commented on code in PR #15569: URL: https://github.com/apache/kafka/pull/15569#discussion_r1569237791 ## core/src/main/scala/kafka/server/ZkAdminManager.scala: ## @@ -80,10 +80,10 @@ class ZkAdminManager(val config: KafkaConfig, private val configHelper = new Config

Re: [PR] KAFKA-16103: AsyncConsumer should await pending async commits on commitSync and close [kafka]

2024-04-17 Thread via GitHub
kirktrue commented on code in PR #15613: URL: https://github.com/apache/kafka/pull/15613#discussion_r1569228945 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java: ## @@ -616,6 +620,80 @@ public void testCommitSyncTriggersFencedExce

Re: [PR] KAFKA-16103: AsyncConsumer should await pending async commits on commitSync and close [kafka]

2024-04-17 Thread via GitHub
kirktrue commented on code in PR #15613: URL: https://github.com/apache/kafka/pull/15613#discussion_r1569232314 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java: ## @@ -616,6 +620,80 @@ public void testCommitSyncTriggersFencedExce

Re: [PR] KAFKA-16103: AsyncConsumer should await pending async commits on commitSync and close [kafka]

2024-04-17 Thread via GitHub
kirktrue commented on code in PR #15613: URL: https://github.com/apache/kafka/pull/15613#discussion_r1569231774 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java: ## @@ -616,6 +620,80 @@ public void testCommitSyncTriggersFencedExce

Re: [PR] KAFKA-16103: AsyncConsumer should await pending async commits on commitSync and close [kafka]

2024-04-17 Thread via GitHub
kirktrue commented on code in PR #15613: URL: https://github.com/apache/kafka/pull/15613#discussion_r1569226961 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -793,9 +795,9 @@ public void commitAsync(Map offsets, OffsetCo

Re: [PR] KAFKA-16298: Ensure rebalance listener exceptions are propagated to the user on consumer poll [kafka]

2024-04-17 Thread via GitHub
kirktrue commented on code in PR #15742: URL: https://github.com/apache/kafka/pull/15742#discussion_r1569217494 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -228,13 +228,16 @@ private void process(final ErrorEvent event) {

Re: [PR] MINOR: move topic configuration defaults [kafka]

2024-04-17 Thread via GitHub
cmccabe closed pull request #10589: MINOR: move topic configuration defaults URL: https://github.com/apache/kafka/pull/10589 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

2024-04-17 Thread via GitHub
CalvinConfluent commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1569214320 ## metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java: ## @@ -2117,6 +2117,20 @@ ListPartitionReassignmentsResponseData listPart

Re: [PR] KAFKA-16539 Fix IncrementalAlterConfigs during ZK migration [kafka]

2024-04-17 Thread via GitHub
mumrah commented on code in PR #15744: URL: https://github.com/apache/kafka/pull/15744#discussion_r1569214270 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -3003,9 +3008,10 @@ class KafkaApis(val requestChannel: RequestChannel, } } +// Forwarding h

Re: [PR] MINOR: Fix some flaky behavior in DeleteConsumerGroupsTest and clean up [kafka]

2024-04-17 Thread via GitHub
cmccabe closed pull request #8115: MINOR: Fix some flaky behavior in DeleteConsumerGroupsTest and clean up URL: https://github.com/apache/kafka/pull/8115 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] KAFKA-14370: Simplify the ImageWriter API by adding freeze [kafka]

2024-04-17 Thread via GitHub
cmccabe closed pull request #12833: KAFKA-14370: Simplify the ImageWriter API by adding freeze URL: https://github.com/apache/kafka/pull/12833 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

2024-04-17 Thread via GitHub
CalvinConfluent commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1569210550 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -2360,4 +2363,9 @@ void setNewNextWriteOffset(long newNextWriteOffset) {

Re: [PR] KAFKA-16539 Fix IncrementalAlterConfigs during ZK migration [kafka]

2024-04-17 Thread via GitHub
mumrah commented on code in PR #15744: URL: https://github.com/apache/kafka/pull/15744#discussion_r1569208039 ## core/src/main/scala/kafka/zk/KafkaZkClient.scala: ## @@ -467,13 +470,33 @@ class KafkaZkClient private[zk] (zooKeeperClient: ZooKeeperClient, isSecure: Boo * @pa

[jira] [Updated] (KAFKA-16570) FenceProducers API returns "unexpected error" when successful

2024-04-17 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan updated KAFKA-16570: --- Description: When we want to fence a producer using the admin client, we send an InitProduc

Re: [PR] KAFKA-13152: Kip 770 buffer size fix [kafka]

2024-04-17 Thread via GitHub
ableegoldman commented on PR #13283: URL: https://github.com/apache/kafka/pull/13283#issuecomment-2061827689 No pressure! Just wanted to make sure you weren't still waiting on me for this. Or rather, just wanted to say, if you do want to try and get this in to 3.8 I will make sure to help y

Re: [PR] KAFKA-16561: Disable `allow.auto.create.topics` in MirrorMaker2 Consumer Config [kafka]

2024-04-17 Thread via GitHub
C0urante commented on code in PR #15728: URL: https://github.com/apache/kafka/pull/15728#discussion_r1569197938 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorConnectorConfig.java: ## @@ -169,6 +170,7 @@ static Map sourceConsumerConfig(Map props) {

[PR] KAFKA-16461: New consumer fails to consume records in security_test.py system test [kafka]

2024-04-17 Thread via GitHub
kirktrue opened a new pull request, #15746: URL: https://github.com/apache/kafka/pull/15746 The system test was failing because the `VerifiableConsumer` failed with a `NullPointerException` during startup. The reason for the NPE was an attempt to put a `null` as the value of `--group-remote

Re: [PR] KAFKA-16539 Fix IncrementalAlterConfigs during ZK migration [kafka]

2024-04-17 Thread via GitHub
akhileshchg commented on code in PR #15744: URL: https://github.com/apache/kafka/pull/15744#discussion_r1569190991 ## core/src/main/scala/kafka/zk/KafkaZkClient.scala: ## @@ -467,13 +470,33 @@ class KafkaZkClient private[zk] (zooKeeperClient: ZooKeeperClient, isSecure: Boo

Re: [PR] KAFKA-16572: allow defining number of disks per broker in ClusterTest [kafka]

2024-04-17 Thread via GitHub
gaurav-narula commented on code in PR #15745: URL: https://github.com/apache/kafka/pull/15745#discussion_r1569160539 ## core/src/test/java/kafka/test/junit/RaftClusterInvocationContext.java: ## @@ -93,7 +93,7 @@ public List getAdditionalExtensions() { TestKitNod

Re: [PR] KAFKA-16483: migrate DeleteOffsetsConsumerGroupCommandIntegrationTest to use ClusterTestExtensions [kafka]

2024-04-17 Thread via GitHub
chia7712 commented on PR #15679: URL: https://github.com/apache/kafka/pull/15679#issuecomment-2061751961 @FrankYang0529 Could you reduce the partition number of offsets topic? It seems the timeout is caused by that coordinator is waiting for the offset partition, and our CI could be too bus

Re: [PR] KAFKA-16073: Increment the local-log-start-offset before deleting segments in memory table [kafka]

2024-04-17 Thread via GitHub
junrao commented on PR #15631: URL: https://github.com/apache/kafka/pull/15631#issuecomment-2061739168 @kamalcph : Do you want this PR to be in 3.7 and 3.6? If so, could you create a separate cherry-pick RP? Thanks. -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] KAFKA-16073: Increment the local-log-start-offset before deleting segments in memory table [kafka]

2024-04-17 Thread via GitHub
junrao merged PR #15631: URL: https://github.com/apache/kafka/pull/15631 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

Re: [PR] KAFKA-16073: Increment the local-log-start-offset before deleting segments in memory table [kafka]

2024-04-17 Thread via GitHub
junrao commented on PR #15631: URL: https://github.com/apache/kafka/pull/15631#issuecomment-2061732009 @kamalcph : Thanks for triaging the failed tests. The PR LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

  1   2   >