[
https://issues.apache.org/jira/browse/KAFKA-12511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17838878#comment-17838878
]
Josep Prat commented on KAFKA-12511:
Another instance:
https://ci-builds.apache.org/
[
https://issues.apache.org/jira/browse/KAFKA-15146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17838877#comment-17838877
]
Josep Prat commented on KAFKA-15146:
Another instance here:
https://ci-builds.apach
Ritika Reddy created KAFKA-16587:
Summary: Store subscription model for consumer group in group state
Key: KAFKA-16587
URL: https://issues.apache.org/jira/browse/KAFKA-16587
Project: Kafka
Is
github-actions[bot] commented on PR #15181:
URL: https://github.com/apache/kafka/pull/15181#issuecomment-2065686746
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has merge
github-actions[bot] commented on PR #15223:
URL: https://github.com/apache/kafka/pull/15223#issuecomment-2065686726
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has merge
github-actions[bot] commented on PR #15224:
URL: https://github.com/apache/kafka/pull/15224#issuecomment-2065686700
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has merge
FrankYang0529 commented on PR #15679:
URL: https://github.com/apache/kafka/pull/15679#issuecomment-2065616140
> > @FrankYang0529 Could you reduce the partition number of offsets topic?
It seems the timeout is caused by that coordinator is waiting for the offset
partition, and our CI could b
mjsax merged PR #15660:
URL: https://github.com/apache/kafka/pull/15660
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
Matthias J. Sax created KAFKA-16586:
---
Summary: Test TaskAssignorConvergenceTest failing
Key: KAFKA-16586
URL: https://issues.apache.org/jira/browse/KAFKA-16586
Project: Kafka
Issue Type: Te
[
https://issues.apache.org/jira/browse/KAFKA-16514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17838829#comment-17838829
]
Matthias J. Sax commented on KAFKA-16514:
-
Thanks for the input. I was not revie
[
https://issues.apache.org/jira/browse/KAFKA-16573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-16573:
Priority: Minor (was: Major)
> Streams does not specify where a Serde is needed
> ---
[
https://issues.apache.org/jira/browse/KAFKA-16573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17838827#comment-17838827
]
Matthias J. Sax commented on KAFKA-16573:
-
Thanks for filing this ticket. I thin
[
https://issues.apache.org/jira/browse/KAFKA-16280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax resolved KAFKA-16280.
-
Resolution: Done
> Expose method to determine Metric Measurability
> ---
[
https://issues.apache.org/jira/browse/KAFKA-16280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-16280:
Issue Type: Improvement (was: Bug)
> Expose method to determine Metric Measurability
> --
mjsax merged PR #15681:
URL: https://github.com/apache/kafka/pull/15681
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
dongnuo123 commented on code in PR #15721:
URL: https://github.com/apache/kafka/pull/15721#discussion_r1571520271
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/Assertions.java:
##
@@ -198,6 +204,62 @@ private static void assertApiMessageAndVersionEquals(
phooq commented on PR #15750:
URL: https://github.com/apache/kafka/pull/15750#issuecomment-2065444919
Hey @lianetm , @kirktrue Thanks for the feedback and suggestions!
I like @kirktrue 's advice on having a `toString()` override at the base
class while each subclass customized the `to
dongnuo123 commented on code in PR #15721:
URL: https://github.com/apache/kafka/pull/15721#discussion_r1571469219
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -777,11 +778,78 @@ public ClassicGroup classicGroup(
jolshan commented on PR #15685:
URL: https://github.com/apache/kafka/pull/15685#issuecomment-2065435357
I may need to figure out how to deal with this...when setting the version to
0.
```
Replayed a FeatureLevelRecord removing feature test.feature.version
```
```
Broker 1
rreddy-22 commented on code in PR #15717:
URL: https://github.com/apache/kafka/pull/15717#discussion_r1571435096
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/group_coordinator/ServerSideAssignorBenchmark.java:
##
@@ -0,0 +1,185 @@
+package org.apache.kafka.jmh.group_coor
kirktrue commented on PR #15750:
URL: https://github.com/apache/kafka/pull/15750#issuecomment-2065387420
We've been encouraged to follow the pattern of having the super class
implement `toString()` and add a `toStringBase()`, like this:
```java
public class Parent {
priv
jolshan opened a new pull request, #15755:
URL: https://github.com/apache/kafka/pull/15755
KIP-890 Part 1 introduced verification of transactions with the transaction
coordinator on the `Produce` and `TxnOffsetCommit` paths. This introduced the
possibility of new errors when responding to t
[
https://issues.apache.org/jira/browse/KAFKA-16570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17838796#comment-17838796
]
Justine Olshan commented on KAFKA-16570:
Hmmm – retries here are a bit strange s
philipnee commented on code in PR #15723:
URL: https://github.com/apache/kafka/pull/15723#discussion_r1571359996
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/RequestState.java:
##
@@ -98,12 +93,11 @@ public boolean canSendRequest(final long currentTimeMs)
rreddy-22 commented on code in PR #15717:
URL: https://github.com/apache/kafka/pull/15717#discussion_r1571348485
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/assignor/ClientSideAssignorBenchmark.java:
##
@@ -0,0 +1,262 @@
+/*
+ * Licensed to the Apache Software Foundatio
rreddy-22 commented on code in PR #15717:
URL: https://github.com/apache/kafka/pull/15717#discussion_r1571339288
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/assignor/ServerSideAssignorBenchmark.java:
##
@@ -0,0 +1,252 @@
+/*
+ * Licensed to the Apache Software Foundatio
lucasbru commented on code in PR #15723:
URL: https://github.com/apache/kafka/pull/15723#discussion_r1571335784
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/RequestState.java:
##
@@ -98,12 +93,11 @@ public boolean canSendRequest(final long currentTimeMs)
rreddy-22 commented on code in PR #15717:
URL: https://github.com/apache/kafka/pull/15717#discussion_r1571327160
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/assignor/ServerSideAssignorBenchmark.java:
##
@@ -0,0 +1,252 @@
+/*
+ * Licensed to the Apache Software Foundatio
[
https://issues.apache.org/jira/browse/KAFKA-16570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17838786#comment-17838786
]
Artem Livshits commented on KAFKA-16570:
> We should just swallow this error and
[
https://issues.apache.org/jira/browse/KAFKA-16386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justine Olshan updated KAFKA-16386:
---
Affects Version/s: 3.7.0
> NETWORK_EXCEPTIONs from transaction verification are not translat
[
https://issues.apache.org/jira/browse/KAFKA-16386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17838768#comment-17838768
]
Justine Olshan commented on KAFKA-16386:
Note: For 3.6, this is only returned in
vamossagar12 commented on code in PR #15305:
URL: https://github.com/apache/kafka/pull/15305#discussion_r1571150850
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorTest.java:
##
@@ -533,6 +536,57 @@ public void testSkippingAssignmen
emitskevich-blp commented on PR #15722:
URL: https://github.com/apache/kafka/pull/15722#issuecomment-2064749720
Is it possible to add unit test?
> I'm not sure whether it's needed here. Effectively, such test would verify
the behavior of deprecated method. What do you think?
We sh
vamossagar12 commented on code in PR #15305:
URL: https://github.com/apache/kafka/pull/15305#discussion_r1571147929
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorTest.java:
##
@@ -533,6 +536,57 @@ public void testSkippingAssignmen
[
https://issues.apache.org/jira/browse/KAFKA-15089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17838754#comment-17838754
]
David Jacot commented on KAFKA-15089:
-
The goal was to also define the “AbstractConf
vamossagar12 commented on code in PR #15305:
URL: https://github.com/apache/kafka/pull/15305#discussion_r1571150850
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorTest.java:
##
@@ -533,6 +536,57 @@ public void testSkippingAssignmen
vamossagar12 commented on code in PR #15305:
URL: https://github.com/apache/kafka/pull/15305#discussion_r1571147929
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorTest.java:
##
@@ -533,6 +536,57 @@ public void testSkippingAssignmen
emitskevich-blp commented on code in PR #15722:
URL: https://github.com/apache/kafka/pull/15722#discussion_r1571063662
##
clients/src/main/java/org/apache/kafka/common/network/Selector.java:
##
@@ -1281,14 +1281,14 @@ private Meter createMeter(Metrics metrics, String
groupName,
[
https://issues.apache.org/jira/browse/KAFKA-16389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philip Nee resolved KAFKA-16389.
Resolution: Fixed
> consumer_test.py’s test_valid_assignment fails with new consumer
> ---
vamossagar12 commented on code in PR #15305:
URL: https://github.com/apache/kafka/pull/15305#discussion_r1571146638
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorTest.java:
##
@@ -533,6 +537,45 @@ public void testSkippingAssignmen
chia7712 commented on code in PR #15569:
URL: https://github.com/apache/kafka/pull/15569#discussion_r1571142879
##
server-common/src/main/java/org/apache/kafka/server/config/KafkaLogConfigs.java:
##
@@ -0,0 +1,188 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
jolshan commented on PR #15559:
URL: https://github.com/apache/kafka/pull/15559#issuecomment-2064671000
I wonder if I should backport this to 3.7 as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
kamalcph commented on code in PR #15634:
URL: https://github.com/apache/kafka/pull/15634#discussion_r1571126880
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -282,15 +282,15 @@ class UnifiedLog(@volatile var logStartOffset: Long,
/**
* Update high watermark w
kamalcph commented on PR #15634:
URL: https://github.com/apache/kafka/pull/15634#issuecomment-2064647379
Thanks @chia7712 for the review!
> log-start-offset-checkpoint is missing and remote storage is enabled. The
logStartOffset will be set to zero, and it seems be a potential issue s
jolshan closed pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets
does not return actual first offsets
URL: https://github.com/apache/kafka/pull/9590
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
OmniaGM commented on code in PR #15569:
URL: https://github.com/apache/kafka/pull/15569#discussion_r1571119979
##
server-common/src/main/java/org/apache/kafka/server/config/KafkaLogConfigs.java:
##
@@ -0,0 +1,188 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
OmniaGM commented on code in PR #15569:
URL: https://github.com/apache/kafka/pull/15569#discussion_r1571099798
##
server-common/src/main/java/org/apache/kafka/server/config/KafkaLogConfigs.java:
##
@@ -0,0 +1,188 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
chia7712 commented on code in PR #15569:
URL: https://github.com/apache/kafka/pull/15569#discussion_r1571093805
##
server-common/src/main/java/org/apache/kafka/server/config/KafkaLogConfigs.java:
##
@@ -0,0 +1,188 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
dajac commented on code in PR #15721:
URL: https://github.com/apache/kafka/pull/15721#discussion_r1571079283
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -777,11 +778,78 @@ public ClassicGroup classicGroup(
}
[
https://issues.apache.org/jira/browse/KAFKA-16566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lianet Magrans updated KAFKA-16566:
---
Labels: kip-848-client-support system-tests (was: kip-848-client-support)
> Update consumer
[
https://issues.apache.org/jira/browse/KAFKA-16566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lianet Magrans updated KAFKA-16566:
---
Component/s: clients
consumer
system tests
> Update consum
[
https://issues.apache.org/jira/browse/KAFKA-16585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17838730#comment-17838730
]
Matthias J. Sax commented on KAFKA-16585:
-
Thanks for raising this ticket. Wonde
[
https://issues.apache.org/jira/browse/KAFKA-16567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17838728#comment-17838728
]
Matthias J. Sax commented on KAFKA-16567:
-
Why is this ticket marked as "blocker
[
https://issues.apache.org/jira/browse/KAFKA-16567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-16567:
Component/s: streams
> Add New Stream Metrics based on KIP-869
> -
[
https://issues.apache.org/jira/browse/KAFKA-16567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-16567:
Labels: kip (was: )
> Add New Stream Metrics based on KIP-869
> -
[
https://issues.apache.org/jira/browse/KAFKA-16263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17838727#comment-17838727
]
Matthias J. Sax commented on KAFKA-16263:
-
Yes, these are the handlers this tick
linu-shibu commented on PR #15620:
URL: https://github.com/apache/kafka/pull/15620#issuecomment-2064470343
> Hi @linu-shibu @showuon this still uses raw types, and so is still
type-unsafe. Fixing that was my motivation for creating the ticket, sorry for
not emphasizing it more.
>
> I
emitskevich-blp commented on code in PR #15722:
URL: https://github.com/apache/kafka/pull/15722#discussion_r1571063662
##
clients/src/main/java/org/apache/kafka/common/network/Selector.java:
##
@@ -1281,14 +1281,14 @@ private Meter createMeter(Metrics metrics, String
groupName,
[
https://issues.apache.org/jira/browse/KAFKA-16336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17838724#comment-17838724
]
Matthias J. Sax commented on KAFKA-16336:
-
The next planned release is 3.8, but
OmniaGM commented on PR #15569:
URL: https://github.com/apache/kafka/pull/15569#issuecomment-2064450248
> > However I'm bit concern that LogConfig seems already huge. What others
prefer? Keep it in KafkaLogConfigs or move them to LogConfig.ServerLogConfig
>
> the most default values o
mumrah merged PR #15470:
URL: https://github.com/apache/kafka/pull/15470
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
gaurav-narula commented on code in PR #15136:
URL: https://github.com/apache/kafka/pull/15136#discussion_r1571030504
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -1178,6 +1178,33 @@ class LogManager(logDirs: Seq[File],
}
}
+ def recoverAbandonedFutureLogs(
birdoplank closed pull request #15752: Fix typos
URL: https://github.com/apache/kafka/pull/15752
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-un
C0urante commented on code in PR #15379:
URL: https://github.com/apache/kafka/pull/15379#discussion_r1571018390
##
connect/transforms/src/test/java/org/apache/kafka/connect/transforms/field/SingleFieldPathTest.java:
##
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Fou
rreddy-22 commented on code in PR #15717:
URL: https://github.com/apache/kafka/pull/15717#discussion_r1571012712
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/assignor/ServerSideAssignorBenchmark.java:
##
@@ -0,0 +1,252 @@
+/*
+ * Licensed to the Apache Software Foundatio
chia7712 commented on code in PR #15136:
URL: https://github.com/apache/kafka/pull/15136#discussion_r1571012160
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -1189,49 +1217,62 @@ class LogManager(logDirs: Seq[File],
val sourceLog = currentLogs.get(topicPartitio
C0urante commented on code in PR #15379:
URL: https://github.com/apache/kafka/pull/15379#discussion_r1571007787
##
connect/transforms/src/test/java/org/apache/kafka/connect/transforms/field/FieldPathNotationTest.java:
##
@@ -0,0 +1,149 @@
+/*
+ * Licensed to the Apache Software
philipnee commented on PR #15753:
URL: https://github.com/apache/kafka/pull/15753#issuecomment-2064308513
@lucasbru - This is just to remove the consumer protocol from testing as it
is not suited for this test. Much appreciated if you get a chance to look at
this.
--
This is an automated
philipnee opened a new pull request, #15753:
URL: https://github.com/apache/kafka/pull/15753
Consumer Rolling Upgrade is meant to test the protocol upgrade for the old
protocol. Therefore, I am removing old changes.
```
C0urante commented on code in PR #15379:
URL: https://github.com/apache/kafka/pull/15379#discussion_r1570998105
##
connect/transforms/src/test/java/org/apache/kafka/connect/transforms/field/FieldPathNotationTest.java:
##
@@ -0,0 +1,149 @@
+/*
+ * Licensed to the Apache Software
philipnee commented on code in PR #15723:
URL: https://github.com/apache/kafka/pull/15723#discussion_r1570988398
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/RequestState.java:
##
@@ -98,12 +93,11 @@ public boolean canSendRequest(final long currentTimeMs)
philipnee commented on code in PR #15723:
URL: https://github.com/apache/kafka/pull/15723#discussion_r1570986831
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/RequestStateTest.java:
##
@@ -48,4 +50,40 @@ public void testRequestStateSimple() {
stat
lianetm commented on PR #15698:
URL: https://github.com/apache/kafka/pull/15698#issuecomment-2064258399
Hey @cadonna, could you take a look when you have chance? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
lianetm commented on PR #15750:
URL: https://github.com/apache/kafka/pull/15750#issuecomment-2064223926
Hey @phooq, thanks for taking on this one. High level question about the
motivation. The `toStringBase` defined in the base class `RequestState`
includes vars that all states have, so tha
viktorsomogyi commented on PR #15697:
URL: https://github.com/apache/kafka/pull/15697#issuecomment-2064216189
Rebased on latest trunk as there were some conflicts. Addressed some of the
comments but there are 2 things I need to investigate:
* `LogDirFailureTest` fails in `@AfterAll` likel
cadonna commented on code in PR #15613:
URL: https://github.com/apache/kafka/pull/15613#discussion_r1570932239
##
core/src/test/scala/integration/kafka/api/PlaintextConsumerCommitTest.scala:
##
@@ -304,6 +304,64 @@ class PlaintextConsumerCommitTest extends
AbstractConsumerTest
C0urante commented on code in PR #15379:
URL: https://github.com/apache/kafka/pull/15379#discussion_r1570962332
##
connect/transforms/src/main/java/org/apache/kafka/connect/transforms/field/SingleFieldPath.java:
##
@@ -0,0 +1,258 @@
+/*
+ * Licensed to the Apache Software Founda
gaurav-narula commented on code in PR #15136:
URL: https://github.com/apache/kafka/pull/15136#discussion_r1570959086
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -1189,49 +1217,62 @@ class LogManager(logDirs: Seq[File],
val sourceLog = currentLogs.get(topicPar
C0urante commented on code in PR #15379:
URL: https://github.com/apache/kafka/pull/15379#discussion_r1570960525
##
connect/transforms/src/main/java/org/apache/kafka/connect/transforms/field/SingleFieldPath.java:
##
@@ -0,0 +1,258 @@
+/*
+ * Licensed to the Apache Software Founda
C0urante commented on code in PR #15379:
URL: https://github.com/apache/kafka/pull/15379#discussion_r1570939313
##
connect/transforms/src/main/java/org/apache/kafka/connect/transforms/field/SingleFieldPath.java:
##
@@ -0,0 +1,258 @@
+/*
+ * Licensed to the Apache Software Founda
C0urante commented on code in PR #15379:
URL: https://github.com/apache/kafka/pull/15379#discussion_r1570939313
##
connect/transforms/src/main/java/org/apache/kafka/connect/transforms/field/SingleFieldPath.java:
##
@@ -0,0 +1,258 @@
+/*
+ * Licensed to the Apache Software Founda
C0urante commented on code in PR #15379:
URL: https://github.com/apache/kafka/pull/15379#discussion_r1570939313
##
connect/transforms/src/main/java/org/apache/kafka/connect/transforms/field/SingleFieldPath.java:
##
@@ -0,0 +1,258 @@
+/*
+ * Licensed to the Apache Software Founda
C0urante commented on code in PR #15379:
URL: https://github.com/apache/kafka/pull/15379#discussion_r1570939313
##
connect/transforms/src/main/java/org/apache/kafka/connect/transforms/field/SingleFieldPath.java:
##
@@ -0,0 +1,258 @@
+/*
+ * Licensed to the Apache Software Founda
[
https://issues.apache.org/jira/browse/KAFKA-16578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17838609#comment-17838609
]
Sagar Rao edited comment on KAFKA-16578 at 4/18/24 3:02 PM:
vamossagar12 commented on code in PR #15594:
URL: https://github.com/apache/kafka/pull/15594#discussion_r1570933991
##
tests/kafkatest/services/connect.py:
##
@@ -534,33 +535,40 @@ def received_messages(self):
def start(self):
self.logger.info("Creating connector
vamossagar12 commented on PR #15594:
URL: https://github.com/apache/kafka/pull/15594#issuecomment-2064120764
hey @lucasbru , I ran the following test suite
```
my_test_suite:
-
tests/kafkatest/tests/connect/connect_distributed_test.py::ConnectDistributedTest.test_restart_failed_c
chia7712 commented on code in PR #15136:
URL: https://github.com/apache/kafka/pull/15136#discussion_r1570922398
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -1189,49 +1217,62 @@ class LogManager(logDirs: Seq[File],
val sourceLog = currentLogs.get(topicPartitio
chia7712 commented on code in PR #15136:
URL: https://github.com/apache/kafka/pull/15136#discussion_r1570920951
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -1178,6 +1178,33 @@ class LogManager(logDirs: Seq[File],
}
}
+ def recoverAbandonedFutureLogs(broke
viktorsomogyi commented on code in PR #15697:
URL: https://github.com/apache/kafka/pull/15697#discussion_r1570907841
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -528,6 +529,10 @@ object KafkaConfig {
"If log.message.timestamp.type=CreateTime, the message wi
C0urante commented on code in PR #15379:
URL: https://github.com/apache/kafka/pull/15379#discussion_r1570907754
##
connect/transforms/src/test/java/org/apache/kafka/connect/transforms/ValueToKeyTest.java:
##
@@ -60,6 +62,30 @@ public void schemaless() {
assertEquals(exp
chia7712 commented on code in PR #15714:
URL: https://github.com/apache/kafka/pull/15714#discussion_r1570903125
##
storage/src/test/java/org/apache/kafka/storage/internals/checkpoint/PartitionMetadataFileTest.java:
##
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foun
chia7712 commented on PR #15569:
URL: https://github.com/apache/kafka/pull/15569#issuecomment-2064037126
> However I'm bit concern that LogConfig seems already huge. What others
prefer? Keep it in KafkaLogConfigs or move them to LogConfig.ServerLogConfig
the most default values of `Ka
FrankYang0529 commented on PR #15679:
URL: https://github.com/apache/kafka/pull/15679#issuecomment-2064035886
> @FrankYang0529 Could you reduce the partition number of offsets topic? It
seems the timeout is caused by that coordinator is waiting for the offset
partition, and our CI could be
[
https://issues.apache.org/jira/browse/KAFKA-16573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17838672#comment-17838672
]
Ayoub Omari commented on KAFKA-16573:
-
[~ableegoldman] [~mjsax] I looked a bit into
lianetm commented on code in PR #15742:
URL: https://github.com/apache/kafka/pull/15742#discussion_r1570871801
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -228,13 +228,16 @@ private void process(final ErrorEvent event) {
FrankYang0529 commented on PR #15616:
URL: https://github.com/apache/kafka/pull/15616#issuecomment-2063996320
> @FrankYang0529 , there is checkstyle error: `[2024-04-17T14:04:27.072Z]
[ant:checkstyle] [ERROR]
/home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-15616/storage/src/main/jav
chia7712 commented on code in PR #15732:
URL: https://github.com/apache/kafka/pull/15732#discussion_r1570822868
##
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java:
##
@@ -786,12 +773,29 @@ public void run() throws Exception {
}
lianetm commented on code in PR #15738:
URL: https://github.com/apache/kafka/pull/15738#discussion_r1570773742
##
tests/kafkatest/tests/client/consumer_test.py:
##
@@ -348,26 +348,45 @@ def test_fencing_static_consumer(self,
num_conflict_consumers, fencing_stage, me
lianetm commented on PR #15738:
URL: https://github.com/apache/kafka/pull/15738#issuecomment-2063881962
Hey @lucasbru, yes, I had closed it just to investigate a bit more about
some failures that I noticed, but ended up getting only to flaky behaviour not
related to the changes in this PR,
[
https://issues.apache.org/jira/browse/KAFKA-14733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17838647#comment-17838647
]
Matthew de Detrich commented on KAFKA-14733:
[~emissionnebula] Have you star
1 - 100 of 153 matches
Mail list logo
