lianetm commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1585005659
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/CompletableEventReaper.java:
##
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache Software Fo
[
https://issues.apache.org/jira/browse/KAFKA-16645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842419#comment-17842419
]
Matthias J. Sax commented on KAFKA-16645:
-
I believe fixing these CVEs should be
[
https://issues.apache.org/jira/browse/KAFKA-16645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-16645:
Priority: Blocker (was: Major)
> CVEs in 3.7.0 docker image
> --
[
https://issues.apache.org/jira/browse/KAFKA-16645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-16645:
Fix Version/s: 3.8.0
3.7.1
> CVEs in 3.7.0 docker image
> -
[
https://issues.apache.org/jira/browse/KAFKA-16644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842417#comment-17842417
]
Matthias J. Sax commented on KAFKA-16644:
-
Thanks for the pointer. I did not hav
nizhikov commented on code in PR #15832:
URL: https://github.com/apache/kafka/pull/15832#discussion_r1584953273
##
core/src/test/java/kafka/admin/UserScramCredentialsCommandTest.java:
##
@@ -0,0 +1,178 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
nizhikov commented on PR #15832:
URL: https://github.com/apache/kafka/pull/15832#issuecomment-2085538452
@chia7712 All your comments resolved. Please, take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
nizhikov commented on code in PR #15832:
URL: https://github.com/apache/kafka/pull/15832#discussion_r1584946619
##
core/src/test/java/kafka/admin/UserScramCredentialsCommandTest.java:
##
@@ -0,0 +1,184 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
[
https://issues.apache.org/jira/browse/KAFKA-16604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842412#comment-17842412
]
Chris Egerton commented on KAFKA-16604:
---
We don't necessarily have to deprecate an
lianetm commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1584929720
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteConsumerGroupsTest.java:
##
@@ -17,279 +17,332 @@
package org.apache.kafka.tools.consumer.group;
lianetm commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1584902357
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteConsumerGroupsTest.java:
##
@@ -17,279 +17,332 @@
package org.apache.kafka.tools.consumer.group;
lianetm commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1584897939
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteConsumerGroupsTest.java:
##
@@ -17,279 +17,332 @@
package org.apache.kafka.tools.consumer.group;
lianetm commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1584897939
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteConsumerGroupsTest.java:
##
@@ -17,279 +17,332 @@
package org.apache.kafka.tools.consumer.group;
riedelmax commented on PR #15727:
URL: https://github.com/apache/kafka/pull/15727#issuecomment-2085407284
@dajac
part 4/4 would be to handle IncludeAuthorizedOperations in the request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
lianetm commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1584853415
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupExecutor.java:
##
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
chia7712 commented on code in PR #15832:
URL: https://github.com/apache/kafka/pull/15832#discussion_r1584811761
##
core/src/test/java/kafka/admin/UserScramCredentialsCommandTest.java:
##
@@ -0,0 +1,184 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
nizhikov commented on PR #15832:
URL: https://github.com/apache/kafka/pull/15832#issuecomment-2085194654
@soarez Thanks for the valuable feedback. I create java version of
waitUntilTrue method and used it in test. Please, take a look.
--
This is an automated message from the Apache Git Se
nizhikov commented on code in PR #15832:
URL: https://github.com/apache/kafka/pull/15832#discussion_r1584714610
##
core/src/test/java/kafka/admin/UserScramCredentialsCommandTest.java:
##
@@ -0,0 +1,178 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
[
https://issues.apache.org/jira/browse/KAFKA-16513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Siddharth Yagnik reassigned KAFKA-16513:
Assignee: Siddharth Yagnik
> Allow WriteTxnMarkers API with Alter Cluster Permiss
brandboat commented on code in PR #15715:
URL: https://github.com/apache/kafka/pull/15715#discussion_r1584685682
##
core/src/test/java/kafka/test/ClusterConfig.java:
##
@@ -172,14 +179,16 @@ public boolean equals(Object object) {
&& Objects.equals(adminClientPro
FrankYang0529 commented on code in PR #15715:
URL: https://github.com/apache/kafka/pull/15715#discussion_r1584677103
##
core/src/test/java/kafka/test/ClusterConfig.java:
##
@@ -172,14 +179,16 @@ public boolean equals(Object object) {
&& Objects.equals(adminClien
FrankYang0529 commented on code in PR #15773:
URL: https://github.com/apache/kafka/pull/15773#discussion_r1584662969
##
server-common/src/main/java/org/apache/kafka/server/config/ServerLogConfigs.java:
##
@@ -86,7 +86,7 @@ public class ServerLogConfigs {
public static fin
[
https://issues.apache.org/jira/browse/KAFKA-16506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842340#comment-17842340
]
PoAn Yang edited comment on KAFKA-16506 at 4/30/24 11:44 AM:
-
[
https://issues.apache.org/jira/browse/KAFKA-16506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
PoAn Yang resolved KAFKA-16506.
---
Resolution: Not A Problem
Compare commands between 2.8 and trunk brand in folders
core/src/main/sca
nizhikov commented on code in PR #15832:
URL: https://github.com/apache/kafka/pull/15832#discussion_r1584629877
##
core/src/test/java/kafka/admin/UserScramCredentialsCommandTest.java:
##
@@ -0,0 +1,178 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
chia7712 commented on code in PR #15832:
URL: https://github.com/apache/kafka/pull/15832#discussion_r1584553620
##
core/src/test/java/kafka/admin/UserScramCredentialsCommandTest.java:
##
@@ -0,0 +1,178 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
[
https://issues.apache.org/jira/browse/KAFKA-16506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842330#comment-17842330
]
Chia-Ping Tsai commented on KAFKA-16506:
[~yangpoan] thanks for the check. pleas
chia7712 closed pull request #15381: KAFKA-16223: Migrate
KafkaConfigBackingStoreTest to Mockito
URL: https://github.com/apache/kafka/pull/15381
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
[
https://issues.apache.org/jira/browse/KAFKA-16223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842328#comment-17842328
]
Chia-Ping Tsai edited comment on KAFKA-16223 at 4/30/24 10:29 AM:
[
https://issues.apache.org/jira/browse/KAFKA-16648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
sanghyeok An updated KAFKA-16648:
-
Description:
Hi, Kafka Team.
I am writing test code for the new rebalancing protocol proposed in
[
https://issues.apache.org/jira/browse/KAFKA-16223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842328#comment-17842328
]
Chia-Ping Tsai commented on KAFKA-16223:
It seems `KafkaConfigBackingStoreMockit
sanghyeok An created KAFKA-16648:
Summary: Question: KIP-848 and KafkaTestKit.java
Key: KAFKA-16648
URL: https://issues.apache.org/jira/browse/KAFKA-16648
Project: Kafka
Issue Type: Bug
nizhikov commented on PR #15832:
URL: https://github.com/apache/kafka/pull/15832#issuecomment-2084909110
Hello @chia7712
Can you, please, take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
nizhikov opened a new pull request, #15832:
URL: https://github.com/apache/kafka/pull/15832
This is second part of https://github.com/apache/kafka/pull/15417
refactoring.
PR intention - split big PR in parts to simplify review.
PR contains UserScramCredentialsCommandTest rewritten in j
cadonna commented on PR #15640:
URL: https://github.com/apache/kafka/pull/15640#issuecomment-2084906500
> > Here I have a comment, I could not put at the right location in the code:
> > On line 1362, in `commitSync()` the consumer waits on the `commitFuture`
with a timer. I think, it shou
mukkachaitanya commented on PR #15381:
URL: https://github.com/apache/kafka/pull/15381#issuecomment-2084860037
This can be closed. @hgeraldino has closed this ticket via other PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
[
https://issues.apache.org/jira/browse/KAFKA-16506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842319#comment-17842319
]
PoAn Yang commented on KAFKA-16506:
---
Yeah, if version 2.8 commands are only in folder
chia7712 commented on PR #15381:
URL: https://github.com/apache/kafka/pull/15381#issuecomment-2084846862
@mukkachaitanya Could you please fix the conflicts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
chia7712 commented on code in PR #14716:
URL: https://github.com/apache/kafka/pull/14716#discussion_r1584442796
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java:
##
@@ -411,25 +394,32 @@ public void seek(final TopicPartition partition, fi
nizhikov commented on PR #15645:
URL: https://github.com/apache/kafka/pull/15645#issuecomment-2084760582
@chia7712 Thank you for the review and merge!
Will prepare next test of ConfigCommand for review shortly.
--
This is an automated message from the Apache Git Service.
To respond to
FrankYang0529 commented on code in PR #15745:
URL: https://github.com/apache/kafka/pull/15745#discussion_r1584379526
##
core/src/test/java/kafka/test/junit/ClusterTestExtensions.java:
##
@@ -162,32 +162,39 @@ private void processClusterTest(ExtensionContext context,
ClusterTest
[
https://issues.apache.org/jira/browse/KAFKA-16647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842298#comment-17842298
]
Chia-Ping Tsai commented on KAFKA-16647:
btw, this jira can remove the duplicate
[
https://issues.apache.org/jira/browse/KAFKA-16646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842297#comment-17842297
]
Vedarth Sharma commented on KAFKA-16646:
Created a fix PR https://github.com/apa
[
https://issues.apache.org/jira/browse/KAFKA-16646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vedarth Sharma reassigned KAFKA-16646:
--
Assignee: Vedarth Sharma
> Consider only running the CVE scanner action on apache/kaf
Chia-Ping Tsai created KAFKA-16647:
--
Summary: Remove setMetadataDirectory from BrokerNode/ControllerNode
Key: KAFKA-16647
URL: https://issues.apache.org/jira/browse/KAFKA-16647
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-16382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842293#comment-17842293
]
Stanislav Spiridonov commented on KAFKA-16382:
--
Any updates/estimations on
Mickael Maison created KAFKA-16646:
--
Summary: Consider only running the CVE scanner action on
apache/kafka and not in forks
Key: KAFKA-16646
URL: https://issues.apache.org/jira/browse/KAFKA-16646
Pro
[
https://issues.apache.org/jira/browse/KAFKA-16645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison updated KAFKA-16645:
---
Description:
Our [Docker Image CVE
Scanner|https://github.com/apache/kafka/actions/runs/
Mickael Maison created KAFKA-16645:
--
Summary: CVEs in 3.7.0 docker image
Key: KAFKA-16645
URL: https://issues.apache.org/jira/browse/KAFKA-16645
Project: Kafka
Issue Type: Task
Affects V
chia7712 commented on code in PR #15715:
URL: https://github.com/apache/kafka/pull/15715#discussion_r1584322426
##
core/src/test/java/kafka/test/junit/ClusterTestExtensions.java:
##
@@ -196,16 +197,35 @@ private void processClusterTest(ExtensionContext context,
ClusterTest anno
[
https://issues.apache.org/jira/browse/KAFKA-16644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842285#comment-17842285
]
Ayoub Omari commented on KAFKA-16644:
-
Hi [~mjsax], I think this is the same issue r
AyoubOm commented on PR #15615:
URL: https://github.com/apache/kafka/pull/15615#issuecomment-2084651380
> @AyoubOm -- Thanks for the PR! I did not forget about it. Just did not
find time yet to take a look. Still plan to get this merged for 3.8 release...
Sorry for the long wait, and thanks
lucasbru merged PR #15723:
URL: https://github.com/apache/kafka/pull/15723
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
lucasbru commented on PR #15723:
URL: https://github.com/apache/kafka/pull/15723#issuecomment-2084640215
@philipnee Since the unresolved conversation is only around an internal
method name, I'm merging this. Feel free to ask for a follow-up PR
--
This is an automated message from the Apac
raminqaf commented on PR #15601:
URL: https://github.com/apache/kafka/pull/15601#issuecomment-2084636567
@gharris1727 Thanks for the positive feedback! I am happy that you like the
changes! I addressed all your nit reviews and refactored the logic of the
non-final boolean variables (i.e., `
[
https://issues.apache.org/jira/browse/KAFKA-10859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-10859.
Resolution: Duplicate
fixed by
https://github.com/apache/kafka/commit/3dacdc5694da5db2835
chia7712 commented on PR #15055:
URL: https://github.com/apache/kafka/pull/15055#issuecomment-2084584466
any update here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
chia7712 commented on code in PR #15808:
URL: https://github.com/apache/kafka/pull/15808#discussion_r1584251393
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -321,16 +322,16 @@ class RemoteIndexCacheTest {
// Give the thread cleaner thread s
chia7712 commented on code in PR #15819:
URL: https://github.com/apache/kafka/pull/15819#discussion_r1584226418
##
streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java:
##
@@ -1469,6 +1469,10 @@ private Thread shutdownHelper(final boolean error, final
long timeoutMs
m1a2st commented on code in PR #15808:
URL: https://github.com/apache/kafka/pull/15808#discussion_r1584248006
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -321,16 +322,16 @@ class RemoteIndexCacheTest {
// Give the thread cleaner thread som
101 - 160 of 160 matches
Mail list logo
