showuon merged PR #14778:
URL: https://github.com/apache/kafka/pull/14778
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
showuon commented on PR #14778:
URL: https://github.com/apache/kafka/pull/14778#issuecomment-2148998985
Failed tests are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
sjhajharia opened a new pull request, #16205:
URL: https://github.com/apache/kafka/pull/16205
Minor cleanups in Raft module
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verif
dajac commented on PR #16145:
URL: https://github.com/apache/kafka/pull/16145#issuecomment-2148958205
Merged to trunk and to 3.8.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
dajac merged PR #16145:
URL: https://github.com/apache/kafka/pull/16145
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
[
https://issues.apache.org/jira/browse/KAFKA-16662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852291#comment-17852291
]
Luke Chen commented on KAFKA-16662:
---
This issue is fixed in KAFKA-16583 and will be in
[
https://issues.apache.org/jira/browse/KAFKA-16662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen resolved KAFKA-16662.
---
Fix Version/s: 3.8.0
3.7.1
Resolution: Duplicate
> UnwritableMetadataExcep
sjhajharia opened a new pull request, #16204:
URL: https://github.com/apache/kafka/pull/16204
Some cleanup in shell module
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify
dajac commented on code in PR #16184:
URL: https://github.com/apache/kafka/pull/16184#discussion_r1626957182
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -3927,6 +3929,36 @@ class KafkaApis(val requestChannel: RequestChannel,
}
}
+ def handleShareFetchRe
omkreddy merged PR #16184:
URL: https://github.com/apache/kafka/pull/16184
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
kamalcph commented on code in PR #16199:
URL: https://github.com/apache/kafka/pull/16199#discussion_r1626934928
##
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java:
##
@@ -348,280 +346,124 @@ public final class RemoteLogManagerConfig {
kamalcph commented on PR #16203:
URL: https://github.com/apache/kafka/pull/16203#issuecomment-2148816401
This patch also depends on #16199
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
kamalcph opened a new pull request, #16203:
URL: https://github.com/apache/kafka/pull/16203
This patch is built on top of #14778
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ]
kamalcph commented on PR #16202:
URL: https://github.com/apache/kafka/pull/16202#issuecomment-2148809490
@brandboat
Call for review. PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
kamalcph opened a new pull request, #16202:
URL: https://github.com/apache/kafka/pull/16202
- Use SystemTime instead of MockTime when time is not mocked
- Use static assertions to reduce the line length
- Fold the lines if it exceeds the limit
- rename tp0 to tpId0 when it refers to
github-actions[bot] commented on PR #15304:
URL: https://github.com/apache/kafka/pull/15304#issuecomment-2148789422
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has merge
github-actions[bot] commented on PR #15472:
URL: https://github.com/apache/kafka/pull/15472#issuecomment-2148789357
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has merge
[
https://issues.apache.org/jira/browse/KAFKA-16885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-16885:
--
Assignee: Chia Chuan Yu (was: Chia-Ping Tsai)
> Consider renaming RemoteLogManagerCo
[
https://issues.apache.org/jira/browse/KAFKA-16885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852252#comment-17852252
]
Chia Chuan Yu commented on KAFKA-16885:
---
Hi, [~chia7712]
Can I have this one, th
[
https://issues.apache.org/jira/browse/KAFKA-16823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852250#comment-17852250
]
Chia-Ping Tsai commented on KAFKA-16823:
BTW, we = me + [~yangpoan] :)
> Extrac
[
https://issues.apache.org/jira/browse/KAFKA-16823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852248#comment-17852248
]
PoAn Yang commented on KAFKA-16823:
---
I would like to handle this if [~lianetm] is not
showuon commented on code in PR #16195:
URL: https://github.com/apache/kafka/pull/16195#discussion_r1626829763
##
metadata/src/main/java/org/apache/kafka/image/TopicDelta.java:
##
@@ -118,13 +118,17 @@ public boolean hasPartitionsWithAssignmentChanges() {
/**
* Find
[
https://issues.apache.org/jira/browse/KAFKA-16823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852242#comment-17852242
]
Chia-Ping Tsai commented on KAFKA-16823:
I love this idea. [~lianetm] Do you pla
[
https://issues.apache.org/jira/browse/KAFKA-16811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852239#comment-17852239
]
Ganesh Sadanala edited comment on KAFKA-16811 at 6/5/24 1:45 AM:
-
chia7712 commented on code in PR #16176:
URL: https://github.com/apache/kafka/pull/16176#discussion_r1626816871
##
build.gradle:
##
@@ -47,9 +47,10 @@ plugins {
// Updating the shadow plugin version to 8.1.1 causes issue with signing and
publishing the shadowed
// artifac
chia7712 commented on code in PR #16176:
URL: https://github.com/apache/kafka/pull/16176#discussion_r1626816156
##
build.gradle:
##
@@ -200,7 +201,60 @@ def determineCommitId() {
}
}
-def spotlessApplyModules = ['']
+def excludedSpotlessModules = [':clients',
Review Comme
[
https://issues.apache.org/jira/browse/KAFKA-16811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852239#comment-17852239
]
Ganesh Sadanala commented on KAFKA-16811:
-
I did not change anything apart from
[
https://issues.apache.org/jira/browse/KAFKA-16811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852239#comment-17852239
]
Ganesh Sadanala edited comment on KAFKA-16811 at 6/5/24 1:20 AM:
-
[
https://issues.apache.org/jira/browse/KAFKA-16811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852231#comment-17852231
]
Matthias J. Sax commented on KAFKA-16811:
-
[~ganesh_6] – WordCountProcessorDemo
[
https://issues.apache.org/jira/browse/KAFKA-16874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-16874:
Component/s: streams
> Remove old TaskAssignor interface
> ---
[
https://issues.apache.org/jira/browse/KAFKA-15905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-15905:
Fix Version/s: 3.8.0
(was: 3.8)
> Restarts of MirrorCheckpointTask
[
https://issues.apache.org/jira/browse/KAFKA-16622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-16622:
Fix Version/s: 3.8.0
(was: 3.8)
> Mirromaker2 first Checkpoint not
[
https://issues.apache.org/jira/browse/KAFKA-16757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-16757:
Fix Version/s: 3.8.0
(was: 3.8)
> Fix broker re-registration issues
[
https://issues.apache.org/jira/browse/KAFKA-16692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-16692:
Fix Version/s: 3.8.0
(was: 3.8)
> InvalidRequestException: ADD_PART
[
https://issues.apache.org/jira/browse/KAFKA-15045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-15045:
Fix Version/s: 3.8.0
> Move Streams task assignor to public configs
>
[
https://issues.apache.org/jira/browse/KAFKA-16875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-16875:
Component/s: streams
> Replace ClientState with TaskAssignment when creating individual co
[
https://issues.apache.org/jira/browse/KAFKA-16873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-16873:
Component/s: streams
> Remove StreamsConfig.INTERNAL_TASK_ASSIGNOR_CLASS
> ---
[
https://issues.apache.org/jira/browse/KAFKA-16872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-16872:
Component/s: streams
> Remove ClientState class
>
>
>
[
https://issues.apache.org/jira/browse/KAFKA-16871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-16871:
Component/s: streams
> Clean up internal AssignmentConfigs class in Streams
>
[
https://issues.apache.org/jira/browse/KAFKA-16868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-16868:
Component/s: streams
> Post KIP-924 StreamsPartitionAssignor code cleanup
> --
apourchet opened a new pull request, #16201:
URL: https://github.com/apache/kafka/pull/16201
Added more testing for the StickyTaskAssignor, which includes a large-scale
test with rack aware enabled.
Also added a no-op change to `StreamsAssignmentScaleTest.java` to allow for
rack awar
[
https://issues.apache.org/jira/browse/KAFKA-16843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
PoAn Yang resolved KAFKA-16843.
---
Resolution: Fixed
> Remove preAppendErrors from createPutCacheCallback
> ---
[
https://issues.apache.org/jira/browse/KAFKA-16843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852228#comment-17852228
]
PoAn Yang commented on KAFKA-16843:
---
The PR [https://github.com/apache/kafka/pull/1610
showuon commented on code in PR #16195:
URL: https://github.com/apache/kafka/pull/16195#discussion_r1626767519
##
metadata/src/main/java/org/apache/kafka/image/TopicsDelta.java:
##
@@ -178,13 +178,15 @@ public Set createdTopicIds() {
/**
* Find the topic partitions
kirktrue commented on code in PR #16031:
URL: https://github.com/apache/kafka/pull/16031#discussion_r1626764237
##
core/src/test/scala/integration/kafka/api/PlaintextConsumerPollTest.scala:
##
@@ -238,6 +238,20 @@ class PlaintextConsumerPollTest extends
AbstractConsumerTest {
kirktrue commented on PR #16031:
URL: https://github.com/apache/kafka/pull/16031#issuecomment-2148602850
@lianetm @cadonna I believe I've handled the feedback (thanks!) and this is
ready for another review.
--
This is an automated message from the Apache Git Service.
To respond to the mes
showuon commented on PR #16105:
URL: https://github.com/apache/kafka/pull/16105#issuecomment-2148602465
@FrankYang0529 , thanks for the contribution. Nice find!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
showuon merged PR #16105:
URL: https://github.com/apache/kafka/pull/16105
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
showuon commented on PR #16105:
URL: https://github.com/apache/kafka/pull/16105#issuecomment-2148600592
Failed tests are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
kirktrue commented on code in PR #16031:
URL: https://github.com/apache/kafka/pull/16031#discussion_r1626761730
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -1097,19 +1132,18 @@ private void testNonRetriable(final
Lis
showuon commented on PR #14778:
URL: https://github.com/apache/kafka/pull/14778#issuecomment-2148598853
@kamalcph , could we move the dynamic config change into another PR? I have
some comments to it, but that is separate from the original changes.
--
This is an automated message from the
kirktrue commented on code in PR #16031:
URL: https://github.com/apache/kafka/pull/16031#discussion_r1626759185
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/TimedRequestState.java:
##
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
kirktrue commented on code in PR #16031:
URL: https://github.com/apache/kafka/pull/16031#discussion_r1626759656
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -875,8 +872,12 @@ private void handleClientResponse(final ClientR
kirktrue commented on code in PR #16031:
URL: https://github.com/apache/kafka/pull/16031#discussion_r1626759390
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -875,8 +872,12 @@ private void handleClientResponse(final ClientR
showuon merged PR #16165:
URL: https://github.com/apache/kafka/pull/16165
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
[
https://issues.apache.org/jira/browse/KAFKA-16814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen resolved KAFKA-16814.
---
Resolution: Fixed
> KRaft broker cannot startup when `partition.metadata` is missing
> -
showuon commented on PR #16165:
URL: https://github.com/apache/kafka/pull/16165#issuecomment-2148594681
Failed tests are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
showuon merged PR #16189:
URL: https://github.com/apache/kafka/pull/16189
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
showuon commented on PR #16189:
URL: https://github.com/apache/kafka/pull/16189#issuecomment-2148592407
Failed tests are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
kirktrue commented on code in PR #16031:
URL: https://github.com/apache/kafka/pull/16031#discussion_r1626752933
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -613,15 +614,44 @@ public void testOffsetFetchRequestErroredR
mjsax commented on code in PR #16162:
URL: https://github.com/apache/kafka/pull/16162#discussion_r1626750822
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/PunctuateRatioSlidingWindow.java:
##
@@ -0,0 +1,38 @@
+package org.apache.kafka.streams.processor.in
kirktrue commented on code in PR #16031:
URL: https://github.com/apache/kafka/pull/16031#discussion_r1626748855
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -319,11 +326,11 @@ private void
autoCommitSyncBeforeRevocationWi
ahuang98 commented on PR #16160:
URL: https://github.com/apache/kafka/pull/16160#issuecomment-2148481736
Yeah looks like those are existing failures. Looks like Jose didn't take any
of the changes, closing this out.
--
This is an automated message from the Apache Git Service.
To respond t
ahuang98 closed pull request #16160: KAFKA-16252: Dynamic KRaft network manager
and channel
URL: https://github.com/apache/kafka/pull/16160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
caysony1 commented on code in PR #16110:
URL: https://github.com/apache/kafka/pull/16110#discussion_r1625791366
##
core/src/test/java/kafka/test/ClusterConfigTest.java:
##
@@ -96,4 +99,16 @@ public void testDisksPerBrokerIsZero() {
.setDisksPerBroker(0)
gharris1727 commented on code in PR #16199:
URL: https://github.com/apache/kafka/pull/16199#discussion_r1626609501
##
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java:
##
@@ -348,280 +346,124 @@ public final class RemoteLogManagerConfi
chia7712 merged PR #16192:
URL: https://github.com/apache/kafka/pull/16192
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
brenden20 commented on code in PR #16140:
URL: https://github.com/apache/kafka/pull/16140#discussion_r1626607635
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##
@@ -329,6 +382,8 @@ void testEnsureEventsAreCompleted() {
lianetm commented on code in PR #16140:
URL: https://github.com/apache/kafka/pull/16140#discussion_r1626606071
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##
@@ -329,6 +382,8 @@ void testEnsureEventsAreCompleted() {
chia7712 merged PR #16190:
URL: https://github.com/apache/kafka/pull/16190
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
muralibasani commented on code in PR #16199:
URL: https://github.com/apache/kafka/pull/16199#discussion_r1626604359
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -212,9 +213,9 @@ public RemoteLogManager(RemoteLogManagerConfig rlmConfig,
rlmCopyQuot
muralibasani commented on code in PR #16199:
URL: https://github.com/apache/kafka/pull/16199#discussion_r1626604359
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -212,9 +213,9 @@ public RemoteLogManager(RemoteLogManagerConfig rlmConfig,
rlmCopyQuot
lianetm commented on PR #16031:
URL: https://github.com/apache/kafka/pull/16031#issuecomment-2148416617
Hey @kirktrue , I just completed another full pass, left some comments,
thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
lianetm commented on code in PR #16031:
URL: https://github.com/apache/kafka/pull/16031#discussion_r1626603047
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -613,15 +614,44 @@ public void testOffsetFetchRequestErroredRe
cmccabe commented on PR #16058:
URL: https://github.com/apache/kafka/pull/16058#issuecomment-2148415739
thanks, committed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
cmccabe closed pull request #16058: KAFKA-16535: Implement AddVoter,
RemoveVoter, UpdateVoter RPCs
URL: https://github.com/apache/kafka/pull/16058
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
lianetm commented on code in PR #16031:
URL: https://github.com/apache/kafka/pull/16031#discussion_r1626596195
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -613,15 +614,44 @@ public void testOffsetFetchRequestErroredRe
gharris1727 commented on code in PR #16053:
URL: https://github.com/apache/kafka/pull/16053#discussion_r1626593367
##
connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java:
##
@@ -1123,6 +1125,24 @@ private void processTasksCommitRecord(Stri
chia7712 commented on code in PR #16198:
URL: https://github.com/apache/kafka/pull/16198#discussion_r1626582230
##
group-coordinator/group-coordinator-api/src/main/java/org/apache/kafka/coordinator/group/api/assignor/GroupSpec.java:
##
@@ -14,7 +14,7 @@
* See the License for t
lianetm commented on code in PR #16031:
URL: https://github.com/apache/kafka/pull/16031#discussion_r1626569362
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -1097,19 +1132,18 @@ private void testNonRetriable(final
List
lianetm commented on code in PR #16031:
URL: https://github.com/apache/kafka/pull/16031#discussion_r1626569362
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -1097,19 +1132,18 @@ private void testNonRetriable(final
List
gharris1727 commented on code in PR #16199:
URL: https://github.com/apache/kafka/pull/16199#discussion_r1626574550
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -212,9 +213,9 @@ public RemoteLogManager(RemoteLogManagerConfig rlmConfig,
rlmCopyQuota
gharris1727 commented on code in PR #16161:
URL: https://github.com/apache/kafka/pull/16161#discussion_r1626571296
##
connect/api/src/main/java/org/apache/kafka/connect/data/ConnectSchema.java:
##
@@ -251,19 +251,30 @@ public static void validateValue(String name, Schema
schema
lianetm commented on code in PR #16031:
URL: https://github.com/apache/kafka/pull/16031#discussion_r1626569362
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -1097,19 +1132,18 @@ private void testNonRetriable(final
List
lianetm commented on code in PR #16031:
URL: https://github.com/apache/kafka/pull/16031#discussion_r1626569362
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -1097,19 +1132,18 @@ private void testNonRetriable(final
List
[
https://issues.apache.org/jira/browse/KAFKA-15305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-15305:
--
Assignee: TengYao Chi (was: Chia-Ping Tsai)
> The background thread should try to pr
[
https://issues.apache.org/jira/browse/KAFKA-15305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-15305.
Resolution: Fixed
push to trunk and 3.8
> The background thread should try to process the
chia7712 merged PR #16156:
URL: https://github.com/apache/kafka/pull/16156
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
lianetm commented on code in PR #16031:
URL: https://github.com/apache/kafka/pull/16031#discussion_r1626550778
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/TimedRequestState.java:
##
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
muralibasani commented on code in PR #16199:
URL: https://github.com/apache/kafka/pull/16199#discussion_r1626545984
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -212,9 +213,9 @@ public RemoteLogManager(RemoteLogManagerConfig rlmConfig,
rlmCopyQuot
muralibasani commented on code in PR #16199:
URL: https://github.com/apache/kafka/pull/16199#discussion_r1626544362
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -125,6 +125,7 @@
import java.util.stream.Stream;
import static
org.apache.kafka.server.log
lianetm commented on code in PR #16031:
URL: https://github.com/apache/kafka/pull/16031#discussion_r1626544295
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/NetworkClientDelegate.java:
##
@@ -313,7 +306,7 @@ public String toString() {
chia7712 commented on code in PR #16126:
URL: https://github.com/apache/kafka/pull/16126#discussion_r1626542796
##
connect/runtime/src/test/java/org/apache/kafka/connect/storage/KafkaConfigBackingStoreTest.java:
##
@@ -194,121 +234,1293 @@ public void setUp() {
}
@Te
lianetm commented on code in PR #16031:
URL: https://github.com/apache/kafka/pull/16031#discussion_r1626534240
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/NetworkClientDelegate.java:
##
@@ -235,7 +235,6 @@ public void addAll(final List requests) {
gharris1727 commented on code in PR #16199:
URL: https://github.com/apache/kafka/pull/16199#discussion_r1626526038
##
storage/src/test/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfigTest.java:
##
@@ -27,171 +25,72 @@
import static
org.apache.kafka.serv
muralibasani commented on PR #16199:
URL: https://github.com/apache/kafka/pull/16199#issuecomment-2148273575
@gharris1727 would you like to take a look ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
lianetm commented on code in PR #16031:
URL: https://github.com/apache/kafka/pull/16031#discussion_r1626513292
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -875,8 +872,12 @@ private void handleClientResponse(final ClientRe
muralibasani opened a new pull request, #16199:
URL: https://github.com/apache/kafka/pull/16199
Resolves https://issues.apache.org/jira/browse/KAFKA-16884
- Update RemoteLogManagerConfig, extend with AbstractConfig
- Update all the dependent getValue methods
### Committer Che
lianetm commented on code in PR #16031:
URL: https://github.com/apache/kafka/pull/16031#discussion_r1626501003
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -516,8 +527,9 @@ private void fetchOffsetsWithRetries(final
Offse
chia7712 commented on PR #16156:
URL: https://github.com/apache/kafka/pull/16156#issuecomment-2148227156
the failed tests are already fixed by
https://github.com/apache/kafka/commit/a08db65670ddea78da859a8c29a00632d5e8b779
--
This is an automated message from the Apache Git Service.
To re
1 - 100 of 299 matches
Mail list logo
