Re: [PR] KAFKA-17285: Consider using `Utils.closeQuietly` to replace `CoreUtils.swallow` when handling Closeable objects [kafka]

2024-09-07 Thread via GitHub
bboyleonp666 commented on PR #16843: URL: https://github.com/apache/kafka/pull/16843#issuecomment-2336570508 Looks great. Let me apply this change to all the instances that I can find. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Assigned] (KAFKA-17492) Can't register 3.9+ broker to 3.8 controller since 3.8 controller assume the default version of feature is zero

2024-09-07 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-17492: -- Assignee: 黃竣陽 (was: Chia-Ping Tsai) > Can't register 3.9+ broker to 3.8 controller s

[jira] [Commented] (KAFKA-17492) Can't register 3.9+ broker to 3.8 controller since 3.8 controller assume the default version of feature is zero

2024-09-07 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-17492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17880088#comment-17880088 ] 黃竣陽 commented on KAFKA-17492: - I'm interesting in this issue, Could you assign to me, thanks

Re: [PR] KAFKA-17323: Document UINT16 and COMPACT_RECORDS in Protocol Guide [kafka]

2024-09-07 Thread via GitHub
chia7712 commented on PR #16868: URL: https://github.com/apache/kafka/pull/16868#issuecomment-2336562163 > could you please also look at https://github.com/apache/kafka/pull/16867 and https://github.com/apache/kafka/pull/17122? They also touch the protocol documentation and are short. --

Re: [PR] KAFKA-17417: Backport KAFKA-15751 and KAFKA-15752 to 3.8 and 3.7 [kafka]

2024-09-07 Thread via GitHub
chia7712 merged PR #17101: URL: https://github.com/apache/kafka/pull/17101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Updated] (KAFKA-17323) Document UINT16 and COMPACT_RECORDS in Protocol Guide

2024-09-07 Thread Ivan Yurchenko (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Yurchenko updated KAFKA-17323: --- Description: As these types are used in the protocol. (was: Currently, the [protocol guide|

Re: [PR] KAFKA-17323: Document UINT16 and COMPACT_RECORDS in Protocol Guide [kafka]

2024-09-07 Thread via GitHub
chia7712 merged PR #16868: URL: https://github.com/apache/kafka/pull/16868 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-17478 Fix NPE with bad metric.reporters config [kafka]

2024-09-07 Thread via GitHub
chia7712 commented on code in PR #17086: URL: https://github.com/apache/kafka/pull/17086#discussion_r1749072462 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -395,6 +395,24 @@ public void testConstructorClose(GroupProtocol groupProtoco

Re: [PR] MINOR: Clean up logic to enable/disable new group coordinator in system tests [kafka]

2024-09-07 Thread via GitHub
chia7712 merged PR #17113: URL: https://github.com/apache/kafka/pull/17113 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-16407: Fix foreign key INNER join on change of FK from/to a null value [kafka]

2024-09-07 Thread via GitHub
github-actions[bot] commented on PR #15615: URL: https://github.com/apache/kafka/pull/15615#issuecomment-2336531318 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge

Re: [PR] KAFKA-16863 : Deprecate default exception handlers [kafka]

2024-09-07 Thread via GitHub
mjsax commented on PR #17005: URL: https://github.com/apache/kafka/pull/17005#issuecomment-2336528265 Merged to `trunk`. Congrats! Thanks for the KIP and PR! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[PR] MINOR Allow PRs to publish build scan [kafka]

2024-09-07 Thread via GitHub
mumrah opened a new pull request, #17123: URL: https://github.com/apache/kafka/pull/17123 Public fork pull requests triggered with `pull_request` do not get access to the repository secrets. This means they cannot upload gradle build scans. -- This is an automated message from the Apache

[jira] [Updated] (KAFKA-17057) Add "retry" option to ProductionExceptionHandler

2024-09-07 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-17057: Description: With KAFKA-16508 we changed the KS behavior to call the ProductionExceptionH

Re: [PR] KAFKA-14460: Skip removed entries from in-memory KeyValueIterator [kafka]

2024-09-07 Thread via GitHub
ableegoldman merged PR #16505: URL: https://github.com/apache/kafka/pull/16505 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.ap

Re: [PR] KAFKA-14460: Skip removed entries from in-memory KeyValueIterator [kafka]

2024-09-07 Thread via GitHub
ableegoldman commented on PR #16505: URL: https://github.com/apache/kafka/pull/16505#issuecomment-2336487531 Test failures unrelated, merging to trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Resolved] (KAFKA-17486) Fix failed test RestoreIntegrationTest.shouldInvokeUserDefinedGlobalStateRestoreListener

2024-09-07 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck resolved KAFKA-17486. - Resolution: Fixed [https://github.com/apache/kafka/pull/17104] merged to trunk > Fix failed tes

Re: [PR] KAFKA-17091: Add @FunctionalInterface to Streams interfaces [kafka]

2024-09-07 Thread via GitHub
mjsax commented on PR #16544: URL: https://github.com/apache/kafka/pull/16544#issuecomment-2336439767 @raymcdermott -- what is the status? Seems the KIP is not making much progress lately? -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] KAFKA-16863 : Deprecate default exception handlers [kafka]

2024-09-07 Thread via GitHub
muralibasani commented on PR #17005: URL: https://github.com/apache/kafka/pull/17005#issuecomment-2336431350 Pushed that change. Will get site-docs running locally from next time. Thought this would be a smaller one. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] MINOR Enable the GitHub build by default [kafka]

2024-09-07 Thread via GitHub
mumrah commented on PR #17105: URL: https://github.com/apache/kafka/pull/17105#issuecomment-2336411494 @chia7712 WDYT, should we go ahead with this one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] KAFKA-17011: Fix a bug preventing features from supporting v0 [kafka]

2024-09-07 Thread via GitHub
chia7712 commented on code in PR #16421: URL: https://github.com/apache/kafka/pull/16421#discussion_r1748904248 ## clients/src/main/java/org/apache/kafka/common/requests/BrokerRegistrationRequest.java: ## @@ -45,7 +46,21 @@ public short oldestAllowedVersion() { @Overr

Re: [PR] KAFKA-17011: Fix a bug preventing features from supporting v0 [kafka]

2024-09-07 Thread via GitHub
junrao commented on code in PR #16421: URL: https://github.com/apache/kafka/pull/16421#discussion_r1748529806 ## clients/src/main/java/org/apache/kafka/common/requests/BrokerRegistrationRequest.java: ## @@ -45,7 +46,21 @@ public short oldestAllowedVersion() { @Overrid

[jira] [Updated] (KAFKA-17457) Raise minimum MetadataVersion for ZK migration to 3.6

2024-09-07 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-17457: - Fix Version/s: (was: 3.6.3) > Raise minimum MetadataVersion for ZK migration to 3.6 > --

Re: [PR] KAFKA-17457 backport to 3.8 [kafka]

2024-09-07 Thread via GitHub
cmccabe merged PR #17119: URL: https://github.com/apache/kafka/pull/17119 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-17323: Document UINT16 and COMPACT_RECORDS in Protocol Guide [kafka]

2024-09-07 Thread via GitHub
ivanyu commented on code in PR #16868: URL: https://github.com/apache/kafka/pull/16868#discussion_r1748429904 ## clients/src/main/java/org/apache/kafka/common/protocol/types/Type.java: ## @@ -1113,7 +1113,7 @@ public String documentation() { private static String toHtml() {

Re: [PR] KAFKA-17479 Fail the whole pipeline if junit step times out [4/n] [kafka]

2024-09-07 Thread via GitHub
chia7712 commented on PR #17121: URL: https://github.com/apache/kafka/pull/17121#issuecomment-2335383316 > The trouble is, we may have some of the copied XML files, but not all of them. For example, if all the tests finished except for :core we would have several XML files in build/junit-xm

Re: [PR] KAFKA-17479 Fail the whole pipeline if junit step times out [4/n] [kafka]

2024-09-07 Thread via GitHub
mumrah commented on PR #17121: URL: https://github.com/apache/kafka/pull/17121#issuecomment-2335279790 > Could we check the create time of build/.../xml instead? The trouble is, we may have some of the copied XML files, but not all of them. For example, if all the tests finished excep

[jira] [Commented] (KAFKA-14995) Automate asf.yaml collaborators refresh

2024-09-07 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17880049#comment-17880049 ] Josep Prat commented on KAFKA-14995: Hi [~joaopedrofonseca]  Usually when someone t

Re: [PR] KAFKA-17479 Fail the whole pipeline if junit step times out [4/n] [kafka]

2024-09-07 Thread via GitHub
chia7712 commented on PR #17121: URL: https://github.com/apache/kafka/pull/17121#issuecomment-2335199060 > Adding a finalizer to the default "test" task did not work as expected. I can't find a simple way to add task to run after all the subproject ":test" tasks, so I changed this to have t

[jira] [Comment Edited] (KAFKA-14995) Automate asf.yaml collaborators refresh

2024-09-07 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-14995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17880046#comment-17880046 ] João Pedro Fonseca edited comment on KAFKA-14995 at 9/7/24 2:03 PM: --

[jira] [Comment Edited] (KAFKA-14995) Automate asf.yaml collaborators refresh

2024-09-07 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-14995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17880046#comment-17880046 ] João Pedro Fonseca edited comment on KAFKA-14995 at 9/7/24 2:01 PM: --

Re: [PR] KAFKA-17479 Fail the whole pipeline if junit step times out [4/n] [kafka]

2024-09-07 Thread via GitHub
mumrah commented on code in PR #17121: URL: https://github.com/apache/kafka/pull/17121#discussion_r1748093273 ## .github/scripts/junit.py: ## @@ -144,7 +144,10 @@ def pretty_time_duration(seconds: float) -> str: required=False, d

Re: [PR] KAFKA-17479 Fail the whole pipeline if junit step times out [4/n] [kafka]

2024-09-07 Thread via GitHub
mumrah commented on code in PR #17121: URL: https://github.com/apache/kafka/pull/17121#discussion_r1748093273 ## .github/scripts/junit.py: ## @@ -144,7 +144,10 @@ def pretty_time_duration(seconds: float) -> str: required=False, d

Re: [PR] KAFKA-14995: Automate asf.yaml collaborators refresh [kafka]

2024-09-07 Thread via GitHub
fonsdant commented on PR #13842: URL: https://github.com/apache/kafka/pull/13842#issuecomment-2335191041 @mimaison, @stevenbooke could I try to resume this work? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Updated] (KAFKA-15146) Flaky test ConsumerBounceTest.testConsumptionWithBrokerFailures

2024-09-07 Thread Chia-Chuan Yu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Chuan Yu updated KAFKA-15146: -- Component/s: (was: unit tests) > Flaky test ConsumerBounceTest.testConsumptionWithBrokerFa

[jira] [Updated] (KAFKA-15146) Flaky test ConsumerBounceTest.testConsumptionWithBrokerFailures

2024-09-07 Thread Chia-Chuan Yu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Chuan Yu updated KAFKA-15146: -- Component/s: unit tests > Flaky test ConsumerBounceTest.testConsumptionWithBrokerFailures > --

Re: [PR] KAFKA-17053: Restructure build.gradle to configure publishing last [kafka]

2024-09-07 Thread via GitHub
KTKTK-HZ commented on code in PR #16950: URL: https://github.com/apache/kafka/pull/16950#discussion_r1748054897 ## build.gradle: ## @@ -1674,7 +1730,6 @@ project(':clients') { configurations { generator -shadowed Review Comment: This is because moving shadowJar