chia7712 merged PR #17570:
URL: https://github.com/apache/kafka/pull/17570
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
apoorvmittal10 commented on code in PR #16842:
URL: https://github.com/apache/kafka/pull/16842#discussion_r1815160655
##
core/src/main/java/kafka/server/share/SharePartitionManager.java:
##
@@ -606,22 +641,51 @@ private void maybeCompleteInitializationWithException(
chirag-wadhwa5 commented on code in PR #17573:
URL: https://github.com/apache/kafka/pull/17573#discussion_r1815105965
##
share/src/main/java/org/apache/kafka/server/share/persister/PartitionFactory.java:
##
@@ -26,7 +26,7 @@
*/
public class PartitionFactory {
public stat
chia7712 commented on PR #17562:
URL: https://github.com/apache/kafka/pull/17562#issuecomment-2436111037
@m1a2st could you please rebase code to have QA again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
[
https://issues.apache.org/jira/browse/KAFKA-17784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17892672#comment-17892672
]
Zhijian Chen commented on KAFKA-17784:
--
In the MirrorMaker scenario, a MirrorMaker
frankvicky opened a new pull request, #17589:
URL: https://github.com/apache/kafka/pull/17589
The current implementation of `TestUtils#verifyTopicDeletion` contained an
incorrect logic when verifying the hard-deletion of topic directories.
Specifically, the logic was erroneously applying
m1a2st commented on code in PR #17562:
URL: https://github.com/apache/kafka/pull/17562#discussion_r1815081374
##
server/src/main/java/org/apache/kafka/server/RPCProducerIdManager.java:
##
@@ -0,0 +1,191 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
frankvicky commented on PR #17549:
URL: https://github.com/apache/kafka/pull/17549#issuecomment-2436851353
Hi @lianetm,
Here is my understanding. Please correct me if I’m wrong:
Since the group management has now moved to the server-side, the
`ConsumerGroupMetadata` basically re
jolshan commented on code in PR #17597:
URL: https://github.com/apache/kafka/pull/17597#discussion_r1815691522
##
core/src/main/scala/kafka/tools/StorageTool.scala:
##
@@ -466,4 +472,27 @@ object StorageTool extends Logging {
}
}
}
+
+ private def parseNameAndLev
TaiJuWu commented on code in PR #17584:
URL: https://github.com/apache/kafka/pull/17584#discussion_r1815974636
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java:
##
@@ -925,7 +925,7 @@ public Map
fetchCommittedOffsets(final Set
TaiJuWu commented on PR #17584:
URL: https://github.com/apache/kafka/pull/17584#issuecomment-2436795086
> Thanks for the PR @TaiJuWu.
>
> Is it possible this could be fixed for the new `AsyncKafkaConsumer`, too?
>
> Thanks!
Will do. Thanks!
--
This is an automated mess
Manish Kumar Sinha created KAFKA-17872:
--
Summary: Kafka stream job does not commit offset when packets are
getting ignored intentionally
Key: KAFKA-17872
URL: https://issues.apache.org/jira/browse/KAFKA-1787
[
https://issues.apache.org/jira/browse/KAFKA-17869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-17869:
Component/s: admin
clients
consumer
prod
Yunyung commented on PR #17586:
URL: https://github.com/apache/kafka/pull/17586#issuecomment-2436124669
Thanks for review :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
[
https://issues.apache.org/jira/browse/KAFKA-17866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17892577#comment-17892577
]
Colin McCabe commented on KAFKA-17866:
--
Unfortunately, we don't have a way to upgra
bbejeck commented on code in PR #17021:
URL: https://github.com/apache/kafka/pull/17021#discussion_r1815609713
##
streams/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsTelemetryIntegrationTest.java:
##
@@ -0,0 +1,547 @@
+/*
+ * Licensed to the Apache Software Fo
junrao commented on code in PR #17539:
URL: https://github.com/apache/kafka/pull/17539#discussion_r1815731593
##
core/src/main/java/kafka/server/share/SharePartition.java:
##
@@ -1525,6 +1537,24 @@ private Optional acknowledgeCompleteBatch(
return Optional.empty();
clarkwtc commented on code in PR #17578:
URL: https://github.com/apache/kafka/pull/17578#discussion_r1815283080
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java:
##
@@ -707,7 +708,8 @@ private Optional>
createPushRequest(ClientTe
rreddy-22 commented on code in PR #17402:
URL: https://github.com/apache/kafka/pull/17402#discussion_r1815863127
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -762,7 +764,7 @@ synchronized void maybeResolveSequences() {
chia7712 commented on code in PR #17444:
URL: https://github.com/apache/kafka/pull/17444#discussion_r1815505034
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/ModernGroup.java:
##
@@ -388,10 +386,25 @@ public Map
computeSubscriptionMetadata(
bbejeck commented on code in PR #17021:
URL: https://github.com/apache/kafka/pull/17021#discussion_r1815637024
##
streams/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsTelemetryIntegrationTest.java:
##
@@ -0,0 +1,547 @@
+/*
+ * Licensed to the Apache Software Fo
junrao commented on code in PR #16842:
URL: https://github.com/apache/kafka/pull/16842#discussion_r1815847272
##
core/src/main/java/kafka/server/share/SharePartitionManager.java:
##
@@ -617,22 +650,35 @@ private void maybeCompleteInitializationWithException(
return;
jolshan commented on code in PR #17597:
URL: https://github.com/apache/kafka/pull/17597#discussion_r1815718745
##
core/src/main/scala/kafka/tools/StorageTool.scala:
##
@@ -134,6 +134,12 @@ object StorageTool extends Logging {
case None =>
Option(config.originals.get(Repl
jolshan commented on PR #17576:
URL: https://github.com/apache/kafka/pull/17576#issuecomment-2436549619
Digging deeper, looks like an issue with ZK -- the brokers see
`kafka.zookeeper.ZooKeeperClientTimeoutException: Timed out waiting for
connection while in state: CONNECTING`
and on
chia7712 commented on code in PR #17562:
URL: https://github.com/apache/kafka/pull/17562#discussion_r1815557814
##
server-common/src/main/java/org/apache/kafka/server/common/serialization/NodeToControllerChannelManager.java:
##
@@ -15,10 +15,11 @@
* limitations under the Licen
[
https://issues.apache.org/jira/browse/KAFKA-17854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-17854.
Fix Version/s: 4.0.0
Resolution: Fixed
> Improve tests for ReadOnlyWindowStoreStub#
jolshan commented on PR #17576:
URL: https://github.com/apache/kafka/pull/17576#issuecomment-2436543307
@chia7712 you should be able to see this one:
http://confluent-open-source-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/trunk/2024-10-23--001.98fe335d-7619-47bc-a9b8
[
https://issues.apache.org/jira/browse/KAFKA-17847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-17847.
Fix Version/s: 4.0.0
Resolution: Fixed
> Avoid the extra bytes copy when compressin
dajac commented on PR #17444:
URL: https://github.com/apache/kafka/pull/17444#issuecomment-2435752971
@FrankYang0529 @chia7712 We may need a KIP for this one. Let's first agree
on the ideal solution and we can do a small KIP if needed.
--
This is an automated message from the Apache Git S
[
https://issues.apache.org/jira/browse/KAFKA-15284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17892638#comment-17892638
]
Kirk True commented on KAFKA-15284:
---
[~yangpoan]—sorry, I am working on this but forgo
junrao commented on code in PR #17534:
URL: https://github.com/apache/kafka/pull/17534#discussion_r1815560941
##
core/src/main/java/kafka/server/share/SharePartitionManager.java:
##
@@ -611,20 +564,9 @@ void maybeProcessFetchQueue() {
// Add the share fetch to the d
[
https://issues.apache.org/jira/browse/KAFKA-15284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True reassigned KAFKA-15284:
-
Assignee: Kirk True
> Implement GroupProtocolResolver to dynamically determine consumer group
[
https://issues.apache.org/jira/browse/KAFKA-17857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17892629#comment-17892629
]
Matthias J. Sax commented on KAFKA-17857:
-
I thinks it's fine to move the integr
[
https://issues.apache.org/jira/browse/KAFKA-17857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17892634#comment-17892634
]
Greg Harris commented on KAFKA-17857:
-
[~mjsax] This was covered in the motivation s
lianetm commented on code in PR #17035:
URL: https://github.com/apache/kafka/pull/17035#discussion_r1815159364
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1520,6 +1523,9 @@ private Fetch pollForFetches(Timer timer) {
junrao commented on code in PR #17539:
URL: https://github.com/apache/kafka/pull/17539#discussion_r1815739504
##
core/src/main/java/kafka/server/share/SharePartition.java:
##
@@ -542,6 +552,8 @@ public ShareAcquiredRecords acquire(
RecordBatch firstBatch =
fetchPartiti
junrao commented on code in PR #16842:
URL: https://github.com/apache/kafka/pull/16842#discussion_r1815761464
##
core/src/main/java/kafka/server/share/SharePartition.java:
##
@@ -1743,7 +1750,7 @@ CompletableFuture
writeShareGroupState(List stateBatc
.setGroupI
chia7712 merged PR #17225:
URL: https://github.com/apache/kafka/pull/17225
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-17871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17892627#comment-17892627
]
Greg Harris commented on KAFKA-17871:
-
The herder thread should avoid blocking on lo
[
https://issues.apache.org/jira/browse/KAFKA-17871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Harris updated KAFKA-17871:
Description:
In KAFKA-9051, source task offsets reading was modified to allow for
in-progress rea
Colin McCabe created KAFKA-17870:
Summary: Disallow creating too many partitions before using
ReplicaPlacer
Key: KAFKA-17870
URL: https://issues.apache.org/jira/browse/KAFKA-17870
Project: Kafka
junrao commented on code in PR #17539:
URL: https://github.com/apache/kafka/pull/17539#discussion_r1815741519
##
core/src/main/java/kafka/server/share/DelayedShareFetch.java:
##
@@ -204,7 +202,117 @@ Map
acquirablePartitions() {
return topicPartitionData;
}
-
jolshan commented on code in PR #17597:
URL: https://github.com/apache/kafka/pull/17597#discussion_r1815720086
##
core/src/main/scala/kafka/tools/StorageTool.scala:
##
@@ -134,6 +134,12 @@ object StorageTool extends Logging {
case None =>
Option(config.originals.get(Repl
cmccabe opened a new pull request, #17597:
URL: https://github.com/apache/kafka/pull/17597
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-ma
cmccabe commented on code in PR #17597:
URL: https://github.com/apache/kafka/pull/17597#discussion_r1815708150
##
core/src/main/scala/kafka/tools/StorageTool.scala:
##
@@ -134,6 +134,12 @@ object StorageTool extends Logging {
case None =>
Option(config.originals.get(Repl
jolshan commented on code in PR #17597:
URL: https://github.com/apache/kafka/pull/17597#discussion_r1815692935
##
core/src/main/scala/kafka/tools/StorageTool.scala:
##
@@ -134,6 +134,12 @@ object StorageTool extends Logging {
case None =>
Option(config.originals.get(Repl
adixitconfluent commented on code in PR #17539:
URL: https://github.com/apache/kafka/pull/17539#discussion_r1815592778
##
core/src/main/java/kafka/server/share/SharePartition.java:
##
@@ -542,6 +552,8 @@ public ShareAcquiredRecords acquire(
RecordBatch firstBatch =
fet
bbejeck commented on PR #17021:
URL: https://github.com/apache/kafka/pull/17021#issuecomment-2436263206
> should we extend the test, to not only verify task metrics, but also
thread metrics? What about DEBUG and TRACE level?
Sure, but I don't think that should block the PR. Given that
bbejeck commented on code in PR #17021:
URL: https://github.com/apache/kafka/pull/17021#discussion_r1815597028
##
clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java:
##
@@ -469,6 +471,30 @@ public void testExplicitlyEnableJmxReporter() {
admi
Bill Bejeck created KAFKA-17869:
---
Summary: Tests for clients ensuring KIP-1076 doesn't affect
existing metrics
Key: KAFKA-17869
URL: https://issues.apache.org/jira/browse/KAFKA-17869
Project: Kafka
mimaison commented on PR #17507:
URL: https://github.com/apache/kafka/pull/17507#issuecomment-2436219908
My earlier comment `It looks like there are still a few unused methods left,
for example parseEntity()` is still not addressed. You can delete
`createPasswordEncoder()`, `parseEntity()`,
adixitconfluent commented on code in PR #17539:
URL: https://github.com/apache/kafka/pull/17539#discussion_r1815599413
##
core/src/main/java/kafka/server/share/SharePartition.java:
##
@@ -1525,6 +1537,24 @@ private Optional acknowledgeCompleteBatch(
return Optional.empt
chia7712 commented on PR #17507:
URL: https://github.com/apache/kafka/pull/17507#issuecomment-2436194152
@ChengyanOo Could you please rebase code to run QA again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
chia7712 merged PR #17089:
URL: https://github.com/apache/kafka/pull/17089
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
bbejeck commented on code in PR #17021:
URL: https://github.com/apache/kafka/pull/17021#discussion_r1815598995
##
core/src/test/java/kafka/admin/ClientTelemetryTest.java:
##
@@ -80,7 +80,7 @@ public class ClientTelemetryTest {
public void testClientInstanceId(ClusterInstanc
chia7712 merged PR #17578:
URL: https://github.com/apache/kafka/pull/17578
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
junrao commented on code in PR #17539:
URL: https://github.com/apache/kafka/pull/17539#discussion_r1815510878
##
core/src/main/java/kafka/server/share/SharePartition.java:
##
@@ -1525,6 +1537,24 @@ private Optional acknowledgeCompleteBatch(
return Optional.empty();
[
https://issues.apache.org/jira/browse/KAFKA-17857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17892589#comment-17892589
]
Chia-Ping Tsai commented on KAFKA-17857:
{quote}
and the integration test shoul
chia7712 commented on PR #17594:
URL: https://github.com/apache/kafka/pull/17594#issuecomment-2436107378
I have left some comment in jira.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
chia7712 merged PR #17586:
URL: https://github.com/apache/kafka/pull/17586
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-17854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-17854:
---
Summary: Improve tests for ReadOnlyWindowStoreStub#fetch and #backwardFetch
(was: add tests
chia7712 commented on PR #17586:
URL: https://github.com/apache/kafka/pull/17586#issuecomment-2436078887
> If this change makes sense to you, should we update the Jira and Git
commit headers and descriptions to something like Improve tests for
ReadOnlyWindowStoreStub#fetch and #backwardFetc
chia7712 merged PR #17589:
URL: https://github.com/apache/kafka/pull/17589
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-17574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-17574.
Fix Version/s: 4.0.0
Assignee: Stig Rohde Døssing
Resolution: Fixed
> Kafk
[
https://issues.apache.org/jira/browse/KAFKA-16538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe updated KAFKA-16538:
-
Summary: Support UpdateFeatures for kraft.version so we can go from static
quorums to dynamic (
[
https://issues.apache.org/jira/browse/KAFKA-17866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe resolved KAFKA-17866.
--
Resolution: Duplicate
> kraft.version/dirID is not updated after upgrading to MV 3.9
> ---
kevin-wu24 opened a new pull request, #17596:
URL: https://github.com/apache/kafka/pull/17596
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of test
brandboat commented on code in PR #17594:
URL: https://github.com/apache/kafka/pull/17594#discussion_r1815371458
##
tools/src/test/java/org/apache/kafka/tools/AbstractResetIntegrationTest.java:
##
@@ -306,17 +304,17 @@ private void
testReprocessingFromScratchAfterResetWithInter
dajac commented on code in PR #17444:
URL: https://github.com/apache/kafka/pull/17444#discussion_r1815360708
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/ModernGroup.java:
##
@@ -388,10 +386,25 @@ public Map
computeSubscriptionMetadata(
lianetm commented on PR #17549:
URL: https://github.com/apache/kafka/pull/17549#issuecomment-2435743145
One concern, the unsubscribe() logic in the consumer includes logic for
resetting the group metadata (will clear the member ID).
https://github.com/apache/kafka/blob/140d35c5459f4c7a9
m1a2st opened a new pull request, #17595:
URL: https://github.com/apache/kafka/pull/17595
as title
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (includi
lianetm commented on code in PR #17549:
URL: https://github.com/apache/kafka/pull/17549#discussion_r1815339271
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerMembershipManager.java:
##
@@ -188,6 +186,7 @@ public ConsumerMembershipManager(String grou
brandboat commented on code in PR #17594:
URL: https://github.com/apache/kafka/pull/17594#discussion_r1815303550
##
build.gradle:
##
@@ -2500,6 +2502,7 @@ project(':tools') {
testImplementation libs.apachedsLdifPartition
testRuntimeOnly libs.junitPlatformLanucher
+
brandboat opened a new pull request, #17594:
URL: https://github.com/apache/kafka/pull/17594
related to https://issues.apache.org/jira/browse/KAFKA-17867,
as title, move AbstractResetIntegrationTest and subclasses to tools module
### Committer Checklist (excluded from commit mes
[
https://issues.apache.org/jira/browse/KAFKA-17861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-17861:
--
Component/s: clients
> Serialize with ByteBuffer instead of byte[]
> -
clarkwtc commented on code in PR #17570:
URL: https://github.com/apache/kafka/pull/17570#discussion_r1815245609
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java:
##
@@ -337,35 +336,33 @@ public long timeToNextUpdate(long requestTi
m1a2st commented on code in PR #17516:
URL: https://github.com/apache/kafka/pull/17516#discussion_r1815232741
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1477,10 +1481,12 @@ public void unsubscribe() {
[
https://issues.apache.org/jira/browse/KAFKA-17600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-17600:
Labels: kip (was: )
> Add nextOffsets to the ConsumerRecords
> --
srdo commented on PR #17225:
URL: https://github.com/apache/kafka/pull/17225#issuecomment-2435499004
@chia7712 Sure, done.
FWIW ShareConsumerTest passes for me locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
[
https://issues.apache.org/jira/browse/KAFKA-17867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17892509#comment-17892509
]
Kuan Po Tseng commented on KAFKA-17867:
---
Hi [~chia7712] , can I take over this iss
[
https://issues.apache.org/jira/browse/KAFKA-17867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-17867:
--
Assignee: Kuan Po Tseng (was: Chia-Ping Tsai)
> Consider using zero-copy for PushTel
chirag-wadhwa5 commented on code in PR #17573:
URL: https://github.com/apache/kafka/pull/17573#discussion_r1815110664
##
core/src/main/java/kafka/server/share/SharePartition.java:
##
@@ -382,7 +387,35 @@ public CompletableFuture maybeInitialize() {
}
chia7712 commented on code in PR #17562:
URL: https://github.com/apache/kafka/pull/17562#discussion_r1815102087
##
server/src/main/java/org/apache/kafka/server/RPCProducerIdManager.java:
##
@@ -0,0 +1,191 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or m
chia7712 commented on code in PR #17562:
URL: https://github.com/apache/kafka/pull/17562#discussion_r1815077868
##
server/src/main/java/org/apache/kafka/server/RPCProducerIdManager.java:
##
@@ -0,0 +1,191 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or m
m1a2st commented on code in PR #17562:
URL: https://github.com/apache/kafka/pull/17562#discussion_r1815067841
##
server/src/main/java/org/apache/kafka/server/RPCProducerIdManager.java:
##
@@ -0,0 +1,191 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
chia7712 commented on code in PR #17562:
URL: https://github.com/apache/kafka/pull/17562#discussion_r1815051678
##
server/src/main/java/org/apache/kafka/server/RPCProducerIdManager.java:
##
@@ -0,0 +1,191 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or m
m1a2st commented on code in PR #17562:
URL: https://github.com/apache/kafka/pull/17562#discussion_r1815038835
##
server/src/main/java/org/apache/kafka/server/RPCProducerIdManager.java:
##
@@ -0,0 +1,191 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
[
https://issues.apache.org/jira/browse/KAFKA-16728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Schofield resolved KAFKA-16728.
--
Resolution: Duplicate
> Add dynamic group configuration for heartbeat interval and ses
chia7712 commented on PR #17225:
URL: https://github.com/apache/kafka/pull/17225#issuecomment-2435331398
I feel the failed tests are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/KAFKA-8779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-8779.
---
Fix Version/s: 4.0.0
Resolution: Fixed
> Fix flaky tests introduced by dynamic log lev
apoorvmittal10 commented on code in PR #16842:
URL: https://github.com/apache/kafka/pull/16842#discussion_r1814931552
##
core/src/main/java/kafka/server/share/SharePartitionManager.java:
##
@@ -606,22 +641,51 @@ private void maybeCompleteInitializationWithException(
lianetm commented on code in PR #17549:
URL: https://github.com/apache/kafka/pull/17549#discussion_r1814943048
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -1293,17 +1287,16 @@ public void setInflightCommitStatus(final boo
chirag-wadhwa5 commented on code in PR #17573:
URL: https://github.com/apache/kafka/pull/17573#discussion_r1814945195
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfig.java:
##
@@ -238,4 +264,39 @@ public int shareHeartbeatIntervalMs() {
publ
mimaison commented on PR #17560:
URL: https://github.com/apache/kafka/pull/17560#issuecomment-2434822686
Thanks for the PR. This seems like a nice improvement however since it's
introducing a new configuration, you need to create a KIP to propose this
change. See
https://cwiki.apache.org/c
AndrewJSchofield commented on code in PR #16842:
URL: https://github.com/apache/kafka/pull/16842#discussion_r1814936067
##
core/src/main/java/kafka/server/share/SharePartitionManager.java:
##
@@ -606,22 +641,51 @@ private void maybeCompleteInitializationWithException(
[
https://issues.apache.org/jira/browse/KAFKA-17866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17892461#comment-17892461
]
Luke Chen commented on KAFKA-17866:
---
For the directory ID, it looks like we can only s
mimaison merged PR #17038:
URL: https://github.com/apache/kafka/pull/17038
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-17866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen updated KAFKA-17866:
--
Description:
When upgrading old controllers to v3.9.0, we didn't update the kraft.version to
1 and th
[
https://issues.apache.org/jira/browse/KAFKA-17866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17892461#comment-17892461
]
Luke Chen edited comment on KAFKA-17866 at 10/24/24 12:19 PM:
AndrewJSchofield commented on code in PR #17573:
URL: https://github.com/apache/kafka/pull/17573#discussion_r1814829726
##
core/src/test/scala/unit/kafka/server/ShareFetchAcknowledgeRequestTest.scala:
##
@@ -113,9 +111,8 @@ class ShareFetchAcknowledgeRequestTest(cluster:
Cluste
1 - 100 of 145 matches
Mail list logo
