Re: [PR] KAFKA-17480: New consumer commit all consumed should retrieve offsets in background thread [kafka]

2024-10-30 Thread via GitHub
FrankYang0529 commented on code in PR #17150: URL: https://github.com/apache/kafka/pull/17150#discussion_r1823879430 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java: ## @@ -187,22 +188,62 @@ private void process(final Cr

Re: [PR] KAFKA-17880: Move integration test from streams module to streams/integration-tests module [kafka]

2024-10-30 Thread via GitHub
FrankYang0529 commented on code in PR #17615: URL: https://github.com/apache/kafka/pull/17615#discussion_r1823892341 ## build.gradle: ## @@ -2803,6 +2793,7 @@ project(':streams:streams-scala') { testImplementation project(':server-common').sourceSets.test.output testIm

Re: [PR] KAFKA-17546: Admin.listGroups and kafka-groups.sh [kafka]

2024-10-30 Thread via GitHub
chia7712 commented on code in PR #17626: URL: https://github.com/apache/kafka/pull/17626#discussion_r1823828860 ## clients/src/main/java/org/apache/kafka/clients/admin/ListGroupsResult.java: ## @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[jira] [Resolved] (KAFKA-17903) Remove KafkaFuture#Function and KafkaFuture#thenApply

2024-10-30 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17903. Fix Version/s: 4.0.0 Resolution: Fixed > Remove KafkaFuture#Function and KafkaFutur

Re: [PR] KAFKA-17903: Remove KafkaFuture#Function and KafkaFuture#thenApply [kafka]

2024-10-30 Thread via GitHub
chia7712 merged PR #17644: URL: https://github.com/apache/kafka/pull/17644 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-17903: Remove KafkaFuture#Function and KafkaFuture#thenApply [kafka]

2024-10-30 Thread via GitHub
chia7712 commented on PR #17644: URL: https://github.com/apache/kafka/pull/17644#issuecomment-2449098698 the failed test is handled by #17645 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] KAFKA-17888: e2e should support to run <2.3 kafka under JDK 11 [kafka]

2024-10-30 Thread via GitHub
chia7712 commented on code in PR #17625: URL: https://github.com/apache/kafka/pull/17625#discussion_r1823811195 ## tests/docker/Dockerfile: ## @@ -13,10 +13,38 @@ # See the License for the specific language governing permissions and # limitations under the License. -# The ba

Re: [PR] KAFKA-17546: Admin.listGroups and kafka-groups.sh [kafka]

2024-10-30 Thread via GitHub
chia7712 commented on code in PR #17626: URL: https://github.com/apache/kafka/pull/17626#discussion_r1823807269 ## tools/src/main/java/org/apache/kafka/tools/GroupsCommand.java: ## @@ -0,0 +1,298 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * c

Re: [PR] KAFKA-17546: Admin.listGroups and kafka-groups.sh [kafka]

2024-10-30 Thread via GitHub
chia7712 commented on code in PR #17626: URL: https://github.com/apache/kafka/pull/17626#discussion_r1823805661 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -3490,6 +3490,138 @@ void handleFailure(Throwable throwable) { return new

[PR] KAFKA-17836: Move RackAwareTest to server module [kafka]

2024-10-30 Thread via GitHub
chiacyu opened a new pull request, #17646: URL: https://github.com/apache/kafka/pull/17646 As titled, this pr move the `RackAwareTest`, `AdminRackAwareTest` to `server-common`, please check [KAFKA-17836](https://issues.apache.org/jira/browse/KAFKA-17836) for more details. thanks! ##

Re: [PR] KAFKA-17546: Admin.listGroups and kafka-groups.sh [kafka]

2024-10-30 Thread via GitHub
chia7712 commented on code in PR #17626: URL: https://github.com/apache/kafka/pull/17626#discussion_r1823797800 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -3490,6 +3490,138 @@ void handleFailure(Throwable throwable) { return new

Re: [PR] MINOR: Revert "Temporarily update Vagrantfile to Java 11" [kafka]

2024-10-30 Thread via GitHub
chia7712 merged PR #17642: URL: https://github.com/apache/kafka/pull/17642 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Commented] (KAFKA-17893) Support record keys in the foreignKeyExtractor argument of KTable foreign join

2024-10-30 Thread Peter Lee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17894418#comment-17894418 ] Peter Lee commented on KAFKA-17893: --- [~mjsax]  [https://cwiki.apache.org/confluence/di

[jira] [Commented] (KAFKA-17902) Flaky Test kafka.admin.DeleteTopicTest testAddPartitionDuringDeleteTopic

2024-10-30 Thread kangning.li (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17894414#comment-17894414 ] kangning.li commented on KAFKA-17902: - hi  [~davidarthur] , I saw the test throw FAI

Re: [PR] KAFKA-17625: Removing ZK test variations from ducktape [kafka]

2024-10-30 Thread via GitHub
kevin-wu24 closed pull request #17601: KAFKA-17625: Removing ZK test variations from ducktape URL: https://github.com/apache/kafka/pull/17601 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] KAFKA-16985: Ensure consumer sends leave request on close even if interrupted [kafka]

2024-10-30 Thread via GitHub
kirktrue commented on PR #16686: URL: https://github.com/apache/kafka/pull/16686#issuecomment-2448860832 @lianetm— > If there is time, the classic consumer does wait for the leave request response You're right. I got my wires crossed, as you state. The new consumer will wait u

[jira] [Commented] (KAFKA-17904) Flaky testMultiConsumerSessionTimeoutOnClose

2024-10-30 Thread kangning.li (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17894392#comment-17894392 ] kangning.li commented on KAFKA-17904: - hi [~lianetm] ,  I am interested in this issu

Re: [PR] KAFKA-16985: Ensure consumer sends leave request on close even if interrupted [kafka]

2024-10-30 Thread via GitHub
kirktrue commented on code in PR #16686: URL: https://github.com/apache/kafka/pull/16686#discussion_r1823647737 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1781,30 +1776,54 @@ private boolean processBackgroundEvents() {

[jira] [Commented] (KAFKA-17864) Ensure all fields in the protocol have a description

2024-10-30 Thread Xiao Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17894388#comment-17894388 ] Xiao Yang commented on KAFKA-17864: --- OK, thanks for your reply. > Ensure all fields i

Re: [PR] KAFKA-16985: Ensure consumer sends leave request on close even if interrupted [kafka]

2024-10-30 Thread via GitHub
kirktrue commented on code in PR #16686: URL: https://github.com/apache/kafka/pull/16686#discussion_r1823645974 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1813,36 +1832,64 @@ private boolean processBackgroundEvents() {

Re: [PR] KAFKA-16985: Ensure consumer sends leave request on close even if interrupted [kafka]

2024-10-30 Thread via GitHub
kirktrue commented on code in PR #16686: URL: https://github.com/apache/kafka/pull/16686#discussion_r1823649661 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1781,30 +1776,54 @@ private boolean processBackgroundEvents() {

Re: [PR] KAFKA-16985: Ensure consumer sends leave request on close even if interrupted [kafka]

2024-10-30 Thread via GitHub
kirktrue commented on code in PR #16686: URL: https://github.com/apache/kafka/pull/16686#discussion_r1823645242 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1781,30 +1776,54 @@ private boolean processBackgroundEvents() {

Re: [PR] KAFKA-16985: Ensure consumer sends leave request on close even if interrupted [kafka]

2024-10-30 Thread via GitHub
kirktrue commented on code in PR #16686: URL: https://github.com/apache/kafka/pull/16686#discussion_r1823645497 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1781,30 +1776,54 @@ private boolean processBackgroundEvents() {

Re: [PR] KAFKA-17888: e2e should support to run <2.3 kafka under JDK 11 [kafka]

2024-10-30 Thread via GitHub
m1a2st commented on code in PR #17625: URL: https://github.com/apache/kafka/pull/17625#discussion_r1823639494 ## tests/docker/ducker-ak: ## @@ -346,15 +362,23 @@ ducker_up() { -C|--custom-ducktape) set_once custom_ducktape "${2}" "the custom ducktape directory"; sh

Re: [PR] KAFKA-12827 Remove Deprecated method KafkaStreams#setUncaughtExceptionHandler [kafka]

2024-10-30 Thread via GitHub
mjsax commented on PR #16988: URL: https://github.com/apache/kafka/pull/16988#issuecomment-2448757006 Thanks for updating the PR. There is test errors: ``` FAILED ❌ EosIntegrationTest > "shouldNotViolateEosIfOneTaskFails(boolean).processingThreadsEnabled=true" FAILED ❌ EosIntegratio

[PR] KAFKA-17463: Fixing test share groups test [kafka]

2024-10-30 Thread via GitHub
apoorvmittal10 opened a new pull request, #17645: URL: https://github.com/apache/kafka/pull/17645 Fixing the test by adding retry in Persister for NOT_COORDINATOR error. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify te

Re: [PR] KAFKA-16339: [1/4 KStream#transform] Remove Deprecated "transformer" methods and classes [kafka]

2024-10-30 Thread via GitHub
mjsax commented on PR #17198: URL: https://github.com/apache/kafka/pull/17198#issuecomment-2448759467 > Given the coming deadline, I agree it would be adequate someone more experienced to resume it. As long as you have enough time to keep working, I think we are a good. Of course, if

Re: [PR] KAFKA-17803: Changing KafkaMetadataLog#read to match MockLog#read behavior + correcting LogSegment#read javadoc [kafka]

2024-10-30 Thread via GitHub
kevin-wu24 commented on code in PR #17528: URL: https://github.com/apache/kafka/pull/17528#discussion_r1823600140 ## storage/src/test/java/org/apache/kafka/storage/internals/log/LogSegmentTest.java: ## @@ -103,6 +103,16 @@ private MemoryRecords records(long offset, String... re

[PR] KAFKA-17903: Remove KafkaFuture#Function and KafkaFuture#thenApply [kafka]

2024-10-30 Thread via GitHub
Yunyung opened a new pull request, #17644: URL: https://github.com/apache/kafka/pull/17644 JIRA: https://issues.apache.org/jira/browse/KAFKA-17903 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI buil

Re: [PR] KAFKA-17888: e2e should support to run <2.3 kafka under JDK 11 [kafka]

2024-10-30 Thread via GitHub
m1a2st commented on code in PR #17625: URL: https://github.com/apache/kafka/pull/17625#discussion_r1823619824 ## tests/docker/Dockerfile: ## @@ -55,6 +83,20 @@ ENV TZ="/usr/share/zoneinfo/America/Los_Angeles" # Do not ask for confirmations when running apt-get, etc. ENV DEBIAN

Re: [PR] KAFKA-17888: e2e should support to run <2.3 kafka under JDK 11 [kafka]

2024-10-30 Thread via GitHub
m1a2st commented on code in PR #17625: URL: https://github.com/apache/kafka/pull/17625#discussion_r1823617779 ## tests/docker/Dockerfile: ## @@ -13,10 +13,38 @@ # See the License for the specific language governing permissions and # limitations under the License. -# The base

Re: [PR] KAFKA-17609:[3/4]Convert system tests to kraft part 3 [kafka]

2024-10-30 Thread via GitHub
bbejeck commented on PR #17327: URL: https://github.com/apache/kafka/pull/17327#issuecomment-2447703748 Merged #17327 into trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] KAFKA-16339: [1/4 KStream#transform] Remove Deprecated "transformer" methods and classes [kafka]

2024-10-30 Thread via GitHub
fonsdant commented on PR #17198: URL: https://github.com/apache/kafka/pull/17198#issuecomment-2448661761 I will push the work I done this passed week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] MINOR: Using rocksdb's prefixScan in fk joins for better performances [kafka]

2024-10-30 Thread via GitHub
Chuckame commented on code in PR #16218: URL: https://github.com/apache/kafka/pull/16218#discussion_r1823583121 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/ForeignTableJoinProcessorSupplier.java: ## @@ -111,34 +110,26 @@ public void process

Re: [PR] KAFKA-17803: Changing KafkaMetadataLog#read to match MockLog#read behavior + correcting LogSegment#read javadoc [kafka]

2024-10-30 Thread via GitHub
kevin-wu24 commented on code in PR #17528: URL: https://github.com/apache/kafka/pull/17528#discussion_r1823600140 ## storage/src/test/java/org/apache/kafka/storage/internals/log/LogSegmentTest.java: ## @@ -103,6 +103,16 @@ private MemoryRecords records(long offset, String... re

[jira] [Commented] (KAFKA-17902) Flaky Test kafka.admin.DeleteTopicTest testAddPartitionDuringDeleteTopic

2024-10-30 Thread kangning.li (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17894376#comment-17894376 ] kangning.li commented on KAFKA-17902: - [~davidarthur] hi David, I'll take it :) > F

[jira] [Assigned] (KAFKA-17902) Flaky Test kafka.admin.DeleteTopicTest testAddPartitionDuringDeleteTopic

2024-10-30 Thread kangning.li (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kangning.li reassigned KAFKA-17902: --- Assignee: kangning.li > Flaky Test kafka.admin.DeleteTopicTest testAddPartitionDuringDelete

Re: [PR] KAFKA-17803: Changing KafkaMetadataLog#read to match MockLog#read behavior + correcting LogSegment#read javadoc [kafka]

2024-10-30 Thread via GitHub
kevin-wu24 commented on code in PR #17528: URL: https://github.com/apache/kafka/pull/17528#discussion_r1823588180 ## storage/src/test/java/org/apache/kafka/storage/internals/log/LogSegmentTest.java: ## @@ -103,6 +103,16 @@ private MemoryRecords records(long offset, String... re

Re: [PR] KAFKA-17803: Changing KafkaMetadataLog#read to match MockLog#read behavior + correcting LogSegment#read javadoc [kafka]

2024-10-30 Thread via GitHub
kevin-wu24 commented on code in PR #17528: URL: https://github.com/apache/kafka/pull/17528#discussion_r1823588180 ## storage/src/test/java/org/apache/kafka/storage/internals/log/LogSegmentTest.java: ## @@ -103,6 +103,16 @@ private MemoryRecords records(long offset, String... re

Re: [PR] KAFKA-17803: Changing KafkaMetadataLog#read to match MockLog#read behavior + correcting LogSegment#read javadoc [kafka]

2024-10-30 Thread via GitHub
junrao commented on code in PR #17528: URL: https://github.com/apache/kafka/pull/17528#discussion_r1823582232 ## storage/src/test/java/org/apache/kafka/storage/internals/log/LogSegmentTest.java: ## @@ -103,6 +103,16 @@ private MemoryRecords records(long offset, String... record

[jira] [Assigned] (KAFKA-17903) Remove KafkaFuture#Function and KafkaFuture#thenApply

2024-10-30 Thread Jhen Yung Hsu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jhen Yung Hsu reassigned KAFKA-17903: - Assignee: Jhen Yung Hsu (was: Chia-Ping Tsai) > Remove KafkaFuture#Function and KafkaF

Re: [PR] MINOR: Using rocksdb's prefixScan in fk joins for better performances [kafka]

2024-10-30 Thread via GitHub
Chuckame commented on code in PR #16218: URL: https://github.com/apache/kafka/pull/16218#discussion_r1823572135 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/ForeignTableJoinProcessorSupplier.java: ## @@ -111,34 +110,26 @@ public void process

Re: [PR] KAFKA-16143: New JMX metrics for AsyncKafkaConsumer [kafka]

2024-10-30 Thread via GitHub
kirktrue commented on code in PR #17199: URL: https://github.com/apache/kafka/pull/17199#discussion_r1823530021 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/BackgroundEvent.java: ## @@ -37,6 +37,7 @@ public enum Type { * {@link #equals(Object

[jira] [Created] (KAFKA-17899) Add more unit tests for NetworkReceive

2024-10-30 Thread TengYao Chi (Jira)
TengYao Chi created KAFKA-17899: --- Summary: Add more unit tests for NetworkReceive Key: KAFKA-17899 URL: https://issues.apache.org/jira/browse/KAFKA-17899 Project: Kafka Issue Type: Test

[PR] KAFKA-17627: ConfigProvider TTLs do not restart Tasks [kafka]

2024-10-30 Thread via GitHub
SpacRocket opened a new pull request, #17643: URL: https://github.com/apache/kafka/pull/17643 When WorkerConfigTransformer got TTLs in config provided it only scheduled connector restart, this PR schedules restart for Tasks too. *Testing rationale* I implemented similar testing as

Re: [PR] KAFKA-17696 New consumer background operations unaware of metadata errors [kafka]

2024-10-30 Thread via GitHub
kirktrue commented on PR #17440: URL: https://github.com/apache/kafka/pull/17440#issuecomment-2448556088 @m1a2st—I tested this fix by merging the changes in this PR with the changes from [my PR that sets the default `group.protocol` value to `CONSUMER`](https://github.com/apache/kafka/pull/

Re: [PR] KAFKA-17803: Changing KafkaMetadataLog#read to match MockLog#read behavior + correcting LogSegment#read javadoc [kafka]

2024-10-30 Thread via GitHub
junrao commented on code in PR #17528: URL: https://github.com/apache/kafka/pull/17528#discussion_r1823516406 ## storage/src/test/java/org/apache/kafka/storage/internals/log/LogSegmentTest.java: ## @@ -103,6 +103,16 @@ private MemoryRecords records(long offset, String... record

[PR] MINOR: Revert "Temporarily update Vagrantfile to Java 11" [kafka]

2024-10-30 Thread via GitHub
bbejeck opened a new pull request, #17642: URL: https://github.com/apache/kafka/pull/17642 This reverts commit from #17603 the Vagrant file was updated temporarily to run the system tests. *Summary of testing strategy (including rationale) for the feature or bug fix. Unit and/o

Re: [PR] KAFKA-10551: Add topic id support to produce request and response [kafka]

2024-10-30 Thread via GitHub
junrao commented on PR #15968: URL: https://github.com/apache/kafka/pull/15968#issuecomment-2448542693 > I will first fix the conflict with ReplicaManager as new class TopicOptionalIdPartition as part of https://github.com/apache/kafka/pull/17437. TopicOptionalIdPartition is a tempora

Re: [PR] KAFKA-17546: Admin.listGroups and kafka-groups.sh [kafka]

2024-10-30 Thread via GitHub
AndrewJSchofield commented on code in PR #17626: URL: https://github.com/apache/kafka/pull/17626#discussion_r1823489185 ## tools/src/main/java/org/apache/kafka/tools/GroupsCommand.java: ## @@ -0,0 +1,298 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mo

Re: [PR] MINOR: Update ClientInstanceIds to match previous refactoring [kafka]

2024-10-30 Thread via GitHub
bbejeck closed pull request #17641: MINOR: Update ClientInstanceIds to match previous refactoring URL: https://github.com/apache/kafka/pull/17641 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-17338 ConsumerConfig should prevent using partition assignors with CONSUMER group protocol [kafka]

2024-10-30 Thread via GitHub
kirktrue commented on code in PR #16899: URL: https://github.com/apache/kafka/pull/16899#discussion_r1823469670 ## clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java: ## @@ -379,7 +374,24 @@ public class ConsumerConfig extends AbstractConfig { priva

Re: [PR] KAFKA-17338 ConsumerConfig should prevent using partition assignors with CONSUMER group protocol [kafka]

2024-10-30 Thread via GitHub
kirktrue commented on code in PR #16899: URL: https://github.com/apache/kafka/pull/16899#discussion_r1823433917 ## clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java: ## @@ -379,7 +374,24 @@ public class ConsumerConfig extends AbstractConfig { priva

Re: [PR] KAFKA-17546: Admin.listGroups and kafka-groups.sh [kafka]

2024-10-30 Thread via GitHub
AndrewJSchofield commented on code in PR #17626: URL: https://github.com/apache/kafka/pull/17626#discussion_r1823460344 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -3490,6 +3490,138 @@ void handleFailure(Throwable throwable) { re

[jira] [Updated] (KAFKA-17821) the set of configs displayed by `logAll` could be invalid

2024-10-30 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-17821: -- Component/s: clients consumer > the set of configs displayed by `logAll` could be inv

Re: [PR] MINOR: Don't run update-test-catalog on PRs [kafka]

2024-10-30 Thread via GitHub
mumrah merged PR #17640: URL: https://github.com/apache/kafka/pull/17640 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

Re: [PR] KAFKA-17546: Admin.listGroups and kafka-groups.sh [kafka]

2024-10-30 Thread via GitHub
AndrewJSchofield commented on code in PR #17626: URL: https://github.com/apache/kafka/pull/17626#discussion_r1823445594 ## tools/src/main/java/org/apache/kafka/tools/GroupsCommand.java: ## @@ -0,0 +1,298 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mo

Re: [PR] KAFKA-17546: Admin.listGroups and kafka-groups.sh [kafka]

2024-10-30 Thread via GitHub
AndrewJSchofield commented on code in PR #17626: URL: https://github.com/apache/kafka/pull/17626#discussion_r1823444073 ## clients/src/main/java/org/apache/kafka/clients/admin/GroupListing.java: ## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] MINOR: Revert "Temporarily update Vagrantfile to Java 11" [kafka]

2024-10-30 Thread via GitHub
bbejeck commented on PR #17642: URL: https://github.com/apache/kafka/pull/17642#issuecomment-2448470143 @chia7712 #17603 also updated the `Vagrantfile` which was supposed to be temporary. Can you approve this and I'll merge it? -- This is an automated message from the Apache Git Servi

Re: [PR] KAFKA-17546: Admin.listGroups and kafka-groups.sh [kafka]

2024-10-30 Thread via GitHub
AndrewJSchofield commented on code in PR #17626: URL: https://github.com/apache/kafka/pull/17626#discussion_r1823431769 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -3490,6 +3490,138 @@ void handleFailure(Throwable throwable) { re

[jira] [Resolved] (KAFKA-17002) Integrate partition leader epoch in Share Partition

2024-10-30 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-17002. - Fix Version/s: 4.0.0 Resolution: Fixed merged the PR to trunk > Integrate partition leader epoch

Re: [PR] KAFKA-17002: Integrated partition leader epoch for Persister APIs (KIP-932) [kafka]

2024-10-30 Thread via GitHub
junrao merged PR #16842: URL: https://github.com/apache/kafka/pull/16842 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

Re: [PR] KAFKA-17546: Admin.listGroups and kafka-groups.sh [kafka]

2024-10-30 Thread via GitHub
AndrewJSchofield commented on code in PR #17626: URL: https://github.com/apache/kafka/pull/17626#discussion_r1823410046 ## clients/src/main/java/org/apache/kafka/clients/admin/ListGroupsOptions.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] KAFKA-17546: Admin.listGroups and kafka-groups.sh [kafka]

2024-10-30 Thread via GitHub
AndrewJSchofield commented on code in PR #17626: URL: https://github.com/apache/kafka/pull/17626#discussion_r1823418131 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -3490,6 +3490,138 @@ void handleFailure(Throwable throwable) { re

Re: [PR] KAFKA-17609: Migrate broker compatibility test from ZK to KRaft [kafka]

2024-10-30 Thread via GitHub
bbejeck commented on PR #17603: URL: https://github.com/apache/kafka/pull/17603#issuecomment-2448386331 Thanks for merging @chia7712! [Link to passing system test](https://semaphore.ci.confluent.io/jobs/9bbf9044-bc0e-4d9b-ba5a-eaa243eb48b2/summary?report_id=0356f43b-c807-318c-b61e-09e

[PR] MINOR: Update ClientInstanceIds to match previous refactoring [kafka]

2024-10-30 Thread via GitHub
bbejeck opened a new pull request, #17641: URL: https://github.com/apache/kafka/pull/17641 During the EOSv1 refactor (#17521) a couple of refactorings with `ClientInstanceIds` were overlooked. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implem

Re: [PR] KAFKA-16964: Integration tests for adding and removing voters [kafka]

2024-10-30 Thread via GitHub
chia7712 commented on code in PR #17582: URL: https://github.com/apache/kafka/pull/17582#discussion_r1823388462 ## core/src/main/java/kafka/server/ServerSocketFactory.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contrib

Re: [PR] KAFKA-17803: Changing KafkaMetadataLog#read to match MockLog#read behavior + correcting LogSegment#read javadoc [kafka]

2024-10-30 Thread via GitHub
junrao commented on code in PR #17528: URL: https://github.com/apache/kafka/pull/17528#discussion_r1823113684 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogSegment.java: ## @@ -409,17 +409,17 @@ public FetchDataInfo read(long startOffset, int maxSize, long

Re: [PR] KAFKA-14562 [2/3]: Implement epoch bump after every transaction (KIP-890) [kafka]

2024-10-30 Thread via GitHub
jolshan commented on PR #17402: URL: https://github.com/apache/kafka/pull/17402#issuecomment-2448398229 While rerunning the test that had issues -- I noticed this one is flaky > "testFailureToFenceEpoch(String, boolean).quorum=kraft, isTV2Enabled=true" should we change something here? I

[jira] [Resolved] (KAFKA-17726) New consumer subscribe/subscribeFromPattern in background thread

2024-10-30 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans resolved KAFKA-17726. Reviewer: Lianet Magrans Resolution: Fixed > New consumer subscribe/subscribeFromPat

Re: [PR] KAFKA-17726: New consumer subscribe/subscribeFromPattern in background thread [kafka]

2024-10-30 Thread via GitHub
lianetm merged PR #17569: URL: https://github.com/apache/kafka/pull/17569 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[jira] [Created] (KAFKA-17904) Flaky testMultiConsumerSessionTimeoutOnClose

2024-10-30 Thread Lianet Magrans (Jira)
Lianet Magrans created KAFKA-17904: -- Summary: Flaky testMultiConsumerSessionTimeoutOnClose Key: KAFKA-17904 URL: https://issues.apache.org/jira/browse/KAFKA-17904 Project: Kafka Issue Type:

Re: [PR] KAFKA-17480: New consumer commit all consumed should retrieve offsets in background thread [kafka]

2024-10-30 Thread via GitHub
kirktrue commented on code in PR #17150: URL: https://github.com/apache/kafka/pull/17150#discussion_r1823388056 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java: ## @@ -508,7 +505,7 @@ public void testSubscriptionRegexEvalOnPollOn

Re: [PR] MINOR: Quarantine worst flaky tests [kafka]

2024-10-30 Thread via GitHub
mumrah merged PR #17639: URL: https://github.com/apache/kafka/pull/17639 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

Re: [PR] MINOR: Don't run update-test-catalog on PRs [kafka]

2024-10-30 Thread via GitHub
chia7712 commented on code in PR #17640: URL: https://github.com/apache/kafka/pull/17640#discussion_r1823376786 ## .github/workflows/build.yml: ## @@ -193,8 +193,9 @@ jobs: if-no-files-found: ignore update-test-catalog: +name: Update Test Catalog Review Comm

Re: [PR] KAFKA-17609: Migrate broker compatibility test from ZK to KRaft [kafka]

2024-10-30 Thread via GitHub
chia7712 merged PR #17603: URL: https://github.com/apache/kafka/pull/17603 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[PR] MINOR: Don't run update-test-catalog on PRs [kafka]

2024-10-30 Thread via GitHub
mumrah opened a new pull request, #17640: URL: https://github.com/apache/kafka/pull/17640 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

Re: [PR] KAFKA-17546: Admin.listGroups and kafka-groups.sh [kafka]

2024-10-30 Thread via GitHub
chia7712 commented on code in PR #17626: URL: https://github.com/apache/kafka/pull/17626#discussion_r1823307470 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -3490,6 +3490,138 @@ void handleFailure(Throwable throwable) { return new

Re: [PR] MINOR: Add Kafka 3.8.1 to system tests [kafka]

2024-10-30 Thread via GitHub
chia7712 merged PR #17629: URL: https://github.com/apache/kafka/pull/17629 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Created] (KAFKA-17903) Remove KafkaFuture#Function and KafkaFuture#thenApply

2024-10-30 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-17903: -- Summary: Remove KafkaFuture#Function and KafkaFuture#thenApply Key: KAFKA-17903 URL: https://issues.apache.org/jira/browse/KAFKA-17903 Project: Kafka Iss

Re: [PR] KAFKA-17609: Migrate broker compatibility test from ZK to KRaft [kafka]

2024-10-30 Thread via GitHub
bbejeck commented on PR #17603: URL: https://github.com/apache/kafka/pull/17603#issuecomment-2448263566 Confirmed 2.8.2 fails in system test per [previous comment](https://github.com/apache/kafka/pull/17603#discussion_r1818118747) ![broker_fails_at_2 8](https://github.com/user-attach

Re: [PR] MINOR: Various cleanups in metadata [kafka]

2024-10-30 Thread via GitHub
chia7712 merged PR #17633: URL: https://github.com/apache/kafka/pull/17633 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[PR] MINOR: Quarantine flaky tests [kafka]

2024-10-30 Thread via GitHub
mumrah opened a new pull request, #17639: URL: https://github.com/apache/kafka/pull/17639 Using the last 7 days of data, this patch marks all flaky tests with more than 10% flakiness on trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] KAFKA-17726: New consumer subscribe/subscribeFromPattern in background thread [kafka]

2024-10-30 Thread via GitHub
FrankYang0529 commented on code in PR #17569: URL: https://github.com/apache/kafka/pull/17569#discussion_r1822943740 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1679,7 +1658,13 @@ private void sendPrefetches(Timer timer) {

Re: [PR] KAFKA-17726: New consumer subscribe/subscribeFromPattern in background thread [kafka]

2024-10-30 Thread via GitHub
TaiJuWu commented on code in PR #17569: URL: https://github.com/apache/kafka/pull/17569#discussion_r1822960666 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1679,7 +1658,13 @@ private void sendPrefetches(Timer timer) {

[jira] [Updated] (KAFKA-17835) Move ProducerIdManager and RPCProducerIdManager to transaction-coordinator module

2024-10-30 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-17835: --- Summary: Move ProducerIdManager and RPCProducerIdManager to transaction-coordinator module

Re: [PR] KAFKA-17835: Move ProducerIdManager and RPCProducerIdManager to server module [kafka]

2024-10-30 Thread via GitHub
chia7712 merged PR #17562: URL: https://github.com/apache/kafka/pull/17562 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[PR] KAFKA-17625: Removing explicit ZK test parameterizations [kafka]

2024-10-30 Thread via GitHub
kevin-wu24 opened a new pull request, #17638: URL: https://github.com/apache/kafka/pull/17638 This PR removes ZK test parameterizations from ducktape by: * Removing `zk` from `quorum.all_non_upgrade` * Removing `quorum.zk` from `@matrix` and `@parametrize` annotations * Changing usa

Re: [PR] MINOR: Use JDK 17 in Vagrant after dropping JDK 8 [kafka]

2024-10-30 Thread via GitHub
chia7712 commented on PR #17576: URL: https://github.com/apache/kafka/pull/17576#issuecomment-2448053676 > We'll file a PR later, see #17625 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] KAFKA-17880: Move integration test from streams module to streams/integration-tests module [kafka]

2024-10-30 Thread via GitHub
chia7712 commented on code in PR #17615: URL: https://github.com/apache/kafka/pull/17615#discussion_r1823191625 ## build.gradle: ## @@ -2803,6 +2793,7 @@ project(':streams:streams-scala') { testImplementation project(':server-common').sourceSets.test.output testImpleme

Re: [PR] KAFKA-14562 [2/3]: Implement epoch bump after every transaction (KIP-890) [kafka]

2024-10-30 Thread via GitHub
rreddy-22 commented on code in PR #17402: URL: https://github.com/apache/kafka/pull/17402#discussion_r1823191365 ## core/src/main/scala/kafka/coordinator/transaction/TransactionMetadata.scala: ## @@ -346,14 +346,14 @@ private[transaction] class TransactionMetadata(val transacti

Re: [PR] KAFKA-14562 [2/3]: Implement epoch bump after every transaction (KIP-890) [kafka]

2024-10-30 Thread via GitHub
rreddy-22 commented on code in PR #17402: URL: https://github.com/apache/kafka/pull/17402#discussion_r1823190412 ## core/src/main/scala/kafka/coordinator/transaction/TransactionMetadata.scala: ## @@ -346,14 +346,14 @@ private[transaction] class TransactionMetadata(val transacti

[jira] [Updated] (KAFKA-17902) Flaky Test kafka.admin.DeleteTopicTest testAddPartitionDuringDeleteTopic

2024-10-30 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-17902: - Labels: flaky-test (was: ) > Flaky Test kafka.admin.DeleteTopicTest testAddPartitionDuringDelet

[jira] [Created] (KAFKA-17902) Flaky Test kafka.admin.DeleteTopicTest testAddPartitionDuringDeleteTopic

2024-10-30 Thread David Arthur (Jira)
David Arthur created KAFKA-17902: Summary: Flaky Test kafka.admin.DeleteTopicTest testAddPartitionDuringDeleteTopic Key: KAFKA-17902 URL: https://issues.apache.org/jira/browse/KAFKA-17902 Project: Kaf

[jira] [Reopened] (KAFKA-15918) Flaky test - OffsetsApiIntegrationTest.testResetSinkConnectorOffsets

2024-10-30 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur reopened KAFKA-15918: -- https://ge.apache.org/scans/tests?search.names=CI%20workflow%2CGit%20repository&search.rootProject

Re: [PR] KAFKA-17002: Integrated partition leader epoch for Persister APIs (KIP-932) [kafka]

2024-10-30 Thread via GitHub
apoorvmittal10 commented on PR #16842: URL: https://github.com/apache/kafka/pull/16842#issuecomment-2447999870 Hi @junrao , thanks for the feedback. Addressed and replied. There is one test which was previously marked as flaky but I can see the failure in this PR as well. I have updated t

Re: [PR] KAFKA-17882: improve the document about "default value" of tagged structure field [kafka]

2024-10-30 Thread via GitHub
chia7712 commented on code in PR #17618: URL: https://github.com/apache/kafka/pull/17618#discussion_r1823170749 ## clients/src/main/resources/common/message/README.md: ## @@ -139,6 +139,20 @@ breaking compatibility. Note that tagged fields can only be added to "flexible" mess

[jira] [Updated] (KAFKA-17463) Flaky test: kafka.api.PlaintextAdminIntegrationTest."testShareGroups(String).quorum=kraft+kip932"

2024-10-30 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal updated KAFKA-17463: -- Description: Test has been failing for multiple runs now: [https://github.com/apache/kafka/ac

[jira] [Updated] (KAFKA-17463) Flaky test: kafka.api.PlaintextAdminIntegrationTest."testShareGroups(String).quorum=kraft+kip932"

2024-10-30 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal updated KAFKA-17463: -- Summary: Flaky test: kafka.api.PlaintextAdminIntegrationTest."testShareGroups(String).quorum=k

Re: [PR] KAFKA-17757: Remove Utils.mkEntry [kafka]

2024-10-30 Thread via GitHub
chia7712 commented on PR #17488: URL: https://github.com/apache/kafka/pull/17488#issuecomment-2447990583 @mingyen066 please fix conflicts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

  1   2   >