[jira] [Assigned] (KAFKA-15549) Bump swagger dependency version

2024-11-08 Thread Jhen-Yung Hsu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jhen-Yung Hsu reassigned KAFKA-15549: - Assignee: Jhen-Yung Hsu > Bump swagger dependency version > ---

[PR] KAFKA-15549: Bump swagger dependency version [kafka]

2024-11-08 Thread via GitHub
Yunyung opened a new pull request, #17730: URL: https://github.com/apache/kafka/pull/17730 Now, we can use swagger 2.2.25, as we're using JDK 11 as the minimum version. JIRA: https://issues.apache.org/jira/browse/KAFKA-15549 ### Committer Checklist (excluded from commit message)

[PR] MINOR: Delete unused member [kafka]

2024-11-08 Thread via GitHub
frankvicky opened a new pull request, #17729: URL: https://github.com/apache/kafka/pull/17729 As title, clientTelemetryEnabled is not accessing now. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI bu

Re: [PR] KAFKA-17570: Rewrite StressTestLog by Java [kafka]

2024-11-08 Thread via GitHub
chia7712 merged PR #17249: URL: https://github.com/apache/kafka/pull/17249 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-17696 New consumer background operations unaware of metadata errors [kafka]

2024-11-08 Thread via GitHub
m1a2st commented on code in PR #17440: URL: https://github.com/apache/kafka/pull/17440#discussion_r1835289473 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1574,7 +1583,11 @@ private boolean updateFetchPositions(final Timer

[jira] [Resolved] (KAFKA-17570) Rewrite StressTestLog by JMH

2024-11-08 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17570. Fix Version/s: 4.0.0 Resolution: Fixed > Rewrite StressTestLog by JMH > ---

[jira] [Created] (KAFKA-17974) Upgrade gradle from 8.10 to 8.10.2

2024-11-08 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-17974: -- Summary: Upgrade gradle from 8.10 to 8.10.2 Key: KAFKA-17974 URL: https://issues.apache.org/jira/browse/KAFKA-17974 Project: Kafka Issue Type: Improvemen

Re: [PR] Move StopPartition to server-common [kafka]

2024-11-08 Thread via GitHub
chia7712 commented on PR #17704: URL: https://github.com/apache/kafka/pull/17704#issuecomment-2466073228 @mimaison Could you please fix the conflicts? thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[jira] [Assigned] (KAFKA-17974) Upgrade gradle from 8.10 to 8.10.2

2024-11-08 Thread Chia-Chuan Yu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Chuan Yu reassigned KAFKA-17974: - Assignee: Chia-Chuan Yu (was: Chia-Ping Tsai) > Upgrade gradle from 8.10 to 8.10.2 > -

[jira] [Commented] (KAFKA-15549) Bump swagger dependency version

2024-11-08 Thread Jhen-Yung Hsu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896851#comment-17896851 ] Jhen-Yung Hsu commented on KAFKA-15549: --- I'm working on this. Thanks:) > Bump swa

[jira] [Commented] (KAFKA-15549) Bump swagger dependency version

2024-11-08 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896850#comment-17896850 ] Chia-Ping Tsai commented on KAFKA-15549: Upgrading Swagger to version 2.2.25 is

Re: [PR] MINOR: log fix in SnapshottableCoordinator [kafka]

2024-11-08 Thread via GitHub
chia7712 merged PR #17726: URL: https://github.com/apache/kafka/pull/17726 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-12894) KIP-750: Drop support for Java 8 in Kafka 4.0 (deprecate in 3.0)

2024-11-08 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-12894. Resolution: Fixed > KIP-750: Drop support for Java 8 in Kafka 4.0 (deprecate in 3.0) > ---

[jira] [Resolved] (KAFKA-17969) Fix StorageToolTest for 3.9

2024-11-08 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17969. Resolution: Fixed > Fix StorageToolTest for 3.9 > --- > >

Re: [PR] KAFKA-17969: Fix StorageToolTest for 3.9 [kafka]

2024-11-08 Thread via GitHub
chia7712 merged PR #17723: URL: https://github.com/apache/kafka/pull/17723 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-17053: Restructure build.gradle to configure publishing last [kafka]

2024-11-08 Thread via GitHub
KTKTK-HZ commented on PR #16950: URL: https://github.com/apache/kafka/pull/16950#issuecomment-2466066194 Hi @chia7712 .I have resolved these conflicts, thanks for your reminder. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] KAFKA-17053: Restructure build.gradle to configure publishing last [kafka]

2024-11-08 Thread via GitHub
KTKTK-HZ commented on PR #16950: URL: https://github.com/apache/kafka/pull/16950#issuecomment-2466065937 Hi, @chia7712.I have resolved these conflicts, thanks for your reminder. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Assigned] (KAFKA-17601) Inter-broker connections do not expose their clientSoftwareName and clientSoftwareVersion tags

2024-11-08 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-17601: -- Assignee: PoAn Yang (was: Chia-Ping Tsai) > Inter-broker connections do not expose t

[jira] [Updated] (KAFKA-17601) Inter-broker connections do not expose their clientSoftwareName and clientSoftwareVersion tags

2024-11-08 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-17601: --- Fix Version/s: 4.0.0 > Inter-broker connections do not expose their clientSoftwareName and

[jira] [Assigned] (KAFKA-17601) Inter-broker connections do not expose their clientSoftwareName and clientSoftwareVersion tags

2024-11-08 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-17601: -- Assignee: Chia-Ping Tsai > Inter-broker connections do not expose their clientSoftwar

[jira] [Commented] (KAFKA-17601) Inter-broker connections do not expose their clientSoftwareName and clientSoftwareVersion tags

2024-11-08 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896849#comment-17896849 ] Chia-Ping Tsai commented on KAFKA-17601: The root cause is that we set the clien

Re: [PR] KAFKA-16758: Extend Consumer#close with an option to leave the group or not [kafka]

2024-11-08 Thread via GitHub
ableegoldman commented on code in PR #17614: URL: https://github.com/apache/kafka/pull/17614#discussion_r1835275947 ## clients/src/main/java/org/apache/kafka/clients/consumer/Consumer.java: ## @@ -267,13 +269,92 @@ public interface Consumer extends Closeable { void close();

Re: [PR] KAFKA-16758: Extend Consumer#close with an option to leave the group or not [kafka]

2024-11-08 Thread via GitHub
ableegoldman commented on code in PR #17614: URL: https://github.com/apache/kafka/pull/17614#discussion_r1835275912 ## clients/src/main/java/org/apache/kafka/clients/consumer/Consumer.java: ## @@ -267,13 +269,92 @@ public interface Consumer extends Closeable { void close();

Re: [PR] KAFKA-17779: Refactor Flaky RLM Test [kafka]

2024-11-08 Thread via GitHub
wperlichek commented on PR #17724: URL: https://github.com/apache/kafka/pull/17724#issuecomment-2466046733 @kamalcph Thanks for triggering the build, I had a formatting issue I fixed here c2297be7b479a93e348fab3469e5efe7917b1e7e, can we try the CI build again? -- This is an automated mess

[jira] [Commented] (KAFKA-16460) New consumer times out consuming records in multiple consumer_test.py system tests

2024-11-08 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896842#comment-17896842 ] Kirk True commented on KAFKA-16460: --- My question is: why was consumer A's assignment r

[jira] [Commented] (KAFKA-16460) New consumer times out consuming records in multiple consumer_test.py system tests

2024-11-08 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896841#comment-17896841 ] Kirk True commented on KAFKA-16460: --- Looking at this in depth, there's an interesting

[jira] [Updated] (KAFKA-16460) New consumer times out consuming records in multiple consumer_test.py system tests

2024-11-08 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16460: -- Attachment: verifiable_consumer_worker_B.log verifiable_consumer_worker_A.log > New co

[jira] [Updated] (KAFKA-16460) New consumer times out consuming records in multiple consumer_test.py system tests

2024-11-08 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16460: -- Attachment: verifiable_consumer_worker_B.stdout verifiable_consumer_worker_A.stdout >

Re: [PR] KAFKA-17801: RemoteLogManager may compute inaccurate upperBoundOffset for aborted txns [kafka]

2024-11-08 Thread via GitHub
kamalcph merged PR #17676: URL: https://github.com/apache/kafka/pull/17676 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: fix time discrepancy between TestInputTopic and TopologyTestDriver that creates it [kafka]

2024-11-08 Thread via GitHub
ableegoldman merged PR #17702: URL: https://github.com/apache/kafka/pull/17702 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.ap

[jira] [Created] (KAFKA-17973) Relax Restriction for Voters Set Change

2024-11-08 Thread Hailey Ni (Jira)
Hailey Ni created KAFKA-17973: - Summary: Relax Restriction for Voters Set Change Key: KAFKA-17973 URL: https://issues.apache.org/jira/browse/KAFKA-17973 Project: Kafka Issue Type: Task

[jira] [Assigned] (KAFKA-17973) Relax Restriction for Voters Set Change

2024-11-08 Thread Hailey Ni (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hailey Ni reassigned KAFKA-17973: - Assignee: Hailey Ni > Relax Restriction for Voters Set Change > ---

Re: [PR] KAFKA-17954: Error getting oldest-iterator-open-since-ms from JMX [kafka]

2024-11-08 Thread via GitHub
ableegoldman commented on code in PR #17713: URL: https://github.com/apache/kafka/pull/17713#discussion_r1835228669 ## streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java: ## @@ -154,7 +155,13 @@ private void registerMetrics() { Stat

[PR] Relax Restriction for Voters Set Change [kafka]

2024-11-08 Thread via GitHub
hni61223 opened a new pull request, #17728: URL: https://github.com/apache/kafka/pull/17728 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testin

[jira] [Updated] (KAFKA-16176) Flaky test: testSendToPartitionWithFollowerShutdownShouldNotTimeout – kafka.api.PlaintextProducerSendTest

2024-11-08 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16176: -- Attachment: CLASSIC_group_protocol.log > Flaky test: testSendToPartitionWithFollowerShutdownShouldNotT

[jira] [Commented] (KAFKA-16176) Flaky test: testSendToPartitionWithFollowerShutdownShouldNotTimeout – kafka.api.PlaintextProducerSendTest

2024-11-08 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896836#comment-17896836 ] Kirk True commented on KAFKA-16176: --- [~apoorvmittal10]—I am getting this error when te

[jira] [Updated] (KAFKA-16176) Flaky test: testSendToPartitionWithFollowerShutdownShouldNotTimeout – kafka.api.PlaintextProducerSendTest

2024-11-08 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16176: -- Attachment: CONSUMER_group_protocol.log > Flaky test: testSendToPartitionWithFollowerShutdownShouldNot

[jira] [Updated] (KAFKA-16176) Flaky test: testSendToPartitionWithFollowerShutdownShouldNotTimeout – kafka.api.PlaintextProducerSendTest

2024-11-08 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16176: -- Labels: integration-test kip-848-client-support (was: integration-test) > Flaky test: testSendToParti

[jira] [Updated] (KAFKA-16176) Flaky test: testSendToPartitionWithFollowerShutdownShouldNotTimeout – kafka.api.PlaintextProducerSendTest

2024-11-08 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16176: -- Component/s: consumer > Flaky test: testSendToPartitionWithFollowerShutdownShouldNotTimeout – > kafka

[jira] [Updated] (KAFKA-16176) Flaky test: testSendToPartitionWithFollowerShutdownShouldNotTimeout – kafka.api.PlaintextProducerSendTest

2024-11-08 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16176: -- Labels: integration-test (was: ) > Flaky test: testSendToPartitionWithFollowerShutdownShouldNotTimeou

[jira] [Commented] (KAFKA-16460) New consumer times out consuming records in multiple consumer_test.py system tests

2024-11-08 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896832#comment-17896832 ] Kirk True commented on KAFKA-16460: --- And, of course, my very next system test run I ge

Re: [PR] KAFKA-16985: Ensure consumer attempts to send leave request on close even if interrupted [kafka]

2024-11-08 Thread via GitHub
kirktrue commented on code in PR #16686: URL: https://github.com/apache/kafka/pull/16686#discussion_r1835191601 ## core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala: ## @@ -824,4 +824,49 @@ class PlaintextConsumerTest extends BaseConsumerTest { assertT

Re: [PR] KAFKA-16985: Ensure consumer attempts to send leave request on close even if interrupted [kafka]

2024-11-08 Thread via GitHub
kirktrue commented on code in PR #16686: URL: https://github.com/apache/kafka/pull/16686#discussion_r1835191165 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java: ## @@ -1875,7 +1907,9 @@ private void completeUnsubscribeApplication

Re: [PR] KAFKA-16985: Ensure consumer attempts to send leave request on close even if interrupted [kafka]

2024-11-08 Thread via GitHub
kirktrue commented on code in PR #16686: URL: https://github.com/apache/kafka/pull/16686#discussion_r1835191016 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractMembershipManager.java: ## @@ -1129,6 +1168,12 @@ private CompletableFuture assignPartitio

Re: [PR] KAFKA-16985: Ensure consumer attempts to send leave request on close even if interrupted [kafka]

2024-11-08 Thread via GitHub
kirktrue commented on code in PR #16686: URL: https://github.com/apache/kafka/pull/16686#discussion_r1835190373 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java: ## @@ -394,6 +398,15 @@ private void process(@SuppressWarni

Re: [PR] KAFKA-16985: Ensure consumer attempts to send leave request on close even if interrupted [kafka]

2024-11-08 Thread via GitHub
kirktrue commented on code in PR #16686: URL: https://github.com/apache/kafka/pull/16686#discussion_r1835190462 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractMembershipManager.java: ## @@ -549,7 +576,7 @@ public CompletableFuture leaveGroup() {

Re: [PR] KAFKA-16985: Ensure consumer attempts to send leave request on close even if interrupted [kafka]

2024-11-08 Thread via GitHub
kirktrue commented on code in PR #16686: URL: https://github.com/apache/kafka/pull/16686#discussion_r1835190735 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractMembershipManager.java: ## @@ -1129,6 +1168,12 @@ private CompletableFuture assignPartitio

Re: [PR] KAFKA-17972: Default all JUnit tests to KRaft [kafka]

2024-11-08 Thread via GitHub
cmccabe commented on PR #17727: URL: https://github.com/apache/kafka/pull/17727#issuecomment-2465956095 > Out of curiosity, what is the next if we have a zk-only list? There are some things that don't need to be tested any more, because they're gone. For example, there are a bunch of

Re: [PR] KAFKA-17972: Default all JUnit tests to KRaft [kafka]

2024-11-08 Thread via GitHub
chia7712 commented on PR #17727: URL: https://github.com/apache/kafka/pull/17727#issuecomment-2465953791 Out of curiosity, what is the next if we have a zk-only list? 1. migrate the tests to Kraft if the tests are required by Kraft too 2. Remove the tests if the bugs happen in Kraft

[jira] [Updated] (KAFKA-17972) Default all JUnit tests to KRaft

2024-11-08 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-17972: - Summary: Default all JUnit tests to KRaft (was: Annotate all tests that still require ZK) > De

[PR] KAFKA-17972: Default all JUnit tests to KRaft [kafka]

2024-11-08 Thread via GitHub
cmccabe opened a new pull request, #17727: URL: https://github.com/apache/kafka/pull/17727 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

[jira] [Created] (KAFKA-17972) Annotate all tests that still require ZK

2024-11-08 Thread Colin McCabe (Jira)
Colin McCabe created KAFKA-17972: Summary: Annotate all tests that still require ZK Key: KAFKA-17972 URL: https://issues.apache.org/jira/browse/KAFKA-17972 Project: Kafka Issue Type: Sub-task

Re: [PR] MINOR: Use JDK 11 in Vagrant after dropping JDK 8 [kafka]

2024-11-08 Thread via GitHub
chia7712 commented on PR #17576: URL: https://github.com/apache/kafka/pull/17576#issuecomment-2465882269 > Hey folks, where do we stand here? Do we want to close this PR in favor of the other one or something else? If the approach of upgrading the ZK client to 3.5.x is acceptable, thi

Re: [PR] KAFKA-17923: Remove old kafka version from e2e [kafka]

2024-11-08 Thread via GitHub
chia7712 commented on code in PR #17673: URL: https://github.com/apache/kafka/pull/17673#discussion_r1835137974 ## tests/docker/Dockerfile: ## @@ -77,15 +77,6 @@ RUN echo 'PermitUserEnvironment yes' >> /etc/ssh/sshd_config # Install binary test dependencies. # we use the same

Re: [PR] KAFKA-17516: Synonyms for client metrics configs [kafka]

2024-11-08 Thread via GitHub
chia7712 commented on PR #17264: URL: https://github.com/apache/kafka/pull/17264#issuecomment-2465885471 @AndrewJSchofield could you please fix the conflicts? I will take a look later -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] KAFKA-17053: Restructure build.gradle to configure publishing last [kafka]

2024-11-08 Thread via GitHub
chia7712 commented on PR #16950: URL: https://github.com/apache/kafka/pull/16950#issuecomment-2465884393 @KTKTK-HZ could you please fix the conflicts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] KAFKA-17925: Convert Kafka Client integration tests to use KRaft [kafka]

2024-11-08 Thread via GitHub
chia7712 commented on code in PR #17670: URL: https://github.com/apache/kafka/pull/17670#discussion_r1835100820 ## core/src/test/scala/integration/kafka/server/QuorumTestHarness.scala: ## @@ -204,10 +205,19 @@ abstract class QuorumTestHarness extends Logging { TestInfoUtils

[jira] [Resolved] (KAFKA-12953) Bump Zookeeper version to 3.6.3

2024-11-08 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-12953. Resolution: Won't Fix zk will be removed in kafka 4.x > Bump Zookeeper version to 3.6.3 >

Re: [PR] KAFKA-17510: Exception handling and purgatory completion on initialization delay [kafka]

2024-11-08 Thread via GitHub
apoorvmittal10 commented on PR #17709: URL: https://github.com/apache/kafka/pull/17709#issuecomment-2465848648 @junrao Thanks for review. I have addressed the comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] KAFKA-17510: Exception handling and purgatory completion on initialization delay [kafka]

2024-11-08 Thread via GitHub
apoorvmittal10 commented on code in PR #17709: URL: https://github.com/apache/kafka/pull/17709#discussion_r1835117129 ## core/src/main/java/kafka/server/share/DelayedShareFetch.java: ## @@ -198,7 +198,7 @@ Map acquirablePartitions() { Map topicPartitionData = new Link

Re: [PR] KAFKA-17510: Exception handling and purgatory completion on initialization delay [kafka]

2024-11-08 Thread via GitHub
apoorvmittal10 commented on code in PR #17709: URL: https://github.com/apache/kafka/pull/17709#discussion_r1835116189 ## core/src/test/scala/unit/kafka/server/ShareFetchAcknowledgeRequestTest.scala: ## @@ -247,13 +248,26 @@ class ShareFetchAcknowledgeRequestTest(cluster: Cluste

Re: [PR] KAFKA-17510: Exception handling and purgatory completion on initialization delay [kafka]

2024-11-08 Thread via GitHub
apoorvmittal10 commented on code in PR #17709: URL: https://github.com/apache/kafka/pull/17709#discussion_r1835115226 ## share/src/main/java/org/apache/kafka/server/share/fetch/ShareFetch.java: ## @@ -0,0 +1,183 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[jira] [Assigned] (KAFKA-17960) PlaintextAdminIntegrationTest.testConsumerGroups fails with CONSUMER group protocol

2024-11-08 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-17960: -- Assignee: Lin Siyuan (was: Chia-Ping Tsai) > PlaintextAdminIntegrationTest.testConsu

[jira] [Assigned] (KAFKA-17960) PlaintextAdminIntegrationTest.testConsumerGroups fails with CONSUMER group protocol

2024-11-08 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-17960: -- Assignee: Chia-Ping Tsai > PlaintextAdminIntegrationTest.testConsumerGroups fails wit

Re: [PR] KAFKA-17837: Rewrite DeleteTopicTest [kafka]

2024-11-08 Thread via GitHub
chia7712 commented on code in PR #17579: URL: https://github.com/apache/kafka/pull/17579#discussion_r1835089796 ## test-common/src/main/java/org/apache/kafka/common/test/TestUtils.java: ## @@ -125,4 +148,131 @@ static void retryOnExceptionWithTimeout(final Runnable runnable) th

Re: [PR] KAFKA-17696 New consumer background operations unaware of metadata errors [kafka]

2024-11-08 Thread via GitHub
lianetm commented on code in PR #17440: URL: https://github.com/apache/kafka/pull/17440#discussion_r1831724350 ## clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java: ## @@ -111,7 +111,7 @@ public class ConsumerConfig extends AbstractConfig { * grou

Re: [PR] KAFKA-17635: Only purge committed offsets [kafka]

2024-11-08 Thread via GitHub
bbejeck commented on PR #17716: URL: https://github.com/apache/kafka/pull/17716#issuecomment-2465803698 ping @mjsax for review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[jira] [Commented] (KAFKA-17518) AsyncKafkaConsumer cannot reliably leave group when closed with small timeout

2024-11-08 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896799#comment-17896799 ] Lianet Magrans commented on KAFKA-17518: [~kirktrue] I think we can mark this as

[PR] MINOR: log fix in SnapshottableCoordinator [kafka]

2024-11-08 Thread via GitHub
jeffkbkim opened a new pull request, #17726: URL: https://github.com/apache/kafka/pull/17726 Example ``` ... of __consumer_offsets-27must be less than or equal to ... ``` ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ]

[PR] KAFKA-17767 Automatically quarantine new tests [5/n] [kafka]

2024-11-08 Thread via GitHub
mumrah opened a new pull request, #17725: URL: https://github.com/apache/kafka/pull/17725 WIP -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-u

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

2024-11-08 Thread via GitHub
CalvinConfluent commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1834910462 ## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ## @@ -85,7 +105,7 @@ class AddPartitionsToTxnManager( private val verificationFailureRa

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

2024-11-08 Thread via GitHub
CalvinConfluent commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1834905815 ## clients/src/main/java/org/apache/kafka/common/requests/TxnOffsetCommitRequest.java: ## @@ -70,21 +72,35 @@ public Builder(final String transactionalId,

[jira] [Created] (KAFKA-17971) Kafka consumer performance has been reduced drastically when added RTT of 50ms to Kafka cluster

2024-11-08 Thread Pratheesh M (Jira)
Pratheesh M created KAFKA-17971: --- Summary: Kafka consumer performance has been reduced drastically when added RTT of 50ms to Kafka cluster Key: KAFKA-17971 URL: https://issues.apache.org/jira/browse/KAFKA-17971

Re: [PR] KAFKA-17510: Exception handling and purgatory completion on initialization delay [kafka]

2024-11-08 Thread via GitHub
junrao commented on code in PR #17709: URL: https://github.com/apache/kafka/pull/17709#discussion_r1834861348 ## share/src/main/java/org/apache/kafka/server/share/fetch/ShareFetch.java: ## @@ -0,0 +1,183 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mo

[jira] [Commented] (KAFKA-17779) Fix flaky RemoteLogManagerTest#testFetchOffsetByTimestampWithTieredStorageDoesNotFetchIndexWhenExistsLocally

2024-11-08 Thread Will Perlichek (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896767#comment-17896767 ] Will Perlichek commented on KAFKA-17779: Thanks for letting me take it over, Min

[PR] KAFKA-17779: Refactor Flaky RLM Test [kafka]

2024-11-08 Thread via GitHub
wperlichek opened a new pull request, #17724: URL: https://github.com/apache/kafka/pull/17724 This test appears to be flaky because we mutated and reused the mocked log segments. Instead of using `thenReturn()` and changing return value of an existing mock, or mutating the log segments wit

[jira] [Assigned] (KAFKA-17278) Figure out and fix why the RPC version tests in KafkaRaftClientTest didn't catch a bug in the Fetch schema

2024-11-08 Thread Kevin Wu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Wu reassigned KAFKA-17278: Assignee: Kevin Wu > Figure out and fix why the RPC version tests in KafkaRaftClientTest didn't

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

2024-11-08 Thread via GitHub
CalvinConfluent commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1834852558 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java: ## @@ -904,16 +904,22 @@ private void sendProduceRequest(long now, int destin

Re: [PR] [Draft] KAFKA-10532: close clean for EOS when it's RUNNING standby or RESTORING active [kafka]

2024-11-08 Thread via GitHub
mjsax commented on PR #13097: URL: https://github.com/apache/kafka/pull/13097#issuecomment-2465424191 Closing this PR as slate. The Jira ticket was reassigned to @eduwercamacaro who is picking up this work. -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] [Draft] KAFKA-10532: close clean for EOS when it's RUNNING standby or RESTORING active [kafka]

2024-11-08 Thread via GitHub
mjsax closed pull request #13097: [Draft] KAFKA-10532: close clean for EOS when it's RUNNING standby or RESTORING active URL: https://github.com/apache/kafka/pull/13097 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] MINOR: Use JDK 11 in Vagrant after dropping JDK 8 [kafka]

2024-11-08 Thread via GitHub
jolshan commented on PR #17576: URL: https://github.com/apache/kafka/pull/17576#issuecomment-2465407957 Hey folks, where do we stand here? Do we want to close this PR in favor of the other one or something else? -- This is an automated message from the Apache Git Service. To respond to th

[jira] [Commented] (KAFKA-10532) Do not wipe state store under EOS when closing-dirty a RESTORING active or RUNNING standby task

2024-11-08 Thread Colt McNealy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896726#comment-17896726 ] Colt McNealy commented on KAFKA-10532: -- Appears that [~lqxshay] is no longer workin

[jira] [Assigned] (KAFKA-10532) Do not wipe state store under EOS when closing-dirty a RESTORING active or RUNNING standby task

2024-11-08 Thread Colt McNealy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colt McNealy reassigned KAFKA-10532: Assignee: Eduwer Camacaro (was: Shay Lin) > Do not wipe state store under EOS when closi

Re: [PR] KAFKA-17923: Remove old kafka version from e2e [kafka]

2024-11-08 Thread via GitHub
chia7712 commented on code in PR #17673: URL: https://github.com/apache/kafka/pull/17673#discussion_r1834649947 ## tests/kafkatest/sanity_checks/test_verifiable_producer.py: ## @@ -91,10 +87,7 @@ def test_simple_run(self, producer_version, acks=None, enable_idempotence=False,

Re: [PR] KAFKA-17885: Enable clients to rebootstrap based on timeout or error code (KIP-1102) [kafka]

2024-11-08 Thread via GitHub
apoorvmittal10 commented on code in PR #17720: URL: https://github.com/apache/kafka/pull/17720#discussion_r1834643738 ## clients/src/main/java/org/apache/kafka/clients/admin/internals/AdminMetadataManager.java: ## @@ -289,17 +304,24 @@ public void update(Cluster cluster, long no

Re: [PR] KAFKA-17922: add helper to ClusterInstance to create client component [kafka]

2024-11-08 Thread via GitHub
chia7712 commented on code in PR #17666: URL: https://github.com/apache/kafka/pull/17666#discussion_r1834636306 ## test-common/test-common-api/src/main/java/org/apache/kafka/common/test/api/ClusterInstance.java: ## @@ -147,10 +155,44 @@ default T getUnderlying(Class asClass) {

Re: [PR] MINOR: Cleanup GroupCoordinatorRecordHelpers [kafka]

2024-11-08 Thread via GitHub
chia7712 merged PR #17718: URL: https://github.com/apache/kafka/pull/17718 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-16985: Ensure consumer attempts to send leave request on close even if interrupted [kafka]

2024-11-08 Thread via GitHub
lianetm commented on code in PR #16686: URL: https://github.com/apache/kafka/pull/16686#discussion_r1834474446 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java: ## @@ -394,6 +398,15 @@ private void process(@SuppressWarnin

[PR] KAFKA-17969: Fix StorageToolTest for 3.9 [kafka]

2024-11-08 Thread via GitHub
Yunyung opened a new pull request, #17723: URL: https://github.com/apache/kafka/pull/17723 Fix StorageToolTest#testFormatWithReleaseVersionAsFeature and StorageToolTest#testFormatWithInvalidFeature for 3.9 The command passes on my end after the fix. `./gradlew core:test --tests Sto

Re: [PR] KIP-1073: Return fenced brokers in DescribeCluster response [kafka]

2024-11-08 Thread via GitHub
tinaselenge commented on PR #17524: URL: https://github.com/apache/kafka/pull/17524#issuecomment-2465094663 thanks a lot @fvaleri! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[jira] [Commented] (KAFKA-17943) Error handling when calling replicaManager.getPartitionOrException

2024-11-08 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896711#comment-17896711 ] Apoorv Mittal commented on KAFKA-17943: --- Corrected as part of PR: https://github.c

Re: [PR] KAFKA-16985: Ensure consumer attempts to send leave request on close even if interrupted [kafka]

2024-11-08 Thread via GitHub
lianetm commented on code in PR #16686: URL: https://github.com/apache/kafka/pull/16686#discussion_r1834529057 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractMembershipManager.java: ## @@ -549,7 +576,7 @@ public CompletableFuture leaveGroup() {

[jira] [Resolved] (KAFKA-17926) Improve the documentation explaining why max.in.flight.requests.per.connection should not exceed 5.

2024-11-08 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17926. Fix Version/s: 4.0.0 Resolution: Fixed > Improve the documentation explaining why

Re: [PR] KAFKA-17970: Moving some share purgatory classes from core to share module [kafka]

2024-11-08 Thread via GitHub
apoorvmittal10 commented on PR #17722: URL: https://github.com/apache/kafka/pull/17722#issuecomment-2465070920 @mimaison @junrao Can you please review the PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[PR] KAFKA-17970: Moving some share purgatory classes from core to share module [kafka]

2024-11-08 Thread via GitHub
apoorvmittal10 opened a new pull request, #17722: URL: https://github.com/apache/kafka/pull/17722 As purgatory code has been moved to server-common (https://github.com/apache/kafka/pull/17636) hence moving some of the classes from `core` to `share` module. ### Committer Checklist (ex

Re: [PR] KAFKA-17926: Improve the documentation explaining why max.in.flight.requests.per.connection should not exceed 5 [kafka]

2024-11-08 Thread via GitHub
chia7712 merged PR #17719: URL: https://github.com/apache/kafka/pull/17719 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Created] (KAFKA-17970) Move some purgatory classes from core to share

2024-11-08 Thread Apoorv Mittal (Jira)
Apoorv Mittal created KAFKA-17970: - Summary: Move some purgatory classes from core to share Key: KAFKA-17970 URL: https://issues.apache.org/jira/browse/KAFKA-17970 Project: Kafka Issue Type:

[jira] [Commented] (KAFKA-17959) Avoid Reverse DNS Lookup for IP-Based SSL Authentication in Kraft Mode

2024-11-08 Thread Arushi Helms (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896705#comment-17896705 ] Arushi Helms commented on KAFKA-17959: -- Hi [~soarez] [~jlprat]  Can you provide you

Re: [PR] KAFKA-17510: Exception handling and purgatory completion on initialization delay [kafka]

2024-11-08 Thread via GitHub
apoorvmittal10 commented on code in PR #17709: URL: https://github.com/apache/kafka/pull/17709#discussion_r1834568839 ## core/src/main/java/kafka/server/share/DelayedShareFetch.java: ## @@ -198,7 +198,7 @@ Map acquirablePartitions() { Map topicPartitionData = new Link

[jira] [Created] (KAFKA-17969) Fix StorageToolTest for 3.9

2024-11-08 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-17969: -- Summary: Fix StorageToolTest for 3.9 Key: KAFKA-17969 URL: https://issues.apache.org/jira/browse/KAFKA-17969 Project: Kafka Issue Type: Bug R

  1   2   >