Re: [PR] KAFKA-17593; [5/N] Include resolved regular expressions into target assignment computation [kafka]

2024-11-12 Thread via GitHub
dajac commented on code in PR #17750: URL: https://github.com/apache/kafka/pull/17750#discussion_r1839658824 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/UnionSet.java: ## @@ -0,0 +1,212 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[jira] [Commented] (KAFKA-17232) MirrorCheckpointConnector does not generate task configs if initial consumer group load times out

2024-11-12 Thread Asker (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17897827#comment-17897827 ] Asker commented on KAFKA-17232: --- [~frankvicky] [~gharris1727] Hello, I believe we're exper

Re: [PR] KAFKA-17053: Restructure build.gradle to configure publishing last [kafka]

2024-11-12 Thread via GitHub
KTKTK-HZ closed pull request #16950: KAFKA-17053: Restructure build.gradle to configure publishing last URL: https://github.com/apache/kafka/pull/16950 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] KAFKA-17948: Potential issue during tryComplete and onComplete simultaneous calls to access global variables [kafka]

2024-11-12 Thread via GitHub
adixitconfluent commented on code in PR #17739: URL: https://github.com/apache/kafka/pull/17739#discussion_r1839527959 ## core/src/main/java/kafka/server/share/DelayedShareFetch.java: ## @@ -90,39 +90,50 @@ public void onExpiration() { */ @Override public void on

[jira] [Assigned] (KAFKA-17998) Fix flaky OffloadAndTxnConsumeFromLeaderTest

2024-11-12 Thread Kamal Chandraprakash (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamal Chandraprakash reassigned KAFKA-17998: Assignee: Kamal Chandraprakash > Fix flaky OffloadAndTxnConsumeFromLeader

[PR] KAFKA-18004: Use 3.8 to run zk service for e2e [kafka]

2024-11-12 Thread via GitHub
FrankYang0529 opened a new pull request, #17790: URL: https://github.com/apache/kafka/pull/17790 We plan to remove all ZooKeeper-related code in version 4.0. However, some old brokers in the end-to-end tests still require ZooKeeper service, so we need to run the ZooKeeper service using the

[jira] [Commented] (KAFKA-18004) Use 3.8 to run zk service for e2e

2024-11-12 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17897811#comment-17897811 ] Chia-Ping Tsai commented on KAFKA-18004: [~yangpoan] please use https://github.c

[jira] [Assigned] (KAFKA-18004) Use 3.8 to run zk service for e2e

2024-11-12 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-18004: -- Assignee: PoAn Yang (was: Chia-Ping Tsai) > Use 3.8 to run zk service for e2e >

[jira] [Commented] (KAFKA-18004) Use 3.8 to run zk service for e2e

2024-11-12 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17897810#comment-17897810 ] PoAn Yang commented on KAFKA-18004: --- Hi [~chia7712], if you're not working on this, ma

Re: [PR] KAFKA-17987: Remove assorted ZK-related files [kafka]

2024-11-12 Thread via GitHub
chia7712 commented on code in PR #17768: URL: https://github.com/apache/kafka/pull/17768#discussion_r1839392461 ## bin/zookeeper-server-start.sh: ## @@ -1,44 +0,0 @@ -#!/bin/bash -# Licensed to the Apache Software Foundation (ASF) under one or more -# contributor license agreeme

[jira] [Updated] (KAFKA-18004) Use 3.8 to run zk service for e2e

2024-11-12 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-18004: --- Summary: Use 3.8 to run zk service for e2e (was: Use 3.8 to run zk service) > Use 3.8 to ru

[jira] [Created] (KAFKA-18004) Use 3.8 to run zk service

2024-11-12 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-18004: -- Summary: Use 3.8 to run zk service Key: KAFKA-18004 URL: https://issues.apache.org/jira/browse/KAFKA-18004 Project: Kafka Issue Type: Sub-task

Re: [PR] KAFKA-17904: Flaky testMultiConsumerSessionTimeoutOnClose [kafka]

2024-11-12 Thread via GitHub
xijiu commented on PR #17789: URL: https://github.com/apache/kafka/pull/17789#issuecomment-2472363186 @lianetm @chia7712 PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[PR] KAFKA-17904: Flaky testMultiConsumerSessionTimeoutOnClose [kafka]

2024-11-12 Thread via GitHub
xijiu opened a new pull request, #17789: URL: https://github.com/apache/kafka/pull/17789 First of all, the reason for the failure of this test is due to TIMEOUT, the method `AbstractConsumerTest#validateGroupAssignment` timeout after waiting for 10 seconds. And it reproduced on my computer.

Re: [PR] KAFKA-15737: KRaft Support in ConsumerBounceTest [kafka]

2024-11-12 Thread via GitHub
frankvicky commented on PR #17770: URL: https://github.com/apache/kafka/pull/17770#issuecomment-2472293182 I have looped `ConsumerBounceTest` on my local machine,and it looks good except for `testConsumptionWithBrokerFailures`, where the interval between two `poll` calls may exceed `max.pol

[jira] [Commented] (KAFKA-18003) add test to make sure `Admin#deleteRecords` can handle the corrupted records

2024-11-12 Thread Kuan Po Tseng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17897804#comment-17897804 ] Kuan Po Tseng commented on KAFKA-18003: --- Hi [~chia7712] , may I take over this iss

[jira] [Created] (KAFKA-18003) add test to make sure `Admin#deleteRecords` can handle the corrupted records

2024-11-12 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-18003: -- Summary: add test to make sure `Admin#deleteRecords` can handle the corrupted records Key: KAFKA-18003 URL: https://issues.apache.org/jira/browse/KAFKA-18003 Proj

[jira] [Assigned] (KAFKA-18003) add test to make sure `Admin#deleteRecords` can handle the corrupted records

2024-11-12 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-18003: -- Assignee: Kuan Po Tseng (was: Chia-Ping Tsai) > add test to make sure `Admin#deleteR

[jira] [Commented] (KAFKA-9613) CorruptRecordException: Found record size 0 smaller than minimum record overhead

2024-11-12 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17897803#comment-17897803 ] Chia-Ping Tsai commented on KAFKA-9613: --- {quote} I did a test on this hardware issu

Re: [PR] KAFKA-17978: Fix invalid topology on Task assignment [kafka]

2024-11-12 Thread via GitHub
chia7712 commented on PR #17778: URL: https://github.com/apache/kafka/pull/17778#issuecomment-2472238431 LGTM > Did we trigger a system test run to verify that the PR fixes the issue? `streams_upgrade_test.py` pass on my local now. I will run e2e for all streams later -- Thi

Re: [PR] MINOR Fix a few test names [kafka]

2024-11-12 Thread via GitHub
mumrah commented on PR #17788: URL: https://github.com/apache/kafka/pull/17788#issuecomment-2472245598 In the test-catalog, we have some errors such as: ``` org.apache.kafka.streams.test.MockProcessorContextStateStoreTest: - builder ``` https://github.com/apache/kafka/blob

[jira] [Commented] (KAFKA-17966) Controller replacement does not support scaling up before scaling down

2024-11-12 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17897799#comment-17897799 ] Luke Chen commented on KAFKA-17966: --- [~jsancio] [~cmccabe] , any thought about it? >

[PR] MINOR Fix a few test names [kafka]

2024-11-12 Thread via GitHub
mumrah opened a new pull request, #17788: URL: https://github.com/apache/kafka/pull/17788 Since we parse the JUnit XML to discover test names as `ClassName#MethodName` we need to avoid making custom test display names. -- This is an automated message from the Apache Git Service. To respon

Re: [PR] KAFKA-17593; [5/N] Include resolved regular expressions into target assignment computation [kafka]

2024-11-12 Thread via GitHub
dajac commented on code in PR #17750: URL: https://github.com/apache/kafka/pull/17750#discussion_r1838780496 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/UnionSet.java: ## @@ -0,0 +1,212 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] MINOR: Update the list of collaborators based on the number of commit… [kafka]

2024-11-12 Thread via GitHub
chia7712 commented on PR #17787: URL: https://github.com/apache/kafka/pull/17787#issuecomment-2472177195 I’ll hold off on merging until we reach a consensus. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[PR] MINOR: Update the list of collaborators based on the number of commit… [kafka]

2024-11-12 Thread via GitHub
chia7712 opened a new pull request, #17787: URL: https://github.com/apache/kafka/pull/17787 as title. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (inclu

[jira] [Resolved] (KAFKA-16589) Consider removing `ClusterInstance#createAdminClient` since callers are not sure whether they need to call close

2024-11-12 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-16589. Resolution: Won't Fix KAFKA-17922 refactor all helpers so we don't need to address this no

Re: [PR] KAFKA-16589: Consider removing `ClusterInstance#createAdminClient` since callers are not sure whether they need to call close [kafka]

2024-11-12 Thread via GitHub
chia7712 closed pull request #15815: KAFKA-16589: Consider removing `ClusterInstance#createAdminClient` since callers are not sure whether they need to call close URL: https://github.com/apache/kafka/pull/15815 -- This is an automated message from the Apache Git Service. To respond to the me

[jira] [Resolved] (KAFKA-17922) add helper to ClusterInstance to create client component

2024-11-12 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17922. Fix Version/s: 4.0.0 Resolution: Fixed > add helper to ClusterInstance to create cl

Re: [PR] KAFKA-16589: Consider removing `ClusterInstance#createAdminClient` since callers are not sure whether they need to call close [kafka]

2024-11-12 Thread via GitHub
chia7712 commented on PR #15815: URL: https://github.com/apache/kafka/pull/15815#issuecomment-2472136306 close due to #17666 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] KAFKA-17922: add helper to ClusterInstance to create client component [kafka]

2024-11-12 Thread via GitHub
chia7712 merged PR #17666: URL: https://github.com/apache/kafka/pull/17666 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Updated] (KAFKA-17978) StreamsUpgradeTest#test_rolling_upgrade_with_2_bounces system tests fail

2024-11-12 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-17978: --- Fix Version/s: 4.0.0 > StreamsUpgradeTest#test_rolling_upgrade_with_2_bounces system tests f

[jira] [Commented] (KAFKA-17978) StreamsUpgradeTest#test_rolling_upgrade_with_2_bounces system tests fail

2024-11-12 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17897789#comment-17897789 ] PoAn Yang commented on KAFKA-17978: --- Latest result on my laptop: {noformat} > TC_PATH

[jira] [Resolved] (KAFKA-17978) StreamsUpgradeTest#test_rolling_upgrade_with_2_bounces system tests fail

2024-11-12 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang resolved KAFKA-17978. --- Resolution: Fixed > StreamsUpgradeTest#test_rolling_upgrade_with_2_bounces system tests fail > -

[jira] [Assigned] (KAFKA-17978) StreamsUpgradeTest#test_rolling_upgrade_with_2_bounces system tests fail

2024-11-12 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang reassigned KAFKA-17978: - Assignee: Nicholas Telford (was: PoAn Yang) > StreamsUpgradeTest#test_rolling_upgrade_with_2_b

[jira] [Commented] (KAFKA-17978) StreamsUpgradeTest#test_rolling_upgrade_with_2_bounces system tests fail

2024-11-12 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17897788#comment-17897788 ] PoAn Yang commented on KAFKA-17978: --- Yes, all test cases can pass now. Close the ticke

Re: [PR] KAFKA-17954: Error getting oldest-iterator-open-since-ms from JMX [kafka]

2024-11-12 Thread via GitHub
mjsax commented on code in PR #17713: URL: https://github.com/apache/kafka/pull/17713#discussion_r1839152414 ## streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java: ## @@ -154,7 +155,13 @@ private void registerMetrics() { StateStoreM

Re: [PR] KAFKA-17584: Fix incorrect synonym handling for dynamic log configurations [kafka]

2024-11-12 Thread via GitHub
mjsax commented on PR #17696: URL: https://github.com/apache/kafka/pull/17696#issuecomment-2472096178 @clolov @cmccabe @showuon -- Can we make progress on this cherry-pick? It's currently blocking me from creating the first RC. -- This is an automated message from the Apache Git Service.

Re: [PR] MINOR: Use JDK 11 in Vagrant after dropping JDK 8 [kafka]

2024-11-12 Thread via GitHub
m1a2st commented on PR #17576: URL: https://github.com/apache/kafka/pull/17576#issuecomment-2472042211 There are some typo in there, we update the zookeeper version is 3.5.7, so the table which is the env used to running Kafka in E2E will be: version | support | zk client version | zk

Re: [PR] KAFKA-17988: Fix flaky ReconfigurableQuorumIntegrationTest.testRemoveAndAddSameController [kafka]

2024-11-12 Thread via GitHub
mumrah commented on PR #17782: URL: https://github.com/apache/kafka/pull/17782#issuecomment-2472026002 Thanks for the quick fix @kevin-wu24! You might need to update with trunk since I merged #17779 -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] MINOR Quarantine some flaky tests [kafka]

2024-11-12 Thread via GitHub
mumrah merged PR #17779: URL: https://github.com/apache/kafka/pull/17779 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

Re: [PR] KAFKA-17972: Default all JUnit tests to KRaft [kafka]

2024-11-12 Thread via GitHub
cmccabe commented on PR #17727: URL: https://github.com/apache/kafka/pull/17727#issuecomment-2471996386 Convert `GssapiAuthenticationTest` : https://github.com/apache/kafka/pull/17786/files -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Resolved] (KAFKA-17681) Fix unstable consumer_test.py#test_fencing_static_consumer

2024-11-12 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True resolved KAFKA-17681. --- Resolution: Cannot Reproduce > Fix unstable consumer_test.py#test_fencing_static_consumer >

[jira] [Reopened] (KAFKA-16949) System test test_dynamic_logging in connect_distributed_test is failing

2024-11-12 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reopened KAFKA-16949: --- > System test test_dynamic_logging in connect_distributed_test is failing >

[jira] [Resolved] (KAFKA-17962) test_pause_and_resume_sink fails with "Failed to consume messages after resuming sink connector" with CONSUMER group protocol

2024-11-12 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True resolved KAFKA-17962. --- Resolution: Cannot Reproduce > test_pause_and_resume_sink fails with "Failed to consume messages aft

[jira] [Commented] (KAFKA-16949) System test test_dynamic_logging in connect_distributed_test is failing

2024-11-12 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17897782#comment-17897782 ] Kirk True commented on KAFKA-16949: --- [~sagarrao]—unfortunately I'm seeing this again i

[PR] MINOR: convert GssapiAuthenticationTest to KRaft [kafka]

2024-11-12 Thread via GitHub
cmccabe opened a new pull request, #17786: URL: https://github.com/apache/kafka/pull/17786 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

Re: [PR] KAFKA-17991: Added timed calls for future.get in persister. [kafka]

2024-11-12 Thread via GitHub
mumrah merged PR #17772: URL: https://github.com/apache/kafka/pull/17772 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

[jira] [Created] (KAFKA-18002) Upgrade connect_distributed_test.py's test_exactly_once_source to support different group.protocol values

2024-11-12 Thread Kirk True (Jira)
Kirk True created KAFKA-18002: - Summary: Upgrade connect_distributed_test.py's test_exactly_once_source to support different group.protocol values Key: KAFKA-18002 URL: https://issues.apache.org/jira/browse/KAFKA-1800

[jira] [Commented] (KAFKA-18001) KafkaNetworkChannel missing UpdateRaftVoterRequestData logic

2024-11-12 Thread Gaurav Narula (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17897779#comment-17897779 ] Gaurav Narula commented on KAFKA-18001: --- Potentially seems like a duplicate of KAF

[PR] MINOR: remove LogDirFailureTest.testZkBrokerWithOldInterBrokerProtocolShouldHaltOnLogDirFailure [kafka]

2024-11-12 Thread via GitHub
cmccabe opened a new pull request, #17785: URL: https://github.com/apache/kafka/pull/17785 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

Re: [PR] KAFKA-17987: Remove assorted ZK-related files [kafka]

2024-11-12 Thread via GitHub
chia7712 commented on code in PR #17768: URL: https://github.com/apache/kafka/pull/17768#discussion_r1839007241 ## bin/zookeeper-server-start.sh: ## @@ -1,44 +0,0 @@ -#!/bin/bash -# Licensed to the Apache Software Foundation (ASF) under one or more -# contributor license agreeme

Re: [PR] MINOR: convert DescribeLogDirsRequestTest to KRaft [kafka]

2024-11-12 Thread via GitHub
mumrah merged PR #17746: URL: https://github.com/apache/kafka/pull/17746 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

Re: [PR] MINOR: Use JDK 11 in Vagrant after dropping JDK 8 [kafka]

2024-11-12 Thread via GitHub
chia7712 commented on PR #17576: URL: https://github.com/apache/kafka/pull/17576#issuecomment-2471861303 > I think the approach sounds fine, but wasn't sure if we typically updated ZK like this without a KIP or anything. It is also a bit odd since it will only be used in tests. But reading

Re: [PR] MINOR: convert AddPartitionsToTxnRequestServerTest to KRaft [kafka]

2024-11-12 Thread via GitHub
mumrah merged PR #17762: URL: https://github.com/apache/kafka/pull/17762 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

Re: [PR] (FIX): Support UpdateRaftVoterRequest in KafkaNetworkChannel [kafka]

2024-11-12 Thread via GitHub
ahuang98 commented on PR #17773: URL: https://github.com/apache/kafka/pull/17773#issuecomment-2471830563 Thanks @justinrlee, created https://issues.apache.org/jira/browse/KAFKA-18001 to track, can you prepend your PR title with `KAFKA-18001:`? -- This is an automated message from the Apa

[jira] [Created] (KAFKA-18001) KafkaNetworkChannel missing UpdateRaftVoterRequestData logic

2024-11-12 Thread Alyssa Huang (Jira)
Alyssa Huang created KAFKA-18001: Summary: KafkaNetworkChannel missing UpdateRaftVoterRequestData logic Key: KAFKA-18001 URL: https://issues.apache.org/jira/browse/KAFKA-18001 Project: Kafka

Re: [PR] KAFKA-17510: Exception handling and purgatory completion on initialization delay [kafka]

2024-11-12 Thread via GitHub
apoorvmittal10 commented on code in PR #17709: URL: https://github.com/apache/kafka/pull/17709#discussion_r1838952613 ## core/src/main/java/kafka/server/share/DelayedShareFetch.java: ## @@ -315,11 +325,17 @@ else if (isolationType == FetchIsolation.HIGH_WATERMARK) }

Re: [PR] KAFKA-17510: Exception handling and purgatory completion on initialization delay [kafka]

2024-11-12 Thread via GitHub
apoorvmittal10 commented on code in PR #17709: URL: https://github.com/apache/kafka/pull/17709#discussion_r1838957188 ## share/src/main/java/org/apache/kafka/server/share/fetch/ShareFetch.java: ## @@ -0,0 +1,200 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

Re: [PR] KAFKA-16985: Ensure consumer attempts to send leave request on close even if interrupted [kafka]

2024-11-12 Thread via GitHub
kirktrue commented on code in PR #16686: URL: https://github.com/apache/kafka/pull/16686#discussion_r1838922199 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractMembershipManager.java: ## @@ -523,18 +524,45 @@ public void transitionToJoining() {

Re: [PR] KAFKA-16985: Ensure consumer attempts to send leave request on close even if interrupted [kafka]

2024-11-12 Thread via GitHub
kirktrue commented on code in PR #16686: URL: https://github.com/apache/kafka/pull/16686#discussion_r1838919865 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1216,6 +1235,81 @@ public void close(Duration timeout) {

Re: [PR] KAFKA-16985: Ensure consumer attempts to send leave request on close even if interrupted [kafka]

2024-11-12 Thread via GitHub
kirktrue commented on code in PR #16686: URL: https://github.com/apache/kafka/pull/16686#discussion_r1838921182 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1216,6 +1235,81 @@ public void close(Duration timeout) {

Re: [PR] KAFKA-17510: Exception handling and purgatory completion on initialization delay [kafka]

2024-11-12 Thread via GitHub
apoorvmittal10 commented on code in PR #17709: URL: https://github.com/apache/kafka/pull/17709#discussion_r1838918361 ## share/src/main/java/org/apache/kafka/server/share/fetch/ShareFetch.java: ## @@ -0,0 +1,200 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

Re: [PR] KAFKA-16985: Ensure consumer attempts to send leave request on close even if interrupted [kafka]

2024-11-12 Thread via GitHub
kirktrue commented on code in PR #16686: URL: https://github.com/apache/kafka/pull/16686#discussion_r1838916306 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractMembershipManager.java: ## @@ -496,8 +496,9 @@ private void clearAssignment() { */

[jira] [Commented] (KAFKA-17978) StreamsUpgradeTest#test_rolling_upgrade_with_2_bounces system tests fail

2024-11-12 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17897768#comment-17897768 ] Matthias J. Sax commented on KAFKA-17978: - Seems the PR was merged. Can we close

Re: [PR] KAFKA-17978: Fix invalid topology on Task assignment [kafka]

2024-11-12 Thread via GitHub
mjsax commented on PR #17778: URL: https://github.com/apache/kafka/pull/17778#issuecomment-2471760556 Did we trigger a system test run to verify that the PR fixes the issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[PR] [No review] KAFKA-14563: additional debug info. [kafka]

2024-11-12 Thread via GitHub
CalvinConfluent opened a new pull request, #17784: URL: https://github.com/apache/kafka/pull/17784 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

Re: [PR] KAFKA-17869: Adding tests to ensure KIP-1076 doesn't interfere with consumer metrics[1/3] [kafka]

2024-11-12 Thread via GitHub
mjsax commented on code in PR #17781: URL: https://github.com/apache/kafka/pull/17781#discussion_r1838848925 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -224,6 +228,34 @@ public void cleanup() { } } +@Parameterized

Re: [PR] KAFKA-17869: Adding tests to ensure KIP-1076 doesn't interfere with consumer metrics[1/3] [kafka]

2024-11-12 Thread via GitHub
mjsax commented on code in PR #17781: URL: https://github.com/apache/kafka/pull/17781#discussion_r1838848038 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -3501,6 +3533,17 @@ private boolean requestGenerated(MockClient client, ApiKeys

[jira] [Commented] (KAFKA-12469) The topic names in the metrics do not retain their format when extracting through JMX.

2024-11-12 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17897760#comment-17897760 ] Apoorv Mittal commented on KAFKA-12469: --- [~junrao] I also looked at this patch you

[jira] [Comment Edited] (KAFKA-12469) The topic names in the metrics do not retain their format when extracting through JMX.

2024-11-12 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17897751#comment-17897751 ] Apoorv Mittal edited comment on KAFKA-12469 at 11/12/24 9:38 PM: -

[jira] [Commented] (KAFKA-17929) `awaitProcessableTasks` is not safe in the presence of spurious wakeups.

2024-11-12 Thread Ao Li (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17897759#comment-17897759 ] Ao Li commented on KAFKA-17929: --- Yes, this issue exists across all Java versions. Apologie

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

2024-11-12 Thread via GitHub
cmccabe commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1838830695 ## metadata/src/main/java/org/apache/kafka/controller/BrokersToElrs.java: ## @@ -159,4 +160,12 @@ BrokersToIsrs.PartitionsOnReplicaIterator partitionsWithBrokerInElr(i

[jira] [Commented] (KAFKA-17929) `awaitProcessableTasks` is not safe in the presence of spurious wakeups.

2024-11-12 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17897756#comment-17897756 ] Matthias J. Sax commented on KAFKA-17929: - Is this still an issue with Java 11 –

[jira] [Updated] (KAFKA-12469) The topic names in the metrics do not retain their format when extracting through JMX.

2024-11-12 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal updated KAFKA-12469: -- Attachment: Screenshot 2024-11-12 at 21.35.59-1.png > The topic names in the metrics do not re

[jira] [Updated] (KAFKA-12469) The topic names in the metrics do not retain their format when extracting through JMX.

2024-11-12 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal updated KAFKA-12469: -- Attachment: (was: Screenshot 2024-11-12 at 21.35.59.png) > The topic names in the metrics

[jira] [Updated] (KAFKA-12469) The topic names in the metrics do not retain their format when extracting through JMX.

2024-11-12 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal updated KAFKA-12469: -- Attachment: (was: Screenshot 2024-11-12 at 21.35.59-2.png) > The topic names in the metric

[jira] [Updated] (KAFKA-12469) The topic names in the metrics do not retain their format when extracting through JMX.

2024-11-12 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal updated KAFKA-12469: -- Attachment: (was: Screenshot 2024-11-12 at 21.35.59-1.png) > The topic names in the metric

[jira] [Comment Edited] (KAFKA-12469) The topic names in the metrics do not retain their format when extracting through JMX.

2024-11-12 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17897751#comment-17897751 ] Apoorv Mittal edited comment on KAFKA-12469 at 11/12/24 9:38 PM: -

[jira] [Commented] (KAFKA-12469) The topic names in the metrics do not retain their format when extracting through JMX.

2024-11-12 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17897751#comment-17897751 ] Apoorv Mittal commented on KAFKA-12469: --- Also looking at the Mbeans I do not see `

[jira] [Updated] (KAFKA-12469) The topic names in the metrics do not retain their format when extracting through JMX.

2024-11-12 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal updated KAFKA-12469: -- Attachment: Screenshot 2024-11-12 at 21.35.59.png > The topic names in the metrics do not reta

[jira] [Commented] (KAFKA-12469) The topic names in the metrics do not retain their format when extracting through JMX.

2024-11-12 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17897750#comment-17897750 ] Apoorv Mittal commented on KAFKA-12469: --- [~junrao] I verified kafka-producer, kafk

[jira] [Updated] (KAFKA-12469) The topic names in the metrics do not retain their format when extracting through JMX.

2024-11-12 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal updated KAFKA-12469: -- Attachment: image-2024-11-12-21-32-55-180.png > The topic names in the metrics do not retain t

Re: [PR] KAFKA-17948: Potential issue during tryComplete and onComplete simultaneous calls to access global variables [kafka]

2024-11-12 Thread via GitHub
apoorvmittal10 commented on code in PR #17739: URL: https://github.com/apache/kafka/pull/17739#discussion_r1836502635 ## core/src/main/java/kafka/server/share/DelayedShareFetch.java: ## @@ -58,8 +58,8 @@ public class DelayedShareFetch extends DelayedOperation { private fina

[jira] [Comment Edited] (KAFKA-17278) Figure out and fix why the RPC version tests in KafkaRaftClientTest didn't catch a bug in the Fetch schema

2024-11-12 Thread Kevin Wu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17897706#comment-17897706 ] Kevin Wu edited comment on KAFKA-17278 at 11/12/24 9:13 PM:

Re: [PR] KAFKA-17593; [5/N] Include resolved regular expressions into target assignment computation [kafka]

2024-11-12 Thread via GitHub
dajac commented on code in PR #17750: URL: https://github.com/apache/kafka/pull/17750#discussion_r1838774665 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/TargetAssignmentBuilder.java: ## @@ -89,6 +92,144 @@ public Map targetAssignment() {

[PR] KAFKA-17988: Fix flaky ReconfigurableQuorumIntegrationTest.testRemoveAndAddSameController [kafka]

2024-11-12 Thread via GitHub
kevin-wu24 opened a new pull request, #17782: URL: https://github.com/apache/kafka/pull/17782 Verified change removes flakiness by running with no failures: ``` N=10; I=0; while [ $I -lt $N ] && ./gradlew core:test --tests kafka.server.ReconfigurableQuorumIntegrationTest.testRemoveAn

[jira] [Commented] (KAFKA-17988) Fix flaky ReconfigurableQuorumIntegrationTest.testRemoveAndAddSameController

2024-11-12 Thread Kevin Wu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17897745#comment-17897745 ] Kevin Wu commented on KAFKA-17988: -- Submitted a PR that fixes this. > Fix flaky Reconf

Re: [PR] KAFKA-17635: Only purge committed offsets [kafka]

2024-11-12 Thread via GitHub
bbejeck merged PR #17716: URL: https://github.com/apache/kafka/pull/17716 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-17635: Only purge committed offsets [kafka]

2024-11-12 Thread via GitHub
bbejeck commented on PR #17716: URL: https://github.com/apache/kafka/pull/17716#issuecomment-2471571031 One test failure (`org.apache.kafka.connect.mirror.integration.DedicatedMirrorIntegrationTest.testMultiNodeCluster()`) is unrelated -- This is an automated message from the Apache Git

Re: [PR] KAFKA-17948: Potential issue during tryComplete and onComplete simultaneous calls to access global variables [kafka]

2024-11-12 Thread via GitHub
adixitconfluent commented on code in PR #17739: URL: https://github.com/apache/kafka/pull/17739#discussion_r1838763754 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -1602,8 +1602,6 @@ protected void updateFetchOffsetMetadata(Optional fetchOffset prote

Re: [PR] MINOR: convert DescribeLogDirsRequestTest to KRaft [kafka]

2024-11-12 Thread via GitHub
cmccabe commented on PR #17746: URL: https://github.com/apache/kafka/pull/17746#issuecomment-2471509471 Sorry, forgot to push something. It should be sending to a broker, not a controller, hence controllerSocketServer -> anySocketServer. Should be fixed now. -- This is an automated messa

[PR] KAFKA-17869: Adding tests to ensure KIP-1076 doesn't interfere producer metrics[2/3] [kafka]

2024-11-12 Thread via GitHub
bbejeck opened a new pull request, #17783: URL: https://github.com/apache/kafka/pull/17783 Adding producer tests to ensure the KIP-1076 methods don't interfere with existing metrics *More detailed description of your change, if necessary. The PR title and PR message become

Re: [PR] KAFKA-17593; [5/N] Include resolved regular expressions into target assignment computation [kafka]

2024-11-12 Thread via GitHub
dajac commented on code in PR #17750: URL: https://github.com/apache/kafka/pull/17750#discussion_r1838698296 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -14979,6 +14980,83 @@ public void testReplayConsumerGroupRegul

Re: [PR] MINOR Quarantine some flaky tests [kafka]

2024-11-12 Thread via GitHub
kevin-wu24 commented on PR #17779: URL: https://github.com/apache/kafka/pull/17779#issuecomment-2471522963 > Report: https://ge.apache.org/scans/tests?search.names=CI%20workflow,Git%20repository&search.relativeStartTime=P28D&search.rootProjectNames=kafka&search.tags=github,trunk&search.tasks

Re: [PR] MINOR: convert ConsumerTopicCreationTest to KRaft [kafka]

2024-11-12 Thread via GitHub
cmccabe merged PR #17760: URL: https://github.com/apache/kafka/pull/17760 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-17593; [5/N] Include resolved regular expressions into target assignment computation [kafka]

2024-11-12 Thread via GitHub
jeffkbkim commented on code in PR #17750: URL: https://github.com/apache/kafka/pull/17750#discussion_r1838730791 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/TargetAssignmentBuilder.java: ## @@ -89,6 +92,144 @@ public Map targetAssignment() {

Re: [PR] KAFKA-17593; [5/N] Include resolved regular expressions into target assignment computation [kafka]

2024-11-12 Thread via GitHub
jeffkbkim commented on code in PR #17750: URL: https://github.com/apache/kafka/pull/17750#discussion_r1838728030 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/UnionSet.java: ## @@ -0,0 +1,212 @@ +/* + * Licensed to the Apache Software Foundation (A

[PR] KAFKA-17869: Adding tests to ensure KIP-1076 doesn't interfere with custom metrics[1/3] [kafka]

2024-11-12 Thread via GitHub
bbejeck opened a new pull request, #17781: URL: https://github.com/apache/kafka/pull/17781 Adding tests to ensure the KIP-1076 methods don't interfere with existing metrics in clients ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementat

[PR] MINOR: convert ProduceRequestTest to KRaft [kafka]

2024-11-12 Thread via GitHub
cmccabe opened a new pull request, #17780: URL: https://github.com/apache/kafka/pull/17780 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

  1   2   3   >