clarkwtc commented on code in PR #19016:
URL: https://github.com/apache/kafka/pull/19016#discussion_r1971104486
##
clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java:
##
@@ -173,12 +173,13 @@ public class TopicConfig {
public static final String MIN_IN_SY
rajinisivaram commented on code in PR #18989:
URL: https://github.com/apache/kafka/pull/18989#discussion_r1971087726
##
core/src/main/scala/kafka/server/BrokerServer.scala:
##
@@ -645,6 +645,7 @@ class BrokerServer(
.withGroupCoordinatorMetrics(new
GroupCoordinatorMetr
[ https://issues.apache.org/jira/browse/KAFKA-18393 ]
Hyunsang Han deleted comment on KAFKA-18393:
--
was (Author: JIRAUSER307848):
I'll take care of it!
> Remove code deprecated to implement KIP-1043
> --
chia7712 commented on code in PR #9766:
URL: https://github.com/apache/kafka/pull/9766#discussion_r1971065624
##
clients/src/main/java/org/apache/kafka/common/record/EndTransactionMarker.java:
##
@@ -95,32 +71,28 @@ public int hashCode() {
private static void ensureTransa
clarkwtc commented on code in PR #19016:
URL: https://github.com/apache/kafka/pull/19016#discussion_r1971049031
##
server-common/src/main/java/org/apache/kafka/server/config/ServerTopicConfigSynonyms.java:
##
@@ -78,6 +78,7 @@ public final class ServerTopicConfigSynonyms {
chia7712 commented on code in PR #19033:
URL: https://github.com/apache/kafka/pull/19033#discussion_r1971054065
##
docs/implementation.html:
##
@@ -103,67 +103,8 @@ 5.3.3 Old Message Format
-Prior to Kafka 0.11, messages were transferred and stored in
message sets
[
https://issues.apache.org/jira/browse/KAFKA-15796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930563#comment-17930563
]
Bartosz Kubiak commented on KAFKA-15796:
Hello, we are having very same case a
[
https://issues.apache.org/jira/browse/KAFKA-18864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930562#comment-17930562
]
Chia-Ping Tsai commented on KAFKA-18864:
{quote}You mean we have the evolving an
clarkwtc commented on code in PR #19016:
URL: https://github.com/apache/kafka/pull/19016#discussion_r1971049031
##
server-common/src/main/java/org/apache/kafka/server/config/ServerTopicConfigSynonyms.java:
##
@@ -78,6 +78,7 @@ public final class ServerTopicConfigSynonyms {
[
https://issues.apache.org/jira/browse/KAFKA-18864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-18864:
---
Attachment: 螢幕快照 2025-02-26 14-56-31.png
> remove the Evolving tag from stable public interf
[
https://issues.apache.org/jira/browse/KAFKA-18864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930559#comment-17930559
]
Ismael Juma edited comment on KAFKA-18864 at 2/26/25 6:52 AM:
[
https://issues.apache.org/jira/browse/KAFKA-18864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930559#comment-17930559
]
Ismael Juma commented on KAFKA-18864:
-
You mean we have the evolving annotation on s
[
https://issues.apache.org/jira/browse/KAFKA-18864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930558#comment-17930558
]
Chia-Ping Tsai commented on KAFKA-18864:
[~gongxuanzhang] I update the title. Pl
[
https://issues.apache.org/jira/browse/KAFKA-18864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930550#comment-17930550
]
Chia-Ping Tsai edited comment on KAFKA-18864 at 2/26/25 6:48 AM:
-
ijuma commented on code in PR #19033:
URL: https://github.com/apache/kafka/pull/19033#discussion_r1970992722
##
docs/implementation.html:
##
@@ -103,67 +103,8 @@ 5.3.3 Old Message Format
-Prior to Kafka 0.11, messages were transferred and stored in
message sets. I
[
https://issues.apache.org/jira/browse/KAFKA-18393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930554#comment-17930554
]
Hyunsang Han commented on KAFKA-18393:
--
I'll take care of it!
> Remove code deprec
[
https://issues.apache.org/jira/browse/KAFKA-18864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930553#comment-17930553
]
Ismael Juma commented on KAFKA-18864:
-
Seems reasonable to remove from all of those.
[
https://issues.apache.org/jira/browse/KAFKA-18864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930550#comment-17930550
]
Chia-Ping Tsai commented on KAFKA-18864:
I list the public APIs which are existe
chia7712 commented on code in PR #19033:
URL: https://github.com/apache/kafka/pull/19033#discussion_r1970972098
##
docs/implementation.html:
##
@@ -103,67 +103,8 @@ 5.3.3 Old Message Format
-Prior to Kafka 0.11, messages were transferred and stored in
message sets
chia7712 commented on code in PR #18989:
URL: https://github.com/apache/kafka/pull/18989#discussion_r1970955890
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -2592,6 +2607,34 @@ class KafkaApis(val requestChannel: RequestChannel,
response.groups.addAll(
[
https://issues.apache.org/jira/browse/KAFKA-3987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930539#comment-17930539
]
jeri jose commented on KAFKA-3987:
--
To align with FIPS 140-3 compliance requirements, MD
Jeri-jose opened a new pull request, #19035:
URL: https://github.com/apache/kafka/pull/19035
Replace MD5 with SHA-256 for FIPS 140-3 compliance in Log Cleaner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
ijuma commented on code in PR #19034:
URL: https://github.com/apache/kafka/pull/19034#discussion_r1970928995
##
tests/kafkatest/services/kafka/kafka.py:
##
@@ -1197,12 +1197,6 @@ def
all_nodes_configs_command_uses_bootstrap_server_scram(self):
return False
ijuma commented on code in PR #19034:
URL: https://github.com/apache/kafka/pull/19034#discussion_r1970930806
##
tests/kafkatest/services/kafka/kafka.py:
##
@@ -1362,7 +1356,7 @@ def alter_message_format(self, topic, msg_format_version,
node=None):
def kafka_acls_cmd_with_o
ijuma commented on code in PR #19034:
URL: https://github.com/apache/kafka/pull/19034#discussion_r1970929874
##
tests/kafkatest/version.py:
##
@@ -25,9 +25,9 @@ class KafkaVersion(LooseVersion):
Example:
-v10 = KafkaVersion("0.10.0")
-v9 = KafkaVersion("
ijuma commented on code in PR #19034:
URL: https://github.com/apache/kafka/pull/19034#discussion_r1970930193
##
tests/kafkatest/version.py:
##
@@ -62,9 +62,6 @@ def _cmp(self, other):
return LooseVersion._cmp(self, other)
-def acl_command_supports_bootstrap_serv
ijuma commented on code in PR #19034:
URL: https://github.com/apache/kafka/pull/19034#discussion_r1970929295
##
tests/kafkatest/services/kafka/quorum.py:
##
@@ -14,14 +14,10 @@
# limitations under the License.
# the types of metadata quorums we support
-zk = 'ZK' # ZooKeeper
ijuma commented on code in PR #19034:
URL: https://github.com/apache/kafka/pull/19034#discussion_r1970928995
##
tests/kafkatest/services/kafka/kafka.py:
##
@@ -1197,12 +1197,6 @@ def
all_nodes_configs_command_uses_bootstrap_server_scram(self):
return False
ijuma commented on code in PR #19034:
URL: https://github.com/apache/kafka/pull/19034#discussion_r1970928536
##
tests/kafkatest/sanity_checks/test_console_consumer.py:
##
@@ -40,7 +40,7 @@ def __init__(self, test_context):
@cluster(num_nodes=4)
@matrix(security_protoco
ijuma opened a new pull request, #19034:
URL: https://github.com/apache/kafka/pull/19034
Also remove references to older versions that are no longer relevant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
ijuma commented on code in PR #19016:
URL: https://github.com/apache/kafka/pull/19016#discussion_r197090
##
clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java:
##
@@ -173,12 +173,13 @@ public class TopicConfig {
public static final String MIN_IN_SYNC_
ijuma commented on code in PR #19016:
URL: https://github.com/apache/kafka/pull/19016#discussion_r1970909685
##
clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java:
##
@@ -173,12 +173,13 @@ public class TopicConfig {
public static final String MIN_IN_SYNC_
ijuma commented on code in PR #19016:
URL: https://github.com/apache/kafka/pull/19016#discussion_r1970906033
##
clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java:
##
@@ -173,12 +173,13 @@ public class TopicConfig {
public static final String MIN_IN_SYNC_
ijuma commented on code in PR #19016:
URL: https://github.com/apache/kafka/pull/19016#discussion_r1970904949
##
clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java:
##
@@ -173,12 +173,13 @@ public class TopicConfig {
public static final String MIN_IN_SYNC_
ijuma commented on code in PR #19016:
URL: https://github.com/apache/kafka/pull/19016#discussion_r1970902496
##
server-common/src/main/java/org/apache/kafka/server/config/ServerTopicConfigSynonyms.java:
##
@@ -78,6 +78,7 @@ public final class ServerTopicConfigSynonyms {
[
https://issues.apache.org/jira/browse/KAFKA-16936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930524#comment-17930524
]
TengYao Chi commented on KAFKA-16936:
-
Gentle Ping [~muralibasani]
I would like to
dao-jun commented on PR #18991:
URL: https://github.com/apache/kafka/pull/18991#issuecomment-2683822342
> Hi @dao-jun Could you please rebase the branch onto the `trunk` ? Kafka
recently applied the new CI flow; it would be better if the patch could walk
through it.
merged
--
This
ijuma opened a new pull request, #19033:
URL: https://github.com/apache/kafka/pull/19033
Link to the older version of the documentation for people who care.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
github-actions[bot] commented on PR #17908:
URL: https://github.com/apache/kafka/pull/17908#issuecomment-2683813615
This PR is being marked as stale since it has not had any activity in 90
days. If you
would like to keep this PR alive, please leave a comment asking for a
review. If the P
github-actions[bot] commented on PR #17969:
URL: https://github.com/apache/kafka/pull/17969#issuecomment-2683813640
This PR is being marked as stale since it has not had any activity in 90
days. If you
would like to keep this PR alive, please leave a comment asking for a
review. If the P
xijiu commented on PR #18299:
URL: https://github.com/apache/kafka/pull/18299#issuecomment-2683795730
@chia7712 I have added it, PTAL.
For test, I added the invalid content to `LICENSE-binary`:
https://github.com/user-attachments/assets/eb505eb8-5284-449c-b6c3-d00b19255891";
/>
[
https://issues.apache.org/jira/browse/KAFKA-18864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930520#comment-17930520
]
Ismael Juma commented on KAFKA-18864:
-
Yeah, this should not be used for stable APIs
github-actions[bot] commented on PR #18828:
URL: https://github.com/apache/kafka/pull/18828#issuecomment-2683787840
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
github-actions[bot] commented on PR #18903:
URL: https://github.com/apache/kafka/pull/18903#issuecomment-2683787805
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
github-actions[bot] commented on PR #18949:
URL: https://github.com/apache/kafka/pull/18949#issuecomment-2683787764
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
mjsax commented on PR #18988:
URL: https://github.com/apache/kafka/pull/18988#issuecomment-2683785351
Merged to `trunk` and cherry-picked to `4.0` release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
mjsax commented on code in PR #18988:
URL: https://github.com/apache/kafka/pull/18988#discussion_r1970835148
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -794,13 +794,11 @@ public class StreamsConfig extends AbstractConfig {
/** {@code upgrade
mjsax merged PR #18988:
URL: https://github.com/apache/kafka/pull/18988
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
memedadexiaobai closed pull request #19032: merge
URL: https://github.com/apache/kafka/pull/19032
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-u
memedadexiaobai opened a new pull request, #19032:
URL: https://github.com/apache/kafka/pull/19032
Delete this text and replace it with a detailed description of your change.
The
PR title and body will become the squashed commit message.
If you would like to tag individuals, add s
clarkwtc commented on code in PR #19016:
URL: https://github.com/apache/kafka/pull/19016#discussion_r1970794134
##
server-common/src/main/java/org/apache/kafka/server/config/ServerLogConfigs.java:
##
@@ -136,14 +136,16 @@ public class ServerLogConfigs {
public static final
clarkwtc commented on code in PR #19016:
URL: https://github.com/apache/kafka/pull/19016#discussion_r1970799319
##
clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java:
##
@@ -172,13 +172,15 @@ public class TopicConfig {
public static final String MIN_IN_SY
clarkwtc commented on code in PR #19016:
URL: https://github.com/apache/kafka/pull/19016#discussion_r1970794134
##
server-common/src/main/java/org/apache/kafka/server/config/ServerLogConfigs.java:
##
@@ -136,14 +136,16 @@ public class ServerLogConfigs {
public static final
Jun Rao created KAFKA-18864:
---
Summary: remove the Evolving tag from public interfaces in
org.apache.kafka.server.log.remote.storage
Key: KAFKA-18864
URL: https://issues.apache.org/jira/browse/KAFKA-18864
Pr
[
https://issues.apache.org/jira/browse/KAFKA-15146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930504#comment-17930504
]
kangning.li commented on KAFKA-15146:
-
This test has succeeded consistently over the
ableegoldman commented on code in PR #18988:
URL: https://github.com/apache/kafka/pull/18988#discussion_r1970784603
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -794,13 +794,11 @@ public class StreamsConfig extends AbstractConfig {
/** {@code
kevin-wu24 commented on code in PR #18987:
URL: https://github.com/apache/kafka/pull/18987#discussion_r1970773425
##
raft/src/main/java/org/apache/kafka/raft/VoterSet.java:
##
@@ -343,6 +343,10 @@ public ReplicaKey voterKey() {
return voterKey;
}
+
kevin-wu24 commented on code in PR #18987:
URL: https://github.com/apache/kafka/pull/18987#discussion_r1970773425
##
raft/src/main/java/org/apache/kafka/raft/VoterSet.java:
##
@@ -343,6 +343,10 @@ public ReplicaKey voterKey() {
return voterKey;
}
+
kevin-wu24 commented on code in PR #18987:
URL: https://github.com/apache/kafka/pull/18987#discussion_r1970766229
##
raft/src/test/java/org/apache/kafka/raft/RaftEventSimulationTest.java:
##
@@ -487,6 +555,12 @@ private EventScheduler
schedulerWithDefaultInvariants(Cluster clus
kevin-wu24 commented on code in PR #18987:
URL: https://github.com/apache/kafka/pull/18987#discussion_r1970773425
##
raft/src/main/java/org/apache/kafka/raft/VoterSet.java:
##
@@ -343,6 +343,10 @@ public ReplicaKey voterKey() {
return voterKey;
}
+
kevin-wu24 commented on code in PR #18987:
URL: https://github.com/apache/kafka/pull/18987#discussion_r1970766229
##
raft/src/test/java/org/apache/kafka/raft/RaftEventSimulationTest.java:
##
@@ -487,6 +555,12 @@ private EventScheduler
schedulerWithDefaultInvariants(Cluster clus
gongxuanzhang commented on PR #19019:
URL: https://github.com/apache/kafka/pull/19019#issuecomment-2683672839
@chia7712 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
[
https://issues.apache.org/jira/browse/KAFKA-18844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
PoAn Yang updated KAFKA-18844:
--
Description:
In https://github.com/apache/kafka/pull/16848, we added kraft.version to
finalized featu
[
https://issues.apache.org/jira/browse/KAFKA-18864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-18864:
--
Assignee: xuanzhang gong
> remove the Evolving tag from public interfaces in
> org.a
FrankYang0529 commented on PR #18997:
URL: https://github.com/apache/kafka/pull/18997#issuecomment-2683668617
Hi @junrao, thanks for the review. Updated title and description on Jira and
the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
kevin-wu24 commented on code in PR #18987:
URL: https://github.com/apache/kafka/pull/18987#discussion_r1970766229
##
raft/src/test/java/org/apache/kafka/raft/RaftEventSimulationTest.java:
##
@@ -487,6 +555,12 @@ private EventScheduler
schedulerWithDefaultInvariants(Cluster clus
[
https://issues.apache.org/jira/browse/KAFKA-18844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
PoAn Yang updated KAFKA-18844:
--
Summary: Stale features information in QuorumController#registerBroker
(was: Fix flaky QuorumControll
[
https://issues.apache.org/jira/browse/KAFKA-18817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930494#comment-17930494
]
Lan Ding commented on KAFKA-18817:
--
Hi [~shivsundar] , are you still working on this? M
[
https://issues.apache.org/jira/browse/KAFKA-18864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930493#comment-17930493
]
Chia-Ping Tsai commented on KAFKA-18864:
[~junrao] Is InterfaceStability.Evolvin
[
https://issues.apache.org/jira/browse/KAFKA-18864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930492#comment-17930492
]
xuanzhang gong commented on KAFKA-18864:
Hi,I will handle this issue,plz ticket
ahuang98 commented on code in PR #18987:
URL: https://github.com/apache/kafka/pull/18987#discussion_r1970745986
##
raft/src/main/java/org/apache/kafka/raft/VoterSet.java:
##
@@ -343,6 +343,10 @@ public ReplicaKey voterKey() {
return voterKey;
}
+p
ahuang98 commented on code in PR #18987:
URL: https://github.com/apache/kafka/pull/18987#discussion_r1970761435
##
raft/src/test/java/org/apache/kafka/raft/RaftEventSimulationTest.java:
##
@@ -1127,14 +1331,75 @@ private MajorityReachedHighWatermark(Cluster cluster) {
ahuang98 commented on code in PR #18987:
URL: https://github.com/apache/kafka/pull/18987#discussion_r1970761578
##
raft/src/test/java/org/apache/kafka/raft/RaftEventSimulationTest.java:
##
@@ -1127,14 +1331,75 @@ private MajorityReachedHighWatermark(Cluster cluster) {
José Armando García Sancio created KAFKA-18865:
--
Summary: Improve KRaft handling of kraft.version
Key: KAFKA-18865
URL: https://issues.apache.org/jira/browse/KAFKA-18865
Project: Kafka
jsancio merged PR #18852:
URL: https://github.com/apache/kafka/pull/18852
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
ahuang98 commented on code in PR #18987:
URL: https://github.com/apache/kafka/pull/18987#discussion_r1970747972
##
raft/src/test/java/org/apache/kafka/raft/RaftEventSimulationTest.java:
##
@@ -487,6 +555,12 @@ private EventScheduler
schedulerWithDefaultInvariants(Cluster cluste
ahuang98 commented on code in PR #18987:
URL: https://github.com/apache/kafka/pull/18987#discussion_r1970747972
##
raft/src/test/java/org/apache/kafka/raft/RaftEventSimulationTest.java:
##
@@ -487,6 +555,12 @@ private EventScheduler
schedulerWithDefaultInvariants(Cluster cluste
mumrah commented on PR #18963:
URL: https://github.com/apache/kafka/pull/18963#issuecomment-2683609144
@lucasbru try updating this PR with trunk. That should fix the build scan
errors
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
chia7712 commented on PR #19027:
URL: https://github.com/apache/kafka/pull/19027#issuecomment-2683604198
@m1a2st could you please update `Admin` to use the error message?
```
switch (error) {
case NONE:
future.complet
chia7712 commented on code in PR #19027:
URL: https://github.com/apache/kafka/pull/19027#discussion_r1970725921
##
clients/src/main/java/org/apache/kafka/common/requests/UnregisterBrokerRequest.java:
##
@@ -57,7 +57,8 @@ public UnregisterBrokerResponse getErrorResponse(int
thro
m1a2st commented on code in PR #19027:
URL: https://github.com/apache/kafka/pull/19027#discussion_r1970719030
##
clients/src/main/java/org/apache/kafka/common/requests/UnregisterBrokerRequest.java:
##
@@ -57,7 +57,8 @@ public UnregisterBrokerResponse getErrorResponse(int
thrott
chia7712 commented on code in PR #19025:
URL: https://github.com/apache/kafka/pull/19025#discussion_r1970716266
##
README.md:
##
@@ -42,6 +42,7 @@ Follow instructions in https://kafka.apache.org/quickstart
./gradlew test # runs both unit and integration tests
./gradle
chia7712 commented on code in PR #18989:
URL: https://github.com/apache/kafka/pull/18989#discussion_r1970705554
##
core/src/test/scala/integration/kafka/api/EndToEndAuthorizationTest.scala:
##
@@ -561,5 +568,17 @@ abstract class EndToEndAuthorizationTest extends
IntegrationTest
[
https://issues.apache.org/jira/browse/KAFKA-18862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
PoAn Yang reassigned KAFKA-18862:
-
Assignee: PoAn Yang
> Review testHeartbeatResponseOnErrorHandling duplicate logic in
> ShareHe
[
https://issues.apache.org/jira/browse/KAFKA-18862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930481#comment-17930481
]
Lianet Magrans commented on KAFKA-18862:
Sure, thanks!
> Review testHeartbeatRe
[
https://issues.apache.org/jira/browse/KAFKA-18862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930480#comment-17930480
]
PoAn Yang commented on KAFKA-18862:
---
Hi [~lianetm], if you're not working on this, may
mumrah opened a new pull request, #19031:
URL: https://github.com/apache/kafka/pull/19031
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
chia7712 commented on PR #18961:
URL: https://github.com/apache/kafka/pull/18961#issuecomment-2683361926
have checked the PR on 4.0 manually. cherry-pick to 4.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
chia7712 commented on code in PR #19016:
URL: https://github.com/apache/kafka/pull/19016#discussion_r1970616675
##
clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java:
##
@@ -172,13 +172,15 @@ public class TopicConfig {
public static final String MIN_IN_SY
ijuma commented on code in PR #19016:
URL: https://github.com/apache/kafka/pull/19016#discussion_r1970576760
##
server-common/src/main/java/org/apache/kafka/server/config/ServerLogConfigs.java:
##
@@ -136,14 +136,16 @@ public class ServerLogConfigs {
public static final Str
ijuma commented on code in PR #19016:
URL: https://github.com/apache/kafka/pull/19016#discussion_r1970582069
##
clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java:
##
@@ -172,13 +172,15 @@ public class TopicConfig {
public static final String MIN_IN_SYNC_
chia7712 merged PR #18961:
URL: https://github.com/apache/kafka/pull/18961
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
ijuma commented on PR #18961:
URL: https://github.com/apache/kafka/pull/18961#issuecomment-2683347392
> I have updated the guidance based on your reminder
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
lucasbru commented on code in PR #18963:
URL: https://github.com/apache/kafka/pull/18963#discussion_r1970571792
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java:
##
@@ -885,7 +885,8 @@ public Set drainRestoredActiveTasks(final
Durat
lucasbru commented on code in PR #18963:
URL: https://github.com/apache/kafka/pull/18963#discussion_r1970569977
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java:
##
@@ -2881,7 +2881,7 @@ private void verifySessionPartitions() {
lucasbru commented on code in PR #18963:
URL: https://github.com/apache/kafka/pull/18963#discussion_r1970569660
##
connect/runtime/src/test/java/org/apache/kafka/connect/integration/MonitorableSinkConnector.java:
##
@@ -60,7 +60,7 @@ public void start(Map props) {
@Over
ijuma commented on code in PR #18997:
URL: https://github.com/apache/kafka/pull/18997#discussion_r1970567923
##
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##
@@ -2004,14 +2004,17 @@ public CompletableFuture
registerBroker(
ControllerReque
ijuma commented on code in PR #18997:
URL: https://github.com/apache/kafka/pull/18997#discussion_r1970567923
##
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##
@@ -2004,14 +2004,17 @@ public CompletableFuture
registerBroker(
ControllerReque
lianetm commented on code in PR #18989:
URL: https://github.com/apache/kafka/pull/18989#discussion_r1970551665
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -16603,6 +16606,232 @@ foooTopicName, new TopicMetadata(foooT
lianetm merged PR #19024:
URL: https://github.com/apache/kafka/pull/19024
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
1 - 100 of 206 matches
Mail list logo
