[PR] MINOR: Cleanup Shell Module [kafka]

2025-05-19 Thread via GitHub
sjhajharia opened a new pull request, #19771: URL: https://github.com/apache/kafka/pull/19771 Now that Kafka support Java 17, this PR updates the shell module to get rid of older code. The changes mostly include: - Collections.emptyList(), Collections.singletonList() and - Arrays.asLis

[jira] [Assigned] (KAFKA-19317) Fix flaky test : ShareConsumerTest.testAlterReadUncommittedToReadCommittedIsolationLevel()

2025-05-19 Thread Shivsundar R (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shivsundar R reassigned KAFKA-19317: Assignee: Shivsundar R > Fix flaky test : > ShareConsumerTest.testAlterReadUncommittedTo

[jira] [Created] (KAFKA-19317) Fix flaky test : ShareConsumerTest.testAlterReadUncommittedToReadCommittedIsolationLevel()

2025-05-19 Thread Shivsundar R (Jira)
Shivsundar R created KAFKA-19317: Summary: Fix flaky test : ShareConsumerTest.testAlterReadUncommittedToReadCommittedIsolationLevel() Key: KAFKA-19317 URL: https://issues.apache.org/jira/browse/KAFKA-19317

Re: [PR] KAFKA-19284: Add documentation to clarify the behavior of null values for all partitionsToOffsetAndMetadata methods. [kafka]

2025-05-19 Thread via GitHub
LoganZhuZzz commented on code in PR #19728: URL: https://github.com/apache/kafka/pull/19728#discussion_r2096987142 ## clients/src/main/java/org/apache/kafka/clients/admin/ListShareGroupOffsetsResult.java: ## @@ -66,7 +66,8 @@ public KafkaFuture>> all() { } /** -

[PR] MINOR: Cleanup Share Coordinator [kafka]

2025-05-19 Thread via GitHub
sjhajharia opened a new pull request, #19770: URL: https://github.com/apache/kafka/pull/19770 Now that Kafka Brokers support Java 17, this PR updates the share coordinator module to get rid of older code. The changes mostly include: - Collections.emptyList(), Collections.singletonList() a

Re: [PR] MINOR Fix: API Responses missing latest version in Kafka protocol guide [kafka]

2025-05-19 Thread via GitHub
andy1li commented on PR #19769: URL: https://github.com/apache/kafka/pull/19769#issuecomment-2892918057 @dengziming Screenshot added. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Assigned] (KAFKA-17207) ConnectWorkerIntegrationTest.testRequestTimeouts times out in stop(), leaking clients

2025-05-19 Thread Francis Godinho (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Godinho reassigned KAFKA-17207: --- Assignee: Francis Godinho (was: Xuze Yang) > ConnectWorkerIntegrationTest.testRequ

Re: [PR] KAFKA-17456: Make sure FindCoordinatorResponse get created before consumer [kafka]

2025-05-19 Thread via GitHub
github-actions[bot] commented on PR #17404: URL: https://github.com/apache/kafka/pull/17404#issuecomment-2892819196 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-17456: Make sure FindCoordinatorResponse get created before consumer [kafka]

2025-05-19 Thread via GitHub
github-actions[bot] closed pull request #17404: KAFKA-17456: Make sure FindCoordinatorResponse get created before consumer URL: https://github.com/apache/kafka/pull/17404 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] KAFKA-18647: Clarify Windows support in Quick Start Guide [kafka]

2025-05-19 Thread via GitHub
github-actions[bot] commented on PR #18715: URL: https://github.com/apache/kafka/pull/18715#issuecomment-2892819320 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] KAFKA-17411: Use shared cache for Task offset sums [kafka]

2025-05-19 Thread via GitHub
github-actions[bot] commented on PR #17715: URL: https://github.com/apache/kafka/pull/17715#issuecomment-2892819246 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] MINOR: Add more description to KIP-1148 [kafka]

2025-05-19 Thread via GitHub
frankvicky commented on PR #19768: URL: https://github.com/apache/kafka/pull/19768#issuecomment-2892816671 Preview: ![image](https://github.com/user-attachments/assets/daa88d2d-f137-4b98-8339-935e56c58722) -- This is an automated message from the Apache Git Service. To respond to t

[PR] MINOR: Add more description to KIP-1148 [kafka]

2025-05-19 Thread via GitHub
frankvicky opened a new pull request, #19768: URL: https://github.com/apache/kafka/pull/19768 Given that we will remove the `log.cleaner.enable`, the related config `log.cleaner.threads` will also have the respective adjustment. This patch will add a description to it. For more det

Re: [PR] KAFKA-18379: Enforce resigned cannot transition to any other state in same epoch [kafka]

2025-05-19 Thread via GitHub
github-actions[bot] commented on PR #19236: URL: https://github.com/apache/kafka/pull/19236#issuecomment-2892796126 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] [WIP] KAFKA-18877: Add an mechanism to find cases where we accessed variables from the wrong thread. [kafka]

2025-05-19 Thread via GitHub
github-actions[bot] commented on PR #19231: URL: https://github.com/apache/kafka/pull/19231#issuecomment-2892796162 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] MINOR: Update the supported tags in docker_scan.yml [kafka]

2025-05-19 Thread via GitHub
frankvicky merged PR #19766: URL: https://github.com/apache/kafka/pull/19766 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apac

[jira] [Updated] (KAFKA-13610) Remove `log.cleaner.enable` and set lower bound 1 to `log.cleaner.threads`

2025-05-19 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TengYao Chi updated KAFKA-13610: Description: It's odd that things like the number of log cleaner threads are configurable, but no

[jira] [Updated] (KAFKA-13610) Remove `log.cleaner.enable` and set lower bound 1 to `log.cleaner.threads`

2025-05-19 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TengYao Chi updated KAFKA-13610: Summary: Remove `log.cleaner.enable` and set lower bound 1 to `log.cleaner.threads` (was: Make lo

[PR] KAFKA-19313: Replace LogOffsetMetadata#UNIFIED_LOG_UNKNOWN_OFFSET by UnifiedLog.UNKNOWN_OFFSET [kafka]

2025-05-19 Thread via GitHub
yuxian0908 opened a new pull request, #19767: URL: https://github.com/apache/kafka/pull/19767 Replaces the UNIFIED_LOG_UNKNOWN_OFFSET constant in LogOffsetMetadata with UnifiedLog.UNKNOWN_OFFSET. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[PR] MINOR: Update the supported tags in docker_scan.yml [kafka]

2025-05-19 Thread via GitHub
frankvicky opened a new pull request, #19766: URL: https://github.com/apache/kafka/pull/19766 The 3.9.1-rc2 has been accepted as the new release. Hence, we should update the supported tags. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] [KAFKA-18681] Created GetReplicaLogInfo* RPCs [kafka]

2025-05-19 Thread via GitHub
ahuang98 commented on code in PR #19664: URL: https://github.com/apache/kafka/pull/19664#discussion_r2096493928 ## clients/src/main/java/org/apache/kafka/common/requests/GetReplicaLogInfoResponse.java: ## @@ -0,0 +1,75 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] MINOR: Update 3.9.1 versions [kafka]

2025-05-19 Thread via GitHub
showuon commented on code in PR #19756: URL: https://github.com/apache/kafka/pull/19756#discussion_r2096617147 ## tests/kafkatest/__init__.py: ## @@ -22,4 +22,4 @@ # Instead, in development branches, the version should have a suffix of the form ".devN" # # For example, when

Re: [PR] KAFKA-15370: Support Participation in 2PC (KIP-939) (K/N) [kafka]

2025-05-19 Thread via GitHub
rreddy-22 commented on code in PR #19751: URL: https://github.com/apache/kafka/pull/19751#discussion_r2096560820 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -135,10 +136,10 @@ class TransactionCoordinator(txnConfig: TransactionConfig,

Re: [PR] KAFKA-19287: document all group coordinator metrics [kafka]

2025-05-19 Thread via GitHub
YutaLin commented on PR #19749: URL: https://github.com/apache/kafka/pull/19749#issuecomment-2892371479 Hi @dajac and @chia7712, here is the screenshot of the updated version. https://github.com/user-attachments/assets/7cc2c490-29be-47c5-bfd5-9abdc422049a"; /> -- This is an automat

Re: [PR] KAFKA-19080 The constraint on segment.ms is not enforced at topic level [kafka]

2025-05-19 Thread via GitHub
junrao commented on code in PR #19371: URL: https://github.com/apache/kafka/pull/19371#discussion_r2096192551 ## server-common/src/main/java/org/apache/kafka/server/config/ServerTopicConfigSynonyms.java: ## @@ -47,9 +48,11 @@ public final class ServerTopicConfigSynonyms {

[PR] (WIP) KAFKA-18486: Remove ReplicaManager#becomeLeaderOrFollower (2/N) [kafka]

2025-05-19 Thread via GitHub
TaiJuWu opened a new pull request, #19765: URL: https://github.com/apache/kafka/pull/19765 Delete this text and replace it with a detailed description of your change. The PR title and body will become the squashed commit message. If you would like to tag individuals, add some comm

Re: [PR] KAFKA-7516: Attempt to dynamically load ManagementFactory [kafka]

2025-05-19 Thread via GitHub
gtbX commented on PR #19764: URL: https://github.com/apache/kafka/pull/19764#issuecomment-2892267264 I originally submitted this PR as #17969, but I haven't been able to get back to it until now, and I don't see a way to re-open it. Also not sure who to tag for review. -- This is an auto

[PR] KAFKA-7516: Attempt to dynamically load ManagementFactory [kafka]

2025-05-19 Thread via GitHub
gtbX opened a new pull request, #19764: URL: https://github.com/apache/kafka/pull/19764 Fail gracefully if not found. This can be the case on Dalvik/Android. With this change, it's no longer necessary to stub out JMX classes on Android. The "metric.reporters" configuration should be s

[jira] [Updated] (KAFKA-19316) Add share_group_command_test.py system test

2025-05-19 Thread Chirag Wadhwa (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chirag Wadhwa updated KAFKA-19316: -- Summary: Add share_group_command_test.py system test (was: Add share_consumer_group_command_t

[jira] [Created] (KAFKA-19316) Add share_consumer_group_command_test.py system test

2025-05-19 Thread Chirag Wadhwa (Jira)
Chirag Wadhwa created KAFKA-19316: - Summary: Add share_consumer_group_command_test.py system test Key: KAFKA-19316 URL: https://issues.apache.org/jira/browse/KAFKA-19316 Project: Kafka Issue

[jira] [Assigned] (KAFKA-19315) Move ControllerMutationQuotaManager to server module

2025-05-19 Thread Bolin Lin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bolin Lin reassigned KAFKA-19315: - Assignee: Bolin Lin (was: Chia-Ping Tsai) > Move ControllerMutationQuotaManager to server modu

[jira] [Assigned] (KAFKA-19315) Move ControllerMutationQuotaManager to server module

2025-05-19 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-19315: -- Assignee: Chia-Ping Tsai (was: Chang Chi Hsu) > Move ControllerMutationQuotaManager

[jira] [Assigned] (KAFKA-19315) Move ControllerMutationQuotaManager to server module

2025-05-19 Thread Chang Chi Hsu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chang Chi Hsu reassigned KAFKA-19315: - Assignee: Chang Chi Hsu (was: Chia-Ping Tsai) > Move ControllerMutationQuotaManager to

[jira] [Created] (KAFKA-19315) Move ControllerMutationQuotaManager to server module

2025-05-19 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-19315: -- Summary: Move ControllerMutationQuotaManager to server module Key: KAFKA-19315 URL: https://issues.apache.org/jira/browse/KAFKA-19315 Project: Kafka Issu

Re: [PR] KAFKA-19312: Avoiding concurrent execution of onComplete and tryComplete [kafka]

2025-05-19 Thread via GitHub
chia7712 commented on PR #19759: URL: https://github.com/apache/kafka/pull/19759#issuecomment-2892046630 > The onComplete method in DelayedOperation is guaranteed to run only once, either by tryComplete or onExpiration. `onExpiration`? or `forceComplete`? > if onComplete

Re: [PR] KAFKA-19056: Rewrite EndToEndClusterIdTest in Java and move it to the server module [kafka]

2025-05-19 Thread via GitHub
mingyen066 commented on code in PR #19741: URL: https://github.com/apache/kafka/pull/19741#discussion_r2096339544 ## server/src/test/java/org/apache/kafka/api/EndToEndClusterIdTest.java: ## @@ -0,0 +1,219 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m

Re: [PR] KAFKA-19056: Rewrite EndToEndClusterIdTest in Java and move it to the server module [kafka]

2025-05-19 Thread via GitHub
mingyen066 commented on PR #19741: URL: https://github.com/apache/kafka/pull/19741#issuecomment-2892027550 Thanks @chia7712 for reviewing the PR. I've merged all the metrics reporters. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[PR] Kafka-19314: Remove unnecessary code of closing snapshotWriter [kafka]

2025-05-19 Thread via GitHub
jingjia88 opened a new pull request, #19763: URL: https://github.com/apache/kafka/pull/19763 - Remove redundant close of `snapshotWriter`. - `snapshotWriter` is already closed by `RaftSnapshotWriter#writer`. -- This is an automated message from the Apache Git Service

[PR] KAFKA-15599: Move KafkaMetadataLog to the raft module [kafka]

2025-05-19 Thread via GitHub
mimaison opened a new pull request, #19762: URL: https://github.com/apache/kafka/pull/19762 - Rename `KafkaMetadataLog` to `KafkaRaftLog` - Make `raft` depend on `storage` - Remove `storage` dependency on `metadata` as this otherwise create a cyclic dependency -- This is an auto

Re: [PR] KAFKA-16717 [2/N]: Add AdminClient.alterShareGroupOffsets [kafka]

2025-05-19 Thread via GitHub
JimmyWang6 commented on PR #18929: URL: https://github.com/apache/kafka/pull/18929#issuecomment-2891847836 > @JimmyWang6 Can you please update the branch while resolving conflicts. @apoorvmittal10 Noted, already resolved. -- This is an automated message from the Apache Git Service.

[jira] [Assigned] (KAFKA-19314) Remove unnecessary code of closing snapshotWriter

2025-05-19 Thread Jing-Jia Hung (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing-Jia Hung reassigned KAFKA-19314: - Assignee: Jing-Jia Hung (was: Chia-Ping Tsai) > Remove unnecessary code of closing sna

[jira] [Created] (KAFKA-19314) Remove unnecessary code of closing snapshotWriter

2025-05-19 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-19314: -- Summary: Remove unnecessary code of closing snapshotWriter Key: KAFKA-19314 URL: https://issues.apache.org/jira/browse/KAFKA-19314 Project: Kafka Issue T

Re: [PR] MINOR: Fix some Request toString methods (#19655) [kafka]

2025-05-19 Thread via GitHub
chia7712 commented on PR #19696: URL: https://github.com/apache/kafka/pull/19696#issuecomment-2891714040 > I see, do you happen to know up to which version we no longer have patch releases for? it seems to me the active branches include 3.8, 3.9, 4.0 and trunk -- This is an automat

Re: [PR] MINOR: Fix some Request toString methods (#19655) [kafka]

2025-05-19 Thread via GitHub
jolshan commented on PR #19692: URL: https://github.com/apache/kafka/pull/19692#issuecomment-2891709742 @ahuang98 here are your failures: https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-19692/1/testReport/ -- This is an automated message from the Apache Git Service. To respond

[jira] [Commented] (KAFKA-19259) Async consumer fetch intermittent delays on console consumer

2025-05-19 Thread Arpit Goyal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17952690#comment-17952690 ] Arpit Goyal commented on KAFKA-19259: - [~lianetm] I am unable to reproduce this issu

Re: [PR] MINOR: Fix some Request toString methods (#19655) [kafka]

2025-05-19 Thread via GitHub
ahuang98 commented on PR #19696: URL: https://github.com/apache/kafka/pull/19696#issuecomment-2891676206 @chia7712 I see, do you happen to know up to which version we no longer have patch releases for? -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] KAFKA-19082:[4/4] Complete Txn Client Side Changes (KIP-939) [kafka]

2025-05-19 Thread via GitHub
rreddy-22 commented on code in PR #19714: URL: https://github.com/apache/kafka/pull/19714#discussion_r2096140934 ## clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java: ## @@ -884,6 +884,50 @@ public void abortTransaction() throws ProducerFencedException

Re: [PR] KAFKA-19082:[4/4] Complete Txn Client Side Changes (KIP-939) [kafka]

2025-05-19 Thread via GitHub
rreddy-22 commented on code in PR #19714: URL: https://github.com/apache/kafka/pull/19714#discussion_r2096139253 ## clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java: ## @@ -884,6 +884,50 @@ public void abortTransaction() throws ProducerFencedException

Re: [PR] KAFKA-18345: Part two, remove exponential backoff for candidate state [kafka]

2025-05-19 Thread via GitHub
ahuang98 commented on code in PR #19747: URL: https://github.com/apache/kafka/pull/19747#discussion_r2096117078 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java: ## @@ -1775,15 +1770,15 @@ public void testCandidateIgnoreVoteRequestOnSameEpoch(boolean withKip

Re: [PR] KAFKA-18345: Part two, remove exponential backoff for candidate state [kafka]

2025-05-19 Thread via GitHub
ahuang98 commented on code in PR #19747: URL: https://github.com/apache/kafka/pull/19747#discussion_r2096115392 ## raft/src/main/java/org/apache/kafka/raft/CandidateState.java: ## @@ -85,16 +81,12 @@ protected CandidateState( } /** - * Check if the candidate is b

Re: [PR] KAFKA-17747: Replace subscription metadata with metadata hash in consumer group (wip) [kafka]

2025-05-19 Thread via GitHub
FrankYang0529 commented on code in PR #19761: URL: https://github.com/apache/kafka/pull/19761#discussion_r2096090102 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Utils.java: ## @@ -349,12 +349,19 @@ static void throwIfRegularExpressionIsInvalid( *

[PR] KAFKA-17747: Replace subscription metadata with metadata hash in consumer group (wip) [kafka]

2025-05-19 Thread via GitHub
FrankYang0529 opened a new pull request, #19761: URL: https://github.com/apache/kafka/pull/19761 * Add `topicHashCache` to `GroupMetadataManager`. * Remove topic hash from cache if related topic image is updated. * Ignore topic hash 0 when calculating group metadata hash. * Add `meta

Re: [PR] [WIP]MINOR: update the gradle version for java 24 support [kafka]

2025-05-19 Thread via GitHub
m1a2st commented on PR #19760: URL: https://github.com/apache/kafka/pull/19760#issuecomment-2891570799 Test `./gradlew` command on my local machine. ![CleanShot 2025-05-19 at 23 40 11@2x](https://github.com/user-attachments/assets/762adf38-8fe7-4530-a78f-a9b7f8b76967) ![CleanShot 2025-

[jira] [Resolved] (KAFKA-19302) Move ReplicaState and Replica to server module

2025-05-19 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-19302. Fix Version/s: 4.1.0 Resolution: Fixed > Move ReplicaState and Replica to server mo

Re: [PR] KAFKA-19302: Move ReplicaState and Replica to server module [kafka]

2025-05-19 Thread via GitHub
chia7712 merged PR #19755: URL: https://github.com/apache/kafka/pull/19755 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-18783 : Extend InvalidConfigurationException related exceptions [kafka]

2025-05-19 Thread via GitHub
jolshan commented on code in PR #19731: URL: https://github.com/apache/kafka/pull/19731#discussion_r2096048236 ## core/src/main/scala/kafka/admin/ConfigCommand.scala: ## @@ -86,13 +86,13 @@ object ConfigCommand extends Logging { opts.checkArgs() processCommand(opts

[jira] [Created] (KAFKA-19313) Replace LogOffsetMetadata#UNIFIED_LOG_UNKNOWN_OFFSET by UnifiedLog.UNKNOWN_OFFSET

2025-05-19 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-19313: -- Summary: Replace LogOffsetMetadata#UNIFIED_LOG_UNKNOWN_OFFSET by UnifiedLog.UNKNOWN_OFFSET Key: KAFKA-19313 URL: https://issues.apache.org/jira/browse/KAFKA-19313

[jira] [Assigned] (KAFKA-19313) Replace LogOffsetMetadata#UNIFIED_LOG_UNKNOWN_OFFSET by UnifiedLog.UNKNOWN_OFFSET

2025-05-19 Thread Yu-Syuan Jheng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu-Syuan Jheng reassigned KAFKA-19313: -- Assignee: Yu-Syuan Jheng (was: Chia-Ping Tsai) > Replace LogOffsetMetadata#UNIFIED_L

Re: [PR] KAFKA-19034: [1/N] Rewrite RemoteTopicCrudTest by ClusterTest and move it to storage module [kafka]

2025-05-19 Thread via GitHub
apalan60 commented on code in PR #19681: URL: https://github.com/apache/kafka/pull/19681#discussion_r2095976152 ## storage/src/test/java/org/apache/kafka/admin/RemoteTopicCrudTest.java: ## @@ -0,0 +1,693 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mo

[PR] KAFKA-19312: Avoiding concurrent execution of onComplete and tryComplete [kafka]

2025-05-19 Thread via GitHub
apoorvmittal10 opened a new pull request, #19759: URL: https://github.com/apache/kafka/pull/19759 The `onComplete` method in DelayedOperation is guaranteed to run only once, either by `tryComplete` or `onExpiration`. The invocation of `tryComplete` is done by attaining `lock` so no concurre

[PR] MINOR: update the gradle version for java 24 support [kafka]

2025-05-19 Thread via GitHub
m1a2st opened a new pull request, #19760: URL: https://github.com/apache/kafka/pull/19760 Gradle 8.14 starts to support Java 24, so we should update the Gradle version accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] [KAFKA-18681] Created GetReplicaLogInfo* RPCs [kafka]

2025-05-19 Thread via GitHub
CalvinConfluent commented on PR #19664: URL: https://github.com/apache/kafka/pull/19664#issuecomment-2891439294 > We need a boolean to indicate that there is more data that we were unable to send due to length restrictions I wonder if it is good enough to indicate the limit is reached

Re: [PR] KAFKA-19303 Move VerifiableProperties to server-common module [kafka]

2025-05-19 Thread via GitHub
m1a2st closed pull request #19752: KAFKA-19303 Move VerifiableProperties to server-common module URL: https://github.com/apache/kafka/pull/19752 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[jira] [Commented] (KAFKA-13610) Make log.cleaner.enable dynamically configurable

2025-05-19 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17952653#comment-17952653 ] Chia-Ping Tsai commented on KAFKA-13610: [~frankvicky] please update the jira ti

[jira] [Created] (KAFKA-19312) Share partition fetch locks concurrent thread release

2025-05-19 Thread Apoorv Mittal (Jira)
Apoorv Mittal created KAFKA-19312: - Summary: Share partition fetch locks concurrent thread release Key: KAFKA-19312 URL: https://issues.apache.org/jira/browse/KAFKA-19312 Project: Kafka Issue

Re: [PR] KAFKA-18884: Move TransactionMetadata to transaction-coordinator module [kafka]

2025-05-19 Thread via GitHub
chia7712 commented on code in PR #19699: URL: https://github.com/apache/kafka/pull/19699#discussion_r2095904141 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -1909,7 +1909,7 @@ class KafkaApis(val requestChannel: RequestChannel, // partitions which failed

[PR] KAFKA-19291: Increase the timeout of remote storage share fetch requests in purgatory [kafka]

2025-05-19 Thread via GitHub
adixitconfluent opened a new pull request, #19757: URL: https://github.com/apache/kafka/pull/19757 ### About Consumer groups have a different timeout `REMOTE_FETCH_MAX_WAIT_MS_PROP` in delayed fetch purgatory for fetch requests having remote storage fetch ([code link](https://github.com/

Re: [PR] KAFKA-18783 : Extend InvalidConfigurationException related exceptions [kafka]

2025-05-19 Thread via GitHub
k-raina commented on PR #19731: URL: https://github.com/apache/kafka/pull/19731#issuecomment-2891142239 Failure in this PR seems Unrelated, as another PR run has same failures: https://github.com/apache/kafka/actions/runs/15096607388/job/42432258294 -- This is an automated message from t

[jira] [Commented] (KAFKA-16355) ConcurrentModificationException in InMemoryTimeOrderedKeyValueBuffer.evictWhile

2025-05-19 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17952553#comment-17952553 ] Mickael Maison commented on KAFKA-16355: Since we've not heard from [~ksolves.ka

Re: [PR] KAFKA-19042: [5/N] Move PlaintextConsumerCommitTest to client-integration-tests module [kafka]

2025-05-19 Thread via GitHub
chia7712 merged PR #19389: URL: https://github.com/apache/kafka/pull/19389 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Created] (KAFKA-19311) Document the different behaviors of commitAsync between classic consumer and async consumer

2025-05-19 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-19311: -- Summary: Document the different behaviors of commitAsync between classic consumer and async consumer Key: KAFKA-19311 URL: https://issues.apache.org/jira/browse/KAFKA-19311

[jira] [Assigned] (KAFKA-19311) Document the different behaviors of commitAsync between classic consumer and async consumer

2025-05-19 Thread Ming-Yen Chung (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ming-Yen Chung reassigned KAFKA-19311: -- Assignee: Ming-Yen Chung (was: Chia-Ping Tsai) > Document the different behaviors of

Re: [PR] KAFKA-17747: [3/N] Get rid of TopicMetadata in SubscribedTopicDescriberImpl [kafka]

2025-05-19 Thread via GitHub
dajac commented on code in PR #19611: URL: https://github.com/apache/kafka/pull/19611#discussion_r2095270860 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/SubscribedTopicDescriberImpl.java: ## @@ -79,49 +81,65 @@ public int numPartitions(Uuid topic

Re: [PR] KAFKA-17747: [3/N] Get rid of TopicMetadata in SubscribedTopicDescriberImpl [kafka]

2025-05-19 Thread via GitHub
dajac commented on code in PR #19611: URL: https://github.com/apache/kafka/pull/19611#discussion_r2095261511 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/SubscribedTopicDescriberImpl.java: ## @@ -79,49 +81,65 @@ public int numPartitions(Uuid topic

Re: [PR] KAFKA-19080 The constraint on segment.ms is not enforced at topic level [kafka]

2025-05-19 Thread via GitHub
m1a2st commented on PR #19371: URL: https://github.com/apache/kafka/pull/19371#issuecomment-2890936867 > It's useful to check if metadata.log.segment.min.bytes is used in any ducktape tests. I’ve checked all the tests in the Kafka project, and none of them use this configuration. -

Re: [PR] MINOR: Update 3.9.1 versions [kafka]

2025-05-19 Thread via GitHub
chia7712 commented on code in PR #19756: URL: https://github.com/apache/kafka/pull/19756#discussion_r2095643700 ## tests/kafkatest/__init__.py: ## @@ -22,4 +22,4 @@ # Instead, in development branches, the version should have a suffix of the form ".devN" # # For example, when

Re: [PR] MINOR: assignablePartitions returns all partitions for non-share groups. [kafka]

2025-05-19 Thread via GitHub
chia7712 commented on PR #19739: URL: https://github.com/apache/kafka/pull/19739#issuecomment-2890887719 @smjn I apologize that I've already merged #19611, and that pull request takes a different approach than this one. Please feel free to update this PR if you have a better way to address

Re: [PR] KAFKA-17747: [3/N] Get rid of TopicMetadata in SubscribedTopicDescriberImpl [kafka]

2025-05-19 Thread via GitHub
chia7712 merged PR #19611: URL: https://github.com/apache/kafka/pull/19611 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[PR] KAFKA-19244: Add support for kafka-streams-groups.sh options (delete all groups) [2/N] [kafka]

2025-05-19 Thread via GitHub
aliehsaeedii opened a new pull request, #19758: URL: https://github.com/apache/kafka/pull/19758 This PR implements all the options for `--delete --group grpId` and `--delete --all-groups` Tests: Integration tests. Unit test will be added after merging https://github.com/apache/

Re: [PR] MINOR: Update 3.9.1 versions [kafka]

2025-05-19 Thread via GitHub
showuon commented on code in PR #19756: URL: https://github.com/apache/kafka/pull/19756#discussion_r2095516665 ## tests/kafkatest/__init__.py: ## @@ -22,4 +22,4 @@ # Instead, in development branches, the version should have a suffix of the form ".devN" # # For example, when

Re: [PR] KAFKA-19042: [7/N] Move PlaintextConsumerPollTest to client-integration-tests module [kafka]

2025-05-19 Thread via GitHub
chia7712 commented on code in PR #19582: URL: https://github.com/apache/kafka/pull/19582#discussion_r2095391155 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/PlaintextConsumerPollTest.java: ## @@ -0,0 +1,755 @@ +/* + * Licensed to the Apach

[jira] [Created] (KAFKA-19310) Missing mocks for DelayedShareFetchTest tests related to Memory Records slicing

2025-05-19 Thread Abhinav Dixit (Jira)
Abhinav Dixit created KAFKA-19310: - Summary: Missing mocks for DelayedShareFetchTest tests related to Memory Records slicing Key: KAFKA-19310 URL: https://issues.apache.org/jira/browse/KAFKA-19310 Pro

Re: [PR] MINOR: Update 3.9.1 versions [kafka]

2025-05-19 Thread via GitHub
frankvicky commented on code in PR #19756: URL: https://github.com/apache/kafka/pull/19756#discussion_r2095465727 ## tests/kafkatest/__init__.py: ## @@ -22,4 +22,4 @@ # Instead, in development branches, the version should have a suffix of the form ".devN" # # For example, wh

Re: [PR] KAFKA-19034: [1/N] Rewrite RemoteTopicCrudTest by ClusterTest and move it to storage module [kafka]

2025-05-19 Thread via GitHub
chia7712 commented on code in PR #19681: URL: https://github.com/apache/kafka/pull/19681#discussion_r2095442180 ## storage/src/test/java/org/apache/kafka/admin/RemoteTopicCrudTest.java: ## @@ -0,0 +1,693 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mo

Re: [PR] KAFKA-19042: [7/N] Move PlaintextConsumerPollTest to client-integration-tests module [kafka]

2025-05-19 Thread via GitHub
m1a2st commented on code in PR #19582: URL: https://github.com/apache/kafka/pull/19582#discussion_r2095429402 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/PlaintextConsumerPollTest.java: ## @@ -0,0 +1,755 @@ +/* + * Licensed to the Apache

Re: [PR] KAFKA-16717 [2/N]: Add AdminClient.alterShareGroupOffsets [kafka]

2025-05-19 Thread via GitHub
AndrewJSchofield commented on code in PR #18929: URL: https://github.com/apache/kafka/pull/18929#discussion_r2095415932 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -8078,6 +8092,73 @@ public List sharePartitionsEli

Re: [PR] KAFKA-19289: Read only disk failure, ReplicaManager.scala's logManager.handleLogDirFailure(dir) not capturing exception correctly, interrupt process causing topic with multiple copies partiti

2025-05-19 Thread via GitHub
felixzh2020 closed pull request #19736: KAFKA-19289: Read only disk failure, ReplicaManager.scala's logManager.handleLogDirFailure(dir) not capturing exception correctly, interrupt process causing topic with multiple copies partition leader failure not switching. URL: https://github.com/apache

[jira] [Resolved] (KAFKA-19217) ShareConsumerTest.testComplexShareConsumer is unreliable

2025-05-19 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal resolved KAFKA-19217. --- Fix Version/s: 4.1.0 Resolution: Fixed > ShareConsumerTest.testComplexShareConsumer i

[PR] MINOR: Update 3.9.1 versions [kafka]

2025-05-19 Thread via GitHub
showuon opened a new pull request, #19756: URL: https://github.com/apache/kafka/pull/19756 Following release process guide: https://cwiki.apache.org/confluence/display/KAFKA/Release+Process#ReleaseProcess-Afterthevotepasses ``` Update version on the branch to 0.10.0.1-SNAPSHOT

[jira] [Resolved] (KAFKA-19226) Add test_console_share_consumer system test

2025-05-19 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal resolved KAFKA-19226. --- Fix Version/s: 4.1.0 Resolution: Fixed > Add test_console_share_consumer system test

Re: [PR] KAFKA-17573: Move KRaftMetadataCache to metadata module [kafka]

2025-05-19 Thread via GitHub
chia7712 commented on code in PR #19232: URL: https://github.com/apache/kafka/pull/19232#discussion_r2095357396 ## metadata/src/main/java/org/apache/kafka/metadata/KRaftMetadataCache.java: ## @@ -0,0 +1,513 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-16717 [2/N]: Add AdminClient.alterShareGroupOffsets [kafka]

2025-05-19 Thread via GitHub
apoorvmittal10 commented on PR #18929: URL: https://github.com/apache/kafka/pull/18929#issuecomment-2890428068 @JimmyWang6 Can you please update the branch with resolved conflicts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] KAFKA-18904: Add Admin#listConfigResources [2/N] [kafka]

2025-05-19 Thread via GitHub
AndrewJSchofield commented on code in PR #19743: URL: https://github.com/apache/kafka/pull/19743#discussion_r2095334181 ## clients/src/main/java/org/apache/kafka/common/requests/ListConfigResourcesRequest.java: ## @@ -28,14 +28,25 @@ public class ListConfigResourcesRequest exte

[jira] [Assigned] (KAFKA-16355) ConcurrentModificationException in InMemoryTimeOrderedKeyValueBuffer.evictWhile

2025-05-19 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison reassigned KAFKA-16355: -- Assignee: (was: Ksolves India Limited) > ConcurrentModificationException in > In

Re: [PR] KAFKA-17747: [3/N] Get rid of TopicMetadata in SubscribedTopicDescriberImpl [kafka]

2025-05-19 Thread via GitHub
chia7712 commented on code in PR #19611: URL: https://github.com/apache/kafka/pull/19611#discussion_r2095283685 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/SubscribedTopicDescriberImpl.java: ## @@ -79,49 +81,65 @@ public int numPartitions(Uuid to

Re: [PR] KAFKA-17747: [3/N] Get rid of TopicMetadata in SubscribedTopicDescriberImpl [kafka]

2025-05-19 Thread via GitHub
dajac commented on code in PR #19611: URL: https://github.com/apache/kafka/pull/19611#discussion_r2095262127 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/SubscribedTopicDescriberImpl.java: ## @@ -79,49 +81,65 @@ public int numPartitions(Uuid topic

Re: [PR] KAFKA-17747: [3/N] Get rid of TopicMetadata in SubscribedTopicDescriberImpl [kafka]

2025-05-19 Thread via GitHub
FrankYang0529 commented on code in PR #19611: URL: https://github.com/apache/kafka/pull/19611#discussion_r2095290200 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/SubscribedTopicDescriberImpl.java: ## @@ -79,49 +81,65 @@ public int numPartitions(Uu

Re: [PR] KAFKA-17747: [3/N] Get rid of TopicMetadata in SubscribedTopicDescriberImpl [kafka]

2025-05-19 Thread via GitHub
dajac commented on code in PR #19611: URL: https://github.com/apache/kafka/pull/19611#discussion_r2095258037 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/SubscribedTopicDescriberImpl.java: ## @@ -19,41 +19,42 @@ import org.apache.kafka.common.Uui

[jira] [Updated] (KAFKA-19289) Read only disk failure, ReplicaManager.scala's logManager.handleLogDirFailure(dir) not capturing exception correctly, interrupt process causing topic with multiple copi

2025-05-19 Thread felixzh (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] felixzh updated KAFKA-19289: Description: Read only disk failure, ReplicaManager.scala's logManager.handleLogDirFailure(dir)  not capt

[jira] [Assigned] (KAFKA-19276) Trigger rebalance when assignment related configurations are updated

2025-05-19 Thread Uladzislau Blok (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uladzislau Blok reassigned KAFKA-19276: --- Assignee: Uladzislau Blok > Trigger rebalance when assignment related configuration

  1   2   >