Re: [PR] KAFKA-19355: Remove interBrokerListenerName from ClusterControlManager [kafka]

2025-05-31 Thread via GitHub
apalan60 commented on code in PR #19866: URL: https://github.com/apache/kafka/pull/19866#discussion_r2118786460 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -1530,7 +1530,6 @@ private QuorumController( setReplicaPlacer(replicaPl

Re: [PR] KAFKA-19053: Remove FetchResponse#of which is not used in production … [kafka]

2025-05-31 Thread via GitHub
apalan60 commented on code in PR #19327: URL: https://github.com/apache/kafka/pull/19327#discussion_r2118737584 ## clients/src/test/java/org/apache/kafka/clients/FetchSessionHandlerTest.java: ## @@ -217,7 +217,8 @@ public void testSessionless() { FetchResponse res

Re: [PR] KAFKA-16951 Notify TransactionManager of disconnects to proactively rediscover Coordinator [kafka]

2025-05-31 Thread via GitHub
github-actions[bot] closed pull request #16390: KAFKA-16951 Notify TransactionManager of disconnects to proactively rediscover Coordinator URL: https://github.com/apache/kafka/pull/16390 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] [ KAFKA-17049 ] fix Incremental rebalances assign too many tasks for the same connector together [kafka]

2025-05-31 Thread via GitHub
github-actions[bot] closed pull request #16486: [ KAFKA-17049 ] fix Incremental rebalances assign too many tasks for the same connector together URL: https://github.com/apache/kafka/pull/16486 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] MINOR: Refactor awaitNonEmptyRecords to remove dead code and improve clarity [kafka]

2025-05-31 Thread via GitHub
jingjia88 commented on code in PR #19868: URL: https://github.com/apache/kafka/pull/19868#discussion_r2118648890 ## core/src/test/scala/integration/kafka/api/AbstractConsumerTest.scala: ## @@ -94,12 +94,18 @@ abstract class AbstractConsumerTest extends BaseRequestTest { def

Re: [PR] feat(clients): MemberToRemove accepting memberId field on constructor… [kafka]

2025-05-31 Thread via GitHub
github-actions[bot] closed pull request #18738: feat(clients): MemberToRemove accepting memberId field on constructor… URL: https://github.com/apache/kafka/pull/18738 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] KAFKA-18638 fix flasky testThrottledProducerConsumer.testThrottledProducerConsumer [kafka]

2025-05-31 Thread via GitHub
github-actions[bot] commented on PR #18689: URL: https://github.com/apache/kafka/pull/18689#issuecomment-2926420589 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] Nilmadhab/co grouped windowed aggrgation [kafka]

2025-05-31 Thread via GitHub
github-actions[bot] commented on PR #19014: URL: https://github.com/apache/kafka/pull/19014#issuecomment-2926420748 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] feat(clients): MemberToRemove accepting memberId field on constructor… [kafka]

2025-05-31 Thread via GitHub
github-actions[bot] commented on PR #18738: URL: https://github.com/apache/kafka/pull/18738#issuecomment-2926420603 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-17503: Fix incorrect calculation of poll-idle-ratio-avg for con… [kafka]

2025-05-31 Thread via GitHub
github-actions[bot] commented on PR #17139: URL: https://github.com/apache/kafka/pull/17139#issuecomment-2926420548 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] [ KAFKA-17049 ] fix Incremental rebalances assign too many tasks for the same connector together [kafka]

2025-05-31 Thread via GitHub
github-actions[bot] commented on PR #16486: URL: https://github.com/apache/kafka/pull/16486#issuecomment-2926420522 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-16951 Notify TransactionManager of disconnects to proactively rediscover Coordinator [kafka]

2025-05-31 Thread via GitHub
github-actions[bot] commented on PR #16390: URL: https://github.com/apache/kafka/pull/16390#issuecomment-2926420497 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-18638 fix flasky testThrottledProducerConsumer.testThrottledProducerConsumer [kafka]

2025-05-31 Thread via GitHub
github-actions[bot] closed pull request #18689: KAFKA-18638 fix flasky testThrottledProducerConsumer.testThrottledProducerConsumer URL: https://github.com/apache/kafka/pull/18689 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] KAFKA-17503: Fix incorrect calculation of poll-idle-ratio-avg for con… [kafka]

2025-05-31 Thread via GitHub
github-actions[bot] closed pull request #17139: KAFKA-17503: Fix incorrect calculation of poll-idle-ratio-avg for con… URL: https://github.com/apache/kafka/pull/17139 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] KAFKA-18066: Fix mismatched StreamThread ID in log messages [kafka]

2025-05-31 Thread via GitHub
github-actions[bot] commented on PR #19517: URL: https://github.com/apache/kafka/pull/19517#issuecomment-2926390189 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] [WIP] KAFKA-18877: Add an mechanism to find cases where we accessed variables from the wrong thread. [kafka]

2025-05-31 Thread via GitHub
github-actions[bot] commented on PR #19231: URL: https://github.com/apache/kafka/pull/19231#issuecomment-2926390540 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18379: Enforce resigned cannot transition to any other state in same epoch [kafka]

2025-05-31 Thread via GitHub
github-actions[bot] commented on PR #19236: URL: https://github.com/apache/kafka/pull/19236#issuecomment-2926390516 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] [WIP] KAFKA-19167: Move RemoteLogManagerConfig out of KafkaConfig [kafka]

2025-05-31 Thread via GitHub
github-actions[bot] commented on PR #19806: URL: https://github.com/apache/kafka/pull/19806#issuecomment-292639 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] MINOR: Refactor awaitNonEmptyRecords to remove dead code and improve clarity [kafka]

2025-05-31 Thread via GitHub
m1a2st commented on code in PR #19868: URL: https://github.com/apache/kafka/pull/19868#discussion_r2118531153 ## core/src/test/scala/integration/kafka/api/AbstractConsumerTest.scala: ## @@ -94,12 +94,18 @@ abstract class AbstractConsumerTest extends BaseRequestTest { def awa

Re: [PR] KAFKA-19315: Move ControllerMutationQuotaManager to server module [kafka]

2025-05-31 Thread via GitHub
YutaLin commented on code in PR #19807: URL: https://github.com/apache/kafka/pull/19807#discussion_r2118210557 ## server/src/main/java/org/apache/kafka/server/ClientQuotaManager.java: ## @@ -0,0 +1,942 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] KAFKA-19315: Move ControllerMutationQuotaManager to server module [kafka]

2025-05-31 Thread via GitHub
YutaLin commented on code in PR #19807: URL: https://github.com/apache/kafka/pull/19807#discussion_r2118210557 ## server/src/main/java/org/apache/kafka/server/ClientQuotaManager.java: ## @@ -0,0 +1,942 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] KAFKA-19284: Add documentation to clarify the behavior of null values for all partitionsToOffsetAndMetadata methods. [kafka]

2025-05-31 Thread via GitHub
chia7712 merged PR #19728: URL: https://github.com/apache/kafka/pull/19728 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-19284) add documentation to clarify the behavior of null values for all partitionsToOffsetAndMetadata methods.

2025-05-31 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-19284. Fix Version/s: 4.1.0 Resolution: Fixed > add documentation to clarify the behavior

Re: [PR] KAFKA-19349: Move CreateTopicsRequestWithPolicyTest to clients-integration-tests [kafka]

2025-05-31 Thread via GitHub
chia7712 commented on code in PR #19849: URL: https://github.com/apache/kafka/pull/19849#discussion_r2118134310 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/CreateTopicsRequestWithPolicyTest.java: ## @@ -0,0 +1,236 @@ +/* + * Licensed to the Apache

[jira] [Resolved] (KAFKA-19311) Document the different behaviors of commitAsync between classic consumer and async consumer

2025-05-31 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-19311. Fix Version/s: 4.1.0 Resolution: Fixed > Document the different behaviors of commit

Re: [PR] KAFKA-19311: Document commitAsync behavioral differences between Classic and Async Consumer [kafka]

2025-05-31 Thread via GitHub
chia7712 merged PR #19864: URL: https://github.com/apache/kafka/pull/19864 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-19355: Remove interBrokerListenerName from ClusterControlManager [kafka]

2025-05-31 Thread via GitHub
chia7712 commented on code in PR #19866: URL: https://github.com/apache/kafka/pull/19866#discussion_r2118125912 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -1530,7 +1530,6 @@ private QuorumController( setReplicaPlacer(replicaPl

Re: [PR] KAFKA-19144 Move DelayedProduce to server module [kafka]

2025-05-31 Thread via GitHub
chia7712 commented on PR #19793: URL: https://github.com/apache/kafka/pull/19793#issuecomment-2925503582 @johnny94 could you please run benchmark for this PR to ensure there is no obvious performance regression -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] KAFKA-19053: Remove FetchResponse#of which is not used in production … [kafka]

2025-05-31 Thread via GitHub
chia7712 commented on code in PR #19327: URL: https://github.com/apache/kafka/pull/19327#discussion_r2118115367 ## clients/src/test/java/org/apache/kafka/clients/FetchSessionHandlerTest.java: ## @@ -217,7 +217,8 @@ public void testSessionless() { FetchResponse res

[jira] [Updated] (KAFKA-19259) Async consumer fetch intermittent delays on console consumer

2025-05-31 Thread Arpit Goyal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arpit Goyal updated KAFKA-19259: Attachment: Screenshot 2025-05-31 at 10.44.29 PM.png > Async consumer fetch intermittent delays on

[jira] [Commented] (KAFKA-19259) Async consumer fetch intermittent delays on console consumer

2025-05-31 Thread Arpit Goyal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17955430#comment-17955430 ] Arpit Goyal commented on KAFKA-19259: - [~lianetm] Though i did not find any differen

[jira] (KAFKA-19259) Async consumer fetch intermittent delays on console consumer

2025-05-31 Thread Arpit Goyal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19259 ] Arpit Goyal deleted comment on KAFKA-19259: - was (Author: JIRAUSER301926): [~lianetm] Though i did not find any difference in running the configuration through command line or intellij. !Sc

[jira] [Updated] (KAFKA-19259) Async consumer fetch intermittent delays on console consumer

2025-05-31 Thread Arpit Goyal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arpit Goyal updated KAFKA-19259: Attachment: consumer_KAFKA-19259.log > Async consumer fetch intermittent delays on console consume

[jira] [Commented] (KAFKA-19259) Async consumer fetch intermittent delays on console consumer

2025-05-31 Thread Arpit Goyal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17955427#comment-17955427 ] Arpit Goyal commented on KAFKA-19259: - Hi [~lianetm] I am also facing a weird issue

[PR] MINOR: Cleanup Connect Module (2/n) [kafka]

2025-05-31 Thread via GitHub
sjhajharia opened a new pull request, #19871: URL: https://github.com/apache/kafka/pull/19871 Now that Kafka support Java 17, this PR makes some changes in connect module. The changes in this PR are limited to only some files. A future PR(s) shall follow. The changes mostly include: -

Re: [PR] MINOR: Refactor awaitNonEmptyRecords to remove dead code and improve clarity [kafka]

2025-05-31 Thread via GitHub
jingjia88 commented on code in PR #19868: URL: https://github.com/apache/kafka/pull/19868#discussion_r2117955764 ## core/src/test/scala/integration/kafka/api/AbstractConsumerTest.scala: ## @@ -94,12 +94,18 @@ abstract class AbstractConsumerTest extends BaseRequestTest { def

Re: [PR] MINOR: Refactor awaitNonEmptyRecords to remove dead code and improve clarity [kafka]

2025-05-31 Thread via GitHub
m1a2st commented on code in PR #19868: URL: https://github.com/apache/kafka/pull/19868#discussion_r2117942448 ## core/src/test/scala/integration/kafka/api/AbstractConsumerTest.scala: ## @@ -94,12 +94,18 @@ abstract class AbstractConsumerTest extends BaseRequestTest { def awa

Re: [PR] KAFKA-17747: [6/N] Replace subscription metadata with metadata hash in share group [kafka]

2025-05-31 Thread via GitHub
FrankYang0529 commented on code in PR #19796: URL: https://github.com/apache/kafka/pull/19796#discussion_r2117873679 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/modern/share/ShareGroupBuilder.java: ## @@ -72,29 +70,8 @@ public List build(TopicsImage to

Re: [PR] KAFKA-19325 improve forceComplete() in DelayedOperation [kafka]

2025-05-31 Thread via GitHub
m1a2st commented on code in PR #19862: URL: https://github.com/apache/kafka/pull/19862#discussion_r2117798086 ## server-common/src/main/java/org/apache/kafka/server/purgatory/DelayedOperation.java: ## @@ -51,32 +51,15 @@ public DelayedOperation(long delayMs) { * * 1.

Re: [PR] KAFKA-19325 improve forceComplete() in DelayedOperation [kafka]

2025-05-31 Thread via GitHub
m1a2st commented on code in PR #19862: URL: https://github.com/apache/kafka/pull/19862#discussion_r2117790356 ## core/src/main/java/kafka/server/share/DelayedShareFetch.java: ## @@ -379,7 +380,12 @@ public boolean tryComplete() { partitionsAcquired.clear();

Re: [PR] KAFKA-19349: Move CreateTopicsRequestWithPolicyTest to clients-integration-tests [kafka]

2025-05-31 Thread via GitHub
Rancho-7 commented on code in PR #19849: URL: https://github.com/apache/kafka/pull/19849#discussion_r2117795540 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/CreateTopicsRequestWithPolicyTest.java: ## @@ -0,0 +1,236 @@ +/* + * Licensed to the Apache

[PR] KAFKA-19010: Added JVM argument to default configuration [kafka]

2025-05-31 Thread via GitHub
kumarlokesh opened a new pull request, #19870: URL: https://github.com/apache/kafka/pull/19870 Fixes https://issues.apache.org/jira/browse/KAFKA-19010 1. Added the `-XX:+EnableDynamicAgentLoading` JVM argument to the `defaultJvmArgs` 2. Configured Mockito agent in main test task, a

Re: [PR] KAFKA-19053: Remove FetchResponse#of which is not used in production … [kafka]

2025-05-31 Thread via GitHub
apalan60 commented on PR #19327: URL: https://github.com/apache/kafka/pull/19327#issuecomment-2924811811 > @apalan60 Could you please consider using `List.of` instead of `Collections.emptyList()`? Thanks for your review. Updated! -- This is an automated message from the Apache Git

Re: [PR] KAFKA-19325 improve forceComplete() in DelayedOperation [kafka]

2025-05-31 Thread via GitHub
junrao commented on code in PR #19862: URL: https://github.com/apache/kafka/pull/19862#discussion_r2117642371 ## server/src/main/java/org/apache/kafka/server/purgatory/DelayedDeleteRecords.java: ## @@ -91,7 +91,8 @@ public boolean tryComplete() { } });

Re: [PR] KAFKA-19221: Propagate IOException on LogSegment#close [kafka]

2025-05-31 Thread via GitHub
junrao commented on code in PR #19607: URL: https://github.com/apache/kafka/pull/19607#discussion_r2117627110 ## server/src/test/java/org/apache/kafka/server/LogManagerIntegrationTest.java: ## @@ -57,6 +58,70 @@ public LogManagerIntegrationTest(ClusterInstance cluster) {

[jira] [Commented] (KAFKA-19259) Async consumer fetch intermittent delays on console consumer

2025-05-31 Thread Arpit Goyal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17955389#comment-17955389 ] Arpit Goyal commented on KAFKA-19259: - Hi [~lianetm] I tried with the same set up an

[jira] [Updated] (KAFKA-19259) Async consumer fetch intermittent delays on console consumer

2025-05-31 Thread Arpit Goyal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arpit Goyal updated KAFKA-19259: Attachment: debug5.log > Async consumer fetch intermittent delays on console consumer > --

[PR] MINOR: Cleanup Connect Module (1/n) [kafka]

2025-05-31 Thread via GitHub
sjhajharia opened a new pull request, #19869: URL: https://github.com/apache/kafka/pull/19869 Now that Kafka support Java 17, this PR makes some changes in connect module. The changes in this PR are limited to only some files. A future PR(s) shall follow. The changes mostly include: -

Re: [PR] KAFKA-15873: Filter topics before sorting [kafka]

2025-05-31 Thread via GitHub
lorcanj commented on PR #19304: URL: https://github.com/apache/kafka/pull/19304#issuecomment-2924609971 Hi @mjsax @bbejeck, do you mind taking a look at this small PR if you have time? It's just a one line change to use the filter before sorting. Thanks. -- This is an automated mes