[jira] [Updated] (KAFKA-18841) Enable to test docker image locally

2025-08-25 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang updated KAFKA-18841: -- Fix Version/s: 4.2.0 > Enable to test docker image locally > --- > >

[jira] [Resolved] (KAFKA-18841) Enable to test docker image locally

2025-08-25 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang resolved KAFKA-18841. --- Resolution: Fixed > Enable to test docker image locally > --- > >

Re: [PR] KAFKA-17344: Empty Follower Fetch Tests [kafka]

2025-08-25 Thread via GitHub
abhijeetk88 commented on code in PR #16884: URL: https://github.com/apache/kafka/pull/16884#discussion_r2299871505 ## core/src/test/scala/unit/kafka/server/AbstractFetcherThreadTest.scala: ## @@ -1180,4 +1180,562 @@ class AbstractFetcherThreadTest { fetcher.processFetchRequ

Re: [PR] KAFKA-17108: Earliest pending upload offset [kafka]

2025-08-25 Thread via GitHub
kamalcph commented on PR #16584: URL: https://github.com/apache/kafka/pull/16584#issuecomment-3222638785 @abhijeetk88 Could you follow this https://github.com/apache/kafka/pull/16781 PR and handle similarly for EarliestPendingUploadSpec? Thanks! -- This is an automated message fr

[jira] [Commented] (KAFKA-19622) Limitations of KRAFT Dual Write Mode for Production Support

2025-08-25 Thread Sharad Garg (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18016189#comment-18016189 ] Sharad Garg commented on KAFKA-19622: - Hello, could someone please check this? > Li

Re: [PR] KAFKA-17344: Empty Follower Fetch Tests [kafka]

2025-08-25 Thread via GitHub
kamalcph commented on code in PR #16884: URL: https://github.com/apache/kafka/pull/16884#discussion_r2299738443 ## core/src/test/scala/unit/kafka/server/AbstractFetcherThreadTest.scala: ## @@ -1180,4 +1180,562 @@ class AbstractFetcherThreadTest { fetcher.processFetchRequest

Re: [PR] KAFKA-19612: Remove Redundant Validation in StripedReplicaPlacer [kafka]

2025-08-25 Thread via GitHub
pjl1070048431 closed pull request #20360: KAFKA-19612: Remove Redundant Validation in StripedReplicaPlacer URL: https://github.com/apache/kafka/pull/20360 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] KAFKA-19612: Remove Redundant Validation in StripedReplicaPlacer [kafka]

2025-08-25 Thread via GitHub
pjl1070048431 commented on PR #20360: URL: https://github.com/apache/kafka/pull/20360#issuecomment-3222459672 Just close the PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] KIP-780: Support fine-grained compression options [kafka]

2025-08-25 Thread via GitHub
github-actions[bot] commented on PR #20367: URL: https://github.com/apache/kafka/pull/20367#issuecomment-3222446334 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] MINOR: Refactor snapshottableSize method for better readability and simplicity [kafka]

2025-08-25 Thread via GitHub
github-actions[bot] commented on PR #20368: URL: https://github.com/apache/kafka/pull/20368#issuecomment-3222446291 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] Revert "KAFKA-18681: Created GetReplicaLogInfo RPCs (#19664)" [kafka]

2025-08-25 Thread via GitHub
github-actions[bot] commented on PR #20371: URL: https://github.com/apache/kafka/pull/20371#issuecomment-3222446257 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-12456: Log 'Listeners are not identical across brokers' message at INFO instead of ERROR [kafka]

2025-08-25 Thread via GitHub
chia7712 merged PR #20404: URL: https://github.com/apache/kafka/pull/20404 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-19432: Add an ERROR log message if broker.heartbeat.interval.ms is too large [kafka]

2025-08-25 Thread via GitHub
chia7712 commented on code in PR #20046: URL: https://github.com/apache/kafka/pull/20046#discussion_r2299617791 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -513,6 +513,11 @@ class KafkaConfig private(doLog: Boolean, val props: util.Map[_, _]) require(repli

Re: [PR] KAFKA-15307: Kafka Streams configuration docs outdated [kafka]

2025-08-25 Thread via GitHub
shashankhs11 commented on PR #20408: URL: https://github.com/apache/kafka/pull/20408#issuecomment-3222408760 Tagging @mjsax for review. Also, I need help in rendering the `html` to preview my changes. I was able to find the guidelines to render the `kafka-site` repo but not the Kafka

[jira] [Assigned] (KAFKA-19645) add a lower bound to num.replica.fetchers

2025-08-25 Thread Lan Ding (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lan Ding reassigned KAFKA-19645: Assignee: Lan Ding (was: Chia-Ping Tsai) > add a lower bound to num.replica.fetchers > -

Re: [PR] KAFKA-15307: Kafka Streams configuration docs outdated [kafka]

2025-08-25 Thread via GitHub
shashankhs11 commented on PR #20329: URL: https://github.com/apache/kafka/pull/20329#issuecomment-3222372711 Hi @mjsax, apologies for the delay and not pushing as promised. Here is the new PR #20408, ready for review! -- This is an automated message from the Apache Git Service. To respond

[PR] KAFKA-15307: Kafka Streams configuration docs outdated [kafka]

2025-08-25 Thread via GitHub
shashankhs11 opened a new pull request, #20408: URL: https://github.com/apache/kafka/pull/20408 Added new section for `window-serdes` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] MINOR: update TransactionLog#readTxnRecordValue to initialize TransactionMetadata with non-empty topic partitions [kafka]

2025-08-25 Thread via GitHub
chia7712 merged PR #20370: URL: https://github.com/apache/kafka/pull/20370 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-18841: Enable to test docker image locally [kafka]

2025-08-25 Thread via GitHub
frankvicky merged PR #19028: URL: https://github.com/apache/kafka/pull/19028 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apac

Re: [PR] KAFKA-19589: Reduce number of events generated in AsyncKafkaConsumer.updateFetchPositions() [kafka]

2025-08-25 Thread via GitHub
kirktrue commented on code in PR #20324: URL: https://github.com/apache/kafka/pull/20324#discussion_r2299517175 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitOffsetsSharedState.java: ## @@ -0,0 +1,162 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] KAFKA-19589: Reduce number of events generated in AsyncKafkaConsumer.updateFetchPositions() [kafka]

2025-08-25 Thread via GitHub
kirktrue commented on code in PR #20324: URL: https://github.com/apache/kafka/pull/20324#discussion_r2299515725 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitOffsetsSharedState.java: ## @@ -0,0 +1,162 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] KAFKA-15307: Kafka Streams configuration docs outdated [kafka]

2025-08-25 Thread via GitHub
mjsax commented on PR #20329: URL: https://github.com/apache/kafka/pull/20329#issuecomment-340103 Thanks @shashankhs11 -- please ping for review on the new PR when you have it ready. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Commented] (KAFKA-19641) Fix flaky RestoreIntegrationTest#shouldInvokeUserDefinedGlobalStateRestoreListener

2025-08-25 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18016158#comment-18016158 ] Matthias J. Sax commented on KAFKA-19641: - We recently merged [https://github.co

Re: [PR] KAFKA-19616: Add compression type and level support to LogCompactionTester [kafka]

2025-08-25 Thread via GitHub
yunchipang commented on code in PR #20396: URL: https://github.com/apache/kafka/pull/20396#discussion_r2299495289 ## tools/src/main/java/org/apache/kafka/tools/LogCompactionTester.java: ## @@ -226,6 +236,56 @@ public static String peekLine(BufferedReader reader) throws IOExcept

[jira] [Updated] (KAFKA-19641) Fix flaky RestoreIntegrationTest#shouldInvokeUserDefinedGlobalStateRestoreListener

2025-08-25 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-19641: Component/s: unit tests > Fix flaky > RestoreIntegrationTest#shouldInvokeUserDefinedGloba

[jira] [Updated] (KAFKA-19641) Fix flaky RestoreIntegrationTest#shouldInvokeUserDefinedGlobalStateRestoreListener

2025-08-25 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-19641: Component/s: streams > Fix flaky > RestoreIntegrationTest#shouldInvokeUserDefinedGlobalSt

[PR] MINOR: renamed testAsyncConsumerClassicConsumerSubscribeInvalidTopicC anUnsubscribe to testAsyncConsumerSubscribeInvalidTopicCanUnsubscribe [kafka]

2025-08-25 Thread via GitHub
kirktrue opened a new pull request, #20407: URL: https://github.com/apache/kafka/pull/20407 Simple test method rename. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] KAFKA-19638: Set dummy ProcessorRecordContext for processor init [kafka]

2025-08-25 Thread via GitHub
mjsax commented on code in PR #20403: URL: https://github.com/apache/kafka/pull/20403#discussion_r2299384167 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java: ## @@ -1104,11 +1104,18 @@ private void initializeTopology() { // initiali

Re: [PR] MINOR: Cleanup Connect Module (4/n) [kafka]

2025-08-25 Thread via GitHub
chia7712 commented on PR #20389: URL: https://github.com/apache/kafka/pull/20389#issuecomment-3221571954 @sjhajharia could you please rebase code to trigger CI again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] KAFKA-19616: Add compression type and level support to LogCompactionTester [kafka]

2025-08-25 Thread via GitHub
chia7712 commented on code in PR #20396: URL: https://github.com/apache/kafka/pull/20396#discussion_r2299003609 ## tools/src/main/java/org/apache/kafka/tools/LogCompactionTester.java: ## @@ -226,6 +236,56 @@ public static String peekLine(BufferedReader reader) throws IOExceptio

[jira] [Created] (KAFKA-19645) add a lower bound to num.replica.fetchers

2025-08-25 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-19645: -- Summary: add a lower bound to num.replica.fetchers Key: KAFKA-19645 URL: https://issues.apache.org/jira/browse/KAFKA-19645 Project: Kafka Issue Type: Imp

Re: [PR] KAFKA-19632: Handle overlap batch on partition re-assignment [kafka]

2025-08-25 Thread via GitHub
apoorvmittal10 commented on code in PR #20395: URL: https://github.com/apache/kafka/pull/20395#discussion_r2298978810 ## core/src/test/java/kafka/server/share/SharePartitionTest.java: ## @@ -1088,6 +1088,672 @@ public void testMaybeInitializeStateBatchesWithoutGaps() {

Re: [PR] KAFKA-19632: Handle overlap batch on partition re-assignment [kafka]

2025-08-25 Thread via GitHub
apoorvmittal10 commented on code in PR #20395: URL: https://github.com/apache/kafka/pull/20395#discussion_r2298978186 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -1512,6 +1566,13 @@ private ShareAcquiredRecords acquireNewBatchRecords( //

Re: [PR] KAFKA-19259: Async consumer fetch intermittent delays on console consumer [kafka]

2025-08-25 Thread via GitHub
kirktrue commented on code in PR #19980: URL: https://github.com/apache/kafka/pull/19980#discussion_r2298971190 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java: ## @@ -222,6 +222,10 @@ protected void handleFetchSuccess(final Node fetchTarg

Re: [PR] KAFKA-19259: Async consumer fetch intermittent delays on console consumer [kafka]

2025-08-25 Thread via GitHub
kirktrue commented on code in PR #19980: URL: https://github.com/apache/kafka/pull/19980#discussion_r2298969509 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/PlaintextConsumerTest.java: ## @@ -1588,6 +1593,103 @@ private void sendCompressed

Re: [PR] KAFKA-19642: Replace dynamicPerBrokerConfigs with dynamicDefaultConfigs [kafka]

2025-08-25 Thread via GitHub
chia7712 commented on PR #20405: URL: https://github.com/apache/kafka/pull/20405#issuecomment-3221510808 > Thanks for the feedback. I'm still working on adding the test case and will update the PR once it's ready. Perhaps we could enhance `testServersCanStartWithInvalidStaticConfigsA

Re: [PR] KAFKA-19632: Handle overlap batch on partition re-assignment [kafka]

2025-08-25 Thread via GitHub
apoorvmittal10 commented on code in PR #20395: URL: https://github.com/apache/kafka/pull/20395#discussion_r2298890511 ## core/src/test/java/kafka/server/share/SharePartitionTest.java: ## @@ -1088,6 +1088,672 @@ public void testMaybeInitializeStateBatchesWithoutGaps() {

Re: [PR] KAFKA-19632: Handle overlap batch on partition re-assignment [kafka]

2025-08-25 Thread via GitHub
apoorvmittal10 commented on code in PR #20395: URL: https://github.com/apache/kafka/pull/20395#discussion_r2298884746 ## core/src/test/java/kafka/server/share/SharePartitionTest.java: ## @@ -1088,6 +1088,672 @@ public void testMaybeInitializeStateBatchesWithoutGaps() {

[PR] KAFKA-8080: Remove system test [kafka]

2025-08-25 Thread via GitHub
RaidenE1 opened a new pull request, #20406: URL: https://github.com/apache/kafka/pull/20406 After [KAFKA-7944](https://github.com/apache/kafka/pull/6382), the system test `streams_eos_test.py` is mostly redundant. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] MINOR: update kraft dynamic voter set doc [kafka]

2025-08-25 Thread via GitHub
chia7712 merged PR #20401: URL: https://github.com/apache/kafka/pull/20401 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: update kraft dynamic voter set doc [kafka]

2025-08-25 Thread via GitHub
chia7712 commented on PR #20401: URL: https://github.com/apache/kafka/pull/20401#issuecomment-3221120177 the flaky is traced by https://issues.apache.org/jira/browse/KAFKA-19641 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] KAFKA-19642: Replace dynamicPerBrokerConfigs with dynamicDefaultConfigs [kafka]

2025-08-25 Thread via GitHub
jim0987795064 commented on PR #20405: URL: https://github.com/apache/kafka/pull/20405#issuecomment-3221108306 > @jim0987795064 : Thanks for the PR. A couple of comments. Also, could we add a test case? Thanks for the feedback. I'm still working on adding the test case and will update the

Re: [PR] KAFKA-19642: Replace dynamicPerBrokerConfigs with dynamicDefaultConfigs [kafka]

2025-08-25 Thread via GitHub
jim0987795064 commented on code in PR #20405: URL: https://github.com/apache/kafka/pull/20405#discussion_r2298676949 ## core/src/main/scala/kafka/server/DynamicBrokerConfig.scala: ## @@ -231,15 +230,15 @@ object DynamicBrokerConfig { if (configRecord.resourc

Re: [PR] KAFKA-19642: Replace dynamicPerBrokerConfigs with dynamicDefaultConfigs [kafka]

2025-08-25 Thread via GitHub
jim0987795064 commented on code in PR #20405: URL: https://github.com/apache/kafka/pull/20405#discussion_r2298676949 ## core/src/main/scala/kafka/server/DynamicBrokerConfig.scala: ## @@ -231,15 +230,15 @@ object DynamicBrokerConfig { if (configRecord.resourc

Re: [PR] KAFKA-19259: Async consumer fetch intermittent delays on console consumer [kafka]

2025-08-25 Thread via GitHub
lianetm commented on code in PR #19980: URL: https://github.com/apache/kafka/pull/19980#discussion_r2298036689 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/PlaintextConsumerTest.java: ## @@ -1588,6 +1593,103 @@ private void sendCompressedM

Re: [PR] KAFKA-19642: Replace dynamicPerBrokerConfigs with dynamicDefaultConfigs [kafka]

2025-08-25 Thread via GitHub
junrao commented on code in PR #20405: URL: https://github.com/apache/kafka/pull/20405#discussion_r2298598556 ## core/src/main/scala/kafka/server/DynamicBrokerConfig.scala: ## @@ -231,15 +230,15 @@ object DynamicBrokerConfig { if (configRecord.resourceName()

Re: [PR] KAFKA-19011: Improve EndToEndLatency Tool with argument parser and message key/header support [kafka]

2025-08-25 Thread via GitHub
Rancho-7 commented on code in PR #20301: URL: https://github.com/apache/kafka/pull/20301#discussion_r2298566652 ## tools/src/main/java/org/apache/kafka/tools/EndToEndLatency.java: ## @@ -221,4 +290,173 @@ private static KafkaProducer createKafkaProducer(Optional(producerProps);

Re: [PR] KAFKA-19011: Improve EndToEndLatency Tool with argument parser and message key/header support [kafka]

2025-08-25 Thread via GitHub
Rancho-7 commented on code in PR #20301: URL: https://github.com/apache/kafka/pull/20301#discussion_r2298564631 ## tools/src/main/java/org/apache/kafka/tools/EndToEndLatency.java: ## @@ -122,33 +137,87 @@ static void execute(String... args) throws Exception { la

Re: [PR] KAFKA-19011: Improve EndToEndLatency Tool with argument parser and message key/header support [kafka]

2025-08-25 Thread via GitHub
Rancho-7 commented on code in PR #20301: URL: https://github.com/apache/kafka/pull/20301#discussion_r2298545145 ## tools/src/main/java/org/apache/kafka/tools/EndToEndLatency.java: ## @@ -221,4 +290,173 @@ private static KafkaProducer createKafkaProducer(Optional(producerProps);

Re: [PR] KAFKA-19011: Improve EndToEndLatency Tool with argument parser and message key/header support [kafka]

2025-08-25 Thread via GitHub
Rancho-7 commented on code in PR #20301: URL: https://github.com/apache/kafka/pull/20301#discussion_r2298541868 ## tools/src/main/java/org/apache/kafka/tools/EndToEndLatency.java: ## @@ -221,4 +290,173 @@ private static KafkaProducer createKafkaProducer(Optional(producerProps);

Re: [PR] KAFKA-19624: Improving consistency of command-line arguments for consumer performance tests [kafka]

2025-08-25 Thread via GitHub
AndrewJSchofield commented on code in PR #20385: URL: https://github.com/apache/kafka/pull/20385#discussion_r2298444121 ## tests/kafkatest/services/performance/share_consumer_performance.py: ## @@ -33,7 +33,7 @@ class ShareConsumerPerformanceService(PerformanceService):

Re: [PR] KAFKA-15987: Refactor ReplicaManager code for transaction verification [kafka]

2025-08-25 Thread via GitHub
jolshan commented on code in PR #15087: URL: https://github.com/apache/kafka/pull/15087#discussion_r2298430334 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -762,167 +763,123 @@ class ReplicaManager(val config: KafkaConfig, delayedProduceLo

Re: [PR] KAFKA-19625: Consistency of command-line arguments for verifiable producer/consumer [kafka]

2025-08-25 Thread via GitHub
AndrewJSchofield commented on code in PR #20390: URL: https://github.com/apache/kafka/pull/20390#discussion_r2298331901 ## tools/src/main/java/org/apache/kafka/tools/VerifiableConsumer.java: ## @@ -622,16 +631,27 @@ public static VerifiableConsumer createFromArgs(ArgumentParser

[jira] [Assigned] (KAFKA-8080) Remove streams_eos_test system test

2025-08-25 Thread travis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] travis reassigned KAFKA-8080: - Assignee: travis > Remove streams_eos_test system test > --- > >

Re: [PR] MINOR: Cleanups in the release scripts [kafka]

2025-08-25 Thread via GitHub
mimaison commented on PR #20308: URL: https://github.com/apache/kafka/pull/20308#issuecomment-3220564096 @showuon Can you take a look? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[jira] [Commented] (KAFKA-19613) Expose consumer CorruptRecordException as case of KafkaException

2025-08-25 Thread Uladzislau Blok (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18016014#comment-18016014 ] Uladzislau Blok commented on KAFKA-19613: - [~lianetm]  Hello  Just today I've go

[jira] [Updated] (KAFKA-19613) Expose consumer CorruptRecordException as case of KafkaException

2025-08-25 Thread Uladzislau Blok (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uladzislau Blok updated KAFKA-19613: Attachment: corrupted_records.excalidraw.png > Expose consumer CorruptRecordException as c

Re: [PR] KAFKA-19624: Improving consistency of command-line arguments for consumer performance tests [kafka]

2025-08-25 Thread via GitHub
m1a2st commented on code in PR #20385: URL: https://github.com/apache/kafka/pull/20385#discussion_r2298240936 ## tools/src/main/java/org/apache/kafka/tools/ConsumerPerformance.java: ## @@ -292,13 +298,18 @@ public ConsumerPerfOptions(String[] args) { .ofType(Int

Re: [PR] KAFKA-19432: Add an ERROR log message if broker.heartbeat.interval.ms is too large [kafka]

2025-08-25 Thread via GitHub
FrankYang0529 commented on code in PR #20046: URL: https://github.com/apache/kafka/pull/20046#discussion_r2298260187 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -513,6 +513,11 @@ class KafkaConfig private(doLog: Boolean, val props: util.Map[_, _]) require(

Re: [PR] KAFKA-19624: Improving consistency of command-line arguments for consumer performance tests [kafka]

2025-08-25 Thread via GitHub
m1a2st commented on code in PR #20385: URL: https://github.com/apache/kafka/pull/20385#discussion_r2298240936 ## tools/src/main/java/org/apache/kafka/tools/ConsumerPerformance.java: ## @@ -292,13 +298,18 @@ public ConsumerPerfOptions(String[] args) { .ofType(Int

Re: [PR] KAFKA-19070:: Adding task number to user provided client id to ensure each consumer has a unique client ID to avoid metric registration conflicts. [kafka]

2025-08-25 Thread via GitHub
mimaison commented on PR #19341: URL: https://github.com/apache/kafka/pull/19341#issuecomment-3220499805 You can bump the thread to remind people to take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] KAFKA-15307: Kafka Streams configuration docs outdated [kafka]

2025-08-25 Thread via GitHub
shashankhs11 commented on PR #20329: URL: https://github.com/apache/kafka/pull/20329#issuecomment-3220470410 Hi @mimaison, I'll raise a new PR with the `4.1` changes within the next 6 hours, which hopefully gives enough time to review before merging. I hope this sounds good. -- This is a

Re: [PR] KAFKA-7883 add schema.namespace support to SetSchemaMetadata SMT in Kafka Connect [kafka]

2025-08-25 Thread via GitHub
mimaison commented on PR #11442: URL: https://github.com/apache/kafka/pull/11442#issuecomment-3220458864 @MartinJohannessen This is an open source project. If an issue or feature matters to you, you can participate and help. In this case, @mnegodaev has done most of the work already b

Re: [PR] MINOR: update TransactionLog#readTxnRecordValue to initialize TransactionMetadata with non-empty topic partitions [kafka]

2025-08-25 Thread via GitHub
FrankYang0529 commented on code in PR #20370: URL: https://github.com/apache/kafka/pull/20370#discussion_r2298216660 ## core/src/main/scala/kafka/coordinator/transaction/TransactionLog.scala: ## @@ -115,28 +115,25 @@ object TransactionLog { val version = buffer.getShort

[PR] KAFKA-19642: Replace dynamicPerBrokerConfigs with dynamicDefaultConfigs [kafka]

2025-08-25 Thread via GitHub
jim0987795064 opened a new pull request, #20405: URL: https://github.com/apache/kafka/pull/20405 - Changes: Replace dynamicPerBrokerConfigs with dynamicDefaultConfigs - Reasons: KRaft servers don't handle the cluser-level configs in starting from: https://github.com/apache/kafka/pul

[jira] [Commented] (KAFKA-19613) Expose consumer CorruptRecordException as case of KafkaException

2025-08-25 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18016004#comment-18016004 ] Lianet Magrans commented on KAFKA-19613: Agree it sounds useful to expose a Corr

Re: [PR] KAFKA-17344: Empty Follower Fetch Tests [kafka]

2025-08-25 Thread via GitHub
abhijeetk88 commented on code in PR #16884: URL: https://github.com/apache/kafka/pull/16884#discussion_r2298169429 ## core/src/test/scala/unit/kafka/server/AbstractFetcherThreadTest.scala: ## @@ -1180,4 +1180,551 @@ class AbstractFetcherThreadTest { fetcher.processFetchRequ

Re: [PR] KAFKA-17344: Empty Follower Fetch Tests [kafka]

2025-08-25 Thread via GitHub
abhijeetk88 commented on code in PR #16884: URL: https://github.com/apache/kafka/pull/16884#discussion_r2298170907 ## core/src/test/scala/unit/kafka/server/AbstractFetcherThreadTest.scala: ## @@ -1180,4 +1180,551 @@ class AbstractFetcherThreadTest { fetcher.processFetchRequ

Re: [PR] KAFKA-17344: Empty Follower Fetch Tests [kafka]

2025-08-25 Thread via GitHub
abhijeetk88 commented on code in PR #16884: URL: https://github.com/apache/kafka/pull/16884#discussion_r2298167782 ## core/src/test/scala/unit/kafka/server/AbstractFetcherThreadTest.scala: ## @@ -1180,4 +1180,551 @@ class AbstractFetcherThreadTest { fetcher.processFetchRequ

Re: [PR] KAFKA-19632: Handle overlap batch on partition re-assignment [kafka]

2025-08-25 Thread via GitHub
chirag-wadhwa5 commented on code in PR #20395: URL: https://github.com/apache/kafka/pull/20395#discussion_r2298033995 ## core/src/test/java/kafka/server/share/SharePartitionTest.java: ## @@ -1088,6 +1088,672 @@ public void testMaybeInitializeStateBatchesWithoutGaps() {

Re: [PR] KAFKA-19624: Improving consistency of command-line arguments for consumer performance tests [kafka]

2025-08-25 Thread via GitHub
brandboat commented on code in PR #20385: URL: https://github.com/apache/kafka/pull/20385#discussion_r2298117407 ## tools/src/main/java/org/apache/kafka/tools/ConsumerPerformance.java: ## @@ -258,11 +258,17 @@ protected static class ConsumerPerfOptions extends CommandDefaultOpt

Re: [PR] MINOR: kafka-stream-groups.sh should fail quickly if the partition leader is unavailable [kafka]

2025-08-25 Thread via GitHub
JimmyWang6 commented on PR #20271: URL: https://github.com/apache/kafka/pull/20271#issuecomment-3220274620 @lucasbru Thanks for your reply! I haved fixed the failure test, PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] MINOR: Cleanup Server Module [kafka]

2025-08-25 Thread via GitHub
sjhajharia commented on PR #20180: URL: https://github.com/apache/kafka/pull/20180#issuecomment-3220274004 Thanks @chia7712 for the review. I have addressed the comments and added two unit test files -> `ClientSensorsTest.java` and `ShareSessionKeyTest.java` for the same. Pls review w

[jira] [Assigned] (KAFKA-12456) Log "Listeners are not identical across brokers" message at WARN/INFO instead of ERROR

2025-08-25 Thread Kuan Po Tseng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kuan Po Tseng reassigned KAFKA-12456: - Assignee: Kuan Po Tseng > Log "Listeners are not identical across brokers" message at W

[jira] [Updated] (KAFKA-12456) Log "Listeners are not identical across brokers" message at WARN/INFO instead of ERROR

2025-08-25 Thread Kuan Po Tseng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kuan Po Tseng updated KAFKA-12456: -- Affects Version/s: 3.9.1 > Log "Listeners are not identical across brokers" message at WARN/IN

[PR] KAFKA-12456: Log 'Listeners are not identical across brokers' message at INFO instead of ERROR [kafka]

2025-08-25 Thread via GitHub
brandboat opened a new pull request, #20404: URL: https://github.com/apache/kafka/pull/20404 Lower the log level to INFO instead of ERROR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] KAFKA-19490: Remove usages of distutils in docker scripts [kafka]

2025-08-25 Thread via GitHub
mimaison commented on PR #20178: URL: https://github.com/apache/kafka/pull/20178#issuecomment-3220249532 Have you been able to validate the actions work? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] KAFKA-19625: Consistency of command-line arguments for verifiable producer/consumer [kafka]

2025-08-25 Thread via GitHub
JimmyWang6 commented on code in PR #20390: URL: https://github.com/apache/kafka/pull/20390#discussion_r2298064862 ## tools/src/main/java/org/apache/kafka/tools/VerifiableConsumer.java: ## @@ -622,16 +631,27 @@ public static VerifiableConsumer createFromArgs(ArgumentParser parse

Re: [PR] KAFKA-18853: Add documentation to remind users to use valid LogLevelConfig constants [kafka]

2025-08-25 Thread via GitHub
JimmyWang6 commented on code in PR #20249: URL: https://github.com/apache/kafka/pull/20249#discussion_r2298093923 ## core/src/main/java/kafka/server/logger/RuntimeLoggerManager.java: ## @@ -69,6 +69,21 @@ public void applyChangesForResource( } } +/** + *

Re: [PR] KAFKA-12456: Log "Listeners are not identical across brokers" message at WARN/INFO instead of ERROR [kafka]

2025-08-25 Thread via GitHub
brandboat commented on PR #10313: URL: https://github.com/apache/kafka/pull/10313#issuecomment-3220254882 here you go! https://github.com/apache/kafka/pull/20404 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] KAFKA-19625: Consistency of command-line arguments for verifiable producer/consumer [kafka]

2025-08-25 Thread via GitHub
JimmyWang6 commented on code in PR #20390: URL: https://github.com/apache/kafka/pull/20390#discussion_r2298064862 ## tools/src/main/java/org/apache/kafka/tools/VerifiableConsumer.java: ## @@ -622,16 +631,27 @@ public static VerifiableConsumer createFromArgs(ArgumentParser parse

[PR] KAFKA-19638: Set dummy ProcessorRecordContext for processor init [kafka]

2025-08-25 Thread via GitHub
eduwercamacaro opened a new pull request, #20403: URL: https://github.com/apache/kafka/pull/20403 Delete this text and replace it with a detailed description of your change. The PR title and body will become the squashed commit message. If you would like to tag individuals, add so

Re: [PR] KAFKA-19620: Move AutoTopicCreationManager to server module [kafka]

2025-08-25 Thread via GitHub
brandboat commented on code in PR #20383: URL: https://github.com/apache/kafka/pull/20383#discussion_r2298066928 ## server/src/main/java/org/apache/kafka/server/DefaultAutoTopicCreationManager.java: ## @@ -0,0 +1,268 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] KAFKA-19625: Consistency of command-line arguments for verifiable producer/consumer [kafka]

2025-08-25 Thread via GitHub
JimmyWang6 commented on code in PR #20390: URL: https://github.com/apache/kafka/pull/20390#discussion_r2298064862 ## tools/src/main/java/org/apache/kafka/tools/VerifiableConsumer.java: ## @@ -622,16 +631,27 @@ public static VerifiableConsumer createFromArgs(ArgumentParser parse

Re: [PR] MINOR: update kraft dynamic voter set doc [kafka]

2025-08-25 Thread via GitHub
brandboat commented on code in PR #20401: URL: https://github.com/apache/kafka/pull/20401#discussion_r2298054761 ## docs/ops.html: ## @@ -4116,11 +4116,10 @@ $ bin/kafka-storage.sh format -t KAFKA_CLUSTER_ID --feature kraft.version=1 -c controller.properties - Cannot set k

Re: [PR] MINOR: update kraft dynamic voter set doc [kafka]

2025-08-25 Thread via GitHub
chia7712 commented on code in PR #20401: URL: https://github.com/apache/kafka/pull/20401#discussion_r2298038668 ## docs/ops.html: ## @@ -4116,11 +4116,10 @@ $ bin/kafka-storage.sh format -t KAFKA_CLUSTER_ID --feature kraft.version=1 -c controller.properties - Cannot set kr

Re: [PR] KAFKA-19478 [3/N]: Use heaps to discover the least loaded process [kafka]

2025-08-25 Thread via GitHub
lucasbru commented on PR #20172: URL: https://github.com/apache/kafka/pull/20172#issuecomment-3220166034 @mjsax Reminder to please review this when you have time, or let me know if I should split up the optimization further. -- This is an automated message from the Apache Git Service. To

Re: [PR] POC: conditional creation of internal topics in Kafka Connect [kafka]

2025-08-25 Thread via GitHub
anton-liauchuk commented on PR #20384: URL: https://github.com/apache/kafka/pull/20384#issuecomment-3220156542 > Hi @anton-liauchuk, > > Your PoC introduces a new configuration so it requires a KIP. See https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals for

Re: [PR] MINOR: describeTopics should pass the timeout to the describeCluster call [kafka]

2025-08-25 Thread via GitHub
jim0987795064 commented on code in PR #20375: URL: https://github.com/apache/kafka/pull/20375#discussion_r2297972834 ## clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java: ## @@ -11668,4 +11668,26 @@ private static StreamsGroupDescribeResponseData ma

[jira] [Updated] (KAFKA-19643) Controller keeps switching and occasionally goes offline.

2025-08-25 Thread zzshine (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zzshine updated KAFKA-19643: Attachment: controller_every_min_change.png part_leader_to_one_node.png > Controller keeps

[jira] [Updated] (KAFKA-19643) Controller keeps switching and occasionally goes offline.

2025-08-25 Thread zzshine (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zzshine updated KAFKA-19643: Attachment: (was: part_leader_to_one_node.png) > Controller keeps switching and occasionally goes offl

Re: [PR] KAFKA-19596: Improve visibility when topic auto-creation fails [kafka]

2025-08-25 Thread via GitHub
chia7712 commented on code in PR #20340: URL: https://github.com/apache/kafka/pull/20340#discussion_r2297961128 ## core/src/main/scala/kafka/server/AutoTopicCreationManager.scala: ## @@ -138,6 +138,19 @@ class DefaultAutoTopicCreationManager( } else if (response.version

[jira] [Updated] (KAFKA-19643) Controller keeps switching and occasionally goes offline.

2025-08-25 Thread zzshine (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zzshine updated KAFKA-19643: Attachment: (was: xxx.png) > Controller keeps switching and occasionally goes offline. > -

[jira] [Updated] (KAFKA-19643) Controller keeps switching and occasionally goes offline.

2025-08-25 Thread zzshine (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zzshine updated KAFKA-19643: Attachment: part_leader_to_one_node.png > Controller keeps switching and occasionally goes offline. >

Re: [PR] MINOR: describeTopics should pass the timeout to the describeCluster call [kafka]

2025-08-25 Thread via GitHub
m1a2st commented on code in PR #20375: URL: https://github.com/apache/kafka/pull/20375#discussion_r2297949904 ## clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java: ## @@ -11668,4 +11669,27 @@ private static StreamsGroupDescribeResponseData makeFullS

Re: [PR] MINOR: describeTopics should pass the timeout to the describeCluster call [kafka]

2025-08-25 Thread via GitHub
chia7712 commented on code in PR #20375: URL: https://github.com/apache/kafka/pull/20375#discussion_r2297944462 ## clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java: ## @@ -11668,4 +11669,27 @@ private static StreamsGroupDescribeResponseData makeFul

[jira] [Commented] (KAFKA-19644) Enhance the documentation for producer headers

2025-08-25 Thread Jhen-Yung Hsu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18015977#comment-18015977 ] Jhen-Yung Hsu commented on KAFKA-19644: --- I'm working on this, thanks :) > Enhance

[jira] [Assigned] (KAFKA-19644) Enhance the documentation for producer headers

2025-08-25 Thread Jhen-Yung Hsu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jhen-Yung Hsu reassigned KAFKA-19644: - Assignee: Jhen-Yung Hsu (was: Chia-Ping Tsai) > Enhance the documentation for producer

Re: [PR] KAFKA-18853: Add documentation to remind users to use valid LogLevelConfig constants [kafka]

2025-08-25 Thread via GitHub
chia7712 commented on code in PR #20249: URL: https://github.com/apache/kafka/pull/20249#discussion_r2297926717 ## core/src/main/java/kafka/server/logger/RuntimeLoggerManager.java: ## @@ -69,6 +69,21 @@ public void applyChangesForResource( } } +/** + * Al

Re: [PR] KAFKA-19632: Handle overlap batch on partition re-assignment [kafka]

2025-08-25 Thread via GitHub
adixitconfluent commented on code in PR #20395: URL: https://github.com/apache/kafka/pull/20395#discussion_r2297922555 ## core/src/test/java/kafka/server/share/SharePartitionTest.java: ## @@ -1088,6 +1088,672 @@ public void testMaybeInitializeStateBatchesWithoutGaps() {

  1   2   >