[jira] [Commented] (KAFKA-6168) Connect Schema comparison is slow for large schemas

2017-11-03 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16238561#comment-16238561 ] Ted Yu commented on KAFKA-6168: --- Can I work on this ? > Connect Schema comparison is slow f

[jira] [Commented] (KAFKA-6167) Timestamp on streams directory contains a colon, which is an illegal character

2017-11-03 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16237856#comment-16237856 ] Ted Yu commented on KAFKA-6167: --- Any suggestion for a replacement ? Semicolon ? > Timestamp

[jira] [Commented] (KAFKA-6166) Streams configuration requires consumer. and producer. in order to be read

2017-11-03 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16237846#comment-16237846 ] Ted Yu commented on KAFKA-6166: --- How about populating the first two configs with the value f

[jira] [Commented] (KAFKA-5889) MetricsTest is flaky

2017-11-02 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16237005#comment-16237005 ] Ted Yu commented on KAFKA-5889: --- https://builds.apache.org/job/kafka-trunk-jdk7/2942 : {code

[jira] [Comment Edited] (KAFKA-6164) ClientQuotaManager threads prevent shutdown when encountering an error loading logs

2017-11-02 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16236900#comment-16236900 ] Ted Yu edited comment on KAFKA-6164 at 11/3/17 12:59 AM: - Throttle

[jira] [Commented] (KAFKA-6164) ClientQuotaManager threads prevent shutdown when encountering an error loading logs

2017-11-02 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16236900#comment-16236900 ] Ted Yu commented on KAFKA-6164: --- ThrottledRequestReaper extends ShutdownableThread where {co

[jira] [Updated] (KAFKA-5943) Reduce dependency on mock in connector tests

2017-11-02 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated KAFKA-5943: -- Description: Currently connector tests make heavy use of mock (easymock, power mock). This may hide the real lo

[jira] [Resolved] (KAFKA-6137) RestoreIntegrationTest sometimes fails with assertion error

2017-11-02 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu resolved KAFKA-6137. --- Resolution: Cannot Reproduce > RestoreIntegrationTest sometimes fails with assertion error > -

[jira] [Commented] (KAFKA-6158) CONSUMER-ID and HOST values are concatenated if the CONSUMER-ID is > 50 chars

2017-11-02 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16235890#comment-16235890 ] Ted Yu commented on KAFKA-6158: --- How about shifting consumer Id column after the following t

[jira] [Updated] (KAFKA-5946) Give connector method parameter better name

2017-11-01 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated KAFKA-5946: -- Description: During the development of KAFKA-5657, there were several iterations where method call didn't match

[jira] [Comment Edited] (KAFKA-5802) ScramServerCallbackHandler#handle should check username not being null before calling credentialCache.get()

2017-11-01 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212069#comment-16212069 ] Ted Yu edited comment on KAFKA-5802 at 11/1/17 5:15 PM: Thanks for

[jira] [Commented] (KAFKA-6144) Allow state stores to serve stale reads during rebalance

2017-10-30 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225395#comment-16225395 ] Ted Yu commented on KAFKA-6144: --- Please prepare a KIP. > Allow state stores to serve stale

[jira] [Commented] (KAFKA-6024) Consider moving validation in KafkaConsumer ahead of call to acquireAndEnsureOpen()

2017-10-27 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16222620#comment-16222620 ] Ted Yu commented on KAFKA-6024: --- lgtm > Consider moving validation in KafkaConsumer ahead o

[jira] [Resolved] (KAFKA-6109) ResetIntegrationTest may fail due to IllegalArgumentException

2017-10-27 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu resolved KAFKA-6109. --- Resolution: Cannot Reproduce > ResetIntegrationTest may fail due to IllegalArgumentException > ---

[jira] [Created] (KAFKA-6137) RestoreIntegrationTest sometimes fails with assertion error

2017-10-27 Thread Ted Yu (JIRA)
Ted Yu created KAFKA-6137: - Summary: RestoreIntegrationTest sometimes fails with assertion error Key: KAFKA-6137 URL: https://issues.apache.org/jira/browse/KAFKA-6137 Project: Kafka Issue Type: Test

[jira] [Issue Comment Deleted] (KAFKA-6109) ResetIntegrationTest may fail due to IllegalArgumentException

2017-10-27 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated KAFKA-6109: -- Comment: was deleted (was: From https://builds.apache.org/job/kafka-1.0-jdk7/62 : {code} org.apache.kafka.stream

[jira] [Comment Edited] (KAFKA-5889) MetricsTest is flaky

2017-10-27 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217277#comment-16217277 ] Ted Yu edited comment on KAFKA-5889 at 10/27/17 2:57 PM: - >From ht

[jira] [Commented] (KAFKA-6109) ResetIntegrationTest may fail due to IllegalArgumentException

2017-10-27 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16222478#comment-16222478 ] Ted Yu commented on KAFKA-6109: --- >From https://builds.apache.org/job/kafka-1.0-jdk7/62 : {co

[jira] [Updated] (KAFKA-6135) TransactionsTest#testFencingOnCommit may fail due to unexpected KafkaException

2017-10-26 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated KAFKA-6135: -- Attachment: 6135.out Test output . > TransactionsTest#testFencingOnCommit may fail due to unexpected KafkaExcep

[jira] [Created] (KAFKA-6135) TransactionsTest#testFencingOnCommit may fail due to unexpected KafkaException

2017-10-26 Thread Ted Yu (JIRA)
Ted Yu created KAFKA-6135: - Summary: TransactionsTest#testFencingOnCommit may fail due to unexpected KafkaException Key: KAFKA-6135 URL: https://issues.apache.org/jira/browse/KAFKA-6135 Project: Kafka

[jira] [Commented] (KAFKA-6132) KafkaProducer.initTransactions dead locks

2017-10-26 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221009#comment-16221009 ] Ted Yu commented on KAFKA-6132: --- Add this to your pom.xml : {code} sta

[jira] [Commented] (KAFKA-6132) KafkaProducer.initTransactions dead locks

2017-10-26 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16220986#comment-16220986 ] Ted Yu commented on KAFKA-6132: --- The RC is in maven staging repo. > KafkaProducer.initTrans

[jira] [Commented] (KAFKA-6132) KafkaProducer.initTransactions dead locks

2017-10-26 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16220951#comment-16220951 ] Ted Yu commented on KAFKA-6132: --- Does KAFKA-6042: 'Avoid deadlock between two groups with de

[jira] [Issue Comment Deleted] (KAFKA-6119) Silent Data Loss in Kafka011 Transactional Producer

2017-10-25 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated KAFKA-6119: -- Comment: was deleted (was: Looks like the new state shouldn't be hardcoded. How about the following change ? {co

[jira] [Comment Edited] (KAFKA-6119) Silent Data Loss in Kafka011 Transactional Producer

2017-10-25 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16219620#comment-16219620 ] Ted Yu edited comment on KAFKA-6119 at 10/25/17 10:08 PM: -- Looks

[jira] [Commented] (KAFKA-6119) Silent Data Loss in Kafka011 Transactional Producer

2017-10-25 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16219620#comment-16219620 ] Ted Yu commented on KAFKA-6119: --- Looks like the new state shouldn't be hardcoded. How about

[jira] [Updated] (KAFKA-6075) Kafka cannot recover after an unclean shutdown on Windows

2017-10-25 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated KAFKA-6075: -- Attachment: 6075.v4 > Kafka cannot recover after an unclean shutdown on Windows > --

[jira] [Updated] (KAFKA-5863) Potential null dereference in DistributedHerder#reconfigureConnector()

2017-10-25 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated KAFKA-5863: -- Description: Here is the call chain: {code} RestServer.httpRequest(reconfigUrl,

[jira] [Updated] (KAFKA-5943) Reduce dependency on mock in connector tests

2017-10-24 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated KAFKA-5943: -- Priority: Minor (was: Major) > Reduce dependency on mock in connector tests > -

[jira] [Commented] (KAFKA-5889) MetricsTest is flaky

2017-10-24 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217277#comment-16217277 ] Ted Yu commented on KAFKA-5889: --- The test didn't fail recently. > MetricsTest is flaky > --

[jira] [Commented] (KAFKA-6074) Use ZookeeperClient in ReplicaManager and Partition

2017-10-23 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16216193#comment-16216193 ] Ted Yu commented on KAFKA-6074: --- {code} val zkPath = new ZkPath(zkClientWrap) {code} Befor

[jira] [Updated] (KAFKA-6074) Use ZookeeperClient in ReplicaManager and Partition

2017-10-23 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated KAFKA-6074: -- Attachment: 6074.v1.txt > Use ZookeeperClient in ReplicaManager and Partition >

[jira] [Commented] (KAFKA-6074) Use ZookeeperClient in ReplicaManager and Partition

2017-10-23 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16216171#comment-16216171 ] Ted Yu commented on KAFKA-6074: --- In ReplicationUtils#propagateIsrChanges() (called by Repli

[jira] [Created] (KAFKA-6109) ResetIntegrationTest may fail due to IllegalArgumentException

2017-10-23 Thread Ted Yu (JIRA)
Ted Yu created KAFKA-6109: - Summary: ResetIntegrationTest may fail due to IllegalArgumentException Key: KAFKA-6109 URL: https://issues.apache.org/jira/browse/KAFKA-6109 Project: Kafka Issue Type: Te

[jira] [Comment Edited] (KAFKA-5846) Use singleton NoOpConsumerRebalanceListener in subscribe() call where listener is not specified

2017-10-23 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16191405#comment-16191405 ] Ted Yu edited comment on KAFKA-5846 at 10/23/17 5:21 PM: - Patch lo

[jira] [Updated] (KAFKA-5946) Give connector method parameter better name

2017-10-22 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated KAFKA-5946: -- Description: During the development of KAFKA-5657, there were several iterations where method call didn't match

[jira] [Updated] (KAFKA-6101) Reconnecting to broker does not exponentially backoff

2017-10-20 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated KAFKA-6101: -- Attachment: 6101.v3.txt > Reconnecting to broker does not exponentially backoff > --

[jira] [Updated] (KAFKA-6101) Reconnecting to broker does not exponentially backoff

2017-10-20 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated KAFKA-6101: -- Attachment: 6101.v2.txt > Reconnecting to broker does not exponentially backoff > --

[jira] [Updated] (KAFKA-6101) Reconnecting to broker does not exponentially backoff

2017-10-20 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated KAFKA-6101: -- Attachment: (was: 6101.v1.txt) > Reconnecting to broker does not exponentially backoff > ---

[jira] [Updated] (KAFKA-6101) Reconnecting to broker does not exponentially backoff

2017-10-20 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated KAFKA-6101: -- Attachment: 6101.v1.txt > Reconnecting to broker does not exponentially backoff > --

[jira] [Commented] (KAFKA-6100) Streams quick start crashes Java on Windows

2017-10-20 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16213140#comment-16213140 ] Ted Yu commented on KAFKA-6100: --- Can you paste the stack trace (by clicking Debug button) ?

[jira] [Commented] (KAFKA-5802) ScramServerCallbackHandler#handle should check username not being null before calling credentialCache.get()

2017-10-19 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212069#comment-16212069 ] Ted Yu commented on KAFKA-5802: --- Thanks for the PR. > ScramServerCallbackHandler#handle sho

[jira] [Commented] (KAFKA-6085) Streams rebalancing may cause a first batch of fetched records to be dropped

2017-10-18 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210527#comment-16210527 ] Ted Yu commented on KAFKA-6085: --- {code} final ConsumerRecords records = pollRequests

[jira] [Commented] (KAFKA-6086) KIP-210 Provide for custom error handling when Kafka Streams fails to produce

2017-10-18 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210291#comment-16210291 ] Ted Yu commented on KAFKA-6086: --- Normally there is no need to put the KIP number in the subj

[jira] [Resolved] (KAFKA-5911) Avoid creation of extra Map for futures in KafkaAdminClient

2017-10-18 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu resolved KAFKA-5911. --- Resolution: Later > Avoid creation of extra Map for futures in KafkaAdminClient >

[jira] [Commented] (KAFKA-5027) Kafka Controller Redesign

2017-10-18 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209377#comment-16209377 ] Ted Yu commented on KAFKA-5027: --- If there is dependency among the 'Use ZookeeperClient in' t

[jira] [Updated] (KAFKA-5943) Reduce dependency on mock in connector tests

2017-10-15 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated KAFKA-5943: -- Issue Type: Test (was: Improvement) > Reduce dependency on mock in connector tests > --

[jira] [Commented] (KAFKA-6024) Consider moving validation in KafkaConsumer ahead of call to acquireAndEnsureOpen()

2017-10-15 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16205329#comment-16205329 ] Ted Yu commented on KAFKA-6024: --- Thanks, Siva. > Consider moving validation in KafkaConsume

[jira] [Commented] (KAFKA-6047) Allow retries configuration for InternalTopicManager

2017-10-15 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16205108#comment-16205108 ] Ted Yu commented on KAFKA-6047: --- Does this require a KIP ? > Allow retries configuration fo

[jira] [Commented] (KAFKA-6063) StreamsException is thrown after the changing `partitions`

2017-10-15 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16205109#comment-16205109 ] Ted Yu commented on KAFKA-6063: --- Is this same as KAFKA-6047 ? > StreamsException is thrown

[jira] [Comment Edited] (KAFKA-5846) Use singleton NoOpConsumerRebalanceListener in subscribe() call where listener is not specified

2017-10-13 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16191405#comment-16191405 ] Ted Yu edited comment on KAFKA-5846 at 10/13/17 3:53 PM: - Patch lo

[jira] [Commented] (KAFKA-6046) DeleteRecordsRequest to a non-leader

2017-10-12 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16202003#comment-16202003 ] Ted Yu commented on KAFKA-6046: --- Can someone assign this to me ? > DeleteRecordsRequest to

[jira] [Updated] (KAFKA-5863) Potential null dereference in DistributedHerder#reconfigureConnector()

2017-10-11 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated KAFKA-5863: -- Description: Here is the call chain: {code} RestServer.httpRequest(reconfigUrl,

[jira] [Resolved] (KAFKA-5988) Consider removing StreamThread#STREAM_THREAD_ID_SEQUENCE

2017-10-11 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu resolved KAFKA-5988. --- Resolution: Won't Fix > Consider removing StreamThread#STREAM_THREAD_ID_SEQUENCE > ---

[jira] [Commented] (KAFKA-6049) Kafka Streams: Add Cogroup in the DSL

2017-10-10 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16199645#comment-16199645 ] Ted Yu commented on KAFKA-6049: --- bq. ValueGetters keep calling ValueGetters until Is there

[jira] [Updated] (KAFKA-6043) Kafka 8.1.1 - .ZookeeperConsumerConnector.shutdown(ZookeeperConsumerConnector.scala:110) blocked

2017-10-10 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated KAFKA-6043: -- Attachment: 6043.v1 > Kafka 8.1.1 - > .ZookeeperConsumerConnector.shutdown(ZookeeperConsumerConnector.scala:110

[jira] [Commented] (KAFKA-6043) Kafka 8.1.1 - .ZookeeperConsumerConnector.shutdown(ZookeeperConsumerConnector.scala:110) blocked

2017-10-10 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16199292#comment-16199292 ] Ted Yu commented on KAFKA-6043: --- Did you see who is holding 0x00076b2e1508 ? > Kafka 8.

[jira] [Commented] (KAFKA-6043) Kafka 8.1.1 - .ZookeeperConsumerConnector.shutdown(ZookeeperConsumerConnector.scala:110) blocked

2017-10-10 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16199291#comment-16199291 ] Ted Yu commented on KAFKA-6043: --- bq. locked <0x00076a922c40> (a java.lang.Object) This

[jira] [Commented] (KAFKA-6043) Kafka 8.1.1 - .ZookeeperConsumerConnector.shutdown(ZookeeperConsumerConnector.scala:110) blocked

2017-10-10 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16198944#comment-16198944 ] Ted Yu commented on KAFKA-6043: --- 0.8.1.1 was very old. Are you able to try newer release ?

[jira] [Commented] (KAFKA-6046) DeleteRecordsRequest to a non-leader

2017-10-10 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16198932#comment-16198932 ] Ted Yu commented on KAFKA-6046: --- Looking at core/src/main/scala/kafka/server/DelayedDeleteRe

[jira] [Updated] (KAFKA-5911) Avoid creation of extra Map for futures in KafkaAdminClient

2017-10-09 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated KAFKA-5911: -- Labels: client (was: ) > Avoid creation of extra Map for futures in KafkaAdminClient >

[jira] [Updated] (KAFKA-5943) Reduce dependency on mock in connector tests

2017-10-09 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated KAFKA-5943: -- Labels: connector (was: ) > Reduce dependency on mock in connector tests >

[jira] [Commented] (KAFKA-6027) System test failure: LogDirFailureTest

2017-10-09 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16197283#comment-16197283 ] Ted Yu commented on KAFKA-6027: --- In any of the link where LogDirFailureTest failed, there wo

[jira] [Updated] (KAFKA-5946) Give connector method parameter better name

2017-10-08 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated KAFKA-5946: -- Labels: connector (was: ) > Give connector method parameter better name > -

[jira] [Commented] (KAFKA-6024) Consider moving validation in KafkaConsumer ahead of call to acquireAndEnsureOpen()

2017-10-08 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16196244#comment-16196244 ] Ted Yu commented on KAFKA-6024: --- Go ahead. > Consider moving validation in KafkaConsumer ah

[jira] [Created] (KAFKA-6024) Consider moving validation in KafkaConsumer ahead of call to acquireAndEnsureOpen()

2017-10-08 Thread Ted Yu (JIRA)
Ted Yu created KAFKA-6024: - Summary: Consider moving validation in KafkaConsumer ahead of call to acquireAndEnsureOpen() Key: KAFKA-6024 URL: https://issues.apache.org/jira/browse/KAFKA-6024 Project: Kafka

[jira] [Created] (KAFKA-6023) ThreadCache#sizeBytes() should check overflow

2017-10-08 Thread Ted Yu (JIRA)
Ted Yu created KAFKA-6023: - Summary: ThreadCache#sizeBytes() should check overflow Key: KAFKA-6023 URL: https://issues.apache.org/jira/browse/KAFKA-6023 Project: Kafka Issue Type: Bug Rep

[jira] [Commented] (KAFKA-6020) Broker side filtering

2017-10-06 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16195223#comment-16195223 ] Ted Yu commented on KAFKA-6020: --- This needs a KIP, right ? > Broker side filtering > --

[jira] [Resolved] (KAFKA-5916) Upgrade rocksdb dependency to 5.8

2017-10-06 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu resolved KAFKA-5916. --- Resolution: Duplicate With KAFKA-5576 > Upgrade rocksdb dependency to 5.8 > -

[jira] [Comment Edited] (KAFKA-5973) ShutdownableThread catching errors can lead to partial hard to diagnose broker failure

2017-10-05 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16193918#comment-16193918 ] Ted Yu edited comment on KAFKA-5973 at 10/5/17 11:38 PM: - bq. whic

[jira] [Commented] (KAFKA-5973) ShutdownableThread catching errors can lead to partial hard to diagnose broker failure

2017-10-05 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16193918#comment-16193918 ] Ted Yu commented on KAFKA-5973: --- bq. which to kill itself, which to kill the whole process

[jira] [Updated] (KAFKA-5916) Upgrade rocksdb dependency to 5.8

2017-10-05 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated KAFKA-5916: -- Summary: Upgrade rocksdb dependency to 5.8 (was: Upgrade rocksdb dependency to 5.7.3) > Upgrade rocksdb depend

[jira] [Updated] (KAFKA-5916) Upgrade rocksdb dependency to 5.8

2017-10-05 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated KAFKA-5916: -- Description: Currently we use 5.3.6. The latest release is 5.8 : https://github.com/facebook/rocksdb/releases

[jira] [Resolved] (KAFKA-5842) QueryableStateIntegrationTest may fail with JDK 7

2017-10-04 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu resolved KAFKA-5842. --- Resolution: Cannot Reproduce > QueryableStateIntegrationTest may fail with JDK 7 > ---

[jira] [Commented] (KAFKA-5846) Use singleton NoOpConsumerRebalanceListener in subscribe() call where listener is not specified

2017-10-04 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16191405#comment-16191405 ] Ted Yu commented on KAFKA-5846: --- lgtm > Use singleton NoOpConsumerRebalanceListener in subs

[jira] [Commented] (KAFKA-6000) streams 0.10.2.1 - kafka 0.11.0.1 state restore not working

2017-10-03 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16189947#comment-16189947 ] Ted Yu commented on KAFKA-6000: --- I wonder if the following had something to do with the prob

[jira] [Commented] (KAFKA-5889) MetricsTest is flaky

2017-10-02 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188721#comment-16188721 ] Ted Yu commented on KAFKA-5889: --- https://builds.apache.org/job/kafka-trunk-jdk7/2836/display

[jira] [Commented] (KAFKA-5988) Consider removing StreamThread#STREAM_THREAD_ID_SEQUENCE

2017-10-01 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16187645#comment-16187645 ] Ted Yu commented on KAFKA-5988: --- Please go ahead. > Consider removing StreamThread#STREAM_T

[jira] [Updated] (KAFKA-5998) /.checkpoint.tmp Not found exception

2017-10-01 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated KAFKA-5998: -- Attachment: 5998.v2.txt Patch v2 enables the log when renaming to secondary fails. > /.checkpoint.tmp Not found

[jira] [Comment Edited] (KAFKA-5998) /.checkpoint.tmp Not found exception

2017-10-01 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16187353#comment-16187353 ] Ted Yu edited comment on KAFKA-5998 at 10/1/17 3:10 PM: Patch v1 h

[jira] [Commented] (KAFKA-5998) /.checkpoint.tmp Not found exception

2017-10-01 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16187353#comment-16187353 ] Ted Yu commented on KAFKA-5998: --- Patch v1 has been attached. If the .tmp file cannot be ren

[jira] [Updated] (KAFKA-5998) /.checkpoint.tmp Not found exception

2017-09-30 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated KAFKA-5998: -- Attachment: 5998.v1.txt {code} Files.move(source, target, StandardCopyOption.REPLACE_EXISTING);

[jira] [Created] (KAFKA-5988) Consider removing StreamThread#STREAM_THREAD_ID_SEQUENCE

2017-09-28 Thread Ted Yu (JIRA)
Ted Yu created KAFKA-5988: - Summary: Consider removing StreamThread#STREAM_THREAD_ID_SEQUENCE Key: KAFKA-5988 URL: https://issues.apache.org/jira/browse/KAFKA-5988 Project: Kafka Issue Type: Improvem

[jira] [Commented] (KAFKA-5967) Ineffective check of negative value in CompositeReadOnlyKeyValueStore#approximateNumEntries()

2017-09-28 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16184644#comment-16184644 ] Ted Yu commented on KAFKA-5967: --- Once you send out pull request, a committer would assign to

[jira] [Commented] (KAFKA-5967) Ineffective check of negative value in CompositeReadOnlyKeyValueStore#approximateNumEntries()

2017-09-28 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16184616#comment-16184616 ] Ted Yu commented on KAFKA-5967: --- Please go ahead. > Ineffective check of negative value in

[jira] [Commented] (KAFKA-5973) ShutdownableThread catching errors can lead to partial hard to diagnose broker failure

2017-09-27 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182775#comment-16182775 ] Ted Yu commented on KAFKA-5973: --- [~ijuma]: Among the threads identified by Tom, can you see

[jira] [Commented] (KAFKA-5973) ShutdownableThread catching errors can lead to partial hard to diagnose broker failure

2017-09-27 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182694#comment-16182694 ] Ted Yu commented on KAFKA-5973: --- [~damianguy] [~guozhang]: Can you take a look ? Thanks >

[jira] [Commented] (KAFKA-5973) ShutdownableThread catching errors can lead to partial hard to diagnose broker failure

2017-09-26 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16181184#comment-16181184 ] Ted Yu commented on KAFKA-5973: --- [~tcrayford-heroku] [~theduderog]: What do you think of the

[jira] [Updated] (KAFKA-5973) ShutdownableThread catching errors can lead to partial hard to diagnose broker failure

2017-09-25 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated KAFKA-5973: -- Attachment: 5973.v1.txt > ShutdownableThread catching errors can lead to partial hard to diagnose > broker fail

[jira] [Updated] (KAFKA-5968) Remove all broker metrics during shutdown

2017-09-25 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated KAFKA-5968: -- Attachment: 5968.v1.txt > Remove all broker metrics during shutdown > -

[jira] [Commented] (KAFKA-5973) ShutdownableThread catching errors can lead to partial hard to diagnose broker failure

2017-09-25 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16179702#comment-16179702 ] Ted Yu commented on KAFKA-5973: --- Interesting. Looks like the following class is not used: co

[jira] [Created] (KAFKA-5967) Ineffective check of negative value in CompositeReadOnlyKeyValueStore#approximateNumEntries()

2017-09-24 Thread Ted Yu (JIRA)
Ted Yu created KAFKA-5967: - Summary: Ineffective check of negative value in CompositeReadOnlyKeyValueStore#approximateNumEntries() Key: KAFKA-5967 URL: https://issues.apache.org/jira/browse/KAFKA-5967 Project

[jira] [Commented] (KAFKA-5889) MetricsTest is flaky

2017-09-22 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16177046#comment-16177046 ] Ted Yu commented on KAFKA-5889: --- As of commit 125d8d6f70829b9a0dbeabfef8f6b2df438dc12b , I g

[jira] [Resolved] (KAFKA-5840) TransactionsTest#testBasicTransactions sometimes hangs

2017-09-22 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu resolved KAFKA-5840. --- Resolution: Cannot Reproduce > TransactionsTest#testBasicTransactions sometimes hangs > --

[jira] [Resolved] (KAFKA-5821) Intermittent test failure in SaslPlainSslEndToEndAuthorizationTest.testAcls

2017-09-21 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu resolved KAFKA-5821. --- Resolution: Cannot Reproduce > Intermittent test failure in SaslPlainSslEndToEndAuthorizationTest.testAcls > -

[jira] [Updated] (KAFKA-5802) ScramServerCallbackHandler#handle should check username not being null before calling credentialCache.get()

2017-09-21 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated KAFKA-5802: -- Description: {code} String username = null; for (Callback callback : callbacks) { if

[jira] [Commented] (KAFKA-5657) Connect REST API should include the connector type when describing a connector

2017-09-20 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16174046#comment-16174046 ] Ted Yu commented on KAFKA-5657: --- Can the newbie label be taken off considering how confusing

[jira] [Created] (KAFKA-5946) Give connector method parameter better name

2017-09-20 Thread Ted Yu (JIRA)
Ted Yu created KAFKA-5946: - Summary: Give connector method parameter better name Key: KAFKA-5946 URL: https://issues.apache.org/jira/browse/KAFKA-5946 Project: Kafka Issue Type: Improvement

[jira] [Created] (KAFKA-5943) Reduce dependency on mock in connector tests

2017-09-20 Thread Ted Yu (JIRA)
Ted Yu created KAFKA-5943: - Summary: Reduce dependency on mock in connector tests Key: KAFKA-5943 URL: https://issues.apache.org/jira/browse/KAFKA-5943 Project: Kafka Issue Type: Improvement

[jira] [Updated] (KAFKA-5863) Potential null dereference in DistributedHerder#reconfigureConnector()

2017-09-19 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated KAFKA-5863: -- Description: Here is the call chain: {code} RestServer.httpRequest(reconfigUrl,

<    1   2   3   4   5   6   >