[GitHub] [kafka] AndrewJSchofield commented on a diff in pull request #14384: KAFKA-15415 On producer-batch retry, skip-backoff on a new leader

2023-09-14 Thread via GitHub
AndrewJSchofield commented on code in PR #14384: URL: https://github.com/apache/kafka/pull/14384#discussion_r1324599448 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/ProducerBatch.java: ## @@ -94,9 +100,40 @@ public ProducerBatch(TopicPartition tp,

[GitHub] [kafka] AndrewJSchofield commented on a diff in pull request #14384: KAFKA-15415 On producer-batch retry, skip-backoff on a new leader

2023-09-14 Thread via GitHub
AndrewJSchofield commented on code in PR #14384: URL: https://github.com/apache/kafka/pull/14384#discussion_r1324641156 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/SenderTest.java: ## @@ -3146,6 +3149,97 @@ public void

[GitHub] [kafka] AndrewJSchofield commented on a diff in pull request #14384: KAFKA-15415 On producer-batch retry, skip-backoff on a new leader

2023-09-13 Thread via GitHub
AndrewJSchofield commented on code in PR #14384: URL: https://github.com/apache/kafka/pull/14384#discussion_r1324590647 ## clients/src/main/java/org/apache/kafka/common/PartitionInfo.java: ## @@ -60,12 +69,19 @@ public int partition() { } /** - * The node id of