[GitHub] [kafka] C0urante commented on a diff in pull request #13178: KAFKA-12468, KAFKA-13659, KAFKA-12566: Fix MM2 causing negative downstream lag

C0urante commented on code in PR #13178: URL: https://github.com/apache/kafka/pull/13178#discussion_r1107352681 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationBaseTest.java: ## @@ -701,43 +745,151 @@ protected void

[GitHub] [kafka] C0urante commented on a diff in pull request #13178: KAFKA-12468, KAFKA-13659, KAFKA-12566: Fix MM2 causing negative downstream lag

C0urante commented on code in PR #13178: URL: https://github.com/apache/kafka/pull/13178#discussion_r1107345427 ## connect/runtime/src/main/java/org/apache/kafka/connect/util/KafkaBasedLog.java: ## @@ -392,6 +400,17 @@ protected Consumer createConsumer() { return new

[GitHub] [kafka] C0urante commented on a diff in pull request #13178: KAFKA-12468, KAFKA-13659, KAFKA-12566: Fix MM2 causing negative downstream lag

C0urante commented on code in PR #13178: URL: https://github.com/apache/kafka/pull/13178#discussion_r1107275404 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointTask.java: ## @@ -134,9 +138,9 @@ public String version() { @Override public

[GitHub] [kafka] C0urante commented on a diff in pull request #13178: KAFKA-12468, KAFKA-13659, KAFKA-12566: Fix MM2 causing negative downstream lag

C0urante commented on code in PR #13178: URL: https://github.com/apache/kafka/pull/13178#discussion_r1107273995 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/OffsetSyncStore.java: ## @@ -16,40 +16,88 @@ */ package org.apache.kafka.connect.mirror; -import

[GitHub] [kafka] C0urante commented on a diff in pull request #13178: KAFKA-12468, KAFKA-13659, KAFKA-12566: Fix MM2 causing negative downstream lag

C0urante commented on code in PR #13178: URL: https://github.com/apache/kafka/pull/13178#discussion_r1106023715 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointTask.java: ## @@ -134,9 +138,9 @@ public String version() { @Override public

[GitHub] [kafka] C0urante commented on a diff in pull request #13178: KAFKA-12468, KAFKA-13659, KAFKA-12566: Fix MM2 causing negative downstream lag

C0urante commented on code in PR #13178: URL: https://github.com/apache/kafka/pull/13178#discussion_r1104643146 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/OffsetSyncStore.java: ## @@ -16,40 +16,76 @@ */ package org.apache.kafka.connect.mirror; +import

[GitHub] [kafka] C0urante commented on a diff in pull request #13178: KAFKA-12468, KAFKA-13659, KAFKA-12566: Fix MM2 causing negative downstream lag

C0urante commented on code in PR #13178: URL: https://github.com/apache/kafka/pull/13178#discussion_r1104664513 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/OffsetSyncStore.java: ## @@ -16,40 +16,76 @@ */ package org.apache.kafka.connect.mirror; +import