[GitHub] [kafka] C0urante commented on a diff in pull request #13465: KAFKA-14368: Connect offset write REST API

2023-05-25 Thread via GitHub
C0urante commented on code in PR #13465: URL: https://github.com/apache/kafka/pull/13465#discussion_r1205535710 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/DistributedHerderTest.java: ## @@ -4123,6 +4136,280 @@ public void testConnectorOffsets()

[GitHub] [kafka] C0urante commented on a diff in pull request #13465: KAFKA-14368: Connect offset write REST API

2023-05-25 Thread via GitHub
C0urante commented on code in PR #13465: URL: https://github.com/apache/kafka/pull/13465#discussion_r1205533269 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/DistributedHerderTest.java: ## @@ -4123,6 +4136,280 @@ public void testConnectorOffsets()

[GitHub] [kafka] C0urante commented on a diff in pull request #13465: KAFKA-14368: Connect offset write REST API

2023-05-24 Thread via GitHub
C0urante commented on code in PR #13465: URL: https://github.com/apache/kafka/pull/13465#discussion_r1204681794 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/DistributedHerderTest.java: ## @@ -4123,6 +4136,280 @@ public void testConnectorOffsets()

[GitHub] [kafka] C0urante commented on a diff in pull request #13465: KAFKA-14368: Connect offset write REST API

2023-05-24 Thread via GitHub
C0urante commented on code in PR #13465: URL: https://github.com/apache/kafka/pull/13465#discussion_r1204612735 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java: ## @@ -1247,6 +1257,257 @@ void sourceConnectorOffsets(String connName, ConnectorOffset

[GitHub] [kafka] C0urante commented on a diff in pull request #13465: KAFKA-14368: Connect offset write REST API

2023-05-24 Thread via GitHub
C0urante commented on code in PR #13465: URL: https://github.com/apache/kafka/pull/13465#discussion_r1204612162 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java: ## @@ -1247,6 +1257,257 @@ void sourceConnectorOffsets(String connName, ConnectorOffset

[GitHub] [kafka] C0urante commented on a diff in pull request #13465: KAFKA-14368: Connect offset write REST API

2023-05-24 Thread via GitHub
C0urante commented on code in PR #13465: URL: https://github.com/apache/kafka/pull/13465#discussion_r1204604996 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java: ## @@ -1528,6 +1539,80 @@ public void connectorOffsets(String con

[GitHub] [kafka] C0urante commented on a diff in pull request #13465: KAFKA-14368: Connect offset write REST API

2023-05-23 Thread via GitHub
C0urante commented on code in PR #13465: URL: https://github.com/apache/kafka/pull/13465#discussion_r1202738629 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java: ## @@ -1247,6 +1257,257 @@ void sourceConnectorOffsets(String connName, ConnectorOffset

[GitHub] [kafka] C0urante commented on a diff in pull request #13465: KAFKA-14368: Connect offset write REST API

2023-05-23 Thread via GitHub
C0urante commented on code in PR #13465: URL: https://github.com/apache/kafka/pull/13465#discussion_r1202709620 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java: ## @@ -1247,6 +1257,257 @@ void sourceConnectorOffsets(String connName, ConnectorOffset

[GitHub] [kafka] C0urante commented on a diff in pull request #13465: KAFKA-14368: Connect offset write REST API

2023-05-23 Thread via GitHub
C0urante commented on code in PR #13465: URL: https://github.com/apache/kafka/pull/13465#discussion_r1202694716 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java: ## @@ -1235,6 +1244,246 @@ void sourceConnectorOffsets(String connName, ConnectorOffset

[GitHub] [kafka] C0urante commented on a diff in pull request #13465: KAFKA-14368: Connect offset write REST API

2023-05-23 Thread via GitHub
C0urante commented on code in PR #13465: URL: https://github.com/apache/kafka/pull/13465#discussion_r1202684769 ## connect/runtime/src/main/java/org/apache/kafka/connect/util/SinkUtils.java: ## @@ -52,4 +53,82 @@ public static ConnectorOffsets consumerGroupOffsetsToConnectorOff

[GitHub] [kafka] C0urante commented on a diff in pull request #13465: KAFKA-14368: Connect offset write REST API

2023-05-23 Thread via GitHub
C0urante commented on code in PR #13465: URL: https://github.com/apache/kafka/pull/13465#discussion_r1202678391 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java: ## @@ -1528,6 +1539,80 @@ public void connectorOffsets(String con

[GitHub] [kafka] C0urante commented on a diff in pull request #13465: KAFKA-14368: Connect offset write REST API

2023-05-23 Thread via GitHub
C0urante commented on code in PR #13465: URL: https://github.com/apache/kafka/pull/13465#discussion_r1202644196 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java: ## @@ -1528,6 +1539,80 @@ public void connectorOffsets(String con

[GitHub] [kafka] C0urante commented on a diff in pull request #13465: KAFKA-14368: Connect offset write REST API

2023-04-13 Thread via GitHub
C0urante commented on code in PR #13465: URL: https://github.com/apache/kafka/pull/13465#discussion_r1166062323 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java: ## @@ -114,6 +127,7 @@ public class Worker { public static final long CONNECTOR_G

[GitHub] [kafka] C0urante commented on a diff in pull request #13465: KAFKA-14368: Connect offset write REST API

2023-04-13 Thread via GitHub
C0urante commented on code in PR #13465: URL: https://github.com/apache/kafka/pull/13465#discussion_r1166062323 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java: ## @@ -114,6 +127,7 @@ public class Worker { public static final long CONNECTOR_G

[GitHub] [kafka] C0urante commented on a diff in pull request #13465: KAFKA-14368: Connect offset write REST API

2023-04-12 Thread via GitHub
C0urante commented on code in PR #13465: URL: https://github.com/apache/kafka/pull/13465#discussion_r1164465874 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java: ## @@ -114,6 +127,7 @@ public class Worker { public static final long CONNECTOR_G