[GitHub] [kafka] C0urante commented on a diff in pull request #14005: KAFKA-15177: Implement KIP-875 SourceConnector::alterOffset API in MirrorMaker 2 connectors

2023-07-20 Thread via GitHub
C0urante commented on code in PR #14005: URL: https://github.com/apache/kafka/pull/14005#discussion_r1269901272 ## connect/runtime/src/test/java/org/apache/kafka/connect/util/clusters/EmbeddedKafkaCluster.java: ## @@ -597,7 +596,9 @@ private Set listPartitions( Admi

[GitHub] [kafka] C0urante commented on a diff in pull request #14005: KAFKA-15177: Implement KIP-875 SourceConnector::alterOffset API in MirrorMaker 2 connectors

2023-07-18 Thread via GitHub
C0urante commented on code in PR #14005: URL: https://github.com/apache/kafka/pull/14005#discussion_r1266848313 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationExactlyOnceTest.java: ## @@ -46,4 +51,49 @@ public void startClu

[GitHub] [kafka] C0urante commented on a diff in pull request #14005: KAFKA-15177: Implement KIP-875 SourceConnector::alterOffset API in MirrorMaker 2 connectors

2023-07-17 Thread via GitHub
C0urante commented on code in PR #14005: URL: https://github.com/apache/kafka/pull/14005#discussion_r1265649203 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationExactlyOnceTest.java: ## @@ -46,4 +51,49 @@ public void startClu

[GitHub] [kafka] C0urante commented on a diff in pull request #14005: KAFKA-15177: Implement KIP-875 SourceConnector::alterOffset API in MirrorMaker 2 connectors

2023-07-13 Thread via GitHub
C0urante commented on code in PR #14005: URL: https://github.com/apache/kafka/pull/14005#discussion_r1262913499 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationExactlyOnceTest.java: ## @@ -46,4 +51,49 @@ public void startClu

[GitHub] [kafka] C0urante commented on a diff in pull request #14005: KAFKA-15177: Implement KIP-875 SourceConnector::alterOffset API in MirrorMaker 2 connectors

2023-07-12 Thread via GitHub
C0urante commented on code in PR #14005: URL: https://github.com/apache/kafka/pull/14005#discussion_r1261630589 ## connect/runtime/src/test/java/org/apache/kafka/connect/util/clusters/EmbeddedKafkaCluster.java: ## @@ -597,7 +596,9 @@ private Set listPartitions( Admi