[GitHub] [kafka] C0urante commented on pull request #11792: Replace EasyMock/PowerMock with Mockito in DistributedHerderTest

2022-09-27 Thread GitBox
C0urante commented on PR #11792: URL: https://github.com/apache/kafka/pull/11792#issuecomment-1259559178 @mdedetrich Great, thanks! I've assigned [KAFKA-13187](https://issues.apache.org/jira/browse/KAFKA-13187) to you to let others know that the ticket is being worked on. If you need to

[GitHub] [kafka] C0urante commented on pull request #11792: Replace EasyMock/PowerMock with Mockito in DistributedHerderTest

2022-09-27 Thread GitBox
C0urante commented on PR #11792: URL: https://github.com/apache/kafka/pull/11792#issuecomment-1259557319 @divijvaidya I've also used the `OngoingStubbing` class to set up multiple expectations for a mock at once. I'm not sure if it's applicable to your case, but I found that it wasn't too

[GitHub] [kafka] C0urante commented on pull request #11792: Replace EasyMock/PowerMock with Mockito in DistributedHerderTest

2022-09-26 Thread GitBox
C0urante commented on PR #11792: URL: https://github.com/apache/kafka/pull/11792#issuecomment-1258272010 @dplavcic No worries, it happens :) @yashmayya @mdedetrich @clolov @divijvaidya any interest in taking this one on? Fairly high-priority as it's blocking other PRs. -- This is

[GitHub] [kafka] C0urante commented on pull request #11792: Replace EasyMock/PowerMock with Mockito in DistributedHerderTest

2022-09-23 Thread GitBox
C0urante commented on PR #11792: URL: https://github.com/apache/kafka/pull/11792#issuecomment-1256282722 Hi @dplavcic! Any update? The refactoring to the `DistributedHerderTest` is blocking a few other PRs; if you don't have the time to tackle it, let us know and I'm sure someone else

[GitHub] [kafka] C0urante commented on pull request #11792: Replace EasyMock/PowerMock with Mockito in DistributedHerderTest

2022-09-14 Thread GitBox
C0urante commented on PR #11792: URL: https://github.com/apache/kafka/pull/11792#issuecomment-1246858578 Hi @dplavcic, are you still working on this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] C0urante commented on pull request #11792: Replace EasyMock/PowerMock with Mockito in DistributedHerderTest

2022-07-26 Thread GitBox
C0urante commented on PR #11792: URL: https://github.com/apache/kafka/pull/11792#issuecomment-1195701534 @jeff303 do you still plan to work on this? Happy to provide a round of review for what's here already if you'd like some feedback. -- This is an automated message from the Apache Git