[GitHub] [kafka] C0urante commented on pull request #13418: MINOR: add equals and hashcode methods to KafkaProducer and ProducerMetadata

C0urante commented on PR #13418: URL: https://github.com/apache/kafka/pull/13418#issuecomment-1476186302 Thanks for providing more detail. I'm still confused about this part: > The default equals method compares by address. But this is not what we want. Wouldn't comparison by a

[GitHub] [kafka] C0urante commented on pull request #13418: MINOR: add equals and hashcode methods to KafkaProducer and ProducerMetadata

C0urante commented on PR #13418: URL: https://github.com/apache/kafka/pull/13418#issuecomment-1475590471 Can you provide some detail on that need? And how it isn't addressed by the existing non-overridden `equals` implementation? -- This is an automated message from the Apache Git Service

[GitHub] [kafka] C0urante commented on pull request #13418: MINOR: add equals and hashcode methods to KafkaProducer and ProducerMetadata

C0urante commented on PR #13418: URL: https://github.com/apache/kafka/pull/13418#issuecomment-1475444359 @leeleeian That all makes sense; I'm wondering if you or anyone has a use case that involves comparing producers, though? -- This is an automated message from the Apache Git Service. T

[GitHub] [kafka] C0urante commented on pull request #13418: MINOR: add equals and hashcode methods to KafkaProducer and ProducerMetadata

C0urante commented on PR #13418: URL: https://github.com/apache/kafka/pull/13418#issuecomment-1475437343 Thanks @leeleeian. I'm wondering about the motivation for this change. Is there something in a project you're working that necessitates or at least would benefit from implementing `equal