[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #13870: KAFKA-14500; [5/N] Implement JoinGroup protocol in new GroupCoordinator

2023-06-29 Thread via GitHub
CalvinConfluent commented on code in PR #13870: URL: https://github.com/apache/kafka/pull/13870#discussion_r1246995181 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -874,4 +1087,1362 @@ public void replay(

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #13870: KAFKA-14500; [5/N] Implement JoinGroup protocol in new GroupCoordinator

2023-06-29 Thread via GitHub
CalvinConfluent commented on code in PR #13870: URL: https://github.com/apache/kafka/pull/13870#discussion_r1246964799 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -102,13 +108,34 @@ public Builder