[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #14053: KAFKA-15221; Fix the race between fetch requests from a rebooted follower.

2023-09-21 Thread via GitHub
CalvinConfluent commented on code in PR #14053: URL: https://github.com/apache/kafka/pull/14053#discussion_r1333490449 ## core/src/main/scala/kafka/cluster/Replica.scala: ## @@ -98,14 +103,20 @@ class Replica(val brokerId: Int, val topicPartition: TopicPartition) extends Log

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #14053: KAFKA-15221; Fix the race between fetch requests from a rebooted follower.

2023-09-14 Thread via GitHub
CalvinConfluent commented on code in PR #14053: URL: https://github.com/apache/kafka/pull/14053#discussion_r1326544485 ## core/src/main/scala/kafka/cluster/Replica.scala: ## @@ -98,14 +103,22 @@ class Replica(val brokerId: Int, val topicPartition: TopicPartition) extends Log

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #14053: KAFKA-15221; Fix the race between fetch requests from a rebooted follower.

2023-09-14 Thread via GitHub
CalvinConfluent commented on code in PR #14053: URL: https://github.com/apache/kafka/pull/14053#discussion_r1326544274 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -137,7 +137,8 @@ object Partition { delayedOperations = delayedOperations, metadataCac

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #14053: KAFKA-15221; Fix the race between fetch requests from a rebooted follower.

2023-09-12 Thread via GitHub
CalvinConfluent commented on code in PR #14053: URL: https://github.com/apache/kafka/pull/14053#discussion_r1323907175 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -858,7 +859,7 @@ class Partition(val topicPartition: TopicPartition, // No need to calculate lo

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #14053: KAFKA-15221; Fix the race between fetch requests from a rebooted follower.

2023-07-24 Thread via GitHub
CalvinConfluent commented on code in PR #14053: URL: https://github.com/apache/kafka/pull/14053#discussion_r1272855952 ## core/src/main/scala/kafka/cluster/Replica.scala: ## @@ -98,31 +101,39 @@ class Replica(val brokerId: Int, val topicPartition: TopicPartition) extends Log

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #14053: KAFKA-15221; Fix the race between fetch requests from a rebooted follower.

2023-07-24 Thread via GitHub
CalvinConfluent commented on code in PR #14053: URL: https://github.com/apache/kafka/pull/14053#discussion_r1272852459 ## core/src/main/scala/kafka/cluster/Replica.scala: ## @@ -98,31 +101,39 @@ class Replica(val brokerId: Int, val topicPartition: TopicPartition) extends Log

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #14053: KAFKA-15221; Fix the race between fetch requests from a rebooted follower.

2023-07-24 Thread via GitHub
CalvinConfluent commented on code in PR #14053: URL: https://github.com/apache/kafka/pull/14053#discussion_r1272852459 ## core/src/main/scala/kafka/cluster/Replica.scala: ## @@ -98,31 +101,39 @@ class Replica(val brokerId: Int, val topicPartition: TopicPartition) extends Log

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #14053: [KAFKA-15221] Fix the race between fetch requests from a rebooted follower.

2023-07-19 Thread via GitHub
CalvinConfluent commented on code in PR #14053: URL: https://github.com/apache/kafka/pull/14053#discussion_r1268783217 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -1366,6 +1376,17 @@ class Partition(val topicPartition: TopicPartition, fetchParams.repli