Hangleton commented on PR #13240:
URL: https://github.com/apache/kafka/pull/13240#issuecomment-1453619279
Used v8 for AlterConsumerGroupOffsets in the admin client and added
corresponding unit and integration tests. `MirrorConnectorsIntegrationBaseTest`
is now successful.
--
This is an
Hangleton commented on PR #13240:
URL: https://github.com/apache/kafka/pull/13240#issuecomment-1453452130
The integration test `MirrorConnectorsIntegrationBaseTest` is failing due to
unknown topic id detected from the admin client. I am looking into it.
--
This is an automated message
Hangleton commented on PR #13240:
URL: https://github.com/apache/kafka/pull/13240#issuecomment-1452495333
Thanks David for the review, have a few more tests to add but this should be
eligible to another pass.
--
This is an automated message from the Apache Git Service.
To respond to the
Hangleton commented on PR #13240:
URL: https://github.com/apache/kafka/pull/13240#issuecomment-1450362232
Please note that as mentioned by David above, in the current state, topic
ids are not provided by the group coordinator when constructing the response,
hence are not returned with the
Hangleton commented on PR #13240:
URL: https://github.com/apache/kafka/pull/13240#issuecomment-1450155072
Thanks David, included all your comments in the PR. I now work on:
- How to limit the highest version of the OffsetCommit API to 8 in the admin
client;
- Integration test
Hangleton commented on PR #13240:
URL: https://github.com/apache/kafka/pull/13240#issuecomment-1449920535
Hello David, thanks for the fast review. Apologies for being slow, I hadn't
finished the previous revision. Will include your comments. Working on it right
now. Thanks!
--
This is
Hangleton commented on PR #13240:
URL: https://github.com/apache/kafka/pull/13240#issuecomment-1447864999
Thanks for review David. Updating the PR to enforce the exclusive use of
topic IDs from version 9 and adding the integration test you mentioned. Thanks
for the guidance!
--
This is
Hangleton commented on PR #13240:
URL: https://github.com/apache/kafka/pull/13240#issuecomment-1443590758
- Added a test for `INVALID_REQUEST` in case of definition of topic id and
name for a topic in the `OffsetCommit` request.
- Added a test exercising a valid `OffsetCommit` request
Hangleton commented on PR #13240:
URL: https://github.com/apache/kafka/pull/13240#issuecomment-1442380719
Many thanks David for the review. I updated the PR to cover all the points
you raised. I still have more unit tests to add for the broker-side code paths,
need to check if any further
Hangleton commented on PR #13240:
URL: https://github.com/apache/kafka/pull/13240#issuecomment-1437297790
Hello David, I updated the PR to take into account your comments and have
been adding tests. Almost ready for review.
--
This is an automated message from the Apache Git Service.
To
Hangleton commented on PR #13240:
URL: https://github.com/apache/kafka/pull/13240#issuecomment-1429942230
Thanks for the review, David. I am working on adding unit tests for
`OffsetCommitResponse` and the server-side handling of the request/response,
and fix the bugs you have identified.
Hangleton commented on PR #13240:
URL: https://github.com/apache/kafka/pull/13240#issuecomment-1428304503
Hello David (@dajac), still working on this but opening a draft if you wish
to start reviewing at your convenience.
--
This is an automated message from the Apache Git Service.
To
12 matches
Mail list logo
