[GitHub] [kafka] MarcoLotz commented on a change in pull request #10131: KAFKA-5146 / move kafka-streams example to a new module

2021-04-06 Thread GitBox
MarcoLotz commented on a change in pull request #10131: URL: https://github.com/apache/kafka/pull/10131#discussion_r608024857 ## File path: build.gradle ## @@ -1423,18 +1423,8 @@ project(':streams') { dependencies { api project(':clients') -// use `api`

[GitHub] [kafka] MarcoLotz commented on a change in pull request #10131: KAFKA-5146 / move kafka-streams example to a new module

2021-04-06 Thread GitBox
MarcoLotz commented on a change in pull request #10131: URL: https://github.com/apache/kafka/pull/10131#discussion_r608024597 ## File path: docs/upgrade.html ## @@ -37,6 +37,8 @@ Notable changes in 3 The deprecated kafka-preferred-replica-election command line tool was

[GitHub] [kafka] MarcoLotz commented on a change in pull request #10131: KAFKA-5146 / move kafka-streams example to a new module

2021-03-11 Thread GitBox
MarcoLotz commented on a change in pull request #10131: URL: https://github.com/apache/kafka/pull/10131#discussion_r592169117 ## File path: build.gradle ## @@ -1635,8 +1627,14 @@ project(':streams:examples') { archivesBaseName = "kafka-streams-examples" dependencies {

[GitHub] [kafka] MarcoLotz commented on a change in pull request #10131: KAFKA-5146 / move kafka-streams example to a new module

2021-03-10 Thread GitBox
MarcoLotz commented on a change in pull request #10131: URL: https://github.com/apache/kafka/pull/10131#discussion_r592126995 ## File path: build.gradle ## @@ -1635,8 +1627,14 @@ project(':streams:examples') { archivesBaseName = "kafka-streams-examples" dependencies {

[GitHub] [kafka] MarcoLotz commented on a change in pull request #10131: KAFKA-5146 / move kafka-streams example to a new module

2021-03-06 Thread GitBox
MarcoLotz commented on a change in pull request #10131: URL: https://github.com/apache/kafka/pull/10131#discussion_r588864401 ## File path: build.gradle ## @@ -1416,14 +1416,6 @@ project(':streams') { dependencies { api project(':clients') -// use `api`

[GitHub] [kafka] MarcoLotz commented on a change in pull request #10131: KAFKA-5146 / move kafka-streams example to a new module

2021-03-06 Thread GitBox
MarcoLotz commented on a change in pull request #10131: URL: https://github.com/apache/kafka/pull/10131#discussion_r588864401 ## File path: build.gradle ## @@ -1416,14 +1416,6 @@ project(':streams') { dependencies { api project(':clients') -// use `api`

[GitHub] [kafka] MarcoLotz commented on a change in pull request #10131: KAFKA-5146 / move kafka-streams example to a new module

2021-03-04 Thread GitBox
MarcoLotz commented on a change in pull request #10131: URL: https://github.com/apache/kafka/pull/10131#discussion_r587511329 ## File path: build.gradle ## @@ -974,8 +974,8 @@ project(':core') { from(project(':streams:streams-scala').configurations.runtime) {